From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2969EC48291 for ; Mon, 5 Feb 2024 08:16:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BA3B8D0002; Mon, 5 Feb 2024 03:16:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96A838D0001; Mon, 5 Feb 2024 03:16:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 832EB8D0002; Mon, 5 Feb 2024 03:16:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 703E28D0001 for ; Mon, 5 Feb 2024 03:16:40 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3C015A09C0 for ; Mon, 5 Feb 2024 08:16:40 +0000 (UTC) X-FDA: 81757043760.29.8014DA6 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf11.hostedemail.com (Postfix) with ESMTP id BBEB740011 for ; Mon, 5 Feb 2024 08:16:36 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Xul78CXW; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707120998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+N4WMM1/lsjVxwoQqsoRoiQOAtzQ+zefrthX2QtoRGc=; b=rtPprqf/zbkc8x2j/vgf9MulA9Iu+rF9eWtEY6CA//QHmL0P/RfDiCXJqGD4+73J6BqryN LGBUs6nJmSw9FO74GwCrUak6T2s9zVlknICReHRE0JGe5XzhEZ9TZZELdyWoPCjhlWYGV3 N1UaIv+B2pNY6VYjq3H5qzGn+cyoT4o= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Xul78CXW; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707120998; a=rsa-sha256; cv=none; b=0ryM17pteK6k9PLKj5NyWT2n0rd+3E1M+2Pbxh5svgNHSlPl8Vbp0ukMuu+CuY8dUx9fQp rZtazYRC3ZnjCYPcWIj6NKECoxaYlUqZDcdHPk2BDYjMSQXi1CRo0NQnu3LX2ULFLosa0A uPJ5z+d0ahSg58K0GYie6S6usL8MagI= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1707120993; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=+N4WMM1/lsjVxwoQqsoRoiQOAtzQ+zefrthX2QtoRGc=; b=Xul78CXWpmZGU2XhK2nynmg6+7YX2Gu5qhwYlSHB+Q83qP3E3sv87p3P53PVy9zxGv5kTB1A5GZr15bdCgkd1JistK4vFJJtvWmPonwGByHsV8t/+urGLM7XtZNPAxHpj8TR+xkLALeBnY+WUCa+nvJuTjevSW5euvjHriohV+w= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0W06o2VN_1707120991; Received: from 30.97.56.40(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W06o2VN_1707120991) by smtp.aliyun-inc.com; Mon, 05 Feb 2024 16:16:32 +0800 Message-ID: <36d709fb-967c-42fa-a47a-465e29e13ef6@linux.alibaba.com> Date: Mon, 5 Feb 2024 16:16:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] Enable >0 order folio memory compaction To: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" References: <20240202161554.565023-1-zi.yan@sent.com> From: Baolin Wang In-Reply-To: <20240202161554.565023-1-zi.yan@sent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: bk7u77cqqipf7ccie3r5niep8mr39k3e X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BBEB740011 X-HE-Tag: 1707120996-731056 X-HE-Meta: U2FsdGVkX19mSftxJdC/dJweUPC4dFlXjDYqZZgjSTEf2FiXSaBrve15JNtPNUpNCBx1Gxp5OCsFNzEW3KsVpgFsTLR69MoUoBHk9rwa7hsSLe59KNTxTbIDC15GK4phKphMdWaPBCPeOqlMJ1R9M+v+A5a5JeWaEJdO1mxCeV8FhotPyEDZBYe01DtOcMyk0iWltuhPF3SqusSGJLzuYC2Q3dqnwACb5ntrL7oOikmz2hZEFSu6Px0HGsXAy44UZyKQYhSqScuxvLv3pkwmD/vAO32kJmHV64XwQY3UjPYU1suukF5ZLUEw0fM5yByDMeecJeUea+GoPul11YVsb733p8UG8fcEQ2D72h5s0QzgbWmSjKA1ZL3a2XcjCoquhmD6ejojK/SkqkCC668TjTgZgRd0lDf6B8VYWLghUfdHskFv6yxnTxjpy+PLMk+5VO1wVSLHj5zK2sCG8fXCgnQux+NvkX32LGJ6r1sUv4s98pq24H/ZzrMpZf8nK9rEqD0t/qU/JWd/IJBOplFi22o0bEPXwyq15T7Mtw7jyj8QnilD+SD+zBxmK4xtTiknyeh+m3jkzeMNtrzOTeqHigDC0/MmnoMQ29qizfex50LPpH8wirifEOfZXkqyZL5tFDPAw68cLLuRPXUtrOvggpZaVkwqOU0iXAvAjDrD7aC0Mgj9Dk5PJjcPqxY127Vb5g3O40cUQPDCAMyLZ2DqSnHyiyzK3nR3I8VSlRExpp1/JgpOBsIafFSk36+eBfQU96Xct+6/iwlENelD7ne2tGfS3JFoLDbFJdERj6IIYvHLtKla2clqBlnB9iVyIRiuPlOOHeddy4GrQISwIW9oJDiTKq/ocq9k1TZ5ln8f8WeGrEzlpNjlzhmUMi1XivS1T+xsx+9rB9nqzgWvQzoxPtRU/n59CNyxgDdsGV8Bz3IDvQPpljWZn67SnwxmX1mZi6a/zrPKq4FMtZu5N+1 3OJbXBNT zv11N+/4YMR7nTpnWBo96HmNg5lFHlo2QuDnbenJrkekS9BuQ3FdWf95UHCVg0RU7aOw6skgvwwXcQoLsFfylL/HoDxiqFm5WCc/pir7JaXdvKzlj+A2GuiyDl3B9QJs4ZeeskxrPpcD2/jU/uPNNx9ACaUAYuZfxBWOsv9/+87C5MC/fcQtU3r1jTK7jODMILZcbOcu+iwSl2ffYVHkm0wxhjaiOeoPC0hWE1uaMhxtOuadeA/xinuqtVOo3QyNZx1kGSn/qdxuy/9OzCQxBquumLC4dTtIxwefIIjF8pHNj4H2WQ0w76Wvr669qylDD4ROqXT5IlKysf1yrwiNCwDELPIsERug3Dqe7TgfdDdlLpqECGB8WvJTSZpkNYZc7odBQKBymcDpdERw2+Gcr85NgEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/3/2024 12:15 AM, Zi Yan wrote: > From: Zi Yan > > Hi all, > > This patchset enables >0 order folio memory compaction, which is one of > the prerequisitions for large folio support[1]. It includes the fix[4] for > V2 and is on top of mm-everything-2024-01-29-07-19. > > I am aware of that split free pages is necessary for folio > migration in compaction, since if >0 order free pages are never split > and no order-0 free page is scanned, compaction will end prematurely due > to migration returns -ENOMEM. Free page split becomes a must instead of > an optimization. > > lkp ncompare results for default LRU (-no-mglru) and CONFIG_LRU_GEN are > shown at the bottom (on a 8-CPU (Intel Xeon E5-2650 v4 @ 2.20GHz) 16G VM). > In sum, most of vm-scalability applications do not see performance change, > and the others see ~4% to ~26% performance boost under default LRU and > ~2% to ~6% performance boost under CONFIG_LRU_GEN. For the whole series, looks good to me. And I did not find any regression after running thpcompact. So feel free to add: Reviewed-by: Baolin Wang Tested-by: Baolin Wang