From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: "Huang, Ying" <ying.huang@intel.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
"Yin, Fengwei" <fengwei.yin@intel.com>,
Yu Zhao <yuzhao@google.com>, Vlastimil Babka <vbabka@suse.cz>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Mel Gorman <mgorman@techsingularity.net>,
Rohan Puri <rohan.puri15@gmail.com>,
Mcgrof Chamberlain <mcgrof@kernel.org>,
Adam Manzanares <a.manzanares@samsung.com>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Subject: Re: [PATCH v3 0/3] Enable >0 order folio memory compaction
Date: Mon, 5 Feb 2024 16:16:47 +0800 [thread overview]
Message-ID: <36d709fb-967c-42fa-a47a-465e29e13ef6@linux.alibaba.com> (raw)
In-Reply-To: <20240202161554.565023-1-zi.yan@sent.com>
On 2/3/2024 12:15 AM, Zi Yan wrote:
> From: Zi Yan <ziy@nvidia.com>
>
> Hi all,
>
> This patchset enables >0 order folio memory compaction, which is one of
> the prerequisitions for large folio support[1]. It includes the fix[4] for
> V2 and is on top of mm-everything-2024-01-29-07-19.
>
> I am aware of that split free pages is necessary for folio
> migration in compaction, since if >0 order free pages are never split
> and no order-0 free page is scanned, compaction will end prematurely due
> to migration returns -ENOMEM. Free page split becomes a must instead of
> an optimization.
>
> lkp ncompare results for default LRU (-no-mglru) and CONFIG_LRU_GEN are
> shown at the bottom (on a 8-CPU (Intel Xeon E5-2650 v4 @ 2.20GHz) 16G VM).
> In sum, most of vm-scalability applications do not see performance change,
> and the others see ~4% to ~26% performance boost under default LRU and
> ~2% to ~6% performance boost under CONFIG_LRU_GEN.
For the whole series, looks good to me. And I did not find any
regression after running thpcompact. So feel free to add:
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
next prev parent reply other threads:[~2024-02-05 8:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 16:15 Zi Yan
2024-02-02 16:15 ` [PATCH v3 1/3] mm/compaction: enable compacting >0 order folios Zi Yan
2024-02-09 14:32 ` Vlastimil Babka
2024-02-09 19:25 ` Zi Yan
2024-02-09 20:43 ` Vlastimil Babka
2024-02-09 20:44 ` Zi Yan
2024-02-02 16:15 ` [PATCH v3 2/3] mm/compaction: add support for >0 order folio memory compaction Zi Yan
2024-02-09 16:37 ` Vlastimil Babka
2024-02-09 19:36 ` Zi Yan
2024-02-09 19:40 ` Zi Yan
2024-02-09 20:46 ` Vlastimil Babka
2024-02-09 20:47 ` Zi Yan
2024-02-09 21:58 ` Zi Yan
2024-02-02 16:15 ` [PATCH v3 3/3] mm/compaction: optimize >0 order folio compaction with free page split Zi Yan
2024-02-09 18:43 ` Vlastimil Babka
2024-02-09 19:57 ` Zi Yan
2024-02-09 20:49 ` Vlastimil Babka
2024-02-02 19:55 ` [PATCH v3 0/3] Enable >0 order folio memory compaction Luis Chamberlain
2024-02-02 20:12 ` Zi Yan
2024-02-05 8:16 ` Baolin Wang [this message]
2024-02-05 14:18 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36d709fb-967c-42fa-a47a-465e29e13ef6@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=rohan.puri15@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox