From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55CD9C433FE for ; Mon, 18 Oct 2021 05:34:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B45561027 for ; Mon, 18 Oct 2021 05:33:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B45561027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8F0086B0071; Mon, 18 Oct 2021 01:33:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A075900002; Mon, 18 Oct 2021 01:33:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B69E6B0073; Mon, 18 Oct 2021 01:33:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 6EC986B0071 for ; Mon, 18 Oct 2021 01:33:59 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0DC8632085 for ; Mon, 18 Oct 2021 05:33:59 +0000 (UTC) X-FDA: 78708441798.06.BA5E08C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id D7C3B5080C8F for ; Mon, 18 Oct 2021 05:33:54 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEE61106F; Sun, 17 Oct 2021 22:33:57 -0700 (PDT) Received: from [10.163.74.6] (unknown [10.163.74.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C5B63F73D; Sun, 17 Oct 2021 22:33:55 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH 2/5] test_printf: Assign all flags to page_flags To: "Kirill A. Shutemov" , "Matthew Wilcox (Oracle)" Cc: Yafang Shao , Sergey Senozhatsky , Petr Mladek , linux-mm@kvack.org, Vlastimil Babka , Rasmus Villemoes References: <20211012182647.1605095-1-willy@infradead.org> <20211012182647.1605095-3-willy@infradead.org> <20211013092530.iidcseycqkn2b3vm@box.shutemov.name> Message-ID: <36b056ec-947e-4532-e1bf-8cd853bb901b@arm.com> Date: Mon, 18 Oct 2021 11:03:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211013092530.iidcseycqkn2b3vm@box.shutemov.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D7C3B5080C8F X-Stat-Signature: zq975e17s8ntccpj1sqyphe3tud8aiy6 Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com X-HE-Tag: 1634535234-551249 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/13/21 2:55 PM, Kirill A. Shutemov wrote: > On Tue, Oct 12, 2021 at 07:26:44PM +0100, Matthew Wilcox (Oracle) wrote: >> Even unknown flags should be passed to %pGp so that we can test what it >> does with them (today: nothing). >> >> Signed-off-by: Matthew Wilcox (Oracle) >> --- >> lib/test_printf.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/lib/test_printf.c b/lib/test_printf.c >> index a52c1c3a55ba..f744b0498672 100644 >> --- a/lib/test_printf.c >> +++ b/lib/test_printf.c >> @@ -608,14 +608,12 @@ page_flags_test(int section, int node, int zone, int last_cpupid, >> int kasan_tag, int flags, const char *name, char *cmp_buf) >> { >> unsigned long values[] = {section, node, zone, last_cpupid, kasan_tag}; >> - unsigned long page_flags = 0; >> + unsigned long page_flags = flags; >> unsigned long size = 0; >> bool append = false; >> int i; >> >> - flags &= PAGEFLAGS_MASK; >> - if (flags) { >> - page_flags |= flags; >> + if (flags & PAGEFLAGS_MASK) { >> snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name); >> size = strlen(cmp_buf); >> #if SECTIONS_WIDTH || NODES_WIDTH || ZONES_WIDTH || \ > > Do we even need 'page_flags'? Can't we do everything on 'flags' directly? Agreed, +1. Otherwise the change LGTM.