From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD02CD11C2 for ; Wed, 10 Apr 2024 11:52:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C37DD6B0082; Wed, 10 Apr 2024 07:52:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE9CE6B0083; Wed, 10 Apr 2024 07:52:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A60F46B0085; Wed, 10 Apr 2024 07:52:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6B1E06B0082 for ; Wed, 10 Apr 2024 07:52:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 25E0E1407B5 for ; Wed, 10 Apr 2024 11:52:18 +0000 (UTC) X-FDA: 81993459156.22.C3DAB5A Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf08.hostedemail.com (Postfix) with ESMTP id E0AB7160017 for ; Wed, 10 Apr 2024 11:52:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dqkAonnR; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf08.hostedemail.com: domain of aleksander.lobakin@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=aleksander.lobakin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712749934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k+r19gjT4VSopkUupVpITvQhPNdZzdev5ftw8NtlKlk=; b=tzMo0lk0lxKz1mK5Xg74MQAsa8dXW2rhvzcpKlYVhu4El71wb7YBidQ+6HEvgFwWUAn6Z7 7MdkItM+hX1K0w5Oi58at2dlmSCSc73mNZgGI8r6fLgL4de1z+SunIL8VE8Rbw2x7ZY6wk O/fBRWSjx0qXO1yfzRonAwK/AbnR4cM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712749934; a=rsa-sha256; cv=fail; b=gz2dSmGjfWOELEa8X6knC3Ci7rrB5qxNqTHOlZfGXFwWiFZDD4N6wGL70+/BvoUjfFWCl3 XQQO8qschKbtbQ3dmyaWYXs9TzUzMtkG/cB5dZUKNA5R57zYi4PQ0xLv7ooxi6eqWk9ZBi uNVcWcpXNxHhuPK/L5MAdNDETskHQ1c= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dqkAonnR; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf08.hostedemail.com: domain of aleksander.lobakin@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=aleksander.lobakin@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712749934; x=1744285934; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=HsALThLavE0te140mafu8Wl27SAhK9ZrFGKViC/d6UE=; b=dqkAonnRvPXmmXr+aDPs+AiUR2DyKJjH8upmWEttkgp1B8e+79MkO/9R r6CXiBdPwMCeHD/nEmgauWL174pgc0ALTevFOQVgwIACnXiaIx3PARqrK tscRW3dX+cO1dL4mq456aMwpOa/bbDzSkG6umpuWa9amN7HL4euyFwl1K /jLimb+67m3yUZKiR3eg7iftwhTJO4DWpCZNaoWYLYdOoiog+/wD+ExsE SROdy5n6O9IWkiWdOzoiYM0R3lk0iUn+riSut/8Si6FbveJUWgNMsvGDH BrCyHiEEddl/3PAwZI3ZMBqPNWPWZOnXHyCI/FdujiF068uv2SwRXlDhV g==; X-CSE-ConnectionGUID: uEnxFtIpQjqb4M+o+DtUEA== X-CSE-MsgGUID: VMO17btETM6Tw1oTIDeB1g== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="18671138" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="18671138" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 04:52:12 -0700 X-CSE-ConnectionGUID: EXZ9GqWaSGWUq5/g3CTkjw== X-CSE-MsgGUID: 305zymBTRta3H59AdHuiKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="20598591" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Apr 2024 04:52:12 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 04:52:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Apr 2024 04:52:11 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 04:52:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F+eLVI5cdRrfobOc6e+QtH8OZnmSuLNSNpuR86URiIOOnguyoKSPravz+PD9VQCYYfnoNzjUospPnLKJRw5U75zH68dbGHuXnNTDNW+c0I80ezhCPAspAkck+vdZ0tLB+JBsvtiaXIsTfMLy1T5oSO7qM2uK5/6kvKDy06lqO3k7qr8+JSN8nGoMID2iE776HF4BAc7WZKWUgF/NENpzqNJ0h05GTw1AV3A7XEeg0ZUTlam1Njf2wMzYoa/LSOQooiO+RXk+VX8qL4sXSONeXzWYOGFxG16FIX+Iyug1I1VssduWU8Mzw7noR9IYKpZW2qyDRA7cgt/h3RR5etoWBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k+r19gjT4VSopkUupVpITvQhPNdZzdev5ftw8NtlKlk=; b=CnMqA682cdipJ6UAIBSTguqFkWotmJYmjVU/haIF5/bnsXo4BXImCoYoufJX1ALe937JL9frkMeDSlgUXtbJe5hn/rDO5CH3nwhXsVQwCifJe57oUQE0j8NchPPgveCARitlJG/zxfH4JYvHIK3DZyvu3o9oi6Y2jZjQS+StLBJ0tGiTXTYdeUXEEXlXLc7xYh9jQIuq8OOE9KntmRleqzz10pMbSYiVGVjAW6JeEECp24tjinOx8qJz1COnvKQ7b8vn9v1lp8xhMZJjnIrt35ZILiexX7a4arPT1jJV2csg8/dB8vgYiaFdh1awhM58sCHtPsj5PJOWD+QCT1fCXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) by PH7PR11MB6053.namprd11.prod.outlook.com (2603:10b6:510:1d1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Wed, 10 Apr 2024 11:52:09 +0000 Received: from DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::654c:d66a:ec8e:45e9]) by DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::654c:d66a:ec8e:45e9%6]) with mapi id 15.20.7452.019; Wed, 10 Apr 2024 11:52:09 +0000 Message-ID: <36a067fa-75c0-4e7d-b704-229deea2d440@intel.com> Date: Wed, 10 Apr 2024 13:49:59 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management To: Przemek Kitszel CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Duyck , Yunsheng Lin , Jesper Dangaard Brouer , "Ilias Apalodimas" , Christoph Lameter , Vlastimil Babka , Andrew Morton , , , , , References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-8-aleksander.lobakin@intel.com> <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com> <9d389192-63c4-44e8-b863-6323b45aec0f@intel.com> From: Alexander Lobakin Content-Language: en-US In-Reply-To: <9d389192-63c4-44e8-b863-6323b45aec0f@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: WA0P291CA0002.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::29) To DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB8718:EE_|PH7PR11MB6053:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rungzplUbALL4lnEgvXglGGccS3jf68Ic9+mMF2TX7YtogWTrNlElATssFTKtDWykPAQAL0ellq0c6lgtdNirsur2ViDUp7IQ0sc5yK+OQSmn74BnIG3+DllgHKxwkJi7VzaUr3Tr2zPo/i04yjtLWvN0pNJDM42qQxrzG24qgfzX1/UCoeqFGeo/bvB/Nh4ndVvteWS6Sd0xqYdfe65/fjPvoE/P7OcrjNdaLhTbZhMitLojaX2kFp7sFsUAOXYiYhyIiy8JkjZ1cF70eVAjCnEXHWRbqQ2cmLSD15Zu6hMqpwQAdcRsCUVcYxY5UogHgfETIshAXtN5vJQm7xvAD5qTi2S4REHYCp44UDJ62mtQwdHNbjqGnAMzO4zxf94xmWu8zbz2UGWFi/8yMcaKC6FMxbjhCkh7oUwXvSXznTXdo+EaH/Wg27vop1bhrqQx7v/iAwErI+JvVyXK5V61pXJybh78TjfBLgfdVDRRzJUj0CsLe2Lp1i4RSNfW4iqtzhZMwCm+zTsDOV/coUgiD3mcoAKrd5e3j5HXfbHtNuPnkjx3RpRqbyXWQEoBzKzijc4rIqAfj7NgpZBaXLGQDXo6vM2XYvBd3LEMpVf+n9ihbWzT+keh1H8PeA0CCaGiLBJc6ItwJIKM9vau30XxadmubVFzSb1FHyBQe5389I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB8718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005)(7416005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nm9KTkNCNlduZ1F0MUJUb01LK2tjcTNPMDdUTGxzUW81Umd2bUF4Zy8zaW5v?= =?utf-8?B?UWFLaUc0QkNjQlBoZldwUGlPL2k3RThhZ01YZGNGaWpxZDFOUW13K0JTYW1C?= =?utf-8?B?UmUvT1JVWElEblpybmp2bldYR2ZjWktGQ29XQjRKUnBTT21RNzh4NjBEZllv?= =?utf-8?B?STliZmRYZ2xmQXMvU3I2eXNQU0ZQVEQ2S2VHelQ0YUU4U0dYSmN1SVk2T3RD?= =?utf-8?B?ZjFWUVVCNUVONTFUbDNqNFdTNEs1RDh4V1RGKzVHQ2tSYkRpaWhhaFZPMGlZ?= =?utf-8?B?RW1VWW5yRTN6VHRNelVDUHp6M0swbEVJMHJENFl5V2lGdXd2T1VVbHlzaGQr?= =?utf-8?B?eXFaM0Urd21rOXR4ZGcrNnJGMlNZNTFzQ1A1ZE1IYTRhL1VFM0dHZVdoVmx3?= =?utf-8?B?YlFSNkxkck5jMEd3dk1jMHpraVR2Q1VQZmxWT1NBL2czb1lyV0hscXJnam03?= =?utf-8?B?dWNtclp4d1YwM1FiaU9aZk5oMVY4ajV1NlVZRUIwWEo0aUcvaUVDTXlFQTJN?= =?utf-8?B?WUpxVEt4QXhwL1BQZ25STFU4Qzc5RVNCWWhQNUlaNG5qU2pnQzdPajZIcWVG?= =?utf-8?B?MWxyUDVSNWt5MFg2VXg3MFFKZUdrMWpsc1BBZUlieTBVQ0ZwZXJoK1NRd3ZI?= =?utf-8?B?Rm1wcHVVNTIrK0hEWURWRjZoeE52TldJOWdtWGVLcUhPKzV2ZWxRTGFiRDBv?= =?utf-8?B?SUk5cjRoQ0ZmOGlRZUM0Mmo3Sm1VdHhOcy94OUlTRlp6VTM2UERuOE8zZTRT?= =?utf-8?B?T2pHWS9STTFXRGVZVnppZ241K2FwZWtIU0RKRlQwZUdCMVkwZzFMNG1kVThi?= =?utf-8?B?Ky91eEd5eEZETlBWU0Vzd1RvNkh6US9yTytkMWluYTQzc3JCUUt6Y3FOSzAz?= =?utf-8?B?TFFBNCtEeUVFU1JNcXVnTHpBWWJva2FaRHZDbkxWSnFTK01ySEJEVkhZYTFQ?= =?utf-8?B?UzlLWWxTN3AwWERlYW9LZStMTzU3NDBEZWtWOVZiNGE4VTlVeThtQWVIeXR0?= =?utf-8?B?Mng0L1o4UGl0SEdMMVRNbEtOR3BTUDJmK29DN1dSeVBEak9oRkpvTVp5eCtV?= =?utf-8?B?S2pXdUdQVTIrbTRpYkNMc3FlK3VFVGdQczRJTkgvSW1CQlo1NlNxcEpTUVEr?= =?utf-8?B?Wjl4WWliZGJlNld4UmR6MzJQZitqWE1hZW9kMll6cHFyYTIxRWMwWGJTS2Z3?= =?utf-8?B?SE82Q3NaSHlIaE43bThjR1NBT1ZFd3I1S1gvK2FXK0dSaHdhdzFmZTRkdThu?= =?utf-8?B?d2RXM3FHbG9hQnA5a2QxUDBENUpIaENKdWsweE4xb0RJTDVDLzJkbkVJOGRh?= =?utf-8?B?MUwzODlXcmtZaWJTY1ovUFVJYUdhRG5QTFMyTXhSTFFzdWEycVlRaXdBRFVo?= =?utf-8?B?VDN1MGhiK211V01QV28xUzZwd05tcE95YTdwZit6YmFObnJJM0FYZmZ1Vzlj?= =?utf-8?B?Vmh5WUxsMmhRMkszazdLV3h1aEM1NERVNWhyMzEwelZUVldVRld3Z1UzT0VO?= =?utf-8?B?K0xwSHduNmkwWmUvb1d4cTRUcnRqazBKRDE4T0JHTzhQMlo4V1RLaTA4cEd4?= =?utf-8?B?WlhmVFlCS3F3MEtKNlJUYXM4RzVTaVBpbzg4TFByTlBWd0MxWmgva2RuU3dX?= =?utf-8?B?YzdSVXVaa3Jwa0hSNXlJZUZMcE9HN24zQXlZU1c5RDNSR3JiMExYTkh1TDJi?= =?utf-8?B?RFBoeVZ1VFVldnNLTGdhanJqd2thM1Mrd0E5bzE3TXdFZ0JZSU8reXdSc2Yz?= =?utf-8?B?Mld0UHovZk10cnh3YjRDVFdKSmV5K0V5dzI1U1dlWnVrVnM0YWpjelY3eE9C?= =?utf-8?B?dkRacFZoQXJoRkt1VjU3U1dkc1Q0UFZRd1pHN1RXRWZwditETXZkRVhkTzFY?= =?utf-8?B?eGY3bkxNSFcvZWIwS1hZRy90OW03MEpEYlVWbStNeGM3cmZoSU5na280YjBM?= =?utf-8?B?TitXTXh0Qi9TcS9paUpnV0ZmbVY3SDFJWmIyMnMzQjlIT2JpMU40bjVKUTlJ?= =?utf-8?B?MWlnWTUyalJQKzNCT0ZQUVVOT3oxZXZseGJZVnJqdVVVQmdzaFZOWHI3V0xK?= =?utf-8?B?K2ZFZ0J6NVd0c2ZJaWwwaDNrTGwwL3lidXROVFFualB6bHhERWFYQjBSOVZt?= =?utf-8?B?UkdIZnRNSUxUTUVkWHZPeWZIYk1YV2V6SUN3VDcvMXBZRWlOY3lPcEVtOHBo?= =?utf-8?B?TlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: a57efcf5-8fd8-4a58-fff3-08dc5954a69e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 11:52:08.9741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XsfnjREgLxg1/7mkF+xBS6WgKDUR3OynZleY7Anwfh3WWpSwIQ0tScaTj+dVcxLkCoJhVjvCu6JcLSbYm5x3odS9vD4oVaTgJTJ60kGyUbU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6053 X-OriginatorOrg: intel.com X-Stat-Signature: 6me7uuq94zkstn3bn337xm1nr4gh3as6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E0AB7160017 X-Rspam-User: X-HE-Tag: 1712749933-734556 X-HE-Meta: U2FsdGVkX19zzr+bjUvWDhIgKlHWeY4/ftP/8hX7CNRU+U3FG6EZUIIzSgf7vwF+6uoXWw83tumBsW62hEMfbY22yJSnfM9I02a55kR+7E+Py91CbOumrdD1gUlHalxs6mu2T080SrzU7KE6U/00p3Y6FwBR9UNea5MZQ4mE6rwd/ehHcBGrlrToF1nPINFDNvJNczKqGUokcjEumuYLXElvkDQZndC2d0Nck3gJceNLx0U1vakp4dOYEgXKfsXVWn+b/s3PgliMT8GwSXca3zVZnSh08gVfNx4fLIB6Tc7Hfj+g7zHHUa71vZF+w0g9uxqhs1YuCqmXZxxPUV5dv1Gk13Pu2CVNIL/jKLY9sTFewitNZf0kbmmHxXm6tUEuEoMlFo1nEWN6+Zd6b6lH2SHXbBEVkydqnKwqDl86IdnynH8IQ1OcKantKmZa1ry6j2/4XZLyOupdGO2CKLxV05RcyETz86s5W8xfiDAzL4o5DhctuvDwpJAzg3O1J7UqX1zii/CkXR5+0bVECbvgOrMEAAh4G26RJgXUxca1GJrU1TVg4IaZvK3/zFIo8tuLqfFsF7khOCbxQM7G08gHHO2JkLWSQgdOYd5u7ZeDXAlS0VJGLET8dY6PrWWCPiDJN4yem1AcA9W/5APVbonuxt4Xo7ocn2Kefw4NX1wV6nNPs7AfAsT3e0ax1+1R52KmodAmX2uZKEVbG08PLr1fWytQ2rvnl7kvi7nFI84CfViYJni48ayklM4IgpObQ+qD2DsIcsNkK/baYCT7xV1XTnVp2vhGLUyl2nhsy6kil93HuxqbC262bbcRRidqxIL/AY7oZ7YBhsZIzeUWEOUD0vTbcsjI4sHMDHeYOequ3xh5YYguvAouZmE9AArpwAxk69J+bsfq/RXtD41/2ZyUk5LtRf4+qQL0tbov047gQJ2V6eVdyXLJ2kZApWbgeBLv3rIrOKuebj1h91uLtCl jFpIk6EM KqsJWRSNqUagRW87RRp9aAxoEQYuPOR91sQpuvN68xopBatnKM8/LTqIDTFhv1r4jzv8stUZ5paDJmI9CXJoPh3Z/3NeTw07avX2ci1Sf5x+blog2m69yKAPvCsR3cRAgv8VXTX9pk1spUGi7T3rEpR0deKt8Z1BmSan7g46nxK5sMBFMAqIJc/bunwsS8zGOXbAkgNPbwO/lWAs28dQO35lM6aMwKdm19JsqeaO6sClOZMDFg0Vco/ndYMJxEvq+odcNPcx6j6bEqFOFW+G+b2akCyh+yYBcgKoW5cgjODgwLZxXgRlKxPQttfA4Gz894eGnK6zYrRDrmY2KPu+AIPN0GFe5Fi0eCl0syG2j1MPklYb0jkBUlkaNDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Przemek Kitszel Date: Tue, 9 Apr 2024 12:58:33 +0200 > On 4/8/24 11:09, Alexander Lobakin wrote: >> From: Przemek Kitszel >> Date: Fri, 5 Apr 2024 12:32:55 +0200 >> >>> On 4/4/24 17:44, Alexander Lobakin wrote: >>>> Add a couple intuitive helpers to hide Rx buffer implementation details >> >> [...] >> >>>> +struct libeth_fqe { >>>> +    struct page        *page; >>>> +    u32            offset; >>>> +    u32            truesize; >>>> +} __aligned_largest; >>>> + >>>> +/** >>>> + * struct libeth_fq - structure representing a buffer queue >>>> + * @fp: hotpath part of the structure >>>> + * @pp: &page_pool for buffer management >>>> + * @fqes: array of Rx buffers >>>> + * @truesize: size to allocate per buffer, w/overhead >>>> + * @count: number of descriptors/buffers the queue has >>>> + * @buf_len: HW-writeable length per each buffer >>>> + * @nid: ID of the closest NUMA node with memory >>>> + */ >>>> +struct libeth_fq { >>>> +    struct_group_tagged(libeth_fq_fp, fp, >>>> +        struct page_pool    *pp; >>>> +        struct libeth_fqe    *fqes; >>>> + >>>> +        u32            truesize; >>>> +        u32            count; >>>> +    ); >>>> + >>>> +    /* Cold fields */ >>>> +    u32            buf_len; >>>> +    int            nid; >>>> +}; >>> >>> [...] >>> >>> Could you please unpack the meaning of `fq` and `fqe` acronyms here? >> >> Rx: >> >> RQ -- receive queue, on which you get Rx DMA complete descriptors >> FQ -- fill queue, the one you fill with free buffers >>    FQE -- fill queue element, i.e. smth like "iavf_rx_buffer" or whatever >> >> Tx: >> >> SQ -- send queue, the one you fill with buffers to transmit >>    SQE -- send queue element, i.e. "iavf_tx_buffer" >> CQ -- completion queue, on which you get Tx DMA complete descriptors >> >> XDPSQ, XSkRQ etc. -- same as above, but for XDP / XSk >> >> I know that rxq, txq, bufq, complq is more common since it's been used >> for years, but I like these "new" ones more :> >> > > Thank you, that sounds right. If you happen to sent v10, a bit of code > comment with this info would be useful ;) The current kdoc in front of each struct and function declaration is not enough? :D Thanks, Olek