From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-mm@kvack.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] MM updates for 6.5-rc1
Date: Wed, 28 Jun 2023 20:18:32 +0100 [thread overview]
Message-ID: <3696804.1687979912@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAHk-=wie=MvQzmjhKGCCbRapK3Zz-b8GFUchEDJi7SkeLAX6Pw@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> Side note: I think we should just do the "FOLL_GET" doesn't touch the
> refcount either, which would make this all become just
Yeah... but there's a lot of places that would potentially need fixing.
iov_iter_get_pages*(), for example, is used to grab pages and push them to all
sorts of destinations, including pipes and sk_buffs.
> but then we would need to fix try_grab_page() and gup_put_folio() and
> friends to match. And any other cases I haven't thought of.
And put_page(), folio_put(), ... I wonder if there would be a noticeable
performance loss from adding an is_zero_page() check into those.
It might also make sense to include the entire kernel post-init static image
in that, perhaps a check:
if ((unsigned long)(virt_address) & KERNEL_MASK == KERNEL_BASE)
return;
David
next prev parent reply other threads:[~2023-06-28 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 15:50 Andrew Morton
2023-06-28 17:27 ` Linus Torvalds
2023-06-28 18:19 ` Linus Torvalds
2023-06-28 19:18 ` David Howells [this message]
2023-06-28 18:49 ` pr-tracker-bot
2023-06-28 19:10 ` David Howells
2023-06-28 19:19 ` Linus Torvalds
2023-06-28 19:50 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3696804.1687979912@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox