From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC2BC32772 for ; Tue, 23 Aug 2022 10:07:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AED58D0002; Tue, 23 Aug 2022 06:07:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95E838D0001; Tue, 23 Aug 2022 06:07:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8265B8D0002; Tue, 23 Aug 2022 06:07:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 703E68D0001 for ; Tue, 23 Aug 2022 06:07:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 35AD5ABBFA for ; Tue, 23 Aug 2022 10:07:09 +0000 (UTC) X-FDA: 79830429378.23.EC63E4F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id BE0831C0014 for ; Tue, 23 Aug 2022 10:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661249228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k4DDfGD38WyRMUhL0albSNaRv3lQW2wKYEOnaNdTLlA=; b=UgHUoit0uJP9An7qWaQm7N38+hdAeDaFTrRkWP6HwZ/R4aa/AfxSBBf2C4Sn2538sRaIdu 86tm+pqULtMSd9mXVRp8Vk3HGkKxD+Wq8XNtU7a/pAzZ4V8/o3H1UA1SBvhyRK/PbhoZ6o gVi3vf+FWdfDp+mdg8ieHucS+EObJI4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-582-TwUCE4_iPiqVe7UXn_Feag-1; Tue, 23 Aug 2022 06:07:07 -0400 X-MC-Unique: TwUCE4_iPiqVe7UXn_Feag-1 Received: by mail-wm1-f71.google.com with SMTP id ay21-20020a05600c1e1500b003a6271a9718so7488424wmb.0 for ; Tue, 23 Aug 2022 03:07:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=k4DDfGD38WyRMUhL0albSNaRv3lQW2wKYEOnaNdTLlA=; b=qUL7apl3t2k+Aac0z7+STjrA+U3xi7oCAD5egtO5KipALPTzpapPtnjyXWSGHx31Nt KYrW5+goZyVHkW1mW0xHO8NV/4uqYP7HPS9+xPIMLEZy7loWHhi/13l6+SiDGEo9Qu6D Q8sm0IxipNxPK8NnfcvFz92tmvvaEbeHz3ho0EVAv7MZ6410FC+IuRj5xY3M95R4SphA l2vGPfu9aumq5Tzi4Vj+EP/85m0oNaoQAAtWEu+ui+Y3uL2n+IhovAdYzUlQsUHtqfB3 lFrqjHod2egE2ImbZE2zilTu2Ml1QhK4oAFhqd1tgc7sTdgs+n+OUI8W5GCFd0ZVyhQ1 +y2g== X-Gm-Message-State: ACgBeo3def1akQX9JZGnZ5xjJXcull85kU5bvZuB5kvCNQvgCOLjtVkl aQxhV0pmQMVLwHclXn9Gjkq05BjFldsTxl/HcZAPKjBKhiONF6qtkJwDAXHQwkdZ+Fq8bL1xLsz FB5iimwdqcOs= X-Received: by 2002:a5d:6d04:0:b0:225:5a6e:7607 with SMTP id e4-20020a5d6d04000000b002255a6e7607mr4838250wrq.336.1661249226030; Tue, 23 Aug 2022 03:07:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR5QgVeo9aZdJeSZeBsNU1jnzRMWXtJejk8Sr/CiqW3Vo9vVh/mkrE/ytXRvpg0xCMGSkVRjEw== X-Received: by 2002:a5d:6d04:0:b0:225:5a6e:7607 with SMTP id e4-20020a5d6d04000000b002255a6e7607mr4838230wrq.336.1661249225685; Tue, 23 Aug 2022 03:07:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:1600:c48b:1fab:a330:5182? (p200300cbc70b1600c48b1faba3305182.dip0.t-ipconnect.de. [2003:cb:c70b:1600:c48b:1fab:a330:5182]) by smtp.gmail.com with ESMTPSA id v8-20020a05600c214800b003a5c244fc13sm21831085wml.2.2022.08.23.03.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 03:07:05 -0700 (PDT) Message-ID: <36925544-8127-fe0c-76e5-49138dff45ae@redhat.com> Date: Tue, 23 Aug 2022 12:07:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v6 2/2] mm: fix the handling Non-LRU pages returned by follow_page To: Miaohe Lin , Haiyue Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, apopple@nvidia.com, ying.huang@intel.com, songmuchun@bytedance.com, naoya.horiguchi@linux.dev, alex.sierra@amd.com, Felix Kuehling References: <20220812084921.409142-1-haiyue.wang@intel.com> <20220816022102.582865-1-haiyue.wang@intel.com> <20220816022102.582865-3-haiyue.wang@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UgHUoit0; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661249228; a=rsa-sha256; cv=none; b=WFwVFLnyQMVzVqVD4ynrvcEGPxR436MutRcAiUcofYuaksjhbVZUKTxlg7P3NlKamlRKNl aUi0FP/F3pOUMbglbvehwIYg8xIPXDFP/pjmBqelV5Kn82w5eLuA+kljCgQD+fer/FdGzs xP+uL7ZVbBW+sinSBvNKr07I18+E9EA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661249228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k4DDfGD38WyRMUhL0albSNaRv3lQW2wKYEOnaNdTLlA=; b=Kvt++t5Sx8TSUf85OQTFBEz2Pu9OIvhvXI3/NrRYIhe+ftGaU7cfhtxhGxDqubOCXymim/ upRWay2s8JVavCIyj+P0M8dcoXrggBcjkJekJLrc6869fNbxUHX9YsSFkOkaoT+Z4YL3tO go8HSlWbf2Qw7gv3lv8ydZd0C3DR3tE= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UgHUoit0; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BE0831C0014 X-Stat-Signature: cjix6qektq3ux7dz57sm1iz979556juq X-HE-Tag: 1661249228-843748 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.08.22 04:34, Miaohe Lin wrote: > On 2022/8/16 10:21, Haiyue Wang wrote: >> The handling Non-LRU pages returned by follow_page() jumps directly, it >> doesn't call put_page() to handle the reference count, since 'FOLL_GET' >> flag for follow_page() has get_page() called. Fix the zone device page >> check by handling the page reference count correctly before returning. >> >> And as David reviewed, "device pages are never PageKsm pages". Drop this >> zone device page check for break_ksm(). >> >> Fixes: 3218f8712d6b ("mm: handling Non-LRU pages returned by vm_normal_pages") >> Signed-off-by: Haiyue Wang >> Reviewed-by: "Huang, Ying" >> Reviewed-by: Felix Kuehling > > Thanks for your fixing. LGTM with one nit below. But I have no strong opinion on it. > So with or without fixing below nit: > > Reviewed-by: Miaohe Lin > >> --- >> mm/huge_memory.c | 4 ++-- >> mm/ksm.c | 12 +++++++++--- >> mm/migrate.c | 19 ++++++++++++------- >> 3 files changed, 23 insertions(+), 12 deletions(-) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 8a7c1b344abe..b2ba17c3dcd7 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -2963,10 +2963,10 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, >> /* FOLL_DUMP to ignore special (like zero) pages */ >> page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP); >> >> - if (IS_ERR_OR_NULL(page) || is_zone_device_page(page)) >> + if (IS_ERR_OR_NULL(page)) >> continue; >> >> - if (!is_transparent_hugepage(page)) >> + if (is_zone_device_page(page) || !is_transparent_hugepage(page)) > > !is_transparent_hugepage should already do the work here? IIRC, zone_device_page can't be > a transhuge page anyway. And only transparent_hugepage is cared here. I agree. Can we avoid sending a new version of a patch series as reply to another patch series (previous version)? Acked-by: David Hildenbrand -- Thanks, David / dhildenb