From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E9D9C369CB for ; Wed, 23 Apr 2025 18:37:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E039A6B0005; Wed, 23 Apr 2025 14:37:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB18B6B0007; Wed, 23 Apr 2025 14:37:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C78EF6B0008; Wed, 23 Apr 2025 14:37:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A72BF6B0005 for ; Wed, 23 Apr 2025 14:37:34 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 43FB7141BD6 for ; Wed, 23 Apr 2025 18:37:35 +0000 (UTC) X-FDA: 83366166870.27.7A9BA89 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id C174114000D for ; Wed, 23 Apr 2025 18:37:32 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EUEOBP2n; spf=pass (imf23.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745433453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y6pwEnRnhkHgazDgVxPbcQpa5mERaCMyYK1dziw6UIo=; b=jVltb0cR3fiN3BCdGax8Lwb7JLsTW8h+rQyZ/0yc/l/gFWHKfTpKpFrfC1Suaa1q8AAmLt WCMP71ersYZLr4um/gjjmSBy4LAraNsCTjOMmQE4xmRvu+o0ooLVUuRkobxLN5EtngXd+V TdBgANSgP43aB7u7cIT/N1pMj1gzRTU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EUEOBP2n; spf=pass (imf23.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745433453; a=rsa-sha256; cv=none; b=6bvI/2F+2guzjKyhjrzTKB60mUWUD6+ZpFjtGEsLa5LyvHPHtniHQO6fEc6SyQo/0iTAKd sM0A0sSPjZPSwsIbxdfaiBmZIvm0pZa1FwHvk9e0oXu1rRdNXA9A2jDWVHguOM5gAdRHHA s7Kbr+nKFuiDrxUjx2ajaaPESc5Dj0M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745433452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y6pwEnRnhkHgazDgVxPbcQpa5mERaCMyYK1dziw6UIo=; b=EUEOBP2nmpJF5XmufuyC/HIcBOTM8TgYaIueDWTT8ofPtnfWc/CGh3aJJ3MVbfT+1Wnu7k lXE+Q4rq9n1OekVQ7HgQ9A3XJsQxwfXGDLp62Ftd8CJS3PkPqDfIls4Vs6ZrAhAN2DrRm8 ebc2avXQ5w+A40Yi7hkS0kSRLfNt934= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-EOgMbrFjMBqyjM0AiMqcxQ-1; Wed, 23 Apr 2025 14:37:28 -0400 X-MC-Unique: EOgMbrFjMBqyjM0AiMqcxQ-1 X-Mimecast-MFC-AGG-ID: EOgMbrFjMBqyjM0AiMqcxQ_1745433447 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-30bfaec88edso5898411fa.1 for ; Wed, 23 Apr 2025 11:37:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745433447; x=1746038247; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y6pwEnRnhkHgazDgVxPbcQpa5mERaCMyYK1dziw6UIo=; b=cP8v/5ojL5KLi5Uv3OrfsOwEpoR3UfnAsN8aNNmwIOMrp9WvYy/18REzDj+AMf+Tpo /MPsSYhmLBuMCbetcITsRF+LXjdkT7KvgJVfYd1KpkQq9aMgkdI9k3Nf1gWQb7Ob51Fz 5oNVEZcfRaK+lz2XV2THDtz84BKoPN3meIwDftqG6XtnupitTqwbirzw6kpcxu45dM+M fwgjI9e9TfRJwAwxIDaeHkWcVvLpWXvtABviYH02Qrblpu3DduhAmeWYBSKd3kpdm0dK 8hU24E4WwT9j7RGiynWQ+txZ/irxNuaeJrdvqGwwnyzekJUQiDCSIlPtyCZI6vUB/5b2 cDfg== X-Forwarded-Encrypted: i=1; AJvYcCW/tLtMgy/FewGLnn45TcdqaqxDatxcvHoA4iFc/urNotFTqlUPtTRPYmVGRQSl5nljVns+17EeSQ==@kvack.org X-Gm-Message-State: AOJu0YyiidoegHebyh+aTSt7YqWBFvWfSJ2mih5mYEHTU6WuH85V+OLO TU6AXlx7B3sHUEkO82uZifrcb6xMpwDr4Y8Obr4LdtflNgzRTQHraGgjwak20mqpjZ94aWXCH4Y NvZFe/NcpVytahzYqk408x1OpprQH/2HhACUgNAguSqXF66Y= X-Gm-Gg: ASbGncurWDbDFp8gBJ9yDIxiCRdXJ/Z7jWn9B4YjWpBGX5Be8JcN67kSrFNF/ChwTMI E05YPj9hH2layvOQlEzUMdp4s8nf3hxjUWIc5GYVUqwPwc48OvrP9Y3xZrOvkvr22ChLx+hY2YO 60PJ8Kthi4HiJIeuPqmgIH5R++KAAL9YWTbuYEo/LB0D54Tm1Xprh25UjT5EaVfFWuAslP+15LN 0sGHQLFLs6GxpuKr0W4kvGULIC3c6cbC4soZDQjztm0hPKqM2i4QQ4orcwUG4M/6HLGREZPtomL IV19u1sYpjmQyRXuPbYJ4P8sTaZqdfl7H3kA8g== X-Received: by 2002:a2e:8818:0:b0:308:e956:66e with SMTP id 38308e7fff4ca-3179449456amr500081fa.0.1745433446935; Wed, 23 Apr 2025 11:37:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHeLX03zhP8nSlFHqNWBiKFBjf3MShxZQb8tc2EeW+8vLK6+b+87nnEoR+0vFre3XFcDl9w4g== X-Received: by 2002:a2e:8818:0:b0:308:e956:66e with SMTP id 38308e7fff4ca-3179449456amr499761fa.0.1745433446435; Wed, 23 Apr 2025 11:37:26 -0700 (PDT) Received: from [192.168.1.86] (85-23-48-6.bb.dnainternet.fi. [85.23.48.6]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3109075e8e9sm19833701fa.12.2025.04.23.11.37.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Apr 2025 11:37:26 -0700 (PDT) Message-ID: <36891b0e-d5fa-4cf8-a181-599a20af1da3@redhat.com> Date: Wed, 23 Apr 2025 21:37:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 10/24] mm/hmm: let users to tag specific PFN with DMA mapped bit To: Jason Gunthorpe Cc: Leon Romanovsky , Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Leon Romanovsky , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni References: <0a7c1e06269eee12ff8912fe0da4b7692081fcde.1745394536.git.leon@kernel.org> <7185c055-fc9e-4510-a9bf-6245673f2f92@redhat.com> <20250423181706.GT1213339@ziepe.ca> From: =?UTF-8?Q?Mika_Penttil=C3=A4?= In-Reply-To: <20250423181706.GT1213339@ziepe.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: M77WPS0VoJ6g8YXyw-jOxOSD7AXWLzXdSHIaqoqfRCA_1745433447 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C174114000D X-Stat-Signature: zqiamfr3y1kjekeh49ne7pb9g8mj4nss X-HE-Tag: 1745433452-741104 X-HE-Meta: U2FsdGVkX19MORXGImcYrLReTYKOIRhFOdAX/faOCrkCXO3ZDQr65STHUM5POCycRvqVrXW/gtRu0S3SXK1T4EGdZz76Oyfmkq3lHCWzdmFsDAhSjGeZoBT4tA8Mm5jMNw5tDt0dtfMLowdHMw7bDU0rsYogzaN1ROulzuq1QXqusGlIWBYhyXmuYp99v+lgvTSWTMvrwHtQh20S9UiGnlqQ32ptMpqqrcrJBg2ROMRcJMJBnYM3JHvr1/8X6dkQ+F+HcuSakF+G58DOiX5zFWEk7wZ3U6GjOPdcUcnNDFZ7hwvo3bt4ajK+Ffspi9ctsao/dv3xkZXLPCMWVa0M8k8FL+r5a4xjHcgw8V5FJBt9j3lGpEbSc+AZtB84INS8ov0LuPKfQoAmKfKanpadf4t2bW6B++UvY4Ws/ZuIhZiJuKbIwdofktRdGFyhmOtY/Oh8cmVH7yBt6oUgZnuF8Mp9VL+VJAvnjUlAgWnzW1T1Dbcv4Gjab98MEdoQL/5T5ZvnZl3UiS0qEwH7ND9vuRZRWqet4fG9FIWr85roGXV3uB1e0qxNJyzVr6U9gqTqjF1q29Wy3VGbghBzIwG9u0Oi1+QT/aNVf+46BHlhxYfWTzUHKQI1IwJFk5OIfPs6fADUm3FML5ddJ7m0vIvmWSLXBOLVabJMOZn8KBRIs9/OlO9BfEelbMYKlKyie0lyWlitXGKHClgxkFDO/6ko2TRvUEcZoXA9RfxwhImXkt51VjJTVbNboAUi3kOp/RYqypnKfYYMBvGFjOsD90da7rubMllIhq2kgcm6rW+CNCs69xIXrQV5JH+PYKvCi7PXhMACAz/PXZn05HsBtnWEbB/yqwBwt8UGkg8juBbwczj1QW0jK2SCUwlMeNHGd+s20/oXhUV+lr5QvXeTwXZAtve9LpOyodtkH91S20Va1sXixJPRvWxYV8qS5U9T0gVwZlT4556GsQqIHQ6CN46 DRIVS4Xx BYbVOZexwQejVt0XKxYAOyh7I9OW+B2pVFJ6frXJsLJBhsTnUGUshrHteDCmFD1ufKmih2TnDGA6KuIpoaXRURT8FQ1XNORVYhDxvFRyl6Qd+2fAl+4vqQCC2QKx7a/yNNe9L5xhJDAh0kPP+z7ryl1fb/ABN7vGTv1AL9PVhGIAdXvNxSdl42z0dOEJoj9jCofDsW4r3s0Z08JXGl9hR0jFisDFVxZIVO/uqwriwQlWZWi48T7qrlgr6huNKM6AToBi+YWgPhuyZwSLuC7ohhJg5oMiLuwWS7LaKSn4Y4y3Jie2/5HGwLsq9r5uEFjkctuqvsw1e/wvrrZ8euhfzJ/9LT89XPtPoMVZBzDlgEiU2T/QrtQE3439QbWw0u4y/XxrZmjR3hMaz5MUfcDKaRa1mANID6ku2yhYqhWKPZQe8q3gIsI81s9xTYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/23/25 21:17, Jason Gunthorpe wrote: > On Wed, Apr 23, 2025 at 08:54:05PM +0300, Mika Penttilä wrote: >>> @@ -36,6 +38,13 @@ enum hmm_pfn_flags { >>> HMM_PFN_VALID = 1UL << (BITS_PER_LONG - 1), >>> HMM_PFN_WRITE = 1UL << (BITS_PER_LONG - 2), >>> HMM_PFN_ERROR = 1UL << (BITS_PER_LONG - 3), >>> + >>> + /* >>> + * Sticky flags, carried from input to output, >>> + * don't forget to update HMM_PFN_INOUT_FLAGS >>> + */ >>> + HMM_PFN_DMA_MAPPED = 1UL << (BITS_PER_LONG - 7), >>> + >> How is this playing together with the mapped order usage? > Order shift starts at bit 8, DMA_MAPPED is at bit 7 hmm bits are the high bits, and order is 5 bits starting from (BITS_PER_LONG - 8) > The pfn array is linear and simply indexed. The order is intended for > page table like HW to be able to build larger entries from the hmm > data without having to scan for contiguity. > > Even if order is present the entry is still replicated across all the > pfns that are inside the order. > > At least this series should replicate the dma_mapped flag as well as > it doesn't pay attention to order. > > I suspect a page table implementation may need to make some small > changes. Indeed with guarenteed contiguous IOVA there may be a > significant optimization available to have the HW page table cover all > the contiguous present pages in the iommu, which would be a higher > order than the pages themselves. However this would require being able > to punch non-present holes into contiguous mappings... > > Jason > --Mika