From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D093C3DA6E for ; Wed, 3 Jan 2024 14:04:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C16E26B01A3; Wed, 3 Jan 2024 09:04:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC7006B01A4; Wed, 3 Jan 2024 09:04:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8E706B01A6; Wed, 3 Jan 2024 09:04:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 918D96B01A3 for ; Wed, 3 Jan 2024 09:04:34 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5C8B2A1D7C for ; Wed, 3 Jan 2024 14:04:34 +0000 (UTC) X-FDA: 81638170068.25.DA18716 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 50E1E40022 for ; Wed, 3 Jan 2024 14:04:32 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OImrNqN3; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704290672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dm5uQwn+49K96zJWxQsiqkazcQLayYKEShHZEQ+JYDg=; b=NU5FsXl185txq0Kxk3tE58C/qbsJm1J3KW4DR6JAbC2P38+GHSKmEEr4sS8l6TM8spMvUA pPZPLfvAeUHJuMSHBIhoKfrKthLUIrxE7tp4YjMv98t2EZucslxkEX1Poe9pOd4l1Jr1us L2ieIcgIe9eysKqXkPNL7LPFFYyVhNM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OImrNqN3; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704290672; a=rsa-sha256; cv=none; b=ZEupo4fDMlUBFcJWNzortBHWKLXFVh/fvrWcAk0rtXve08lz+jf7wErYm8sAfC6WmNSw1v Vk84WkVydFxicOOgeqO24aVUwC7xzDBmYqXke3YMwzCclO7L51D6KWAdgdZO15alZA6Pzy aPvjFc9Nx+k/HmWzDtlAeJggksEAYK0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704290671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dm5uQwn+49K96zJWxQsiqkazcQLayYKEShHZEQ+JYDg=; b=OImrNqN3nm2E/YRuaMqqhyWP3sI+mxdIUQSh0SG2ZgwAktAEBJEXVciIcFn+jGnERXEpf6 xvT9YtfM0DsoD/Sf6zfObapkw2NG1+s/5+FFRP7BZFyWq/Qw1Rr3QYWoZ5L/TQavYLdxUo a0NkmVHIi3An2pH/J7ZaGcP4bh3H0+8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-i-DxWH5nPu6c-fysuoabdA-1; Wed, 03 Jan 2024 09:04:26 -0500 X-MC-Unique: i-DxWH5nPu6c-fysuoabdA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1041384AF84; Wed, 3 Jan 2024 14:04:22 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 372852026D66; Wed, 3 Jan 2024 14:04:18 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20231221132400.1601991-41-dhowells@redhat.com> <20231221132400.1601991-1-dhowells@redhat.com> <292837.1704232179@warthog.procyon.org.uk> To: Dominique Martinet Cc: dhowells@redhat.com, Eric Van Hensbergen , Latchesar Ionkov , Jeff Layton , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Schoenebeck Subject: Re: [PATCH] 9p: Fix initialisation of netfs_inode for 9p MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <368445.1704290657.1@warthog.procyon.org.uk> Date: Wed, 03 Jan 2024 14:04:17 +0000 Message-ID: <368446.1704290657@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Rspamd-Queue-Id: 50E1E40022 X-Rspam-User: X-Stat-Signature: sy147hjuhxuoffj4wex9pktcpri3rr8p X-Rspamd-Server: rspam01 X-HE-Tag: 1704290672-943331 X-HE-Meta: U2FsdGVkX1/bA8BCRP7TFo6HTGPChPQqSsfmFhvQwoihI8Z4FgziZfzavBmMoeeOLZlg9xQWO651eITX0YiM9L0QGrkBtyTvTEJ/1dVXp2qN9rewyGdMoZOPCiemA7qFqnwScuwtRsEU4uUd8SArtyDVLsp/wYmOPZA4U4qTTnhhHUGh3Gg0ek3QVAftSIam7G1/OIrVWWM/Y5C/XYYZkmdMgoMt2YpFypzj3EsvGY3Bzj/EHi60tq2fdpZTBeCyDB4PDmAc65x88JefNeYcKg5cZXrkBzKjIaJTUIR/LH2/0VOg0Vblrtdv+uZBSvTyHsssNY+pCyCnyLP7sBMHDPr7HBI3qTJ9J5Ml5TCxyyLmlmsC0vUT/cdfD+6Nqcjz8YmSvsL8aVoNMRJvXq0Th3aTd55dzFB2VKE9KWLtcGZBDUl4ZMbppZTKLB4WZrji3p3YwuyVoluHQDUVi9O4PQdtr55JOkSrQUhQ3dMwnTaFIiHXiW9WVyGJ9ZWroYiss0GgLIYwmjZ2+d6rHn8IuKgQXjwy21Mg3i8yAApP5Jfmh22y3QmvWRXaAn+7D5G+O4q7mn+Q/TBg9IMyNtrb71LbAqF9+yeROdP6dDVa3dUPqTJvk3p1dyHjm3ZgnvGPzBaQmjYXxmCuioyn0mbEK+ZtGWKdPiZTP8NfC7iyD2ymmRcC0w5UzLiZu5OiUYh6qxP7bS5OmEmrxVHBETgWBcsc4LDzykzQyMWSYiCDVNJvKrqAJnoNMtgoNo9E2zNkeShI3CzT/kwNRBIWsuCTgrMiJVlZ4vpCBtvCrw/24mb/+8DH6VDGN7Jp974rUU6nnnaRIvjELvlH9JUk0Ji+imPdskxhW+HtiwyGmy6J08mwgCiPmHui5LSa7HQrq/OPHT/yfwma3z+bImlwbqUpoAtW9E8ctSmpMGIev6zTO2Q3KAioX64z8RQFUf2XJkmQrtpzEInoCR+bMcEzvHP fK5XBjvm udCt+W0b3FI5Mo5ciFHGbsIESmf4VOZLDYWQ5tBcK5APpWNktv3CcvY9W0Ly4sbnyiUe3FXd+yvfLH1DjVzQ19BBYvxRKeWl+lkYueFrGKtOxqP91o4nX9tFsETXWnrn3HphbUk35G91eDf0nEZqawqSKeO6Pxx71qWyjzcC4hLySfUWqIlGj+L5olRYpOFp75l7qX3TvlnkmA6JnKg1h/IcEMcc8FOCI9KT00SPYfMhOGrDqvy9xJINrk1bdcTY09LKNAYv4NYEtkLg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Dominique Martinet wrote: > Would it make sense to just always update netfs's ctx->remote_i_size in > the various stat2inode calls instead? Btw, v9fs_i_size_write() should be redundant. It should be sufficient to just use i_size_write() as long as you use i_size_read(). David