From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EABECDB47E for ; Thu, 19 Oct 2023 03:12:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D31EE80087; Wed, 18 Oct 2023 23:12:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBB8180081; Wed, 18 Oct 2023 23:12:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5C0780087; Wed, 18 Oct 2023 23:12:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A1DD680081 for ; Wed, 18 Oct 2023 23:12:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6BB9F120440 for ; Thu, 19 Oct 2023 03:12:15 +0000 (UTC) X-FDA: 81360737430.03.B0019C8 Received: from out-203.mta1.migadu.com (out-203.mta1.migadu.com [95.215.58.203]) by imf24.hostedemail.com (Postfix) with ESMTP id 761E6180007 for ; Thu, 19 Oct 2023 03:12:12 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vHR5GN7t; spf=pass (imf24.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.203 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697685132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sdRbdmTqIVWIQiBunchnjyRkLxfYXVSBe4eJv/kibxw=; b=nhd8pSbcUiqsa3ruXl1+6RTrVWw0RowRqTQ/Q9AQkg6Sk9SmXsAKHbszdiV1gm1pzKWvhx Np7VI8UAZJVgStoQYpP6sJgkJ3YcMXjSKhdw0XPbwfSSGg2P0eWkOw0NNqnmaxsx6MLzka Fo5kybM9PCscqMyYhCkUFmqXG3tfp60= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697685132; a=rsa-sha256; cv=none; b=rsfSCqeNHzXGDNJ6Ui4UOwYDD8Vd1cHj0uzLwZIUHmzP5AI0t/QHX3YjVKdJRBICuhjVP5 izGhPo85viTjxhoeOpP53mh0Qv62OaIpKBL7OcHAh+c92uKsymSapDyOdMZstQQ7XMwkRZ i7ou8eeJjtL45U2Qr+sibdV2Oc6lVFw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vHR5GN7t; spf=pass (imf24.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.203 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697685130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sdRbdmTqIVWIQiBunchnjyRkLxfYXVSBe4eJv/kibxw=; b=vHR5GN7t5FJjTs1VvuImp+7zOdtNGQlU0ySVTFZU+yxOoUt2DxLABScqPbYIkzj11DuKZw /gyc2aFR1pFTiC5SteAxlrtBAXD5B945anS0l4FWU0q8MLKEqnHuWgkjei8yr3z0wuncdS B3bWZtfRqaOVgKY+Oys9gr5mtqFt/TM= Mime-Version: 1.0 Subject: Re: [PATCH v8 2/8] hugetlb: restructure pool allocations X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20231019023113.345257-3-mike.kravetz@oracle.com> Date: Thu, 19 Oct 2023 11:11:06 +0800 Cc: Linux-MM , LKML , Muchun Song , Joao Martins , Konrad Dybcio , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Barry Song <21cnbao@gmail.com>, Michal Hocko , Matthew Wilcox , Xiongchun Duan , Sergey Senozhatsky , Usama Arif , Andrew Morton Content-Transfer-Encoding: 7bit Message-Id: <367C3465-B07D-402A-9647-9E0890130107@linux.dev> References: <20231019023113.345257-1-mike.kravetz@oracle.com> <20231019023113.345257-3-mike.kravetz@oracle.com> To: Mike Kravetz X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 15do4d68xsg98emmfuhssunb6i64pj74 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 761E6180007 X-Rspam-User: X-HE-Tag: 1697685132-375131 X-HE-Meta: U2FsdGVkX18XvPpRBhVQXlMrZNXIFwLkIEq81STADZ95/mwY35B50KpErobzNPEEVWM5+46vqFvXMivF+RPDtzxLy7d2awlptIWjyKHnxyEAr/ngjL6TdqD1fq9Du9kYld/YsQiMWK8/tdiWcr3yMWkobkzbtuUcKkNNF7hknKrf1yDmqW41/YmJ+0b+xT/M2+IMOV5JiKd+d0Q1/f32itdSXs3YXRNwSuY2OtQN0I1ttmzds1UFm6UjTDBno5c3qdyRaLtjzPQjvXXSB3RDqHQ3AhLS3ffJ1jQ6yMMt4FqKxgHffkRvS2f1R54aK5U7MlgLO33jklQvGQaNEpmj53MKdUh2T7eskv2c98dIyCBEEYELSIyT3R5r3IW0MYZmzg2hJ59OMu8pU0OvD3eevtcdKYbmsJfcQYP9JWEanKq42EBUnhLNChZM0Xwz6fEUNX3jEzepnh6CjWmHsGA8lAj8Eo8ZPbtjyrcKBXofb95rc6QFp/B5KPKnbu8rIgt5Zf4WRNnNadhPpa3KGXoAivGECl5qisyy7dUIxMugifay4nU1MPQFTTmxGILkVRw/so4vzIJPuAdUSuH+4TGg7u8bQerUjJkiUoIk8F0kv4Jrw2rjG0eqJevCr6ZahD5xrVyudo6cnvRzwNVT7d+anIRjk6+T4UkRPOck9d8fYj656ZFf+pGG0mhgURobtShCy7/sRaQGkYvsv9F2eBcOguGILiQo4iHyXAjDeeNbYXI44oyJJjQ4SASvNaSHzyp66p8Oevd2n4+rfDn1AdeMOiLdbLrDsongp8dArsKz+ciBuHuDOVBuc2dgush0gjTf2M5UyunJCNc+wQQWfqtpoRnRVFr0WpDUAhVNqk3Z+hVigJidaG94um2/7TGiqNT0juENsXhiypNjrcjqWgMT11zPk5qya79YAsX/ln7ttfIKBn1X9CfCVzcJYe8vyQ6nIZeO9r9JiHs6ZHTGPwU dbJEYTP2 FDxYmyXZQ/IHmeSkhJ+SEfIfCDvAV7pK49nU+LrGsYKC3aadjYwwp/rI9wN1aXpz3TUR+SOSfHe8exjZfKyRQQTVufnce/Tz2vhrhryXyPko+CeL7yw7DDrI9wEbD+BvSGXgrUdJyaZlaIiUitBoGT4Jo6r47raHKJH3Y0WGZHGwQRizwdFl0ZqJS27fds1H20hC2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Oct 19, 2023, at 10:31, Mike Kravetz wrote: > > Allocation of a hugetlb page for the hugetlb pool is done by the routine > alloc_pool_huge_page. This routine will allocate contiguous pages from > a low level allocator, prep the pages for usage as a hugetlb page and > then add the resulting hugetlb page to the pool. > > In the 'prep' stage, optional vmemmap optimization is done. For > performance reasons we want to perform vmemmap optimization on multiple > hugetlb pages at once. To do this, restructure the hugetlb pool > allocation code such that vmemmap optimization can be isolated and later > batched. > > The code to allocate hugetlb pages from bootmem was also modified to > allow batching. > > No functional changes, only code restructure. > > Signed-off-by: Mike Kravetz The difference is small compared with v7. So Reviewed-by: Muchun Song Thanks.