From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8B0CD1296 for ; Wed, 3 Apr 2024 09:05:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E67546B0087; Wed, 3 Apr 2024 05:05:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF0136B0088; Wed, 3 Apr 2024 05:05:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C436F6B008C; Wed, 3 Apr 2024 05:05:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A421F6B0087 for ; Wed, 3 Apr 2024 05:05:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5635280D4D for ; Wed, 3 Apr 2024 09:05:18 +0000 (UTC) X-FDA: 81967636716.01.9BDB9B2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 06BAD100005 for ; Wed, 3 Apr 2024 09:05:15 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aU2sGCTQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712135116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VZBTSQsPqq5JaVsmr3rpbt+Abvnae+DLSobKBrS3xEU=; b=zvR9Gz0KTphnqQznP6QxYSw2Z95U2wuschQtbxEsx8yhWTifbI0NM72yUQt+CvspOsmfOJ TmJ+LVMuIEgVSuFYRwoL0EjbxS/WmIZOP5sHrHJsBcut2PssocJk1QPnhqUzAqUIF3tG+l J14ie3V9mJxh87b6nxMuiaM8TBAWz78= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aU2sGCTQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712135116; a=rsa-sha256; cv=none; b=DhhURsWzaCq3jeY8RiGqzZactiArTuUzN+wq8rLxs+K+Tb+Ur0i4gapKOBLtklXTuYWrzW U1eO8XAU11qLXdF/26LQDyx5s4yenJKpwhgxQc4pl2LcT0xxDX5KL7puFZ3nhSeq7AnnWj I4cO/g9XMhEO+BnNJ2NJvUHvvieqq9g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712135115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VZBTSQsPqq5JaVsmr3rpbt+Abvnae+DLSobKBrS3xEU=; b=aU2sGCTQji7UHdnRP1mBIJBiTzMTWoXA1IzLvnQRt07MoaI/W0CvMywEw+6MB2S8Il60tt Y60nrVSBljcIO2OYMrUiq7Bqfsxd4s94feZIG6s2pv1DNndvIt6JS/hcmQlyT3ouzzfDE4 3rygWmklwzh62qJCCqx+IceAL9q8ATg= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-DT4KRBHpPjmkw5-LiB12xA-1; Wed, 03 Apr 2024 05:05:13 -0400 X-MC-Unique: DT4KRBHpPjmkw5-LiB12xA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d6b9530792so54752211fa.2 for ; Wed, 03 Apr 2024 02:05:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712135112; x=1712739912; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VZBTSQsPqq5JaVsmr3rpbt+Abvnae+DLSobKBrS3xEU=; b=ufEGnlyP5L3kbzR+knW8Ii5aWNS/B9tVw5AjXyLhQZvjDgFgmAECmtqaF0ok0eHrqW 9jrLPiITqmV6hShkdgGKFJDQPrpML5YDMvbH4zNdHCuccD6l+0nLbPO2R8lzdJgj+7qD 8BZJjJtB0l3PWXkPz3uDTnW0nkgb3/FSV4xDn9LkvKxNYi+PtiHQX9Sr0rDANmN1XpvM TSVyJLC3poPJK5lWtUh5D8tN5MOBichTnEf3G9KaaRlEpNZ/yo8YxjXobjwC0xmRBKK5 TvcD70K/t+HingzE7x6XVnuZG1Jh9w5qMDNKcQw2urx+JvtfEgnh6vguMlWJFaAcVQXm fJRA== X-Forwarded-Encrypted: i=1; AJvYcCXrNOUyeyWkecZc+iZgOhBUrcl6/JHCmqUA+qI7yPMMqut9VmrFiSb1q1XUu6Rd1sF9iPOX8BqDJMRWh8kwRY6oY88= X-Gm-Message-State: AOJu0Yw+tNJbAmcztrIu+b6Sealeyu8B105g1eIHQg3FRsYky3iLtjPN 1/55GZZTXMVWPnDf0dSb1O/4Zgo00inIJ2nnP2Tln4AqchmFM+PpGz175UKT1EtGQMgM0bj27AD OSlCztGzLrnbjLmUVBilx4xKaJzx5s6wEq9p4BQI2B1+Ldivz X-Received: by 2002:a2e:3c0c:0:b0:2d6:f5c6:e5a1 with SMTP id j12-20020a2e3c0c000000b002d6f5c6e5a1mr3443995lja.12.1712135112219; Wed, 03 Apr 2024 02:05:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaTvRUayfmYqhB09FMxmO/NjOVOftQqeEuVXfOE3uMqS/IxiLG6g9qjiSf8SmgpgMqq4+swg== X-Received: by 2002:a2e:3c0c:0:b0:2d6:f5c6:e5a1 with SMTP id j12-20020a2e3c0c000000b002d6f5c6e5a1mr3443949lja.12.1712135111702; Wed, 03 Apr 2024 02:05:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:3100:2d28:e0b7:1254:b2f6? (p200300cbc73b31002d28e0b71254b2f6.dip0.t-ipconnect.de. [2003:cb:c73b:3100:2d28:e0b7:1254:b2f6]) by smtp.gmail.com with ESMTPSA id n38-20020a05600c3ba600b00415509b11c3sm17059968wms.22.2024.04.03.02.05.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 02:05:11 -0700 (PDT) Message-ID: <36755b36-0cc1-4833-913b-91a45c8fa7bd@redhat.com> Date: Wed, 3 Apr 2024 11:05:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: add per-order mTHP alloc_success and alloc_fail counters To: Ryan Roberts , Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, willy@infradead.org, cerasuolodomenico@gmail.com, kasong@tencent.com, surenb@google.com, v-songbaohua@oppo.com, yosryahmed@google.com, yuzhao@google.com, chrisl@kernel.org, peterx@redhat.com References: <20240328095139.143374-1-21cnbao@gmail.com> <56027891-090b-4501-ae0c-a86077caf303@redhat.com> <502e5ff9-9b3c-441d-8bb5-bf94b78a4aa4@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <502e5ff9-9b3c-441d-8bb5-bf94b78a4aa4@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: tjitdw8snf4w731u7tqhckcgdc5zaw3s X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 06BAD100005 X-HE-Tag: 1712135115-472588 X-HE-Meta: U2FsdGVkX19fs//zbx/XcnXLIVmnS6xIWlIcYsqdAJscgR+d6YLco3ahnI2YbwUJuxrmCKzXA9922zv3647fRA5qvCVs+54MLgLPYjw5e87dPPG9FF6X/Etg+q4m49r4ODO+Pdf2UoIISR88BzTdSGWipktKn/upxDufAQ0BLlpEGG1QcfilzDAJe3A2vq/YL2YwJS4hB8ziOXQYLDqLPYFys/9zeCwK9g5bsn9kZtbxZmp0J0LDFUdIG6Mm85u76cNt4n5J+ElJ4ixPr/jc2lOn2jItugwjJ/Yr9jgEgC5PqP91fDUq1gt6uTFojA1A2NUGRIfVFTML98PeNTSgHYC3fLsbe97wjFBtFU1xHvigdyJIpRIfxEOlCrFryivu7yCmkRwyLXDvCfdlEeFzA1k9mjO83Na2C6kHG/PplPApWEANdlYh/Obp/Lx4HSrsmuqcWtoiKqzbhjwCQEeYt+OMic2Cw9mZHQPXDpGzp4OkuLbZapZDdwK1ju7EN9pXGTVXgkDAicncA5A2IsS5rz/358aW47drNh7hq1JFq4CYi5NmW8Fdo6zdNR5M4Bpc+UiAh/+wfIMehgXLi1LCmQTQAjST076jp+HuxQ4FiaFcFunqKaS0EVhF35u/IFhiCD5JuP5Ya43Mi5MI0TJDrAyj2Dent4evFC0ubzm9NqRLfNFbJrVR0vpJGBx0uGkYhdEa61XDbIuxmEVqitDn2n2tohM58g0CuQS2kkR0EGY2LIx9rg7HYmVRhDQhFpXHbVASsDZ6EWQ6GdUC8aZT3G+7pc5Y9b7rgnx3Vwk5Rju4c23Gi2cky6T+ACfInxXkKvp1FUf1PMkWHGBfPuV7nJcuz2Bdp2BMffV2CizL8BY9urDrVTDDv+VuBy/GMuYFN2BiwEjGrmaXozrch4WsNcVf1W8USrybQr8gxrTKJcS2sRYTuOXlBiGvW9yKZkoHzhhSSqUnYu+5OAtyfvE zlaoxc8G gaEJLYetLMI1PAEZ5jIQCB38Mx5+xjrfsyN8DDxoLiTeipFfLZXNO2IhCwBAiPnH4ACcLYyzVWrHcpdKm1DcOj9PNicR3vHxcRgci+tmI8AF6/J4OohH+1l6+rCxt/6j+I7c3ex5114GA+HyyKfesugNIOEhyWxw2T6hqD8XVuSkPiVscr1dWl5jwn47VntK9exk6bo1mM2mOuev+3tFkcbyR0sc3f8FrwJvYz3T/0nrZpqLJ3DJay/mIQNf1bRY/cPimw6tsU64A8MU7tbMCPFHSu5k6tfo21EtwheGeboKeTUwx3ebpIHtcWBRdmSE4Mj9Z7X1m91IKVwJciD1KW0L7aqj7wNyf9ZV1Cm0xBXla+K8NkiYqqQdcW6suV5P7VzEWhUKB2adQBt5qyzQhan9dyDmHfD5f+3Qq8weemLxou8bCDGxt3x/Y0X6WhWVsAzIiNbPoFayQC4Yjzr4B5OFQqg4zXyYmdmwCW93XApP6aerpOA9Ds7moZKUit1JJFSEzL3AoBDoUAHOiJebfVwMDQHT4tUQ4Mxgy7NzNUho9pz+YQVhGAA2FMB1RH/c7jJUtY17AcYZsQO7ql6bNWnD8FdxYF1dT4PmkprxuzFAYeEdXs6DsUHJFstPo8+ZOBukyI7Y6bxoPIg5FQq2BhXRghg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.04.24 10:46, Ryan Roberts wrote: > On 03/04/2024 09:24, David Hildenbrand wrote: >> On 03.04.24 10:18, Ryan Roberts wrote: >>> On 02/04/2024 22:29, Barry Song wrote: >>>> On Wed, Apr 3, 2024 at 7:46 AM David Hildenbrand wrote: >>>>> >>>>> On 28.03.24 10:51, Barry Song wrote: >>>>>> From: Barry Song >>>>>> >>>>>> Profiling a system blindly with mTHP has become challenging due >>>>>> to the lack of visibility into its operations. Presenting the >>>>>> success rate of mTHP allocations appears to be pressing need. >>>>>> >>>>>> Recently, I've been experiencing significant difficulty debugging >>>>>> performance improvements and regressions without these figures. >>>>>> It's crucial for us to understand the true effectiveness of >>>>>> mTHP in real-world scenarios, especially in systems with >>>>>> fragmented memory. >>>>>> >>>>>> This patch sets up the framework for per-order mTHP counters, >>>>>> starting with the introduction of alloc_success and alloc_fail >>>>>> counters.  Incorporating additional counters should now be >>>>>> straightforward as well. >>>>>> >>>>>> The initial two unsigned longs for each event are unused, given >>>>>> that order-0 and order-1 are not mTHP. Nonetheless, this refinement >>>>>> improves code clarity. >>>>>> >>>>>> Signed-off-by: Barry Song >>>>>> --- >>>>>>    -v2: >>>>>>    * move to sysfs and provide per-order counters; David, Ryan, Willy >>>>>>    -v1: >>>>>>    https://lore.kernel.org/linux-mm/20240326030103.50678-1-21cnbao@gmail.com/ >>>>>> >>>>>>    include/linux/huge_mm.h | 17 +++++++++++++ >>>>>>    mm/huge_memory.c        | 54 +++++++++++++++++++++++++++++++++++++++++ >>>>>>    mm/memory.c             |  3 +++ >>>>>>    3 files changed, 74 insertions(+) >>>>>> >>>>>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>>>>> index e896ca4760f6..27fa26a22a8f 100644 >>>>>> --- a/include/linux/huge_mm.h >>>>>> +++ b/include/linux/huge_mm.h >>>>>> @@ -264,6 +264,23 @@ unsigned long thp_vma_allowable_orders(struct >>>>>> vm_area_struct *vma, >>>>>>                                          enforce_sysfs, orders); >>>>>>    } >>>>>> >>>>>> +enum thp_event_item { >>>>>> +     THP_ALLOC_SUCCESS, >>>>>> +     THP_ALLOC_FAIL, >>>>>> +     NR_THP_EVENT_ITEMS >>>>>> +}; >>>>> >>>>> I'm wondering if these should be ANON specific for now. We might want to >>>>> add others (shmem, file) in the future. >>>> >>>> I've two ways to do that >>>> 1. rename to ANON_THP_ALLOC, so that I can have SHMEM_THP_ALLOC, FILE_THP_ALLOC >>>> in the future; >>>> 2. let THP_ALLOC cover all of shmem, file and anon. >>>> >>>> following vmstat, actually 1 might be better as we have both THP_FAULT_ALLOC and >>>> THP_FILE_ALLOC for pmd-mapped THP. >>>> >>>> #ifdef CONFIG_TRANSPARENT_HUGEPAGE >>>>                  THP_FAULT_ALLOC, >>>>                  THP_FAULT_FALLBACK, >>>>                  THP_FAULT_FALLBACK_CHARGE, >>>>                  THP_COLLAPSE_ALLOC, >>>>                  THP_COLLAPSE_ALLOC_FAILED, >>>>                  THP_FILE_ALLOC, >>>>                  THP_FILE_FALLBACK, >>>>                  THP_FILE_FALLBACK_CHARGE, >>>>                  THP_FILE_MAPPED, >>>>                  THP_SPLIT_PAGE, >>>>                  THP_SPLIT_PAGE_FAILED, >>>>                  THP_DEFERRED_SPLIT_PAGE, >>>>                  THP_SPLIT_PMD, >>>>                  THP_SCAN_EXCEED_NONE_PTE, >>>>                  THP_SCAN_EXCEED_SWAP_PTE, >>>>                  THP_SCAN_EXCEED_SHARED_PTE, >>>> #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD >>>>                  THP_SPLIT_PUD, >>>> #endif >>>>                  THP_ZERO_PAGE_ALLOC, >>>>                  THP_ZERO_PAGE_ALLOC_FAILED, >>>>                  THP_SWPOUT, >>>>                  THP_SWPOUT_FALLBACK, >>>> #endif >>>> >>>> And reading mm/shmem.c, obviously, shmem is using THP_FILE_ALLOC. >>>> >>>> I will rename it to ANON_THP_ALLOC in v3, let me know if you disagree :-) >>> >>> I don't think the name of the enum is important - its an implementation detail >>> that can be changed. Its the name of the sysfs file that matters. Although of >>> course its nice to keep them in sync from a maintenance pov. >> >> Jup. >> >>> >>> Currently they are called "alloc_success" and "alloc_fail" I believe? Perhaps >>> "anon_alloc" and "anon_alloc_fallback" are a bit more in keeping with vmstat? >>> >>> I'm assuming that: >>> >>> vmstat:thp_fault_alloc == hugepages-2048kB/stats/anon_alloc >>> vmstat:thp_fault_alloc_fallback == hugepages-2048kB/stats/anon_alloc_fallback >> >> Or an "anon" subdirectory ... not sure, just a thought. > > I have no strong opinion. I'm thinking about how to easily display all the information though: > > $ for f in /sys/kernel/mm/hugepages/hugepages-2048kB/*; do printf '%s: ' "$f"; cat "$f"; done > /sys/kernel/mm/hugepages/hugepages-2048kB/free_hugepages: 0 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages: 0 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages_mempolicy: 0 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_overcommit_hugepages: 0 > /sys/kernel/mm/hugepages/hugepages-2048kB/resv_hugepages: 0 > /sys/kernel/mm/hugepages/hugepages-2048kB/surplus_hugepages: 0 > > $ for f in /sys/kernel/mm/hugepages/hugepages-2048kB/*; do printf '%s: ' `basename "$f"`; cat "$f"; done > free_hugepages: 0 > nr_hugepages: 0 > nr_hugepages_mempolicy: 0 > nr_overcommit_hugepages: 0 > resv_hugepages: 0 > surplus_hugepages: 0 > > It looks cleaner to me if we have all the info in the filename so we don't have to display the whole directory hierachy. > > But I'm sure someone more competant with bash will tell me exactly how to do it with fewer chars and an even nicer display... Likely something involving "find" would also work. Once we have stats subdirectories it would get more involved. find /sys/kernel/mm/hugepages/hugepages-2048kB/ -type f -printf '%f: ' -exec cat {} \; -- Cheers, David / dhildenb