From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82E16CA101F for ; Fri, 12 Sep 2025 09:20:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2EAD8E0014; Fri, 12 Sep 2025 05:20:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFF028E0006; Fri, 12 Sep 2025 05:20:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEE818E0014; Fri, 12 Sep 2025 05:20:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE67E8E0006 for ; Fri, 12 Sep 2025 05:20:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8AD3011ABBB for ; Fri, 12 Sep 2025 09:20:14 +0000 (UTC) X-FDA: 83880051948.22.D8F3F7A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 0B1E91C0009 for ; Fri, 12 Sep 2025 09:20:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JIgFH+24; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1757668812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+MzP8ZtzjuFzx7no/Z95bzESB3nOqylto37d5k77ugs=; b=47QzZr73zb1I6LUZXyryjxgTYNWFRfwC+GFtrhC26+3juhlu0P1Hiw1UDUwGpVd0clBgw7 4BI7JGI8tBf3e5Ni+WyRDKuuxIxjhGi3ZkoQ7Bur72wDE+GkgyX5zOO0m0F/N4QL6wt/Ih RCmxWfah1/hRxudVcRBxjMYFTZZnfmw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1757668812; a=rsa-sha256; cv=none; b=dh8AFbY5W0byqvzZUtaAcC3k8RRd4XUc2E/Jp3PjMT5ILoNeq+1ZkEza1Lvt6n59LbUBpT lFCjz3m/AykEIa1Qd4k55MiZOIbKqlQ+k8/Qsmd0ndPMS2t0+RpRX4CNnHYfx0LmvJoocc Ez9UA1bcyedNls5J59xrjIFRwS/AD0E= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JIgFH+24; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757668811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+MzP8ZtzjuFzx7no/Z95bzESB3nOqylto37d5k77ugs=; b=JIgFH+24Jj9eHdrh2r65d4whFVGZufAQ+j/FAkutV92PVhRkzAHJ/yOY9JZlTRpjm/wZP+ iI0RcanYPQB1SnWjvfJyidjhtEzVKNdvgvttpHrxhp2+8sgwGefP2R0jmvx5SAgyJ8SQpi bp6NwxNeonrlymbSvAQc+16C0KSL26Q= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-EoYle17gP96sPS3MaBMfaA-1; Fri, 12 Sep 2025 05:20:09 -0400 X-MC-Unique: EoYle17gP96sPS3MaBMfaA-1 X-Mimecast-MFC-AGG-ID: EoYle17gP96sPS3MaBMfaA_1757668809 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45b990eb77cso10308465e9.0 for ; Fri, 12 Sep 2025 02:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757668808; x=1758273608; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+MzP8ZtzjuFzx7no/Z95bzESB3nOqylto37d5k77ugs=; b=AxpwPxdlbLIAD3AkUscHyur8w2zlhQYLoe+/VlNTLmCRIPj1XfAQIuXXuvR45tFk5v MOG+qsLXd1DVYD33Qi0aH3ftNBLZqJGjOgwHATcwBe1ntiS+Wh4DOZ8JTvx1zcgZD2W2 fXIwOL+vEDxmyQCi+UsZk31M7wZWUVndJmxp3H5c83JrYAdEXTYm19mu5d6JhohF5Kj4 NuIziLW5BWdng2zuBAjc4gBlXTAHJ6Ia3NtUst/xCSnEFwts2AgMhGbFquvR26hNzDn9 gZvtd0eVDLJbEGEI9e+5Ydfbm1Rgh5UE/2DopgsPXM+V+RpZFifornH790sXu6n8s160 FKzQ== X-Forwarded-Encrypted: i=1; AJvYcCVfUVOmIrzhETAwuehmnKXEJJgSmYNLJF/R4RrH5Ad/aCEOOTzWelz5zQc9M3teQk78Q6NqDigrjg==@kvack.org X-Gm-Message-State: AOJu0Ywzhg2HLFnKOqzSdK7d8ib4dSxGPvnCUu992e0HKcXEPvWgIr9x ivhmFDWaMiu5pUG0GUXJG/1zwF8Y0pjd6VW8l/LjT/Q+a+Gc3cYy7Pdm/PqPxVO6F6VTofR+p9Y Pepg6v9+B0rdyYmIKMQxIMhr0c/Y0TU6C+Nh9nhRbkez/AX443Mr2 X-Gm-Gg: ASbGnct0KcjVt3bXLR42nR+Ac11zM+uVMRckEgxP9NA1wvl+4LwwhLCl1oMaxkUMEV8 cr4tXApPgRE24aK6/Ck0GfeYP/19jhn/kERkNiGR1ua7sdO9sgtbTN/jK4gx/gPxQwUBeQPbQGw /fXA9GNkH27T/ieC8W6TIgajEyb6mGUoyOmcznDuzlWGB4549hPDl6QYQWl5wdFfhHzbgddLr+j nIBmiRdl5oAmjBGlwYzBYLFzUJfybNr9RwK0vtQ4DThCyMO2cfSgqjMs0RUmFTMWMGC9w1QIMxl QmuxesmWlp2QCqalCP7exg2Cn2r8pZtS3eowouuBGFA7vaX2Er0V6te1qXiJYYirOI2U/84X5FL bEREsXKqRccYTy70wB7h0k/u8WEkQq0zCHPPh4PJ1TgouZkpwVL5Yh1OoOAcPfIEvVAA= X-Received: by 2002:a05:600c:c112:b0:45b:9b9f:88cb with SMTP id 5b1f17b1804b1-45dfd5fa22amr49779985e9.16.1757668808485; Fri, 12 Sep 2025 02:20:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXkEspv+20MlFbesTl37GXWHbZfquxB4ih7Dl0E1NZ+jD5GQeintUf727ez0VnQ0g0eWxksw== X-Received: by 2002:a05:600c:c112:b0:45b:9b9f:88cb with SMTP id 5b1f17b1804b1-45dfd5fa22amr49779515e9.16.1757668808019; Fri, 12 Sep 2025 02:20:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:da00:b70a:d502:3b51:1f2d? (p200300d82f20da00b70ad5023b511f2d.dip0.t-ipconnect.de. [2003:d8:2f20:da00:b70a:d502:3b51:1f2d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e0156c64bsm58222385e9.2.2025.09.12.02.20.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 02:20:06 -0700 (PDT) Message-ID: <3674bdb2-0e59-4f0d-8adf-4794a6db546c@redhat.com> Date: Fri, 12 Sep 2025 11:20:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v5 01/15] mm/zone_device: support large zone device private folios To: Balbir Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: damon@lists.linux.dev, dri-devel@lists.freedesktop.org, Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20250908000448.180088-1-balbirs@nvidia.com> <20250908000448.180088-2-balbirs@nvidia.com> <8c5267ec-cc85-4eff-b890-eb705472e2b2@redhat.com> <244005a2-4796-4985-853e-f916bdfd096a@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: X7kP61vYGBqBI7P8KeL9_WRrdX7OesXmCN54ZvP31Xw_1757668809 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0B1E91C0009 X-Stat-Signature: 49ssc89aten5cd1z994eh7hbmabqtpg8 X-Rspam-User: X-HE-Tag: 1757668811-487424 X-HE-Meta: U2FsdGVkX1+SUVavnA8/Gw7Zdrub0UXYLoz5ZXcJY4uiWriH3b3ryVTCbfngYCyLA8d5FRn3VDlfBTb27wk4lU5T1HNaxrHvdiGZvSrUX2cgX1wy16PQWyKoVhem2Gf5D53slozfliKE+5UF1DsOI7rfD76BwKmZ+3W6CPqS8qnAfN72sRJljrTYBNIhNT8rhr0H3Ekom7ESIoEtjamMreqkaSENjXhtYb5GLLlY+cR+djxME9zdcTENRygezlzaRVPBujtYeWqWrioaWZaStwc7LG0XzA/r3gs1VTmdfIZ4BlZcnJKcsbJvQda7os45Xg/sybwPyUV32kk3RinNbB6xQU1FC1GgM8K5rcMl3/2gRTnvbrxZYCBYIYqIf8X0YDd0NkwFU7XMG5XBISXeeros8WRNCrHT/13T7P1B2T7mN425EO7XwWRfJZ7NYCjMbevTEuKFkHvxJDo+H5skVdHZdavRasTuwJ7Ie8MrCsBK1i6BTYbb979gKiU7xhDLszYxuR0Pix5ZTEOfSBPK61LdUVF6G3HIbkwbtaNrN354ByodR9o+cAzaAT0MMwhGnKvl75C0iNAuVw4Hz7iseySIylzDCMov97RSoLOlxAwA52Y2Wfar9lc8jb8RU4ZKARJkb5raweWPT74qfFXBmsjoIVSaD3UyXEYeZxbKLg/LO98O/Evfyt5Zse8zuiEIhVl21Y62IJ6t+tkvhubsWqyCcN4i3d1B6JdyO34utE95V6PJwQHPCxlAAXZWzhPB9NOY95dgiP79xW2Hgeeh+Pj47MobFrmj5tBHNxYjy1Y1jF+0dSqkqiQVtchxftwaiuiAxRX/9X6bQqnrM+1c/ItUPRJR+6WPcMWot2xixtxN6ipQwiWkDT/MbJwN/t9b9Tg98th2M19WjP0qjKp1bkD8tE5E4UeRJ8aFMtBZHx7mq986zv+MfUIHYkEZYNstHx5VUyFTIumQks5OTWQ yX+5xilc ByX5g/5hL5p9iwMXJnX6hrScOOVOfN4WCHYmUb9VzyKqiCd5vk/dy3Dxov1oEL/qe9JR8n7GKf/hOJdoRZf4ZeM8x1Nj1CLqa4z1ODqZUBIZPIKrDlZbR7B0bQ8H+9TvH7J45CwuD2ax8kRMH0JR+TOhUAB7dtOClnJ1zezAZ5Idb597sUqIBk3uPVbVO374xx1ipx9P0DJJlw5HwyFJGxcbUElppNK5PH+zwA7jdyrwjbnc27mQV2f6vVd27/lXD3iqV4DbV6gbYdl8+qrB9OqPWyh+bGaokau5A8rYoJmvJI3A3nFSIiGmgcTjXmuIG30yspiLxQYoni1EonV0nyEUQt0B9RjCGkJ1jP9yoPTc37s0N372ITaFfNLivtSswjPw1vJTkzsiAwUl187iXzow8N4QHlyLXsqdfEFYzbPTrHiUiZXMMcYXKpoukkXFmvmgO5zLLcet+PNh77skqk4PA/IHJ/nLAKUdOTEcsml6ZEpI9ga7+qSUGMoe5HcO1+8zGXMsIOL353w/SlBmuVFzh081IoR+ctmPMTLiVyHqmUX5AtDEZRb4UReiXKSdJaFWEfbltaNPQojLS94DqZCKi0EiOcr4k1XyEhgWRJzAAimk7PBydKueLgQJHFVmmlkvufPJPxPqJeA99HwDBkNi66Ww9SKSJuQ7/WlN215vcW1h74AyIfa0Sca3DJZPSqkyvNd42wThZ+i2qXX8drODWlaFs53fQplQzgEmTP8MWwIywpWJhINxE5Kj3XZXwDUA8LkB7hGNl8wjDg9zGeY1UCD2xs/0RmKWLQqokBSvigEdIz/bggvp/wel4Q0vSLvTw/oUqLAV5AqsqD9ivq91MdpiPc/9mi7xx+Pkma6LiGmZ0849tdFORTl9C4AkJY7qJPCdDykydMku1DhziXRlKcx0GuCCCCjEMwZXP9tDnvN37WSOGokoOPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.09.25 06:49, Balbir Singh wrote: > On 9/11/25 22:52, David Hildenbrand wrote: >> On 11.09.25 14:49, Balbir Singh wrote: >>> On 9/11/25 21:45, David Hildenbrand wrote: >>>> On 08.09.25 02:04, Balbir Singh wrote: >>>>> Add routines to support allocation of large order zone device folios >>>>> and helper functions for zone device folios, to check if a folio is >>>>> device private and helpers for setting zone device data. >>>>> >>>>> When large folios are used, the existing page_free() callback in >>>>> pgmap is called when the folio is freed, this is true for both >>>>> PAGE_SIZE and higher order pages. >>>>> >>>>> Zone device private large folios do not support deferred split and >>>>> scan like normal THP folios. >>>>> >>>>> Cc: Andrew Morton >>>>> Cc: David Hildenbrand >>>>> Cc: Zi Yan >>>>> Cc: Joshua Hahn >>>>> Cc: Rakie Kim >>>>> Cc: Byungchul Park >>>>> Cc: Gregory Price >>>>> Cc: Ying Huang >>>>> Cc: Alistair Popple >>>>> Cc: Oscar Salvador >>>>> Cc: Lorenzo Stoakes >>>>> Cc: Baolin Wang >>>>> Cc: "Liam R. Howlett" >>>>> Cc: Nico Pache >>>>> Cc: Ryan Roberts >>>>> Cc: Dev Jain >>>>> Cc: Barry Song >>>>> Cc: Lyude Paul >>>>> Cc: Danilo Krummrich >>>>> Cc: David Airlie >>>>> Cc: Simona Vetter >>>>> Cc: Ralph Campbell >>>>> Cc: Mika Penttilä >>>>> Cc: Matthew Brost >>>>> Cc: Francois Dugast >>>>> >>>>> Signed-off-by: Balbir Singh >>>>> --- >>>> >>>> You missed my comments of this patch in v3. >>>> >>> >>> Hi, David >>> >>> Looks I missed your comments, just checked those were largely about alignment and >>> integrating the code for DEVICE_COHERENT and DEVICE_PRIVATE cases into similar looking >>> bits for zone device folio free and code-alignment. I'll take a look and update as needed. >> >> Yes, and the confusing folio->mapping = NULL that I cannot connect to THP support. >> > > I can remove that, let me reunify those bits, seems relatively straight forward BTW, I was wondering when we invalidate folio_test_anon() by clearing folio->mapping int he current code flow? I mean, this must happen at some point when freeing device folios. -- Cheers David / dhildenb