From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C5FECD1292 for ; Thu, 4 Apr 2024 08:01:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B475B6B00A2; Thu, 4 Apr 2024 04:01:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD0A66B00A3; Thu, 4 Apr 2024 04:01:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E6D6B00A4; Thu, 4 Apr 2024 04:01:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 713AE6B00A2 for ; Thu, 4 Apr 2024 04:01:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2BF41C0CF4 for ; Thu, 4 Apr 2024 08:01:58 +0000 (UTC) X-FDA: 81971105916.18.0B0E17D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 4A7F240005 for ; Thu, 4 Apr 2024 08:01:56 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="IwJre/A/"; spf=pass (imf12.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712217716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IE/xA/cazcP+HXhdhjRdwQDAS2gMvpTgfIxHPPrU41I=; b=JnebFwi5Jn2+6vDreu1a6GwU9gYlyCMFrvcYxw3YNmQWIVHx5XfsJYq07PRUxbOLm9Elwd HuzD4AyrUp5YpsC5zNZ9NG5DYri7brXnUK4qP6nsfA5V5RAE6KaJi+m3Jl5WMO/3FaGWPj /g6T/GCnjN5syJuN2ptmSsYaE0hN0Co= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712217716; a=rsa-sha256; cv=none; b=x/Y/aMB7aam7kIStl4R+QWTZoHN0HiVCE2tKH7ghvoDGFYgi/z1Pa9RYMy0gsb1xqzkFzS cnirz3HTlT4CXF3w8s8NGSwF14yJnJTk1PY/00Y5lBps5RiyMJYkvROebvQb6UJKvKxnxE CGIpSsq8aLM5MqD/YjCIgj0utEx8oTM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="IwJre/A/"; spf=pass (imf12.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712217715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IE/xA/cazcP+HXhdhjRdwQDAS2gMvpTgfIxHPPrU41I=; b=IwJre/A/07Ql0EObJeocI/0TiXdDMGqUjm/SjyYg/ZMrzKhZhd4OffCw5ap7LjGWIj0un5 WlXjYdBycfL/qtmzELFwGR1Mi7Fj13mhsqIfveDr60ORIloHbOBvohSigmC4l/9kXmQlbU vlMPn4ZgoX45bLyZqyGNe1ZoizFBCn4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-c0jY6rVYNYiCi_bmX-evYA-1; Thu, 04 Apr 2024 04:01:52 -0400 X-MC-Unique: c0jY6rVYNYiCi_bmX-evYA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1BF723C02748; Thu, 4 Apr 2024 08:01:51 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD1EAC1576F; Thu, 4 Apr 2024 08:01:47 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <3655511.1712217111@warthog.procyon.org.uk> References: <3655511.1712217111@warthog.procyon.org.uk> <20240328163424.2781320-22-dhowells@redhat.com> <20240328163424.2781320-1-dhowells@redhat.com> To: Christian Brauner Cc: dhowells@redhat.com, Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH 21/26] netfs, 9p: Implement helpers for new write code MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3666290.1712217703.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 04 Apr 2024 09:01:43 +0100 Message-ID: <3666291.1712217703@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspamd-Queue-Id: 4A7F240005 X-Rspam-User: X-Stat-Signature: thwwh8pbuhjst7a6bxokbxfnaz456i1b X-Rspamd-Server: rspam03 X-HE-Tag: 1712217716-556745 X-HE-Meta: U2FsdGVkX1/pHIORXBF6z5D5pemvnoi25fpjv7Bm0sX+gKItwwIRpSqvLxaZy1Frlao7BoWy8ohP8hEkKRAULXh3h94Yf+jqLfUW2A9PXwbQK6rzZlUzC4k1wEo1/WPzGx7ZiDPhRS6IhexKN/3MVKAJmQg00SwwkAN2sZe/EfmaNG4gNTo6R13Jx5Qct4jM+AUfPaSmBsviTmy2Sv3JBsHOQNaJ4tqt3gQxkt0z5G83ZCNb2er77x4NXrvJVsP5AnHB8wLs3sNsDE1/S02Zvehadiz5M1xyIVtvPfMsChYLP6rJ3Q8PyfyqqU8q7L5IKqW5xNQiOPcx986z21t1i+mk5AXNsbwnCDPL/K3vcdohblXyaAQXA1mIOxEL1ooCRZUYpRIKZw0qdDbHAXUmK65OYb8j7KyYqr++YhwlJK9XYE04LTk0BYfjqIzS9A8VpUcquVFNatTc1O9yanFOIli6L/1fPf6hikEszXWQ03SWuILn/B+84fzFIgy94nYxRQisACNdcTKJL7nAT064ctS5+eYT2Pstsct80ZyYOlD07Jwoaeu0PaRoG41djs6ZEUPjOyKtH2qXvD3VH8bf4rk701d1SuxxuRDZsLoSCqXyxiuoHNLW5thZqsmoxS886RMT3rDwXjhTHvytXbP10UA44U6gFCvuVUWfbegC303Iy2f0Ph1GhU9lODtxFnxnfA0Jtulovh2H0elaBX3Ix7OoC+BfokE/9/4rhNKLjxL5gpIHzaI5j/V5003ROo45y2atMGGjdGSlByNHcMo8Ktktv4332eequFmP/c2JNp+6/upv02mp5wjtaXsXo6+ToNlmSwOFRNjlv9j8H2wPFdqgpcgHo/+5uhBtQnD52hdVqCmWNDDo2buR3woL/eoqbgVRXOfSJ5/QfA5lhP+7DVkk+jLCqUrQXhEn9sTEwcGUQo0+lUxJzRwIDq9J1sHXq2BwAxvgHWyaMcMZmuh EBEB9+Z5 poBVtVQOqZrnRTm6FEEESh2gkppdRPJyKzFz2f278O5qeMbUnJuDTTht4D3Xkh2Z94kzFEnCf3JTGgpCurwOtPzbFDbWJq0GJMCWvUJaLqhI3H2nIGCWoajuW5Or0M9Q0Os8i034gb8lgOjy8wr7AvdKCysV0aJgcnvrS/VdxAc9BIK+M3UU3Lv/U8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Howells wrote: > > + size_t len =3D subreq->len - subreq->transferred; > = > This actually needs to be 'int len' because of the varargs packet format= ter. I think the attached change is what's required. David --- diff --git a/net/9p/client.c b/net/9p/client.c index 844aca4fe4d8..04af2a7bf54b 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -1670,10 +1670,10 @@ p9_client_write_subreq(struct netfs_io_subrequest = *subreq) struct p9_client *clnt =3D fid->clnt; struct p9_req_t *req; unsigned long long start =3D subreq->start + subreq->transferred; - size_t len =3D subreq->len - subreq->transferred; - int written, err; + int written, len =3D subreq->len - subreq->transferred; + int err; = - p9_debug(P9_DEBUG_9P, ">>> TWRITE fid %d offset %llu len %zd\n", + p9_debug(P9_DEBUG_9P, ">>> TWRITE fid %d offset %llu len %d\n", fid->fid, start, len); = /* Don't bother zerocopy for small IO (< 1024) */ @@ -1699,11 +1699,11 @@ p9_client_write_subreq(struct netfs_io_subrequest = *subreq) } = if (written > len) { - pr_err("bogus RWRITE count (%d > %lu)\n", written, len); + pr_err("bogus RWRITE count (%d > %u)\n", written, len); written =3D len; } = - p9_debug(P9_DEBUG_9P, "<<< RWRITE count %zd\n", len); + p9_debug(P9_DEBUG_9P, "<<< RWRITE count %d\n", len); = p9_req_put(clnt, req); netfs_write_subrequest_terminated(subreq, written, false);