From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17DFEEB64D9 for ; Mon, 10 Jul 2023 09:02:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 881676B0072; Mon, 10 Jul 2023 05:02:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E4086B0074; Mon, 10 Jul 2023 05:02:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 683BF6B0075; Mon, 10 Jul 2023 05:02:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 54E646B0072 for ; Mon, 10 Jul 2023 05:02:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 11CD580283 for ; Mon, 10 Jul 2023 09:02:34 +0000 (UTC) X-FDA: 80995111428.23.4724840 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf13.hostedemail.com (Postfix) with ESMTP id 43E9D2002D for ; Mon, 10 Jul 2023 09:02:31 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Rbr7ix11; spf=pass (imf13.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688979752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=RY1Cf45ecIWbc7NEFgS5rEslIyMu9IK3gvaqBb6Duos=; b=qDh2vjBmT5bTHZ4kBih2R84JIijd2rhic4JY4ngExtux0tGlG9KuJw4U15HA7Xm/PtMG8Y 0ZppnQHI4z0vlXNG9HIjyo8K5MMPhJ719/pbyhQKw73swmBucrcamb/yGUhMH0+PWj0NRz FdWTMoVtBQjG7m+lGHwbtXZRvmaeaBE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688979752; a=rsa-sha256; cv=none; b=T4FeiMAGEXXSGkE4yA+wvBOgPI6mZ7VIrr196bRe1ZfbfxCSUrFjPUkTV8yZ7V/gL12XXl c2bOBnuhGhzR9DgSuhoddFotr7tjlgoohbj+efHZlGXDFDFAz6xyxlfOUQxaUlYAv4et08 rDS/hpONs6vV+xV3TZPatubOBYlaNWo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Rbr7ix11; spf=pass (imf13.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4fb96e2b573so6353475e87.3 for ; Mon, 10 Jul 2023 02:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688979750; x=1691571750; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=RY1Cf45ecIWbc7NEFgS5rEslIyMu9IK3gvaqBb6Duos=; b=Rbr7ix116IC3UXycX1Yvm0AS9UwmXGOaJGC+zn/J+Lk+p+rESDxtlvW5Lf5VTvzP8l 0O/YVAPm/Oq7XbAPQllEfAjy6iZJHC1uozpAd5SAEZFCDfO2EdgggUg0FwkSvOvFXTyg mFVLKabEUf0OUMOcoynH8KCa/F5luTZfwtkeKpV5/KKOgX8hasRE2cD0+ZF6vVh7xei0 1CxYHaZTj52h6+nBHZthpMTQd/v/4h8VjVspPu+Mo/mPD5sIJPRdBEDVfeQsVBSuTRmB SjRaDKgXQbS+tVcNcA2tC95EScaIEuaMedfmrmxMpfUeTx6Djg/U0kTL4/GHTQBE2Bi9 IiWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688979750; x=1691571750; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RY1Cf45ecIWbc7NEFgS5rEslIyMu9IK3gvaqBb6Duos=; b=GUTQq51AhEdZXT/MjXIIjarOpILGeLZY3jdnWai0f1bEWiCkiY7vWKTNLHila74qom b1riONrzrflawj3vjcGg2bpfIDzgj4IljGCSPzHaKMfuHG23N1FXf1t1cb0ntg8Enoei N2lAkZAeMoiS0dKc3WHbNDqH9qxYpnF6IR2InEih/wko1ETw07EqXyn6ak+3fz84o8q6 BtK3pxCXBvbE7mndtxz4oKa14M4EvJcYiEDqbR6ar7FSlB+wxjb+MtBtmbGln4r/UgRk 7IBvYUdUUERwhSYE0cS2dktgDx21vjL4s4QgeDKhJKAAVmh8euEZOxF/KGYPPrW4bkd5 KZJQ== X-Gm-Message-State: ABy/qLb6q/vCU2y58PXciqU1F9ywZKvBBr8WcrNgFnR8MDQqLZNl26Fn l72nTcxJWKu2lL8v1gf0uw== X-Google-Smtp-Source: APBJJlG63m6dK9hI0i/Atwxqo1d1NMTXw1NIVOWVj0hS/ZK0vavx/VW2cjuvUHiDRizfVk6hz8xzgQ== X-Received: by 2002:ac2:4eca:0:b0:4f8:5604:4b50 with SMTP id p10-20020ac24eca000000b004f856044b50mr8378739lfr.64.1688979750142; Mon, 10 Jul 2023 02:02:30 -0700 (PDT) Received: from p183 ([46.53.254.107]) by smtp.gmail.com with ESMTPSA id y8-20020aa7ccc8000000b0051a2d2f82fdsm5488043edt.6.2023.07.10.02.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 02:02:29 -0700 (PDT) Date: Mon, 10 Jul 2023 12:02:28 +0300 From: Alexey Dobriyan To: lilinke99@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hugetlbfs: Fix integer overflow check in hugetlbfs_file_mmap() Message-ID: <36509a07-5ab0-44e8-85b3-5cf884a9aff4@p183> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 43E9D2002D X-Rspam-User: X-Stat-Signature: 68sn9deo4rnt14wzbybcq7fh5q69ywi8 X-Rspamd-Server: rspam03 X-HE-Tag: 1688979751-907529 X-HE-Meta: U2FsdGVkX1/uZhqBTP8GyCjz9i4+BdG5ZOU/E8vBTbQ9VSfxAcXSwJrvdqz6W80dvZjwYydyP2mNh/ZIQcSmVfgm47qYsdZGijCB8Tyktjt4Og23aRUr1nfqWXb6n8Di7h/L3iJ5+GM5+IcrS+cnJciUw0HusxPJj3EoVHqbYK4UD9fwAmsfDZn4CyqfsyNO5RlRHAm0R9qpW06kxsCtMnXsi4jGTWUFiOhhdibE3XVQGA0pKbQ/xoWip3e1RA/FSCb7wWyRjp9LCZMxG3fmDQDjX2FVFRlvqqot/n8d0tLy32GcoyBl4LNqnJ+YnjEf1OZYbjNeGIVMH1cPH8eIOv+mW7T7+viP8SNsqQ6oB9Zh2MBWCgOZWiCjj2ZmYhqcJXDSsleJDSENE9r7Ts1ssJkLJnpt2t2eMU8viCqwGw3jNH8hU54U7eiQ20o/ilLwUXMKdDs1e7kQVOKmyxxWUy8jN74TmNH/IfEPNmX036RQaK6AkQS6csCXojJ5r+Qxk2j77q3lbVTeWfEPxVkcIQWFKXtHf/cHdCoviYXo1tAC/Jn+ppQ8I/jAMwzmyIrIWm4Nt2u0QdeYl9yR6YbmXBFH1/VTICZlmvXC4doyKTDgWwJOlactlkITCN1PYs28tP1ejQgaqrXRSkHq9OBn5MR7ohEzAVZvYamHwOmfKHD/6lDWzgdC+/rrczssK+ojf5glLX2unRlRQw1JECwiHAvGEyrVrqZsYJ8kVNHMZElhEBX99IbjS+czYeFCrYqdXsweYtCQpHTkxVJOfzzOwbiURPb50amgTmpJpsecm21/2aT4TH3U1HETMyvQ3jHvOhPiUIEFyvPt0QK4DN1IjOcuKVWm5fiXbLhUj+OlR6X7g5Qw/jhMYe06om2v1wcjQ1RlhStL6jsUN3pzXsDOpKeNjSVcVeS3iQrMB7Pu5nGScn8L9aToo1QUWG59QJYEItTcsEPycxtYR/MEda/ QYUVeq5j H6f0cE5lfgFF6asqYUypz32k2gibyb80EUlMOdT0ZS4BD1BJC8su5N8KC/ZZv5AIxwQaZKUttIiUV1t9lD3V90+9ep6hjt63gpO+WErMUSq0OHcHpYGQ110Sl3zRCmhNlfFrazBUDWPun4D/bS6mcUG+fcqKRf8ulvMEs8K3ERFZUaTDw5u2iDfWgmTRN2Jesm5lnjXLVNt/sal39XbePNO6sgegmLm3wefqINNS9QMD71ve2OdzxbRVoWOEG+gB/C5BEL/JdQr0Eh9YmPCZJBfuiZuegkgm6eKEaLtU3SNYUlwJSJSJnO6kjFEueBEBTI4wBct6z1+KYqJPEy4lmH46WpAA5cgQcF/qRt/gYE54FYoJ9izYzH+jPddZmSJuV4RoWD25qi/6J+EJMvT3oMnJmp1gQA/ytX/1tv0JpNKbyi2PDtn+0dhbMQVhNg9z27l2xpxySdx+sADf1QfVoz1zUex6/6a0u2nEZA0do6Xy7RorfMEX2yJ20SA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -157,7 +157,7 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma) > vma_len = (loff_t)(vma->vm_end - vma->vm_start); > len = vma_len + ((loff_t)vma->vm_pgoff << PAGE_SHIFT); > /* check for overflow */ > - if (len < vma_len) > + if (vma_len > LLONG_MAX - ((loff_t)vma->vm_pgoff << PAGE_SHIFT)) > return -EINVAL; Proper fix is to make everything unsigned probably.