From: Alexey Dobriyan <adobriyan@gmail.com>
To: lilinke99@gmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hugetlbfs: Fix integer overflow check in hugetlbfs_file_mmap()
Date: Mon, 10 Jul 2023 12:02:28 +0300 [thread overview]
Message-ID: <36509a07-5ab0-44e8-85b3-5cf884a9aff4@p183> (raw)
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -157,7 +157,7 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma)
> vma_len = (loff_t)(vma->vm_end - vma->vm_start);
> len = vma_len + ((loff_t)vma->vm_pgoff << PAGE_SHIFT);
> /* check for overflow */
> - if (len < vma_len)
> + if (vma_len > LLONG_MAX - ((loff_t)vma->vm_pgoff << PAGE_SHIFT))
> return -EINVAL;
Proper fix is to make everything unsigned probably.
next reply other threads:[~2023-07-10 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 9:02 Alexey Dobriyan [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-10 8:32 Linke Li
2023-07-10 16:12 ` Markus Elfring
2023-07-11 11:49 ` David Hildenbrand
2023-07-12 23:58 ` Mike Kravetz
2023-07-13 7:57 ` linke li
2023-07-13 15:10 ` Dan Carpenter
2023-07-19 23:22 ` Mike Kravetz
2023-07-20 6:25 ` linke li
2023-07-13 7:55 ` linke li
2023-07-14 12:52 ` Matthew Wilcox
2023-07-17 7:33 ` linke li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36509a07-5ab0-44e8-85b3-5cf884a9aff4@p183 \
--to=adobriyan@gmail.com \
--cc=lilinke99@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox