From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 651FFE77188 for ; Fri, 20 Dec 2024 18:33:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE19D6B0083; Fri, 20 Dec 2024 13:33:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C90E96B0089; Fri, 20 Dec 2024 13:33:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B31396B008A; Fri, 20 Dec 2024 13:33:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 94C276B0083 for ; Fri, 20 Dec 2024 13:33:01 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5024B1C7ABD for ; Fri, 20 Dec 2024 18:33:01 +0000 (UTC) X-FDA: 82916183112.26.8C270CE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 567B2A001C for ; Fri, 20 Dec 2024 18:32:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D9duBBCf; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734719546; a=rsa-sha256; cv=none; b=2UynBgOcceVYruX8LkcpPIsNVhcdCYoivPKLlwdFSmmLfhpmAfwTYAHb6UDQFtQIrkf+o3 xn0m8yDH4kRw7C7HZ+pt/MFsMf2WNrhKZKPW6bFoMVAACiAQSIbGUvy4P+6q5WVfIVCfHH oMV+v2lORfvLhOawYbCoaVSp+/Jjg0Q= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D9duBBCf; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734719546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=swU3J22w1qiLCqCLjNaSEiN34P+WDwMezqQF+LZ7YmM=; b=KvpLJBhBmJWa6HAwqiT59T+jdGLlTxO+a1gFVI33m3Aj7Ud4yRTZDhWoykk+RKtN1+gYn6 gpFIZUYwb2Kcr2gBSn6Tqzg85rDpL6H4DTrrEYpBXxiYyKvmft5lmjUumA2C5kIv2at3S+ VRwRsuhJ7gvK8CZlP2/36CJjm2d/5d4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734719578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=swU3J22w1qiLCqCLjNaSEiN34P+WDwMezqQF+LZ7YmM=; b=D9duBBCf6+o3+AF+SHhzSWP9zk5kFNJGjqoV3tpURPULb/VVGxSfOY0thatAKttd5GF51w vCVo5g2xClsZW5cE1jMW1h4R+yR2i3yxCwnNeMgcjdiNbED5++kgu7H3K0yXUcOjvZJdTn 2j+brg0XDacYPSoM9/lpWI+xWkUTPuY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-5FWxXOXNO9-EeLxQN4JpZA-1; Fri, 20 Dec 2024 13:32:57 -0500 X-MC-Unique: 5FWxXOXNO9-EeLxQN4JpZA-1 X-Mimecast-MFC-AGG-ID: 5FWxXOXNO9-EeLxQN4JpZA Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385d51ba2f5so1079827f8f.2 for ; Fri, 20 Dec 2024 10:32:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734719576; x=1735324376; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=swU3J22w1qiLCqCLjNaSEiN34P+WDwMezqQF+LZ7YmM=; b=TXs/TEYAWS3Kd2glKKG0k/d8RgYVQjkzoN66szmYAX601yg/OU9q6ZjUptonihDud5 w7DBbeu1uHDNeA/OJUzMEypCOeSGWAXAcfj1RudZfsNdJ65o/9yIkViHIc/ckwGUQu7I tzEJgFkeIHSy6mP5tH7wqoK8v6TRYkXMdFIrpBZxTZ2UviawF7b6CfRzWc+mv3F0/Pti 3xeRD5XTqNooG+nJx5xUZ8qMFvqBeqh0XhfrOizVYY44L/ckUAmK04uD7PrtANKBDtRX C3Dk/Yytky0rp+rTDuMGSwm8X/Glf3hPzLv0t+0jkJnwQ/1RTuOP2DETSfdaMElStzDl Af4g== X-Forwarded-Encrypted: i=1; AJvYcCXO/47IZdMzb82psRpNYtCVAFtjAgBoeevvsZF4jvMcaSJcz00Hl4tXN2E3vzpFm6ox6fndjou4Jg==@kvack.org X-Gm-Message-State: AOJu0Yz8B99chQ+p9vl37j6o6dTuejwS8EfWLtI5mr2yG4BodLy9RZdp 2hsEh/JExSVILtDgpWWKPexF/3rquIYN2GsiqGFdW+Rrb+Gh0u6qgi0H4utPkwfJncV14z9hCcW XjfKnehEWMz/31KAcQQKP9tDPn2xTwu2/y9nR4Syq7aWCcOeS X-Gm-Gg: ASbGncueiqH+p2u9ViyfBkq+n0DcY/03GcwJT4dW8dyG4UGmq5TyNbOSRcpSRF6RWLL vbreLyWzl8okdSFM+Xo9zTQqIltYozteuKZCR26NDt73BvViEB1v1FZLmRqCUyoWofW6qXtl3+Y cHuz8i02EJ4ovwSQHdO9oRic/ivEI2FiU46xCPLsLMvjof81mthHys4XenEOnMB7h2UDDVk6iYC 6FYLeMfgNwCeVdCtWfNR1Whxs0GKZiBSi/RlXYhlWY1jiJ31soYwMS239TEvw2bU/I3uv1cVht+ mC/+UfTSf1uitm6Ms249bj1tL/uIM/sZiuHQHweFBkeYENLI73uhXZ8WIl+VzfIhXOepEsUx1XT JPEfUmaZX X-Received: by 2002:a05:6000:1fad:b0:385:ec89:2f07 with SMTP id ffacd0b85a97d-38a222001b1mr2999411f8f.32.1734719575893; Fri, 20 Dec 2024 10:32:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEk0Gj/f9sMdkNX68mPrqALSYePXcnIEwcuX62px3U4cp9do+t6yyCpZv960vKDvx0DNpRxKg== X-Received: by 2002:a05:6000:1fad:b0:385:ec89:2f07 with SMTP id ffacd0b85a97d-38a222001b1mr2999374f8f.32.1734719575483; Fri, 20 Dec 2024 10:32:55 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e278sm4706351f8f.75.2024.12.20.10.32.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 10:32:54 -0800 (PST) Message-ID: <36334f20-2b9e-4529-89c4-120678bc5985@redhat.com> Date: Fri, 20 Dec 2024 19:32:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 19/25] proc/task_mmu: Ignore ZONE_DEVICE pages To: Alistair Popple Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org, lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: <37rxl2bjda3psdknhboexhbg3hahf5ifmublp5fw7ltdoyqllc@udbz76jklmnu> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <37rxl2bjda3psdknhboexhbg3hahf5ifmublp5fw7ltdoyqllc@udbz76jklmnu> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TdT6m3XXtcS1YWQFQSd6iEFcqFCxa26W4T69oD_noEU_1734719576 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 567B2A001C X-Stat-Signature: oaw9io9w8zct1ogpmqqezpombkbacxez X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734719525-55972 X-HE-Meta: U2FsdGVkX1/p7iBpK9Mb/kFFs1iEsJ/NKg6ZTRZ+KhdA/oISn2bMy9fZlDPs4d3dC2KcHuUQdeh/fyPEdG7OJwOda7OORvNdr1hqQvOWfCUEMvcUmGjGPmkY3A/jSpcwTyJ2flLRn5WHJDdVROpFREAJrF8ZG4yMR/cu0o2lYvaBtTqKsCFJn+FlNh1RlUf7kh9XUHVdHy1CsGmOMD++1jbN9Km7ZBzjQTsSihwNKfc1mTYVJ76fKzNSZV67gMqzBF1mFO28QU0pl7Rc9Y0+d1Fp8Kip4WEvwztqeq1T1g6/+oG0nribFxcXS2bMqMHDsAIKIqx5LWmkmtj9nv40ZYQ39dQyndF2RlxIM2SrFY4Z+h1zg0j3Z1XxsIy14iGnGT5QtySxhc38GuZc/e17Z/uPXrIkcQYLUbH3rzfNd9jGmJEW5wHm8dlpsKFo+Fa63uD9bfRyo5KTlwaVc+QbkEqP6WyqWb527BWfBc8Z5oJiixBE3SQFrVRonvF2Tqw/veuzx8HGHR8RG4uUr67+DLd4gmJH9Ks0wkp9tR9AIpfA08Q07tqK2E7mcR7dwtdjEK0R6iTdgewIWVnCh9x9A4KI7myJxLxwNC4OEz6xalv5i44yaj4MxvqnmhN0FV6quR0lJ1+LmjTbxRj6rqFyas3v7dGzYZe/vzDF3taD1y5dtL+IKJkFV/sG+/WbIiUpUDLG60nPZ3olr+jzCkuphIoHn4Oo98hXbB0gIuYgVaj1hTXtDQUIkOSAHZqsKteIVOYNRtcLv7ZkJgcpQ+Z+zH8/Ub0NKMGvICFJ9jN0w/9vGpsquaFqnRtQfYiRt0vpFsqL0TwyUaTgi+QA6+aiyz159+qkpS85rCMMMUcRJNq7D22ViC8W91fa2bgFDiDHUeySYocOb4WcOf72Ye+CRMvJIA0MDDGhHadqiV79dHktPyq5INDCnApVAZ3GYcWGUMzdmUzfUoHp9WUZHNU 0H1zzWsa 44v/YGJ99Em00i3x7N7ZMLsGHmv4TQeBib2XSLO0R2fhL/nHE5jiZZrwdH7/2IqES1JK6vPmmPS6X0mNwCoudh20pBihuBL9M7dVzsH06xgR5LQSX1iL7iywTbgAXIht5MM+z8GRbrrD8knHQvLDHHCVkr7CWhH7+IPfSdwYQTqZZVZAspdN4ZcjvWrvrm+opPCR9C1Are6SKMcCeE+slv44NpmIzZbERgPVxj7A1hV08MvJO2aMYMM26AnlezgOlMFlRE2i+GHN5i1LaacDF7K0YTX7E5CrhPlQkVH2sMKufVbKAwglrhvuBmd1xFZv49tUdUGSqVlKBd9FDYVNC3khUqkEO/CDtG+GhRVuDOsUn8dw6qDEMhmaao1G/QlwGw9P6xaLFS9/3r6tzRkajjfCTEw/e80lMEI7JQlg4cP2YI2zq8Fv9xspcmeZ3XV84jCdn1Ur9qtE9efFgb925EU+Ld5pIMnx9H8gTY9glZ6fuIZkp5DOvV5nMQHbD4L5VvL8DoUI2JZpn7K/OcAgEFxtjwbSYSAoRmqmJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000039, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.12.24 00:11, Alistair Popple wrote: > On Tue, Dec 17, 2024 at 11:31:25PM +0100, David Hildenbrand wrote: >> On 17.12.24 06:13, Alistair Popple wrote: >>> The procfs mmu files such as smaps currently ignore device dax and fs >>> dax pages because these pages are considered special. To maintain >>> existing behaviour once these pages are treated as normal pages and >>> returned from vm_normal_page() add tests to explicitly skip them. >>> >>> Signed-off-by: Alistair Popple >>> --- >>> fs/proc/task_mmu.c | 18 ++++++++++++++---- >>> 1 file changed, 14 insertions(+), 4 deletions(-) >>> >>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >>> index 38a5a3e..c9b227a 100644 >>> --- a/fs/proc/task_mmu.c >>> +++ b/fs/proc/task_mmu.c >>> @@ -801,6 +801,8 @@ static void smaps_pte_entry(pte_t *pte, unsigned long addr, >>> if (pte_present(ptent)) { >>> page = vm_normal_page(vma, addr, ptent); >>> + if (page && (is_device_dax_page(page) || is_fsdax_page(page))) >> >> This "is_device_dax_page(page) || is_fsdax_page(page)" is a common theme >> here, likely we should have a special helper? > > Sounds good, will add is_dax_page() if there are enough callers left after any > review comments. :) > >> But, don't we actually want to include them in the smaps output now? I think >> we want. > > I'm not an expert in what callers of vm_normal_page() think of as a "normal" > page. Yeah, it's tricky. It means "this is abnormal, don't look at the struct page". We're moving away from that, such that these folios/pages will be ... mostly normal :) > So my philosphy here was to ensure anything calling vm_normal_page() > didn't accidentally start seeing DAX pages, either by checking existing filters > (lots of callers already call vma_is_special_huge() or some equivalent) or > explicitly filtering them out in the hope someone smarter than me could tell me > it was unneccssary. > > That stategy seems to have worked, and so I agree we likely do want them in > smaps. I just didn't want to silently do it without this kind of discussion > first. Yes, absolutely. > >> The rmap code will indicate these pages in /proc/meminfo, per-node info, in >> the memcg ... as "Mapped:" etc. >> >> So likely we just want to also indicate them here, or is there any downsides >> we know of? > > I don't know of any, and I think it makes sense to also indicate them so will > drop this check in the respin. It will be easy to hide them later, at least we talked about it. Thanks for doing all this! -- Cheers, David / dhildenb