From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D0BC47077 for ; Tue, 16 Jan 2024 22:15:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEC726B00AD; Tue, 16 Jan 2024 17:15:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D9CB56B00AE; Tue, 16 Jan 2024 17:15:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C64936B00AF; Tue, 16 Jan 2024 17:15:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B221D6B00AD for ; Tue, 16 Jan 2024 17:15:35 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 61EE71C136D for ; Tue, 16 Jan 2024 22:15:35 +0000 (UTC) X-FDA: 81686581830.30.49CED81 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf27.hostedemail.com (Postfix) with ESMTP id 7BF974000D for ; Tue, 16 Jan 2024 22:15:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xc5qN5Id; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705443333; a=rsa-sha256; cv=none; b=dHnGoYhRfEDu7J37wOWTg3jVGzkV2dL/HXYV51Lfygm6K7uml2uXa/joHN2phH+3lq76Px tIeAOwkgaAnU0hSX+1iBAmh5fDitc6jgSZU13xFMynb0mJWIzVi3F0uiPBlLsPdZ2/U62j vubldPAzopG5tjaP9TDLO7IvQb70OMo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xc5qN5Id; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705443333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IlHS8lP8N5SFntuRv+MBdf8DEe3RK7CqCJW+w8kR5p4=; b=DtAkvZNpHjl6uWQfIKhNqyUlgL/W5Hu70zhKewJ1jNiOCFgfJV5PulsMzmmtSPQhNqDHbp qzIHLaHZh8znDrzf8VWlGOvabRAku5AK46FxZ8FRTbBqnQvhYPOKdJiegE50BqbQyCFQ+R /qeHAgiRADDiEPWWyzEfCro5smCnU4s= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40e60e135a7so47385785e9.0 for ; Tue, 16 Jan 2024 14:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705443332; x=1706048132; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IlHS8lP8N5SFntuRv+MBdf8DEe3RK7CqCJW+w8kR5p4=; b=Xc5qN5IdI+z1DttO6+FdptHdg+uTlg5v8zvTjQsNwpyi2bOzPlLp7RvaSk6VjyxaCy MH9poyoB6XdzrjuV/LFabdrlFCc9fveAGzERVFGgXIpdJJqtp9Q/Yw0wT5c2vz40rVdP vNIVKbkL2HQhOmA2k/s8f02hW6db3DUdKNa4xHgea6ccUOeDiS1oR6aIMbmC/CbS36EE KTQxfMCo4AZy5FiJuSSsWvF6ALAt85kUWDKr2MMhPDjthb7usoW/evzn5jKi1P4EWJ1I NUDhAOuqZS8TE5I7GVz9VTqaVvL5sxVti3AIRsddDhzu793qEikka1G8Tqnp0Or2ZPY6 uXRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705443332; x=1706048132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IlHS8lP8N5SFntuRv+MBdf8DEe3RK7CqCJW+w8kR5p4=; b=DGg2mNerrR3qOCqLy+cyHlikjtT6kwpSq5bqyux8DQlDWe/K40mr9Wpvpm5AdWxq2P V4UJQoYYtOMUIj/j1SRvEJxNvbmttSKrmcegjVmHSkMz4twp4DVIRYtaoRDbXh0SLzCG nmqOt2rtQaBLdfB8z+Yv+GEIF3wJAa2odPOtN6JWCbN2HSFV1Tny2sGbEqDU3JZ3Mig9 ODsux/DWRlk+yzUNivg2TQCwZPJiNQ4e40VrEgLqfe7oWgn+M/yLZhBgHsqO672ae7go 7IejaPeA/nAfaUAWcX7vuj37B/NaY31Sp98wiCOfrdkzw8e2SKNsDp5+3fuQMMqjNLQT Zosg== X-Gm-Message-State: AOJu0Yw94abCZxN7EbyHFXBHqQy/P8TVSFhpPvU4RCGqYBwKODoSvN2d r/gg8RH/2qwsNE6C9hJaJ4E= X-Google-Smtp-Source: AGHT+IF6o0F1XZR1+9LDmYvD7X5YZQIsdeVF758eA4qGZrWNN9zMaXuWwCUVEcQgQh5wdVTQsZd0rQ== X-Received: by 2002:a05:600c:438a:b0:40e:859d:c96a with SMTP id e10-20020a05600c438a00b0040e859dc96amr919601wmn.71.1705443331583; Tue, 16 Jan 2024 14:15:31 -0800 (PST) Received: from localhost (host86-162-136-255.range86-162.btcentralplus.com. [86.162.136.255]) by smtp.gmail.com with ESMTPSA id bg42-20020a05600c3caa00b0040e3733a32bsm24254922wmb.41.2024.01.16.14.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 14:15:30 -0800 (PST) Date: Tue, 16 Jan 2024 22:13:17 +0000 From: Lorenzo Stoakes To: Uladzislau Rezki Cc: Nathan Chancellor , Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot Subject: Re: [PATCH 1/1] Fix a wrong value passed to __find_vmap_area() Message-ID: <3630611c-c9d5-428a-ad1b-21f4123c69b2@lucifer.local> References: <20240111121104.180993-1-urezki@gmail.com> <20240111155511.GA3451701@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7BF974000D X-Stat-Signature: dcz61maim4rtt98qw59y4sboqy8eq488 X-Rspam-User: X-HE-Tag: 1705443333-640716 X-HE-Meta: U2FsdGVkX1+jKqwKwagBnluRpAZd6+GwkpRm4s7UH0nsCO74QNUeTlvlV42kuxKFlBsaH8LWAd9mqesU8G7GFpc/+mcPpGzLjqi37opIIsCguc9ms0j/1IdqrzOsYMXgWlY1D00k3j16M+rIHkR8+Vkl/tv55Dx2yrGI6jfVMEr4hYEJEop3nWjtxZi1ewk2xYe6y7z2vXHXgemJXLhHwICM0EXWUOctnqJ1r8z0x2iO7Iuwi6MVH2Dq5A09f+byT2USSUdWArTUItpkU1BJ7cHn9AiZcorKdZjoisx3wjaG7KHuzBVmpiflWff0niJRQHcJPg525egKCIfxsmQNmWn4MD7weOJgYaxQ7MmM8KDvmkzewDru1E9LjsAAo4W8oLhKJw5erqDprSHktKZEtHq4LBSjTnNJqOAxQ+uMK/49XsVJx1mlEhOdGikk/YwPTuvGwVQqv8NJvhNGdzJjdA8qgRyAzi/l5CXEGyWCSxhPbHiGQid8f5eagGd4NWr/3sDld3zFLM1NumrQfd2pabhkH+52PSN2IIdZmGg1lHsAIYumMfQZc4s5oFHmMyCHyugQYjJtpVx68bGJlViJ9V3q6PC8j8sOLNj/NY/dEN8z/L+x7q/VlhzXezXBi0z+Bd//irN/Ze98aJgDn6SIfh1c2nu7cSgaKJVlXh+btt1XhonOBeSHsJgR9tFwNWDlu11kqTr0rqAzLt2JE8rrXKvYrottE+7KKFAz9V39/RkAvLOvZ5iRDDS2nOKNdlwkFoXsnV70Wgk+l5kkJhUdsqWM/Tc3aep1j/TeX3uW5OjT/h77404yHESNE69fQMH6PT+fX5BIz2EphOVolie0HlrYvIPeOCXTQeXVqLiyxBuysfBYcjWIvRQC5PtgTYC5N3g2rNGUQxVexd4CuXOkEshYEymnhWbG2DHOrnSXceGFKpUrhX2b/4wI7hoq29ern0SzMJauM0qApVWcghg lF3Fsuv6 t2ROzZOuQ/Q/c7gYsZjuMGPbJZha8bNlKy5gj8kqQJHFCJm2GqoJfXv010J573pwcoCQ/UCyUMhzTx5Kp8CtLVa6B5zznISgZB5HX1MsZgGMureawcFFV/hxLdMAJBfgWhBRfpFcHP9cZzc9MAP2Y4MqCoS/FzmptdgMhrfB3z8FXbYBa6T46WeKg8JGCplLbckaMYsxbMGbZOYQzPZvMLfyLsP+pr53MfGjhpyBt0cv+Mt3Bs7A68IYwa2dBZ7qPof4ySFxi73bwUjbtQBJs7plVEeN+XdV320bqMpS4QklDnuKS34ywiDDIZxGTp3/2Hs8TGJvmyHXhaCHa6YS2RsmdQww7yhOFKdbKBGNAS7y48aCHrrTcSZG8KAC2P4ZcnWy3V0YDGNf6uVuziODz8zLIHMVi9JON+41YqphCzTjGo5a7pJlBglYs5h7cWfCKPrFc1nsw7f9Bcp8+Ph9ConZFUhX29eudYPa1kSAbfxENimPLiht5jlAe17mBfnTM/WKd1VtC64dIzE66M2YR67i0wS77kX7eEDfr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 05:03:41PM +0100, Uladzislau Rezki wrote: > On Thu, Jan 11, 2024 at 08:55:11AM -0700, Nathan Chancellor wrote: > > On Thu, Jan 11, 2024 at 01:11:04PM +0100, Uladzislau Rezki (Sony) wrote: > > > There was a type in the vmalloc_dump_obj() function. Instead > > > of passing a real address which is "objp" an "addr" was used > > > what is wrong and not initialized. > > > > > > Reported-by: kernel test robot > > > Fixes: e88b85b81d5 ("mm: vmalloc: offload free_vmap_area_lock lock") > > > > I am not sure that e88b85b81d5 introduced this. Based on the diff, I > > think it was actually commit 86817057732a ("mm: vmalloc: remove global > > vmap_area_root rb-tree"). Does not really matter for the patch text but > > I think it does matter for what change this gets squashed into. > > > Right you are! Below is updated version: > > > From 98f1fd2d3913f3b7bcbe49785a78f67999151f1c Mon Sep 17 00:00:00 2001 > From: "Uladzislau Rezki (Sony)" > Date: Thu, 11 Jan 2024 13:04:07 +0100 > Subject: [PATCH 1/2] mm: vmalloc: Fix a wrong value passed to > __find_vmap_area() > > There was a type in the vmalloc_dump_obj() function. Instead > of passing a real address which is "objp" an "addr" was used > what is wrong and not initialized. > > Reported-by: kernel test robot > Fixes: 86817057732a ("mm: vmalloc: remove global vmap_area_root rb-tree") I know the commits are likely to get squashed/messed with (this is now d1d9bdd672c4 in my mm-unstable tree), will this get corrected in the commit message also? Slightly tricky one. Perhaps a note for Andrew unless his scripts do this already - please update this to wherever "mm: vmalloc: remove global vmap_area_root rb-tree" lands? > Closes: https://lore.kernel.org/oe-kbuild-all/202401111810.TKPIXLCs-lkp@intel.com/ > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index e30dabf68263..43a6608e1397 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4688,7 +4688,7 @@ bool vmalloc_dump_obj(void *object) > vn = addr_to_node((unsigned long)objp); > > if (spin_trylock(&vn->busy.lock)) { > - va = __find_vmap_area(addr, &vn->busy.root); > + va = __find_vmap_area((unsigned long)objp, &vn->busy.root); > > if (va && va->vm) { > addr = (unsigned long)va->vm->addr; > -- > 2.39.2 > > > -- > Uladzislau Rezki Otherwise looks good to me. I have some style comments but perhaps better for me to address on the actual patch series! Feel free to add: Reviewed-by: Lorenzo Stoakes