From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5742FCF856D for ; Thu, 3 Oct 2024 08:23:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDD216B02EE; Thu, 3 Oct 2024 04:23:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8DFB4401B5; Thu, 3 Oct 2024 04:23:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A55BF6B02F1; Thu, 3 Oct 2024 04:23:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7FFFD6B02EE for ; Thu, 3 Oct 2024 04:23:16 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 212351A0767 for ; Thu, 3 Oct 2024 08:23:16 +0000 (UTC) X-FDA: 82631601192.05.88EB385 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf25.hostedemail.com (Postfix) with ESMTP id ECB61A0015 for ; Thu, 3 Oct 2024 08:23:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fl56vRyM; spf=pass (imf25.hostedemail.com: domain of wqu@suse.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=wqu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727943753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iFODimp1QE4G5JcljKakMWGS2TTG5DP0ztUxHv1oO7M=; b=4d3MVoZA/9bENl3u5GO+xpnwMV92e+YZwE207IzYIM4JTHg62oci5D+50eJD1PAbf9y/7U XXqUB1F/EkJ/HNwuHLQV03ORIOmajSm7BadUIX4G+K/kGE1E2Q89J2LEb3AmnZ10yfaSso 32c9XyfqmDsbUssZvufMcS+1nMnIdz0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fl56vRyM; spf=pass (imf25.hostedemail.com: domain of wqu@suse.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=wqu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727943753; a=rsa-sha256; cv=none; b=N5+lY1zbOIfYCb3ITFz0ZMjMnV33pDjldPtT5JIg9LlUv3/6eUF0MYTSTgnOc2c+HuFL86 iaoCakq5zwojJeoeHCNLYyIKMMhteaa9hG/Swq2kru5+uYAmA/+T17lQMwWioSOyn84w7V uuWXUHVnszHic4HS/4SZNd7Tqe3mV/Q= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2fad0f66d49so10622391fa.3 for ; Thu, 03 Oct 2024 01:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1727943792; x=1728548592; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=iFODimp1QE4G5JcljKakMWGS2TTG5DP0ztUxHv1oO7M=; b=fl56vRyMji+qQcKGmmSeHyVYh6Js6KlbujxUE2Ah6aTSXFjL75ZnjJ9h9TBT2hTAJr jv9oOCx1vey1J7TmgBKqaPo8WqWEsz+QJzat4wVWHbdTDmYcGKrZ4cD+/FQq9HHHf/P1 YBZoYsRDB2byeCamxDFWwfJtY3oqCiirvm5lg8EUigUn3qjAboUhezNdo/p670raml2N dAKWBdqRAF3K2LG7bnElmqXr4Jhl1ZdK+kaU6fbwjNHaHp6SrSHwFP3wmQU8kMntxIfo jZyip8tfrDq6MKxaDRh34ZfPEDqpHLZ0EaIJBcOPJ3aYTRyfPwo2KxF3FnW9F8ou9b/S Gnjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727943792; x=1728548592; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iFODimp1QE4G5JcljKakMWGS2TTG5DP0ztUxHv1oO7M=; b=NX41sWOs6Ofwk88pI+POtvTpTDevUqdxu3NIFYwzkbIitn/gF2NvkcgzRsasqHg1vB 7JjULB5m13KHUArgROdU9UK70z7C1+GbotDYGLuLd4RInIfV1IyVfr2ShcDiksu1n+q3 5ImxQlFj9wKEzORPVt8QZ76k58kqBbxKow7YOXxRskzTkK6Z2alpXw6Ny8zCZHSC9GC1 f8EN3IoUTORAX6iCxQDgznCY9E52fCWh44oWukhwGCFWFWfQCxkKIrRzxSXn34EqebwC EbuonCSiROLUNOwU4h8msYcSHpmlGnjeiswor9m3w8Cm6G3I9PFWlR31US2FuO7mp4gx pObA== X-Forwarded-Encrypted: i=1; AJvYcCVk3PvwWH3NNlZwdi0uL8yMtMJQbggiAz7rrBNZwAxAA/PO+8zEPvY8j+vwzpIatU1TGpN9HXm6xA==@kvack.org X-Gm-Message-State: AOJu0YygLXUFrXd82EC3WCADvExH3Ld/Ejk6duJhGQ8l8+3/aUhuGQqU gkNbrPUb+Q3MyT9PWHXTdMzr9V9VKeNGBuGFLOg/5N4zmcKhqnXfeBbGUH258VQ= X-Google-Smtp-Source: AGHT+IGfSRJS3R2zaDRNfM0V0fPAIEIIjjVBxdwQMJvU7MyMU63zQ9t5U8Zub5+zr0REtiC/4id8Nw== X-Received: by 2002:a05:651c:503:b0:2fa:cf40:7335 with SMTP id 38308e7fff4ca-2fae1029a7emr34867571fa.19.1727943791335; Thu, 03 Oct 2024 01:23:11 -0700 (PDT) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20beeca6fb0sm4725385ad.75.2024.10.03.01.23.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 01:23:10 -0700 (PDT) Message-ID: <362b90cc-d6b3-45b2-a8a2-52387267b33a@suse.com> Date: Thu, 3 Oct 2024 17:53:04 +0930 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] btrfs: root memcgroup for metadata filemap_add_folio() To: Michal Hocko , Qu Wenruo Cc: Christoph Hellwig , linux-btrfs@vger.kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, "Vlastimil Babka (SUSE)" References: <5d3f4dca-f7f3-4228-8645-ad92c7a1e5ac@gmx.com> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJVBQkNOgemAAoJEMI9kfOh Jf6oapEH/3r/xcalNXMvyRODoprkDraOPbCnULLPNwwp4wLP0/nKXvAlhvRbDpyx1+Ht/3gW p+Klw+S9zBQemxu+6v5nX8zny8l7Q6nAM5InkLaD7U5OLRgJ0O1MNr/UTODIEVx3uzD2X6MR ECMigQxu9c3XKSELXVjTJYgRrEo8o2qb7xoInk4mlleji2rRrqBh1rS0pEexImWphJi+Xgp3 dxRGHsNGEbJ5+9yK9Nc5r67EYG4bwm+06yVT8aQS58ZI22C/UeJpPwcsYrdABcisd7dddj4Q RhWiO4Iy5MTGUD7PdfIkQ40iRcQzVEL1BeidP8v8C4LVGmk4vD1wF6xTjQRKfXHOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJuBQkNOge/AAoJEMI9kfOhJf6o rq8H/3LJmWxL6KO2y/BgOMYDZaFWE3TtdrlIEG8YIDJzIYbNIyQ4lw61RR+0P4APKstsu5VJ 9E3WR7vfxSiOmHCRIWPi32xwbkD5TwaA5m2uVg6xjb5wbdHm+OhdSBcw/fsg19aHQpsmh1/Q bjzGi56yfTxxt9R2WmFIxe6MIDzLlNw3JG42/ark2LOXywqFRnOHgFqxygoMKEG7OcGy5wJM AavA+Abj+6XoedYTwOKkwq+RX2hvXElLZbhYlE+npB1WsFYn1wJ22lHoZsuJCLba5lehI+// ShSsZT5Tlfgi92e9P7y+I/OzMvnBezAll+p/Ly2YczznKM5tV0gboCWeusM= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: ypyykg8cz1kkiis4j7dmgm14pewi6d5r X-Rspamd-Queue-Id: ECB61A0015 X-Rspamd-Server: rspam11 X-HE-Tag: 1727943793-464321 X-HE-Meta: U2FsdGVkX196fkxBL8NfiprsTb1skfzSWOzEkFvSxvauYpEDijooUwVxWM9o076qBnmPUDXeo6I7rvNPncQEkOrggxu1Ay8W8dJnAXMMegayKEKi5z4Jj9oD2Ln/dYZeuNWm7q+IB6+e6SDoDCdU2oRsWbZYJ565uslkYb2nxlP83fmfjd7E98ARdsSzYptfP0bwqYzRLHyWzOaF7PMdNuAhIZrcop+wz02lmL2UnJShYMkO+USojvEi1fUVJyiagF+Cl0nygwK7jUwdZUxRZcQAZoHvN3GIzu2GqcRTkq2XKt1MuWRIbaGm6XvFKv0sYc8peLZGJ6y1Hn0fZj4wwFm6divJYCSC9XLr6DnSZJ7nSYkwbnOc3p6/R28p1QlFgwwy8wG8b9pQo80FdOBee6DiGlQM9CfTs9HCzNexsQ3jTnFpr3ci+6WdU/3WngS0KSN2qEKkU/0zObCM1qmeUr6nVFFTVA7S1GYUNu5S9rYe095u8uAjVUbFXZaNZ0tlKXqHYh9hXR8Q3lFiElc/DOlDn5OTKTjt/pnnyyERWelsoPzcSholQQ9TM6YmDyTs4WCqaXeOyKCIhxUmuxTs/S0L1NBUlNTpcg33R0LHCqoUV8JfsCarNd825roCPiWpo4BMZg/N2ObD4iqNY+bFDW8tqSFQznnpGth8pcjnkGLmJuqaQZ5I2TvEBmJx/JPnEHiKD1jSo4NWESLPIbaOoYGDxVbML3x/Vp0lJrqN/61BCoOgWkDzTd8RFoVekMbthgbWIxikGvzLoOeXZZEkhsx95LMOSGXgOMAxGlXPy3DTQ0MPiDbZcRwc+WTlQC2jHBV8Bu+vpy6zs1kUR4GccX/IR+XXZs0wtUe6atkSIU2iV0lXqhfYGSe9BMZLjVbuobrJr9hhRCdf1dcwAHSJEyhgqOod8jf4enT8zHPhijsPsLic5dZcyK9SQqjPqDGBEGEMosB6zwdz+4oFYMi lHj6CGBt 8fBuKc/0wxs2tAYkWvDkyf3zQOUF6Mx+Jnuje4FTg06+yCUdN3LPTaqQV4TE0oREGIYC8pjzwaF+z+27BYxlOwzJMOZAsjkqPIAgiSElcdLsKeyxSK9qC2y5oyEKFc9lrGTf2OhIM/jb26Vy8MZ6sW6QwM/Pv745i4TO8hdxbueqvSoEiuauhkvD1sEH5klNoE4v9Btuj7Qzazt4FxSLfAiw5JaCNUwTInQtCqPAvbh6ImRaioVXR1aygI75SzQxbYhEzVLzRj1Oea8SzoLPdhhDh3vz7gU3JbcZ8dtcpKTZAP2jB/L/an+clnJGiVvbHAmP1MUS4HNNCVZf9dGPF3dBi7sSIjsLFuG6wWTkdmmcU9az9qTZ7wgOEXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/10/3 17:52, Michal Hocko 写道: > On Thu 03-10-24 17:41:23, Qu Wenruo wrote: > [...] >> Just a little curious, would it be better to introduce a flag for >> address_space to indicate whether the folio needs to be charged or not? > > I would say that an explicit interface seems better because it is easier > to find (grep) and reason about. If you make this address space property > then it is really hard to find all the callers. Makes sense, thanks a lot for all the help! Thanks, Qu >