From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 252B8C7618D for ; Thu, 6 Apr 2023 09:12:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66B706B0071; Thu, 6 Apr 2023 05:12:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61B166B0074; Thu, 6 Apr 2023 05:12:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E43F6B0075; Thu, 6 Apr 2023 05:12:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 403F96B0071 for ; Thu, 6 Apr 2023 05:12:29 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E206FACA10 for ; Thu, 6 Apr 2023 09:12:28 +0000 (UTC) X-FDA: 80650400376.25.FBBF744 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 7F0FD120009 for ; Thu, 6 Apr 2023 09:12:26 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CMx9dd82; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680772347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sv2PpChimMYumCFtZaOaAxih1ECUzoRlTNbMO8Dqb/8=; b=VRhBVdA66R6K2OXytZYk9qmt2Gsh7ertQeLndUI9uodE30rGUsZZ+4B3PRt054KaJpLLXn 5rrCpEg02Cl0/5DiVRIh7wwGYDNT10/D+smG+C51yyvGjqyz5BuhefZYFHFEGeQQE2eOA1 Y9d2HNR1XOozCeJiGTrC6vbJX8MISeE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CMx9dd82; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680772347; a=rsa-sha256; cv=none; b=gCtdjV8qPuqqybMZFNWBTB1jjECDamKoAiHLxytcBpU7U1X5uasgBY8ic+ZLXAvEJCrn3U COsgwiqbJdGzELlURAhZ0JCSasEWxzeUPViqw15mcj9bV6A8I5WYB3KHXpxvq31+hXL8sL JxYLGd69iFpJBVnVDj+hfttLgviCi1M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680772345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sv2PpChimMYumCFtZaOaAxih1ECUzoRlTNbMO8Dqb/8=; b=CMx9dd82lwO2xDRwp8QSHHckYfDPR322XeRMy3dsjzyOQIVbdfuRSeVI2RlPZzMsl5lu2q lJ1d44w9NIU3Q0DT+9FtuAjV8RWJ+bUBLO9nYXvvGRuNlplT0GG74Q3IHeTVHkRT2jILar npgtSMN8YqeRSJK7G+6FUDrWb7K31so= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-499-bbJHhxB2MTulRR-9lYLWOw-1; Thu, 06 Apr 2023 05:12:22 -0400 X-MC-Unique: bbJHhxB2MTulRR-9lYLWOw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FBCA38123B9; Thu, 6 Apr 2023 09:12:21 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 84D22492C14; Thu, 6 Apr 2023 09:12:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230405191915.041c2834@kernel.org> References: <20230405191915.041c2834@kernel.org> <20230405165339.3468808-1-dhowells@redhat.com> To: Jakub Kicinski Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v4 00/20] splice, net: Replace sendpage with sendmsg(MSG_SPLICE_PAGES), part 1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3629143.1680772339.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 06 Apr 2023 10:12:19 +0100 Message-ID: <3629144.1680772339@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Stat-Signature: 1ofecw6x1bdsp74b8hqciydgr4637mep X-Rspam-User: X-Rspamd-Queue-Id: 7F0FD120009 X-Rspamd-Server: rspam06 X-HE-Tag: 1680772346-696730 X-HE-Meta: U2FsdGVkX1+j/SxVuPxEL6uv6sPMECwE7CgDYSD4CcZETU4rLTuaXnU2to5fmHqgt7ZA9Yrxfeq7K91xfvfAbnXJGNQQlno1nX4Uw8NO9V6Bf2uByKH/oT/ZpaBRIM/u4mgFbGzzgA3ReyIhmw7M/5LMgrrp8wv/T7m5LxqTZeLYEjh/fzqygI5SwH4Do3EjyMMg0SS6KwK4dLf0yM2RTQSeJi3epLt9gi6DAlEIU0zvRz7lOcD9qfILkp0DGaOcxAk9o2rW5qoen9F80SvIElOGIOsYFdSpKFkP86AUEFeRXeSypwYSSKra9Ot5P8SPm3cpguyi3UTJbXukIXfOfoOU2gGA5z5EQkhvFJWVtW3jnIikD6UnPjxNUGaw3kbi3e9t87NBQIJh6jB/LkntqHZ68kJT6KtYHL6oLU1j3PphFMVHYFqcpMCCk4Njegim9oaWztLqrTZ8TXCF0ZqnPq676Hc+HSIA5ixrIpSxS8uW1RDaiqQjjlogEjP8y/abYltEk0irHQfEpXknzx5eg19u1EaExAruVGWMooAG5+Gs6XJ0A7WIsEbZqGTGcdukJhzP2bvWaDcTy/mzA9D4ZXxlsNOn6DGHQU8v9/cYNwMHWNK7wBDjMt77UC5PK9bsW9yFcuDampbAs9eZMKFsUJLM2F5tgb0f2izzLTZjX4VeihiFfWfHGiezhueI1oO800Uex6ttwjkZk5QYhUxZc6VFASdE0oeNAr/mxPwVlph37Da8lLuTNPwKPe0lQimanXZin5ZZ60MbqwVpbEOMUl8NTq/hh0TIX22yCDbJ2mjUjZiDakqZdYTiPX35hZnaHZGLZ99KIopq01iI4hl99kLb99JqDO4aC+lztMHqLk1eR0Bv8ZNMOpD4GT1ZZ9e958dzdtzHjdq6bpsq8K3cdOfr3TD8b/rHe9CuD6IJAMo9jB2SRDrfb4zx1mzOZYnxj4HJGa1c1inFRBwuxuH DCO/GLZ7 1Hf8z3hefOGjcejhOx6wNjUXPKSexp5GDPbppx+zl8kUJWFKDMWd/xjKOqKu+kOeK8qbmmPUTJQLausvxX+sfbuO3m4TukxpW4KhnEx+bF0EHLBUtX5d60UuluCQ3YQkZrYk8To0WsN2gno8qjLPhFLCgDBhEbHQ7KYtbcDvUCYD4hv/G2BQuIaPyZZyGO9Bw7yWBHY0A7532Ns94ixOXzdgvIQyRsOX8PCuwsz8X/Pg6sFzYb39unSLgVCXwUpmuI4JhS14BAaQbA8gJZwb37GlFN4FeXs/X3vmVe7V/d6xgxBtgKZ5v2uEWaiEbAvL1tJi+oQJN0Fp2SBjo02ke/A17BHOIAPZMzLstjI7oYldxbEsPbLqWdI7jgXP96X2z2extR8gEvLXmXQh6w8G5u4rXeySE5DFgx8pc477r1qeK/ZBrKy3k3mUv/xWrSUBpQ61/tMVEwJ5bDpmVPaQq9mR0zKF2O519/cHmt4tzTi/XdqtFgcedqNKPXzWe2hGc7a1pVuFRFIz3lkdT17wyaItuGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jakub Kicinski wrote: > Thanks for splitting off a smaller series! > My day is out of hours so just a trivial comment, in case kbuild bot > hasn't pinged you - this appears to break the build on the relatively > recently added page_frag_cache in google's vNIC (gve). Yep. I've just been fixing that up. I'll also break off the samples patch and that can go by itself. Is there= a problem with the 32-bit userspace build environment that patchwork is usin= g? The sample programs that patch adds are all userspace helpers. It seems t= hat is referencing a file that doesn't exist: In file included from /usr/include/features.h:514, from /usr/include/bits/libc-header-start.h:33, from /usr/include/stdio.h:27, from ../samples/net/alg-hash.c:9: /usr/include/gnu/stubs.h:7:11: fatal error: gnu/stubs-32.h: No such file o= r directory 7 | # include | ^~~~~~~~~~~~~~~~ compilation terminated. Excerpt from: https://patchwork.hopto.org/static/nipa/737278/13202278/build_32bit/ https://patchwork.kernel.org/project/netdevbpf/patch/20230405165339.346880= 8-2-dhowells@redhat.com/ David