From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DCEC61DA4 for ; Thu, 16 Feb 2023 12:55:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAB576B0071; Thu, 16 Feb 2023 07:55:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B41676B0072; Thu, 16 Feb 2023 07:55:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D4C66B0073; Thu, 16 Feb 2023 07:55:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8C4396B0071 for ; Thu, 16 Feb 2023 07:55:51 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 457B81A0C42 for ; Thu, 16 Feb 2023 12:55:51 +0000 (UTC) X-FDA: 80473152102.12.D3FB8E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 12B2840019 for ; Thu, 16 Feb 2023 12:55:47 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PBURyO56; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676552148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YQju69BiqsaDeQRQ67eE8xOTlMpUfeTc3HdbBLvKdtI=; b=7CARehBaHmwcCvwdfSRFWSUvkt5FEAaEKMbzOpZSWCNuQm0gF1W3CTn0c/nCZMOAmdGAE+ ILwRO0oizcibg2M+klPOpnNNSfVUaw+/Laix72ft7FRkHBucebzu49EB6cw+UJ0uz0vL2L lv4xE4m+qBwW6Z6mfG6fMRyBhmgZuNs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PBURyO56; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676552148; a=rsa-sha256; cv=none; b=NleKOigsM0JK3rVwNNnemf5Oqlsc00hgQ5u6FUjVOBNI2EBgF+f+KVj/JmSm9bO41NpmoH GJ+n17IyjOvViDIqr4t11j6V586q35+btuxwQ1l/HQz85vzXSG6BvBVYxTxz6KPSBeyhVd N0C0qyW5NvdIZbNByenBR7CdnAiqAc4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676552147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YQju69BiqsaDeQRQ67eE8xOTlMpUfeTc3HdbBLvKdtI=; b=PBURyO56yfGpgv+rVaRaGZwrs9ZPQo4h9XZ2P2Zn6bGK7ZFPg432ngCIH8SjasACchWssD Hmvhlq9b9h/M3mpt5NQ5ye+Xyru43pBP4va3n1YHi4SHLaEtBb5v96GIgEOyZPmxZ+OUU+ 22X3ITtNH6jAqn8qyFh6RwkeEISvgcA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-509-z6wu8RDLNmW7e5OhnJoRlQ-1; Thu, 16 Feb 2023 07:55:46 -0500 X-MC-Unique: z6wu8RDLNmW7e5OhnJoRlQ-1 Received: by mail-wm1-f70.google.com with SMTP id az29-20020a05600c601d00b003e21a3f4e84so235545wmb.8 for ; Thu, 16 Feb 2023 04:55:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YQju69BiqsaDeQRQ67eE8xOTlMpUfeTc3HdbBLvKdtI=; b=U6kUXplcK+y7/pB5INFg11R5ux8Z424UmnOVo5/qBd+sLcBdxbJcSj3trO+G0xpZWO 6vYhFHn+LVJLO3nbc4q4qFLC04g1g1y0rB1zMUqQ8i3wEldTqPS9XbpVPyeKxjQjgUIa yAgr9arBYJ2vLWKpmMNcm/35jqxjLPJTtSy7Ae/fVoc4y2FI7czGbwohRCujggKjiqR4 yH/9Qvs+I+N2mNeLn77UJIE1FJjOJDVqkCD34ZEBSaiTmcVhr9RHJYU2tzMIUzj7P3+r 2UdzBE08P4P2YnIt13D2M0ClKEx3CjsabP1FljT5UAr7p/xcUsr7VtDWmT0epsixt3k8 jglA== X-Gm-Message-State: AO0yUKXOAWU5AYq7tarU2LeLZDnzo+br2foitLGmxTQnzmuD+gNErpYS 4Mg63fCbayI9G3v3pBR3KJXXBKmodeTcwT0f4ix4xV04RbjiZ6+tN1nq9c6NxTo4JHa7eciashS yIkRMuoUUymo= X-Received: by 2002:a05:600c:3095:b0:3e0:270f:dc88 with SMTP id g21-20020a05600c309500b003e0270fdc88mr4727015wmn.33.1676552145110; Thu, 16 Feb 2023 04:55:45 -0800 (PST) X-Google-Smtp-Source: AK7set+7vAUFLmGpK/uGMNwqyeDbGIKjmd05FOFkQfPnLLLkNoDCGfYC4U+JHMip2ipd/4/xZ0D3Eg== X-Received: by 2002:a05:600c:3095:b0:3e0:270f:dc88 with SMTP id g21-20020a05600c309500b003e0270fdc88mr4726994wmn.33.1676552144813; Thu, 16 Feb 2023 04:55:44 -0800 (PST) Received: from ?IPV6:2003:cb:c708:bc00:2acb:9e46:1412:686a? (p200300cbc708bc002acb9e461412686a.dip0.t-ipconnect.de. [2003:cb:c708:bc00:2acb:9e46:1412:686a]) by smtp.gmail.com with ESMTPSA id i28-20020a1c541c000000b003dd1c45a7b0sm1803896wmb.23.2023.02.16.04.55.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 04:55:44 -0800 (PST) Message-ID: <36284094-b8b7-abe2-3ac9-f504a7c8010f@redhat.com> Date: Thu, 16 Feb 2023 13:55:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/2] m68k/nommu: add missing definition of ARCH_PFN_OFFSET To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Geert Uytterhoeven , Greg Ungerer , Guenter Roeck , Rich Felker , Yoshinori Sato , linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org References: <20230214140729.1649961-1-rppt@kernel.org> <20230214140729.1649961-2-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230214140729.1649961-2-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 12B2840019 X-Stat-Signature: rf1temgsy1wq9z1ybbmsrbx1xfgja3io X-HE-Tag: 1676552147-651359 X-HE-Meta: U2FsdGVkX1+TPy1PCaDFEhJ+nNhIKVC5dqLukdVNa3AKrrcezfBnFnqmjSdNTuQgZjo3V5aKX2vA/sSgetGtta173LJObvoqquBGhfDU7xDG8uXoJ0GM3ZHPQzzPdUt2cKrdYqHE+O2ws3EhwgGvIndb2d2gsJsV2Bm41LhNK00xUr9DDuLmIlFhJC+XKjoKkl1t+ir/8IdQkFk4DdUviPD4cDfHz+8oXZU3zNeq18u1ocS3h091ERX+Eee3yRhiD7scexAnoOYMJK0EgnsDxknxJ91UmgnXDDB+poRqUpA9a+Pxf582eJMt2d1011eDbJjFc96w/G0kg046Qr9eUW8vjOWIx6/08ig/TbgDNM6jC55KfPP63tD4i58vVplr+gYBBijTedfFY3arfyI5dLdzmYXG4oo6GXyZ0pHQ9CqeLmt61NxSAhC1xQ0n9nF+Rqx2N43ELjHegvzTxEe1wjB9N9LLjNSvDu5LKtR/juJnDd0xmAbYL7qEF97OIM10x4cWbmvZBuEGYj5RQOJCYlrA2h4JSXlk4Sl4cmkaYMTxFDuOfBMwCLsS3BWaYQCRH4DPJZ6hH0B8rDda6MhvpGg2e9fhbxnK2M4CnsHGbPbtvAq5CY8qDd8O5uq+UjUtc13PVIuygbHN8bpG5/reGcPWCW/hZSvyudApsnQktCP1wj35xVEpOm++lXwSL1jEpajDbeyqDyJaN4YsJ7SOdiCvuQJF1ZF1UynEMrFpH6TpYHjGKz31tP+doAI25yjMCjUp3QcY1yFvflS4NqEg9l+k2Jxb+Y25QKcLhqJhPw36C9i0xQN6ZYPz8Kuy123UmPopJk1JL0wYSOdbqh4GEQ2JXoWnNR4ymMNLYPZtkPWj6SBUWS8EDM00IWBjaxJ7lDCtqAjxelzv9yoMJT020aQIG+RxWkpl8uCgey6MGGjHKWjs8QCVs925uZdeDljp6sw7vbECKvkbiPbDKfZ sK7p//vP uk4rQgMyMrJvu+RQ+TX+E4Ta5pPBCTBYId+UJSypBCgUZx1w49pOnMGF6OY8OHlNNQJPzdOYWkGVwKhgkfgQ9yhIxXKNwzbQiR+ZMn/ustw8D+yGJayO77KlwGrSxyuqHLB6W5XZ5+gs9eUwQU0b3D4P6i5rDXktWlTPejKG+GfW7Grvh1T6HxNEZuWqUULaiA54FQPTAk6AmTIl/NJdOzApvhnj521pTZII0laJ7ClH9gSPp8Ei9oLL4LBr2SDgfVUlsTkcG0P1xVtey5Pc9rYKfAhDSetwrcWMyXRT/wgGLdEtnHIrd3KYq2rWQkvnPV/W0BhDwTwzbgDInymephtvHkHQmKTmGB8iLiPj4RrrspkbELtVMZTh7T4+SUH5Jr8GFLDIstTP63pFAiPEBuebuiKI06Xday52J/4M1i8PxElK5cS66BQ5n+EKl7K2vpC1xshRV2kuwwu1ebAlP8KU8bBeKy97E6R9t9MS0HgQ70Op809lAfayUCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.02.23 15:07, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > On m68k/nommu RAM does not necessarily start at 0x0 and when it does not > pfn_valid() uses a wrong offset into the memory map which causes silent > boot failures. > > Define ARCH_PFN_OFFSET to make pfn_valid() use the correct offset. > > Reported-by: Guenter Roeck > Fixes: d82f07f06cf8 ("m68k: use asm-generic/memory_model.h for both MMU and !MMU") > Signed-off-by: Mike Rapoport (IBM) > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb