From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A9CFC6FA8F for ; Wed, 30 Aug 2023 02:55:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F26118E0042; Tue, 29 Aug 2023 22:55:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED6518E000B; Tue, 29 Aug 2023 22:55:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC4A88E0042; Tue, 29 Aug 2023 22:55:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CD5698E000B for ; Tue, 29 Aug 2023 22:55:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 88C7A80409 for ; Wed, 30 Aug 2023 02:55:58 +0000 (UTC) X-FDA: 81179256396.08.A1D692B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id 60EEC180023 for ; Wed, 30 Aug 2023 02:55:56 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693364156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rdPMkuzuGXd9mtDSoA/zYRexKhOV+1ma9dBV3aMi3FU=; b=w6cy079+AeVASu7CaRpJ5QrI4mt/KhyrU9b1rNMuuQUcjwBdpAqs3gGJEACmqxxfOEcRit QAAA38rxi7MD9fpdznG2IAit7sKEebSvPRW01R4jdjxTNAei+4PwcC7OIug98k3q3fGPR4 MqGtoaQZFUCY0occPPg0h5NPXkXNdqE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693364156; a=rsa-sha256; cv=none; b=CLZ8gxi20x/3f0a+Lzj5zb+YPNdBrkQeMaoMcNdegB3ya15M9nfTKe78oF4HJGliJ9Iaim S3eawONLPk4GKOnbo39vFPcIku4oXNiY/KIpJ0orPjah05pecQJJKcEpTwtdDGLwOivufE ITiQgh0UZdk3NeywNmO3uApg5T6/iww= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91A742F4; Tue, 29 Aug 2023 19:56:34 -0700 (PDT) Received: from [10.163.58.191] (unknown [10.163.58.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EF5CA3F740; Tue, 29 Aug 2023 19:55:47 -0700 (PDT) Message-ID: <3622f8fe-00c4-298e-0b35-06bb61b92cde@arm.com> Date: Wed, 30 Aug 2023 08:25:45 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm/mmap: Define DEFAULT_STACK_GUARD_GAP To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org References: <20230828035248.678960-1-anshuman.khandual@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 60EEC180023 X-Stat-Signature: 3e7gt18sxhs6bferazmtpbcjxupmguig X-HE-Tag: 1693364156-509573 X-HE-Meta: U2FsdGVkX18QUHNWkCYHLDZv3kU63utXndHqewTcABv+ZrSpZkHUbFjidrijhN30TzTxUqCyS8Q4SntD8vu6LBR9clfh062bwIY8XZCeh6nF7Ee4gJSoh5zaCE8kMR7N8giibuVArmxGLMVr3BQmhnX3Aa4lS1d8+fwZ+W4mvwDp5Ropf4CQvd9HyXNrKF26Duf8DcbaTc7qOwA8hOEpyGZR8nodJeMOjLeWzFz2bmAKv4oCsEPk8o1rJiLWscnR4mqxCW2gpfj+hpF4AhzRUawxcxC56E5LFpkiRbuoAQRcbd/ahlo3L2ZHjFaiuZ2IX9MsNmE/Lp8BXCXWw0FRsTf7MrYvDB5EDdImWm88Jysc8eHhWIsrOPBY0DdnTr/GeF3YE/jq1fWvawC7+/ZGbQfyg96KBJbvT7GgHUqjCkT/MglGpKT1YcCIJcHLQ4ebiM39cJpai/P9+VZnDqE/gB5YIP5uTHaOy4oK5j874yUQ/HmEmKcsExC7jhK0OqQqYqh6bOeSFU99kCx9783pwhLfHRMDO2hKapBIkjurAih24ym5HqkkeRL+uOydFUqcwwoLcOkvNl1/xRrKY+uC9Py/Rx+P3p9CC56bpHRXyM02IYVusCcIdD1s5hO9TQ9byK5p30Uq9azBxU1WmlwBY0zhfvy0bKGCox9MSpmSjc2daxG/m1RaKk2Q8tl5UahSe6UPjEthZ1BV3uLqhtPq+tGXbGQOgsiMsFX3tNPLimUXhorfTTHNm/bWKCELPNq9rWxSFN8mzZVye8o40lVpt4hyvUmeA0Qzi8WxpctHolIDNb8w+xL7Q0XnNfMp1/JGdBy8pZ+wlXzYoWxE/wxUDdqIYPp235i4s0Pfhw/4m4rz8v1MgiZGjxCFqkN9ZEOIobrKNbPsKgk+rodF1fqyC8zNKcKQPAiD37mHEyDZ3U/lwkiIitwQP7dKw8TXmhgWY+MVFw/yYMTtPRW16Uo GH5FgvWQ 58IYxuG+9wEZRCxwCXogWLLgZ4jBX76JCbOF351KwBBmEBg3wouzOvTQ+/uOfKFWvC41tIMTOroQ9jMVepVFtyqgDyKy7DLUouF+GhuGnETN3k+SEDX+IyxzA8/MCga6iD8JdgVIu3DXYmpyP9sdvvM8z+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.053956, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/29/23 18:02, Matthew Wilcox wrote: > On Mon, Aug 28, 2023 at 09:22:48AM +0530, Anshuman Khandual wrote: >> This just defines a macro constant i.e DEFAULT_STACK_GUARD_GAP representing >> the default gap, guarding the stack mapping. This does not cause functional >> changes. > > But why have you done it at all? Just as a normal cleanup which also improves readability.