From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8712CE79AC for ; Wed, 20 Sep 2023 08:06:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 393F06B012B; Wed, 20 Sep 2023 04:06:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3449B6B012C; Wed, 20 Sep 2023 04:06:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E5016B012D; Wed, 20 Sep 2023 04:06:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0C6436B012B for ; Wed, 20 Sep 2023 04:06:30 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BD85C140568 for ; Wed, 20 Sep 2023 08:06:29 +0000 (UTC) X-FDA: 81256243698.15.64E2605 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf08.hostedemail.com (Postfix) with ESMTP id 61E28160009 for ; Wed, 20 Sep 2023 08:06:25 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=vNUbR26Z; spf=pass (imf08.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695197186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rL1dCDLUMScax9S9apPYzcJ5uUxJ+5qWTUoLNXdgSSM=; b=NqCTR1WCPgyFOjtPeKOe+aCVdCrW1gSUFfJjG8a6FbPSRjgvGhyklhzbnFuUXZ1YZ1T8lm 7KJJvZI5Kuo9R7EGZ3zgOfsh4bPDIPDjZSsr/wqRO0ybpbpFZGeS+fVqdvNcatYp0WXts6 VAMUzk5zZwPwh/RmxvWWjE0yCbKcrbU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695197186; a=rsa-sha256; cv=none; b=0VbuoyOCA8NR41btZu5CsO4NfGWf9N/yEHqV8tXO4Ek0O/ZP/wNyXie1hqXU7JSVUGNHqD rIKQ8L3uK+jLiNTC/UcY5AXjWHCUgOXuv9Kb8X6fjvyHrOguD19jb2gi7MATeO989yTbDe fscJdaqioDq3dzRg0GyMnYrEY9ZZGdA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=vNUbR26Z; spf=pass (imf08.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230920080622euoutp021d61c3a0d5150ba4189a4634825c516a~GjNs2NIKR2102921029euoutp02s for ; Wed, 20 Sep 2023 08:06:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230920080622euoutp021d61c3a0d5150ba4189a4634825c516a~GjNs2NIKR2102921029euoutp02s DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1695197182; bh=rL1dCDLUMScax9S9apPYzcJ5uUxJ+5qWTUoLNXdgSSM=; h=Date:Subject:To:CC:From:In-Reply-To:References:From; b=vNUbR26Zv1WhBlQdHxS8bdUbfWCAmXQG2spvEkMlZw0Mcmxz/sr8skyj3kysMOIIt MSjKQHW1qM2IUcq9ZDeLdVlURzjgSe7qSu4dE4tz5eWCcl7VvSsxIuyTxn548L6xyj PZhPdKdjCfA7H62T+veM4RnixR/xUnNuPDIPBDTs= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230920080622eucas1p1aecea517ed6ddabc4b068b22a3a174ec~GjNss009E1314313143eucas1p1K; Wed, 20 Sep 2023 08:06:22 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 3D.CD.37758.EF7AA056; Wed, 20 Sep 2023 09:06:22 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230920080622eucas1p1e49881e06c0abda7eb7e4fdbdc40fe79~GjNsL8kTE1874818748eucas1p1V; Wed, 20 Sep 2023 08:06:22 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230920080622eusmtrp2525e8133b66a51b136356a133cd1ced0~GjNsLTzWx2686926869eusmtrp2a; Wed, 20 Sep 2023 08:06:22 +0000 (GMT) X-AuditID: cbfec7f5-7ffff7000002937e-77-650aa7fe0602 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id BA.03.10549.EF7AA056; Wed, 20 Sep 2023 09:06:22 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230920080621eusmtip1f15a2c8851daacf5095238f550ad26c1~GjNr_bsIn2781827818eusmtip1M; Wed, 20 Sep 2023 08:06:21 +0000 (GMT) Received: from [192.168.170.212] (106.210.248.121) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 Sep 2023 09:06:20 +0100 Message-ID: <361498b3-e83f-a82c-b1e8-e44720d16fdd@samsung.com> Date: Wed, 20 Sep 2023 10:06:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC 03/23] filemap: add folio with at least mapping_min_order in __filemap_get_folio Content-Language: en-US To: Matthew Wilcox , Pankaj Raghav CC: , , , , , , , , , , From: Pankaj Raghav In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [106.210.248.121] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLKsWRmVeSWpSXmKPExsWy7djP87r/lnOlGlx6rGYxZ/0aNotLR+Us thy7x2hx+QmfxZmXn1ks9uw9yWJxedccNot7a/6zWuz6s4Pd4saEp4wWv3/MYXPg9ji1SMJj 8wotj02rOtk8Nn2axO5xYsZvFo+PT2+xeJxd6ejxeZNcAEcUl01Kak5mWWqRvl0CV8a8zbYF fVwVf5ZOYmpgfMPexcjJISFgIvFhz2HmLkYuDiGBFYwS7YtnMkI4Xxgl3j1bwQbhfGaUeNN2 jBWm5fSbKUwQieWMEhc+72OBq7p68wU7hLOXUWLijEdsIC28AnYSR7/vZgSxWQRUJfpvTIWK C0qcnPmEBcQWFYiWmDltIViNsECKxI6Hq5hAbGYBcYlbT+YD2RwcIgLBEq/PmoHMZxZYyiTx 4exvFpA4m4CWRGMn2EOcQNfd3HibBaJVU6J1+292CFteYvvbOcwQHyhLnNr+HRoAtRKnttwC +0ZCYDWnxK7GXUwQCReJGw/fskDYwhKvjm+BapCR+L9zPlRNtcTTG7+ZIZpbGCX6d65nAzlI QsBaou9MDkSNo0TLzFvsEGE+iRtvBSHu4ZOYtG068wRG1VlIITELycezkLwwC8kLCxhZVjGK p5YW56anFhvnpZbrFSfmFpfmpesl5+duYgSmsNP/jn/dwbji1Ue9Q4xMHIyHGCU4mJVEeHPV uFKFeFMSK6tSi/Lji0pzUosPMUpzsCiJ82rbnkwWEkhPLEnNTk0tSC2CyTJxcEo1MAWELXRo vMDz0ojX8MqERzXhDxymcue7/zPm+PE4uW3yFYXy1rpV03LMm4VvTuEOTw42n3Li5dznR8Xk 4ya4T1jQynMjh5fpvsOhVX2S/C1sXl4TJ/uFs3kkPUo/Y2Og0vikcf/Fx68PzrDvWP8/bsPS Wi5NpkORKRcEIvR3L/2+WWTy36vHXkRP9Fon/SctxfTc0/Z5K9U8V8k87ukzi9OIkNdkCJfa M+nXhqLj62OVvk8LWLLhc42vUWOczptdGseWVdaE9LVlvfFTe1IiHmWwbu2ViUEf6npayyLU 90TW77IsvzU7RarSZWdmjP8ppl+bVJzPvQp+eETHS/yGWcCmy+XGqwvuWFW3ro1lVmIpzkg0 1GIuKk4EACaTlwfQAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsVy+t/xu7r/lnOlGvxtY7GYs34Nm8Wlo3IW W47dY7S4/ITP4szLzywWe/aeZLG4vGsOm8W9Nf9ZLXb92cFucWPCU0aL3z/msDlwe5xaJOGx eYWWx6ZVnWwemz5NYvc4MeM3i8fHp7dYPM6udPT4vEkugCNKz6Yov7QkVSEjv7jEVina0MJI z9DSQs/IxFLP0Ng81srIVEnfziYlNSezLLVI3y5BL2PeZtuCPq6KP0snMTUwvmHvYuTkkBAw kTj9ZgpTFyMXh5DAUkaJ+Q9ns0EkZCQ2frnKCmELS/y51sUGUfSRUWJx1wMWCGcvo8SMe1/A qngF7CSOft/NCGKzCKhK9N+YygYRF5Q4OfMJUAMHh6hAtETXS2OQsLBAisSGuw1gJcwC4hK3 nsxnAikREQiWeH3WDGQ8s8BSJokPZ3+zwC0+8u8qO0gRm4CWRGMn2AecQB/c3HibBWKOpkTr 9t/sELa8xPa3c5ghHlCWOLX9O9THtRKf/z5jnMAoOgvJdbOQnDELyahZSEYtYGRZxSiSWlqc m55bbKhXnJhbXJqXrpecn7uJERj324793LyDcd6rj3qHGJk4GA8xSnAwK4nw5qpxpQrxpiRW VqUW5ccXleakFh9iNAUG0URmKdHkfGDiySuJNzQzMDU0MbM0MLU0M1YS5/Us6EgUEkhPLEnN Tk0tSC2C6WPi4JRqYEq9coVTc77y5yOx3/+LLH1+/Urm/POu87NKA/jzjhtmea2OublGU+KF W82y3I7FSnKxu/4Kzn+4+Oya1ndH/s/3CtPST1Zfe35lxw//s7prIz/u5z/emHCc53xxzJGE /POykX5/b1yRuXOru039Yczf46pzNP2OPn00cVfO6nuz0i7eebnwV+NL72/H2LiPrfyQGbMk uetpMM8LgZXarDKWUVGSk9/NlnbOWyKzp2Gf+tf4SykM1baVUx6f83Y9V3FarPl5s9dHnZJM IYdllXbFBy8abGI3XC2SfPHv6e023ySSDhc8W9wp+Ouda/9et3/cewoOB0ds9z8UL6XwQbPj 0L6a2eUqQm4JS4NuLehXYinOSDTUYi4qTgQA56HPEYQDAAA= X-CMS-MailID: 20230920080622eucas1p1e49881e06c0abda7eb7e4fdbdc40fe79 X-Msg-Generator: CA X-RootMTR: 20230915190017eucas1p2ae10e22f9bf758d554f20e4cd8d99b0d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230915190017eucas1p2ae10e22f9bf758d554f20e4cd8d99b0d References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-4-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 61E28160009 X-Rspam-User: X-Stat-Signature: hwzdcdfsu4pt187uqwghjqmj35ewo37c X-Rspamd-Server: rspam03 X-HE-Tag: 1695197185-960005 X-HE-Meta: U2FsdGVkX192U4EZWC9BtlSBZ3ZYwCA0OxetcDE9kQ8jF5O4XK9+v3GmJtxZIjDQNuS1j6Zcn5I/zT0Db5BxicsHZwLyDKSg6fVBaKF9zdPkSDAX4bqcGfMXjtDxLA5tb3/GpV+3OvjHmfPTrav0rUQTnf9f0EdN2zqAW6sLDNJx6yqmKOj7x7GibejEB1JhXWJ2AgQCns0CWg7npwNdcPaIu0oDd+jRjRkteUKlEdqxct2ViXW6casSYP0IEr94lJCM/WNoBm6v7S8PK93f7eRDN4yZtx04Dr/FA1JkolxPIsVQdfnX0z1OuHVluTxN2oRs4G8NHxFXpPJDik4JvEo8IGx/qxV90c06BsI3qhocGAdOXRqf1HloRXsLj5/hSCu2raTb/ILSNVe8XRf+WeAwcwqokNWgwz0WiiRdA2NrN9JkcAIxyIxy8wpjn/izhFhQJOxzfakZk36LgeliM3XavEUU9plrl47DkiSOZ+lj/7dHkNnMH59ENrmVAcHG20g31OSSBMMBd/n/Pax7IxnUwkGqu9GghD2huME5ibDB4qVJincjn72BY3RHgWar2SneYhlQIUEozsgEXUN1tnEBElwaXOZaiSs6Aijl0gch0SptrWo5EV9nK1p7Xju0Zizod0z/PApJLA4XGU0H+ztyFPe7uNt57Bo6ptl9Njqz8JBG+wBJTyr7y+eYaOuumgDnjbTp2iECoAeCHfRum/D58rnRt6ipO0RdvjjvlmJTOR7CfY9gIIZZHoHPihBU8tHh6WwQPlhovlVLtdRzHyTkA/wjrn+AGAgD1i0gKxRIpI6XAWtX8OwEzJoSJTRmQX3ozX13A1byi8G5kKt96IvqajUrHwjv1U7oYAuW+b8M42ua4u9bIVZgXyseQisyjL1ENIl13XBopo221RApVObsvPgPDy6L4xZsDYinmQRcASyxcIbKSX//tClRXQSWftmf+g9GHJYUvG2hFdH sEC05DFh laYtCs6cvzbRWpEGyqPJys8nj8Hre/pfQ86Tq3vzV331G6dehTJG6ybcU8v4IgPqejdP+rh1THwy5fKpftCzkONn+oVxZvnhpWymtv+TzAgrALel3ghyy2jB84QS1cesOH6P5MzkLToJ3SPKcXTMc2ZMmv2NHeJ/PGv2OlAaWng+tGPE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023-09-15 21:00, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 08:38:28PM +0200, Pankaj Raghav wrote: >> +++ b/mm/filemap.c >> @@ -1862,6 +1862,10 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, >> fgf_t fgp_flags, gfp_t gfp) >> { >> struct folio *folio; >> + int min_order = mapping_min_folio_order(mapping); >> + int nr_of_pages = (1U << min_order); >> + >> + index = round_down(index, nr_of_pages); >> >> repeat: >> folio = filemap_get_entry(mapping, index); >> @@ -1929,8 +1933,14 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, >> err = -ENOMEM; >> if (order == 1) >> order = 0; >> + if (order < min_order) >> + order = min_order; > > ... oh, you do something similar here to what I recommend in my previous > response. I don't understand why you need the previous patch. > Hmm, we made changes here a bit later and that is why it is a duplicated I guess in both iomap fgf order and clamping the order here to min_order. We could remove the previous patch and retain this one here. >> + if (min_order) >> + VM_BUG_ON(index & ((1UL << order) - 1)); > > You don't need the 'if' here; index & ((1 << 0) - 1) becomes false. > Sounds good!