From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90024C02181 for ; Mon, 20 Jan 2025 20:16:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 199936B0085; Mon, 20 Jan 2025 15:16:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 14A306B0088; Mon, 20 Jan 2025 15:16:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDDB76B0089; Mon, 20 Jan 2025 15:16:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CD5D36B0085 for ; Mon, 20 Jan 2025 15:16:58 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5B530A0391 for ; Mon, 20 Jan 2025 20:16:58 +0000 (UTC) X-FDA: 83028938916.02.DD9F98F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id C95B4180014 for ; Mon, 20 Jan 2025 20:16:55 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZKnTCFb4; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737404216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rxNZDgHHpNg2/W+/DtkEp4r5rDDnZBfDci05R81CKvM=; b=WO8vheRRFTTmHZG/Oa/ff4qv+CMSQZsa1TdLqrNaFlcNdL6hjrfiyGmF+Jv8xijNIUmFA7 2zZUNmw6N1RMv/EHSdKg2tGKfnAJ9hj1g52zU/AJNULgpx0hMVWhZwIscOZxCQDF4bmyM6 ZkCvXFlA/CQZEPbEoia1bIkA45snGSQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737404216; a=rsa-sha256; cv=none; b=yXMJkE2pV3Noln2feT0OoRnKGGdGSuaLJX+eJvjBoPm00v69IcHvZps8FCxNlpw/4TIXwI 4VHKsFehagn3lrupq6ybHCOQDGJc8knP/uuZwdSZrD4ya54yd8kglgm6ccif1ajWaveBGq LCaayFN+KIZfSjeZ6vZ3WdIj2GXXop8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZKnTCFb4; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737404215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rxNZDgHHpNg2/W+/DtkEp4r5rDDnZBfDci05R81CKvM=; b=ZKnTCFb4UzFJq8ET0V6aGevIz9O19A3z0Jt6nrOE9+h9nruJZvNiiQDiPAocvp60rBjHKG /liXEya76ILTAooDowUblc8KHehmJYJeEGKvEwgM8GxH3Kmc+tbN9HPNr+LmmERn8k6F7A 8XWjU7DLABarssABaBI5+KF611PeiWs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-DeaBBUZdNCyW7NgHlqPUnA-1; Mon, 20 Jan 2025 15:16:54 -0500 X-MC-Unique: DeaBBUZdNCyW7NgHlqPUnA-1 X-Mimecast-MFC-AGG-ID: DeaBBUZdNCyW7NgHlqPUnA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43646b453bcso25354605e9.3 for ; Mon, 20 Jan 2025 12:16:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737404213; x=1738009013; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rxNZDgHHpNg2/W+/DtkEp4r5rDDnZBfDci05R81CKvM=; b=H6h0M59NaOPuLXPXmz3kixnfhCrxrEIPA+onC3n7f9syHee1MQv4PEEhIzt9xbU9yW KcYprakkC2WVMGjY7d4y0WVwyc0CgfmR4e2/u3c8Th2E/DU3Bqj2ulxfRrWYTlbHXVn5 Ukp3wEdOK1YVeidDWooquYgKPmiludJvkc422y6py2lOj20xy9wreTizjVsN8GzLQUqC HiuYQeU60oUlN/vreybYhgRPWoeft/Y/pZ5J8MOOVmpzXMEL7ufk4O0pwISH/s0zSsWk p63DYrkKD0F87j24i44smfjn0wSVL7uP/B8q1wZmsBdeOfG7etN1oNgdoHmEsZ+htL3h zNKA== X-Gm-Message-State: AOJu0Yyghh0rMf3IeGVQCMUiL2lyNuRV8PLeGSJKm/qn2aG87fV+m3yU LdYKlwgpqHI1vGySAftPqUgswwgpwL1NCtd5syfu5c0wN8paAjgA3VZwDGCVCODKWWH7elBB+7q Wm8cSKlnSGaTx7uiNvyWs8yck0dXEOsgU3keN53osF32iZ3ZZvlbIC8KZ X-Gm-Gg: ASbGncvmfF+TpB9y+/GwH25VuOdsiWnsLd2CZKvw3y2dtBZ3XyCvrxIq+38mY6pdOy0 pTeUhw8f0PQRRvwiQM0fvOtQo0fANe4UsLPtfj3eetyFSCTf2tQ/szSx8C/ewMIvfuZlwip+LOl oU2YntYp3Mb2qaMEjLSRpezc/oM3/uKElzuey23UEW6poqpgVIDt5k8emOQtwv2BMk/kC0FTppv BoOck2GMoKVaIMXFoKqgONPhrR8GKjR3fSxPKsFaxZamAqN295KQrJQRnm+B4bmloetLCX+qlvp 5BXTFNB/QUPX99tiy9Z1XLeI X-Received: by 2002:a05:600c:4e0c:b0:434:a802:e9b2 with SMTP id 5b1f17b1804b1-438913bd972mr131386045e9.4.1737404212718; Mon, 20 Jan 2025 12:16:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhXW3eC8X/Z3zk3Q5/MJeYpypdZKm5hACpaMl4+QVG94buci3CHFN5dgx/2XA2nw5mlfIleQ== X-Received: by 2002:a05:600c:4e0c:b0:434:a802:e9b2 with SMTP id 5b1f17b1804b1-438913bd972mr131385905e9.4.1737404212333; Mon, 20 Jan 2025 12:16:52 -0800 (PST) Received: from [192.168.3.141] (p4ff23481.dip0.t-ipconnect.de. [79.242.52.129]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c7499821sm212197915e9.2.2025.01.20.12.16.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 12:16:51 -0800 (PST) Message-ID: <3613bdb9-a933-4027-89e9-03a261410f68@redhat.com> Date: Mon, 20 Jan 2025 21:16:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm/cow : Fix memory leak in child_vmsplice_memcmp_fn() To: liuye , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250114022929.46364-1-liuye@kylinos.cn> <4fd2fdca-ea98-499f-ba04-0f1140180ba4@redhat.com> <778941db-27fb-48b3-8d98-81d1673deffc@kylinos.cn> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <778941db-27fb-48b3-8d98-81d1673deffc@kylinos.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5JvX3kLdhJW92yqGZr5ObwWyxNum29V3S3UNC9oTO6U_1737404213 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: deq6h7iatsxmhru1gj7eihirturfuimn X-Rspam-User: X-Rspamd-Queue-Id: C95B4180014 X-Rspamd-Server: rspam03 X-HE-Tag: 1737404215-612623 X-HE-Meta: U2FsdGVkX19Sq7/XoE22W/j1uyjBIKWNBIzS4TKf4LCwD8p15Js6lYrdeV71KMutR3KJxoZ/9gFSYgYLQysAPms8vwzB0Bne/jRn2ZHHEPw+Zanhc2BE+hMC8Ffyk8f33zkvenkqsKhruNVpIsqq6GWoWBmwWxNgg3LYEvIBercf6agCtXngaz2jZ5W43BW6SkV737W+1G7t+z0H5n8RVPjjnsaDDiYC/iNXUO9NdabGjzKThllCiB19rIkVbzwquMFrD4xvWF4bRq0BnSwWOkyUhqOAVxiHQxEDlAnmeVFjdjcu++qp0jqTCuRhNUaPhJvA7be5COzUCC/tk1QOaZ9l3vySZHGHNdzEzrmmADoVavjyZCuX2jr03mspR7lSfqLI75TQhxv+aTcO7j3TfzFitG1mJMqkXm3ovg9QwlVG8RpVyYCYROqTn/rFvd8fYvN89f/lyAALIjpFKs5eQYCGlJ5bgvcSw+Hx6kRq+YSMdj6WFeXzPm05AidR0aQQxj7b1880ePJpwy3re/xPeLEsMl/V2ciJyjPdOlbd6ShfIvU7Z2lKQz02XGghVTjgH9nMIRvKcnKIkYw8AIzBY/u5uhoNx9v5gxyg5TUJ8Sc7Yo7UIX5zauFxArJV49knUq5e2BduvXYv+o0OQkhOZeFqJjRyw9y3+DeMG6FxoFDv4S7efULDBO36cDHk4PwhAoym7uDLwoqa/daDFeY0XOwxv7nWmK7FbWAuNwiB+AgHBY7XgEUijWTkVY1VUAiSHuRRxpDNN8IJ8kUr33uz58UjrKqDvVhMVCNWjpiyLIehZ3AkYEeEONkyhe55FqUPQVrzeLQLOf4j29IGAyadLhHmr10F1BSXDYvHuzYrtGLAZ1QxvucNEw6MHHgtiV6ERplOOnUVYl+cBU5M6JqzZzQ9feQCTKL5Zin10SEzLZMG8UCzsC2rjdgQGH2r6jPVHXIT/JK8V5tBazXNQMD dJtScUj8 N/IJi1rXggtLU/3+ZqHqw/L8CYUR5hRGbd0isSzgYaK/3WeUcWBN+8Mx8vOEQEa0CAdOMYNHGfk4zjvoST/kFsU1Kf1gmGeF3V/87jEv7ZHC5Y0YgyEe5yUD9EZCl2vKrQBufD2lniPhd/+4tUZ3xAj9PG4+o1ZyCbE3IMC5Ukf0U6uyPAyurbR9XwMQeLj/vHmun/nOBTLdqE0bGFmMDs50ZnyqfCVWGrTPLLqbY2mU6s85+l4Xsh+xDOZQzMRNHP91ytCgo4ll3bKQjxRmP80Et7GTCqRb2Uiklf0OYdXpgMD1OleuxHf5j/edmVDXWE6uMAmqBc01AyP6J/I5kEyJ9ICap01RFCYR3+++Qn0jRTLHGk3kJ4fJ2liS3kbRvKxE8U/qdAupzPgVIc9GqweaGieopv0aFP6/OLNcdgIkBOU5my+sFn9tsVrArCi+8ESVWdC5nir1RVcsCu/WGPiou9lOmQQTfpw9FdhR2zaYJ2t8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.01.25 06:45, liuye wrote: > > 在 2025/1/14 18:23, David Hildenbrand 写道: >> On 14.01.25 03:29, liuye wrote: >>>      Release memory before exception branch returns to prevent memory >>> leaks. >>> >>> Signed-off-by: liuye >>> --- >>>   tools/testing/selftests/mm/cow.c | 21 ++++++++++++++++----- >>>   1 file changed, 16 insertions(+), 5 deletions(-) >>> >>> diff --git a/tools/testing/selftests/mm/cow.c >>> b/tools/testing/selftests/mm/cow.c >>> index 1238e1c5aae1..959327ba6258 100644 >>> --- a/tools/testing/selftests/mm/cow.c >>> +++ b/tools/testing/selftests/mm/cow.c >>> @@ -167,19 +167,30 @@ static int child_vmsplice_memcmp_fn(char *mem, >>> size_t size, >>>       /* Backup the original content. */ >>>       memcpy(old, mem, size); >>>   -    if (pipe(fds) < 0) >>> +    if (pipe(fds) < 0) { >>> +        free(old); >>> +        free(new); >>>           return -errno; >>> - >>> +    } >>>       /* Trigger a read-only pin. */ >>>       transferred = vmsplice(fds[1], &iov, 1, 0); >>> -    if (transferred < 0) >>> +    if (transferred < 0) { >>> +        free(old); >>> +        free(new); >>>           return -errno; >>> -    if (transferred == 0) >>> +    } >>> +    if (transferred == 0) { >>> +        free(old); >>> +        free(new); >>>           return -EINVAL; >>> +    } >>>         /* Unmap it from our page tables. */ >>> -    if (munmap(mem, size) < 0) >>> +    if (munmap(mem, size) < 0) { >>> +        free(old); >>> +        free(new); >>>           return -errno; >>> +    } >> >> We are immediately exiting the test in do_test_cow_in_parent() >>     exit(fn(mem, size, &comm_pipes)); >> >> Your changes make the code unnecessarily more complicated to read, so >> I'm not in favor of this one to make some checker tool happy. >> > > It is indeed exiting the process. After the process exits, the memory > will be reclaimed naturally. > > As code in the kernel branch, it will be used by beginners, such as me, > for learning. Modifications are recommended. > > Regarding the readability of the code, is the following modification > better than before? > > > > diff --git a/tools/testing/selftests/mm/cow.c > b/tools/testing/selftests/mm/cow.c > index 1238e1c5aae1..db5e71c5bf2f 100644 > --- a/tools/testing/selftests/mm/cow.c > +++ b/tools/testing/selftests/mm/cow.c > @@ -167,19 +167,21 @@ static int child_vmsplice_memcmp_fn(char *mem, > size_t size, >         /* Backup the original content. */ >         memcpy(old, mem, size); > > -       if (pipe(fds) < 0) > -               return -errno; > +       if (pipe(fds) < 0) > +               goto free; > >         /* Trigger a read-only pin. */ >         transferred = vmsplice(fds[1], &iov, 1, 0); > -       if (transferred < 0) > -               return -errno; > -       if (transferred == 0) > -               return -EINVAL; > +       if (transferred < 0) > +               goto free; > +       if (transferred == 0) { > +               error = EINVAL; > +               goto free; > +       } > >         /* Unmap it from our page tables. */ >         if (munmap(mem, size) < 0) > -               return -errno; > +               goto free; > >         /* Wait until the parent modified it. */ >         write(comm_pipes->child_ready[1], "0", 1); > @@ -194,6 +196,10 @@ static int child_vmsplice_memcmp_fn(char *mem, > size_t size, >         } > >         return memcmp(old, new, transferred); > +free: > +       free(old); > +       free(new); > +       return -error; >  } As an alternative, we can replace all return statements by explicit exit() ? -- Cheers, David / dhildenb