From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE1FC48BC3 for ; Sat, 17 Feb 2024 12:35:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0A9B8D0002; Sat, 17 Feb 2024 07:35:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EBA928D0001; Sat, 17 Feb 2024 07:35:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA9DE8D0002; Sat, 17 Feb 2024 07:35:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CB9D78D0001 for ; Sat, 17 Feb 2024 07:35:35 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 91174A01E9 for ; Sat, 17 Feb 2024 12:35:35 +0000 (UTC) X-FDA: 81801241830.22.FC66E59 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf25.hostedemail.com (Postfix) with ESMTP id 8AFB0A0003 for ; Sat, 17 Feb 2024 12:35:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ByVuoUxg; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.11) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708173332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NzjXg3CKQ0TaXqBd497Q3mH5G/e3fLCWWcCEz7gEw7M=; b=7bkpRznSZt8aJiVZeTcbLiXc4pqgsAq9l3YY77Oiq/T63LFasD8f6bPxBGDgHribdH/5Lv dK8P1fm0Iy1yA4kS9Y5Lb1UQdWBwF7LVjYM2wM1uX4laMHJ/hicvjzMq7TGypIQ+o64WVM lsBdQgE09K0bORC7+vxf1mFS4KOhrF8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ByVuoUxg; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.11) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708173332; a=rsa-sha256; cv=none; b=wYSeO2qCrJmTPSn6MA2yxzi6V5oKSBD85NOppRC6fFsPDD2wn4V1uNHJVW1zTGPS9/mSmL TeQM+Yk0NtWrN5sLjFBQ89P+kqPLdpu6aqCqGqsTZ/MktSbZqU88HiGdhcUXBxnkvTYcKr QGgQR74n96X4PATyCGSwoeEvhQvfzgI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708173330; x=1739709330; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=dxYmYjvFhU5nWz52Hqun3yHSuCsp6TLZ1/ueI0sBGp0=; b=ByVuoUxgQA6P/rOY1npW5ZZhv8afDoVyTqFnsbFp3PsaqI/M3tGfeLiZ LZ0dvgXrtqXwixxsVz45Dxlq/U4l3oK61zexryW4eeptsR4PsX6tpEXOy gB39n9iusP8Z7Ln5RzhRf5EhweHZdbelVSOCX9RZ9/Xb6oVyrL/KerUGV alNqlrWKpSGQ6B6c/oN734VgJ64Zgc1slk9Dvnq5zdGOSMdVJCWALrspu bZ3TUgxOBtmcauc2uMePbDZkW2RmUabEDPkGQX3zFtxPm1Fmdn/CCiRYy lFI3Ng3FeAMEtW5BL7Ls0bT9vJj/yByCcJbtFeMopnhsfVd0whMwuHIdO w==; X-IronPort-AV: E=McAfee;i="6600,9927,10986"; a="12925710" X-IronPort-AV: E=Sophos;i="6.06,166,1705392000"; d="scan'208";a="12925710" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2024 04:35:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10986"; a="935994551" X-IronPort-AV: E=Sophos;i="6.06,166,1705392000"; d="scan'208";a="935994551" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 17 Feb 2024 04:35:24 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id AFA0C2E9; Sat, 17 Feb 2024 14:35:23 +0200 (EET) Date: Sat, 17 Feb 2024 14:35:23 +0200 From: "kirill.shutemov@linux.intel.com" To: "Edgecombe, Rick P" Cc: "debug@rivosinc.com" , "luto@kernel.org" , "x86@kernel.org" , "Liam.Howlett@oracle.com" , "broonie@kernel.org" , "keescook@chromium.org" , "bp@alien8.de" , "mingo@redhat.com" , "tglx@linutronix.de" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "peterz@infradead.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH 3/8] mm: Use get_unmapped_area_vmflags() Message-ID: <35rzsyepg3wx5vjsyd5n5pix2c5oo6pibzfmdvlfbpmf2mvvgy@icrlxlydgs6z> References: <20240215231332.1556787-1-rick.p.edgecombe@intel.com> <20240215231332.1556787-4-rick.p.edgecombe@intel.com> <6d034d561dcab4300a7eb66e34e2a03aaf17ea79.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6d034d561dcab4300a7eb66e34e2a03aaf17ea79.camel@intel.com> X-Rspam-User: X-Stat-Signature: ykgk83b7ejinexyamdok7utqk37z84hu X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8AFB0A0003 X-HE-Tag: 1708173330-897644 X-HE-Meta: U2FsdGVkX1+dfFcuP5/S/T2xdkZaC9OPKOswC5fmC8+MaCVxKdsjQlAnU/JRfb5M8aRD0BDFYTyZSwec2k/wpsvFkrfLVRq0EXhn+soSXFiId9VTD1AJFSEkocXX7Ail59IeWPFiLceZ9EMEDZxkKNRRQvrHdBt4wAsiB2WIncqxJbwI8SHaV+O/b6XrGmnP4YK6FfFISEP6ttgSfUPhaVOlAjVWtEbiFVuFJsX5XNxsp5AqCMIWgNnr6/Qkw5ruhhtLySfobgwg6+hcVdxxNB0/vjMY1ydXVfnhf+g5QyhHyheSX1MZbroYJl7UAI+VmuZjiS19VFheO30q3S5e9RNvJMDkuKOIbOwNuPOf40cykb/W5iWuOXSjee1rjrU1RM+uOZGXALTkK3a5FjwNj+M2JXbRBc8pXEqHea0r4HastEKMdMsL7mbDJJkuAl4FQVMPnK+qYpcvW8eGxtBvE0/qj7sy9qSuJUIHaA5UPng2yXHg0zY+ksKTgJTQEW5ULSCCldnP+zN16SDhQrQ2PmaP8N8eoG1+ad+s7v0Zl7WxeQ+fohKIm+HDFjSNT/y9taxowkClcNUO/s5KGZUNw0VbW0ccN/nZDVOsrWaPq3ksRoYOeQeGQMMt2a13/DH+vmRVdsh+0iXT+EHx4Grf1/6ClCABFm/pCl7E5np9/7XYAxbRUGRSLuGQcQcyHlGMX43396GwIzrlB0/c9p/KhQqLDp5vhQ8uXq3SXjgyG1SV4aRlV7bY+kKhADbsGMrGiyccA3v+R/02ye731HjvJDkUQITNzbeq0ftlxGuNXtB8NvihK7U/Z7mWmL5nkoirLzOZabnS1OTmFZXJPDDKs7Pk/L9o2trG7gGH5t83qrrCOskItQioROZjF7MuVeHk/vwCD/vQZxZG0GN/NrnvOWRGDweu33zxFiXnjof2wFM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 10:15:05PM +0000, Edgecombe, Rick P wrote: > On Fri, 2024-02-16 at 14:56 +0200, Kirill A. Shutemov wrote: > > > +unsigned long > > > +get_unmapped_area(struct file *file, unsigned long addr, unsigned > > > long len, > > > +               unsigned long pgoff, unsigned long flags) > > > +{ > > > +       return __get_unmapped_area(file, addr, len, pgoff, flags, > > > 0); > > > +} > > >   EXPORT_SYMBOL(get_unmapped_area); > > > > Any reason it is not a static inline function in the header file? > > get_unmapped_area() doesn't seem to be referenced from any modules. I > don't think it needs to be exported actually. Maybe it used to be? > > It could be a static inline it seems. Why are you thinking it would be > better? That's just what I would do for legacy interface wrapper for new function interface. And save a function call for caller (it shouldn't matter in this case, but still). > I think maybe get_unmapped_area() should stay as is, static-inline > wise, but remove the export, and the newly added __get_unmapped_area() > should be made static. Does it sound reasonable? Up to you. -- Kiryl Shutsemau / Kirill A. Shutemov