From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACEB9E6B278 for ; Fri, 1 Nov 2024 13:58:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 450966B00A4; Fri, 1 Nov 2024 09:58:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FE3F6B00A9; Fri, 1 Nov 2024 09:58:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 279036B00C2; Fri, 1 Nov 2024 09:58:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 055E36B00A4 for ; Fri, 1 Nov 2024 09:58:33 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B6587AC146 for ; Fri, 1 Nov 2024 13:58:33 +0000 (UTC) X-FDA: 82737681012.02.D1B04CC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id B4334C0014 for ; Fri, 1 Nov 2024 13:58:18 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kt7tRwgQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1USpon3P; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mNiaqf+h; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hN83u7VB; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730469348; a=rsa-sha256; cv=none; b=LeWsZAtBfWxwC5+5zhdWRYaPZ0yYG6RjLe5H6TqjV5y1ea3qloT2A7ztlzcEHEWY6nNCsL 0yajKpCJ5ny3lj5Xl3mZJv3paFq+8tjJcWdq0/kSfwdwtW85qvCDSFTaB+/SC+13yRl8ph swCaoLfM1bzXNAXKsJx0EPfN/treiS8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kt7tRwgQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1USpon3P; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mNiaqf+h; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hN83u7VB; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730469348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jjF3UBicJ3mI52bTKDJK7RFsmQx2+GctYo5/fkN9ie0=; b=ij0fpDgiroBJhig2km3HWdKhp8twREs6fMjxVdhxBJdBvkc1/0cO/oUMw+yNijs5XGC3Qs 5P0Tv+ONwfWhY5I/CN5c2NSWoHI83Bs1rLr5B5Aafdh1f4MevcB6B6TH1DLE4aIqknQnx3 2Ek+5n5hzMGDCK4z6mrwtL+ZlwKsz1o= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BAA9E21C1F; Fri, 1 Nov 2024 13:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730469508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jjF3UBicJ3mI52bTKDJK7RFsmQx2+GctYo5/fkN9ie0=; b=kt7tRwgQ9BhUVdpKbdYY2+EJP7LtPZq0JbE5nX/hf44uun4P2pDGG9vRSRKdKS7cpW7jYf zWWEuqpFlgK+2a8cdRU6lEE4bAwHnrZApBXS1Zn/XMFJZnHl8XpNYc4dUS69X1zT2vqI/9 eUm1pr2oo9mByrsRjlbyPWlcmPXsNM0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730469508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jjF3UBicJ3mI52bTKDJK7RFsmQx2+GctYo5/fkN9ie0=; b=1USpon3PvZXw2nWCiMp+ErC5KsPuuJq2drLltCFwMVTx0EXSsmv3na05yy0iyeClKqOH5s 3n+mzXk6MG7HrDBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730469506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jjF3UBicJ3mI52bTKDJK7RFsmQx2+GctYo5/fkN9ie0=; b=mNiaqf+hi98g6BTGTBRARgw3obeIhAk6T4F46Hh/9cJqm8SF51PpgxZjYcGbCfmzdjvYT0 SsZfz/ujCafEZRB28EomXmH5iAtvp9OOT2Y1GEjdjSRXGw8Lvwh7HGST8fcC4uBfpSb1nn DQp7XEFLKh5XnLh/d7XacHu45LiLYMI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730469506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jjF3UBicJ3mI52bTKDJK7RFsmQx2+GctYo5/fkN9ie0=; b=hN83u7VB8s7U70Lf2GVw2sXmXhn9BIT4ihJtnm5f4p0uTaPhtB4yJdUnAlB5DG1sKHzJgz 64vfM449iQAMyGDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9C2B8136D9; Fri, 1 Nov 2024 13:58:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3mBQJYLeJGeFAQAAD6G6ig (envelope-from ); Fri, 01 Nov 2024 13:58:26 +0000 Message-ID: <35f58f1b-6e71-42ce-8619-2ecd810b4510@suse.cz> Date: Fri, 1 Nov 2024 14:58:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/slab: Allow cache creation to proceed even if sysfs registration fails Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin Cc: linux-mm@kvack.org, Jinjie Ruan , Liu Shixin References: <20241101130845.19100-1-42.hyeyoo@gmail.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Stat-Signature: sqgafryxtssctqxggdtxo9me3meeepzg X-Rspamd-Queue-Id: B4334C0014 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730469498-418104 X-HE-Meta: U2FsdGVkX19+7xC1n9pbz0jHb7yIghQpDj09yCtxw6YfIouWtCxlg81+T8vy4cUsMXq4Cg5Bhp8tAa1qZfkRBgFbCOHSr0Ac9Sf3dELo4bxF6lFvZhzEVjOtYN5XRfkcgS6GcwtoJr88soKu3ARFYACH56HZt216u+j16BPcYZNDxTpG5xCvUZlP9lTk3CrCjXuK8P8nEsC+Olu0k/k+EuN2pSZvVCGFv0E+6BkT1w6eRY9O0KyHrfBajUZqGpubSLH5WBI8JcnlXOQ0qtifw5K4icqpYHl8j3aw1YX6U8N7nQdrV6sQTU6hz/E87GYdzMNKndhdny4OfimS8Orknkm6/bMBEh3ABiCzGVXj1Jm9qAyTgQNvHVwGznUQpZczK1dLbgswBsrHaHhXyv4frfMgG9SOxWLsEBhqeB8SYy9A8oMjllnbVkhwjyi6eGldgHbpCI6MssCRWbs07fueDgZ82sWatiLO468noaBaagrk5OWwIil5WiEjOS7X2S2tzfqN2DFvINKcD62qU2BDlvj7EF5UMTElnLh8gr56dYe5JBIN/8TvMUSsa1Z8WcoxBX3hojJyVtpn3qzMZ0XGbnP6S76oYH6Gtd5tNDPHBw380KdbzbIeIwHsyU8RO4QpZyIacChaxrMoH3NlQ1PLhvAGefV11vMLRHl3pmb+TE98CDypLKrXyIjNaiJL1/sYYv7Mcp99MPwG1XbprushKYVoeMbNA8SFjYmvRMvUd2XdyvcNYKWGNE0SqAghDsjfSTuwF68A9NcBVd6uYq/zq8q/VoIiqYmK+Ek5MROTXTd8iTw7aMpgyaDWBA1ApwqcO+AaZJO1nO9ACJmFf6g8HMyQ5WzqiBz8/9z86buPwAOXyEwhnIjG4kJcVj45ypbwMznjamwpvVBaWYlaWU5EKWux34anZNuqgZvqEVbsG08EXnZoUpExHzVr2Ndre99HnsHtc6A5kA4ibflDLsp y2nHS47n bSM57voSR4jS5CZnIhQ2BWlsB26ptm101JclFu+ZrpbLah5Q/DrQN6Rllucv2kcbIiWpGOjthPdLzUFUeUoqjuMq77BPfuzfM+zEMIrLber/1gJDjhehsCqlW1HbfI6fpV9tjSR6eQBTHA/JOup55FlmeyL6Lnfec4tugNBANN94MHFlZ6GeA8O6vCxqqQwgR/HgtqtEdjYGpDOZuwR902D1Fx5xC5TV63Wfe/SIy/fZ8C1uhIA/Cy6Vk+YR99Se/5GOk5jzTkKVQiDVeyEbQGz37EjgVlLzjq6e9ny2i0V/QtkVx6HdUMBnixQz4+VQHnIIR5gxVF9CcIjqymW+l74t7tWIvdsem81PQN5dr1yzzpEcBg9mShw7lpljwTLFwwcmQSH4xjJoV5ZPr1ifHRG0izdRKjok1HGH3EoGZ6cU5xBzy+bdZgf3k9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/1/24 14:15, Hyeonggon Yoo wrote: > On Fri, Nov 1, 2024 at 10:08 PM Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: >> >> When kobject_init_and_add() fails during cache creation, >> kobj->name can be leaked because SLUB does not call kobject_put(), >> which should be invoked per the kobject API documentation. >> This has a bit of historical context, though; SLUB does not call >> kobject_put() to avoid double-free for struct kmem_cache because >> 1) simply calling it would free all resources related to the cache, and >> 2) struct kmem_cache descriptor is always freed by cache_cache()'s >> error handling path, causing struct kmem_cache to be freed twice. >> >> This issue can be reproduced by creating new slab caches while applying >> failslab for kernfs_node_cache. This makes kobject_add_varg() succeed, >> but causes kobject_add_internal() to fail in kobject_init_and_add() >> during cache creation. >> >> Historically, this issue has attracted developers' attention several times. >> Each time a fix addressed either the leak or the double-free, >> it caused the other issue. Let's summarize a bit of history here: >> >> The leak has existed since the early days of SLUB. >> >> Commit 54b6a731025f ("slub: fix leak of 'name' in sysfs_slab_add") >> introduced a double-free bug while fixing the leak. >> >> Commit 80da026a8e5d ("mm/slub: fix slab double-free in case of duplicate >> sysfs filename") re-introduced the leak while fixing the double-free >> error. >> >> Commit dde3c6b72a16 ("mm/slub: fix a memory leak in sysfs_slab_add()") >> fixed the memory leak, but it was later reverted by commit 757fed1d0898 >> ("Revert "mm/slub: fix a memory leak in sysfs_slab_add()"") to avoid >> the double-free error. >> >> This is where we are now: we've chosen a memory leak over a double-free. >> >> To resolve this memory leak, skip creating sysfs files if it fails >> and continue with cache creation regardless (as suggested by Christoph). >> This resolves the memory leak because both the cache and the kobject >> remain alive on kobject_init_and_add() failure. >> >> If SLUB tries to create an alias for a cache without sysfs files, >> its symbolic link will not be generated. >> >> Since a slab cache might not have associated sysfs files, call kobject_del() >> only if such files exist. >> >> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks, added to slab/for-next > > [+Cc Jinjie, Liu] > >> --- >> >> RFC -> v1: Make sysfs optional instead of destroying the cache on sysfs >> errors. (Suggested by Christoph) > > RFC version for reference: > https://lore.kernel.org/linux-mm/20241021091413.154775-1-42.hyeyoo@gmail.com/ > >> mm/slub.c | 21 +++++++++++++++++---- >> 1 file changed, 17 insertions(+), 4 deletions(-) >> >> diff --git a/mm/slub.c b/mm/slub.c >> index 151a987dc3a0..b4b211468f77 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -6116,7 +6116,8 @@ __kmem_cache_alias(const char *name, unsigned int size, unsigned int align, >> s = find_mergeable(size, align, flags, name, ctor); >> if (s) { >> if (sysfs_slab_alias(s, name)) >> - return NULL; >> + pr_err("SLUB: Unable to add slab alias %s to sysfs\n", I've changed "slab" to "cache". >> + name); >> >> s->refcount++; >> >> @@ -6204,9 +6205,15 @@ int do_kmem_cache_create(struct kmem_cache *s, const char *name, >> goto out; >> } >> >> + /* >> + * Failing to create sysfs files is not critical to SLUB functionality. >> + * If it fails, proceed with cache creation without these files. >> + */ >> err = sysfs_slab_add(s); >> - if (err) >> - goto out; >> + if (err) { >> + err = 0; >> + pr_err("SLUB: Unable to add slab %s to sysfs\n", s->name); Also here, and simplified to "if (sysfs_slab_add(s)) ... " to avoid dealing with err. >> + } >> >> if (s->flags & SLAB_STORE_USER) >> debugfs_slab_add(s); >> @@ -7276,7 +7283,8 @@ static int sysfs_slab_add(struct kmem_cache *s) >> >> void sysfs_slab_unlink(struct kmem_cache *s) >> { >> - kobject_del(&s->kobj); >> + if (s->kobj.state_in_sysfs) >> + kobject_del(&s->kobj); >> } >> >> void sysfs_slab_release(struct kmem_cache *s) >> @@ -7305,6 +7313,11 @@ static int sysfs_slab_alias(struct kmem_cache *s, const char *name) >> * If we have a leftover link then remove it. >> */ >> sysfs_remove_link(&slab_kset->kobj, name); >> + /* >> + * The original cache may have failed to generate sysfs file. >> + * In that case, sysfs_create_link() returns -ENOENT and >> + * symbolic link creation is skipped. >> + */ >> return sysfs_create_link(&slab_kset->kobj, &s->kobj, name); >> } >> >> -- >> 2.45.0 >>