From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2027FEED629 for ; Thu, 12 Sep 2024 17:28:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F6F06B0088; Thu, 12 Sep 2024 13:28:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77DC56B008C; Thu, 12 Sep 2024 13:28:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61F5C6B0092; Thu, 12 Sep 2024 13:28:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3F2976B0088 for ; Thu, 12 Sep 2024 13:28:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BA5E812120D for ; Thu, 12 Sep 2024 17:28:34 +0000 (UTC) X-FDA: 82556770548.06.1DF9E74 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf14.hostedemail.com (Postfix) with ESMTP id C18E0100011 for ; Thu, 12 Sep 2024 17:28:32 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=OwAtgdc+; spf=pass (imf14.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.172 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726162084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ojQdylEuR/edm6P0t3l0EQbjxi/mFjIvSyby4tAxelQ=; b=rAo3eVSvzwa2BFJXJnBEsx6IhCJKTa/MyVK9ggd+CAth6KkYLgNPXNukHpd3vrzW22GJkq TsVHsnDe9RLN4dK7Q5iccKuo93KX2ChL6tWF9fE6XMu8Mfx1HncWsyfa53t2gZ6Vq76yFG yPbv5UoHzLfcMWrVHTCl/K4yFLk9wvw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=OwAtgdc+; spf=pass (imf14.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.172 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726162084; a=rsa-sha256; cv=none; b=e3jrZ0wQLsIjd1S21ppf57VVh8o322/bbh4SeMpFu71bpLfMmuGDaOCO2XOgBjfFYq+W9U /g6J+tt0TNSdX3C2J9c7ZFRQpVghrYeKJUaPOvr7Ro9dDe2IZzIJRDXUB6msmWU6d4HhDO yJSLyMQGOeLbMoJN6762f2eFDhuV39w= Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-39f4ff22a49so5880955ab.1 for ; Thu, 12 Sep 2024 10:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1726162112; x=1726766912; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ojQdylEuR/edm6P0t3l0EQbjxi/mFjIvSyby4tAxelQ=; b=OwAtgdc+bznNaRGRRwrZ8JJyMi5rNI7+flBjCM5Ruz+DafFwzv2EjiO8GWLLIB/O4m ktWP5/l/wyJgYul+945WuDncDOcNKbB5JP8NL6aDwEXtvfL35JahNq2dw5S9BCbgNAlI FYtHnnrDgiRJm9HWCcXn3aIahvx7tySWlvA1E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726162112; x=1726766912; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ojQdylEuR/edm6P0t3l0EQbjxi/mFjIvSyby4tAxelQ=; b=mEy+nsUmsaAw8VBs0jYAdv8Hxy8NUmKTpEbBTkRh/FajRnAQfGCmlv1RVVRNzYMF3e JdZeRybSaNtWwNHW4/8/k15WyjbFLovnl7/0dnS/txz6nGPn0zvXBYmjM+qCPiwQLDrw gxx+x5LWed09gg1q/GD5xTHWqmdY6x5wI783BDRYJxLPup6R6YEjBkt/neOhIq70VhnH CcmB+B0SqWQ/gAabp0+2H37gHKj+kNE2FhQm/5D54QiWYbky1TISNYqbWaankSmU5yW5 dPHfB88k4Y035hzeUEBbtQFnmWcUD0Ji09y37xop4yozpCvLo3DMOeJnO3iziMl5fyBh jTpw== X-Forwarded-Encrypted: i=1; AJvYcCXTO7kPr2mUYP4XuSAkThuZTmDGquhxl1pSWi8FJJUFN2J6oCtzgt6e/LOeyWYez8AQT+LANNqdyw==@kvack.org X-Gm-Message-State: AOJu0YwPKrST8b0+ZXpVbMQ4BVdC3s7JmM6mC96am/9shjw/f66Tpt6L 60rzVgJhQzQqb4SmlLYtAkJF1zuZMC2HfCm8wrtryL7E1i9++Dutk14QwADvOr4= X-Google-Smtp-Source: AGHT+IEyBc3XdFgDxw7hY6Gd9nsgNpNQtOKxJT4r9NCaxxvWyYvBogxI7FkBep7jhm5pjtRdduYOtg== X-Received: by 2002:a05:6e02:164f:b0:39b:330b:bb25 with SMTP id e9e14a558f8ab-3a0848f7e52mr36208285ab.12.1726162111590; Thu, 12 Sep 2024 10:28:31 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a065816d89sm22413055ab.79.2024.09.12.10.28.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 10:28:31 -0700 (PDT) Message-ID: <35f21581-71f3-4234-9b03-dd3e3bda664f@linuxfoundation.org> Date: Thu, 12 Sep 2024 11:28:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] kselftests: mm: Fail the test if userfaultfd syscall isn't found To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240912103151.1520254-1-usama.anjum@collabora.com> <20240912103151.1520254-2-usama.anjum@collabora.com> <3b700650-159d-45ad-91a3-59fca3019766@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <3b700650-159d-45ad-91a3-59fca3019766@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: acp6ff4sfmwye3exhui8muwmeo4ukyc5 X-Rspamd-Queue-Id: C18E0100011 X-Rspamd-Server: rspam11 X-HE-Tag: 1726162112-825157 X-HE-Meta: U2FsdGVkX197cTlH6zSH16qGwL7l3np+Vm4gdqXkKQvpMyphGvP290vNRzaT9S0/NjYUOKmzWdDz4t3o6Ysfn1uhKjtVajJdba+UQPxTxu5F5875kmKvMuumBDKqlopdbDiyDhO3dRJUeds40WwsuNBY3s8H3TUppGq0SbGz2/eXopCuamCDdQf/K0fsczrAImYbNN24URgOW8fpgcjJsd2yBR8HYutP3jHvBzfmS64f4mwmP806rizyqpWH/ZzPt4f/y8LueLnvSAKSf/tmgdm8FPGD20I+Be9YEWcwqjN3TheX7IEifyQWwLa4H5YsqeZANR1+Ul9X33zskCkPqhIGOdcA8m2439MVtUmmRWK4f6ASd7HooRHUg53LbApn8MwXDIEQjFtIl4hQCiULwfpD7IrYv8AuxILAHZXFEkRRVOSfr0bQ0b9jW3CzYD69L9oZaRqEZ4HE2vnGi+KLXewnmBXMoYWAfabH+iB0vCRzQiXccJGdNcaf7lh8YIoKEEhOGE+66qS5mbviu1inM7geMmVD8/EiU6+WAkLwC2qP4NhXE0+1ks58JjNSDhB+EtusfUu5YbSTx8Bj/F11qF0GC/Z37SJxymaUu+VGJYId4pgTBnMwEz12GdclnbQSk363zuKLlUgJWgBwJosFMtr8E/t/650vYFkOfRYHIL0/yNDaKBkjMlOfDb2SqjDnBt7l9HklJEnoafcwQlK1RPn/LeJdPCzL43zkaIrKzzQXqze+NGubdLn5KE1LE+p4RKdbL19LigmldV2xRFD4nMvwle7gwEpGI3v1OlJKmnDkxnzIFpnEsSwp8XMJ/GftlHWbekHeH/2zNPn3spaBw0ZqKHls6cjpPjJE01EInIq9IcuWG1v9v6eyuxtURVJYepa7N97Ph2mmY3iDannm6Fgc/FldZCgbr3unfTlE0dqNh2SOyRBjakDqiTsEySUdqyNZnvCR99UnUFTLyyW TPjaryaL 2w1vs+Q9DXPDDWIgA+l++910nbukJj5RkHovK31fuWrZkts7qQdxS88kg2OwHTNa5Lrnk7MzQL+VJcjIS63vyEU4cwkDxOARFVwj+J2GdsN3oyNal+AleA/vRnmvMPoAQKTNhFBf8/0DedNLzTJoolEPg+XHh7tqo4a/o7T8LIYjaJcELLYEHCqAcPeQ2DGeKAQPrb7gVsMM7+dRHV0mcRhu37Nm0BXf8qHjwYU96xQelR9wyKy9aI78HdLR/cT5dBWPnYCqyd0YBSjU4ylO17VusueN5WW6fLXSeVEryCPExM3V0V5pNTCOanMQymxk0SJIGzF1N2DdS6W/cUAPsa4ZWOjkWGti3U27xa9JoZDCJsqsrRGhJOkuduEBj7tbZ24XVQ0a5bZdGinf1JCX1uMjRvToxuucbVJXz X-Bogosity: Ham, tests=bogofilter, spamicity=0.101308, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 10:10, Shuah Khan wrote: > On 9/12/24 04:31, Muhammad Usama Anjum wrote: >> The userfaultfd is enabled in the config fragment of mm selftest suite. >> It must always be present. If it isn't present, we should throw error >> and not just skip. This would have helped us catch the test breakage. > > Please elaborate on this to help understand the what breakage was > missed. > > Also this commit log doesn't look right to me. syscall() could > fail for any reason. Do you mean to see skip is incorrect in this > error leg? Please see comments below. > >> Adding this now to catch the future breakages. >> >> Signed-off-by: Muhammad Usama Anjum >> --- >>   tools/testing/selftests/mm/pagemap_ioctl.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c >> index bcc73b4e805c6..d83dda8edf62c 100644 >> --- a/tools/testing/selftests/mm/pagemap_ioctl.c >> +++ b/tools/testing/selftests/mm/pagemap_ioctl.c >> @@ -95,7 +95,7 @@ int init_uffd(void) >>       uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY); >>       if (uffd == -1) >> -        return uffd; >> +        ksft_exit_fail_perror("Userfaultfd syscall failed"); > > This looks wrong to me - Is missing config the only reason this syscall > would fail? It should still skip if __NR_userfaultfd isn't supported on a release or an architecture. The real problem seems to be in main(): if (init_uffd()) ksft_exit_pass(); Why is this ksft_exit_pass()? Looks like further investigation is necessary to understand the problem and fix. thanks, -- Shuah