From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E888EC5478C for ; Mon, 26 Feb 2024 04:23:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B7B0940010; Sun, 25 Feb 2024 23:23:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 667AB940008; Sun, 25 Feb 2024 23:23:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5304D940010; Sun, 25 Feb 2024 23:23:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 43EAF940008 for ; Sun, 25 Feb 2024 23:23:47 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 152191C073B for ; Mon, 26 Feb 2024 04:23:47 +0000 (UTC) X-FDA: 81832661694.21.C6F98E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 0411EC000E for ; Mon, 26 Feb 2024 04:23:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z3pBoBAb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of xiubli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708921425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vZ8LkK657qDlNnzdVPB+undXtR8IvGKGbjYwCsGXQrg=; b=8hZnlgtonfK6jOmtJOkDfNaG/T151MSyQeD3LLXkizqaUTHx11QOIu224msdlMnK9rOTWN KZ5AtgGBL6hefUpcro50tfuU1wayhxJisgx4AwtN3W7NSx8AsWpTHYTxn5Pf3RsmmJ/jXp 2X+sWRl7wN/ICHlvWFQUUPB2ScBpWqI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z3pBoBAb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of xiubli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708921425; a=rsa-sha256; cv=none; b=OXx4KLWrZzQYwocdkL2f52UqLaXNCG7xGouecJjN4aHYgXKyj+cANZJ+BodN8ZfrHOCHDS 1pJQwGFdQDC8A4WmbfaDbqefBOEpB6xHbIna+t2HfdzjIUcx3F6TtxU3j2z9nz/jgnUzoJ O6GfoKBemuexGYO0B79jDGKhGytIBF0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708921424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vZ8LkK657qDlNnzdVPB+undXtR8IvGKGbjYwCsGXQrg=; b=Z3pBoBAbIXd7Us5uJFvR9A11/h9aXuIJYKL7hoGPBAJsIhESzmz8WlVvSc/3oKKcfvbDn3 Jn3zIzQAQ2ZiJPWtboxiMJ3+D2eywkgcJg73BOPD9OJ1KCFArXHbCq/ns+H4vOJQcqqoUM te38thJDTLwvTNRZje0NOAR2SO75wy4= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-h5jmFYFON9memobBPm8LMQ-1; Sun, 25 Feb 2024 23:23:42 -0500 X-MC-Unique: h5jmFYFON9memobBPm8LMQ-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-6da57e2d2b9so2583506b3a.2 for ; Sun, 25 Feb 2024 20:23:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708921421; x=1709526221; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vZ8LkK657qDlNnzdVPB+undXtR8IvGKGbjYwCsGXQrg=; b=sSBlXmV9/t5wHZcSjAV8KNSsJCphpmWgTnFTAnn2slnoxPTUs6sW0fSzBglcII8jVz TAsnFjqnmXg//0+AEjT+cAZuOpIERpvmfhwuccozPKMQdYZ0pPyejmfszdFeXxpjYYpi FCaxkwVRSA0032FHL398GNpkZQd0DD9w5IL3i8tpksfkesWHNeJPWb7RYnqF5IgDZ5Xc OHTshJcHaFjCbbfXg1pzuhPoQW7VaUsRUT/dbYHO6oIDE6Zm6Hr05tH0XBd3UQEfHIE7 m6Ul5x0+A6Spf5iewLd9Bj3jJGtdWReGFKoFwC8ymbVWTFzUt4KyYIA1tQGZMZvZiGuT OUHg== X-Forwarded-Encrypted: i=1; AJvYcCUBchRPhZ6luDTeh7wYG6xnlfZ4VKWx8+58FlPXSbd79A4E0EvxAE/38N9ZtZdRotN81T+GZ2AWweRoI/X2SSuan0A= X-Gm-Message-State: AOJu0YxQ8mj8B060Ys187Z74h7AFdOQPtXS6QflfFBQ70y3gSew+3Vct WJdxEPZtDbV6KCCK4EcL8RVU7hss1OMD1LussdeQI8sqEU0EJmwGD7NqUAT+7bCzukX9wZM47R3 rTU973D1u1gA6Jnjfdp6kzaq43DVEksMype4YfUV+pdTHnK3t X-Received: by 2002:a62:cd4c:0:b0:6e5:32ee:216b with SMTP id o73-20020a62cd4c000000b006e532ee216bmr686948pfg.27.1708921421661; Sun, 25 Feb 2024 20:23:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUgQ4pUFoJVW/Zojwd70Fsl2xZVEuB2n+UyD866yIWg58GZastMHqqDfVMBV4VGopFxyzW+g== X-Received: by 2002:a62:cd4c:0:b0:6e5:32ee:216b with SMTP id o73-20020a62cd4c000000b006e532ee216bmr686936pfg.27.1708921421340; Sun, 25 Feb 2024 20:23:41 -0800 (PST) Received: from [10.72.112.214] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id c4-20020aa78804000000b006e2f9f007b0sm3091995pfo.92.2024.02.25.20.23.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Feb 2024 20:23:41 -0800 (PST) Message-ID: <35df81f5-feac-4373-87a3-d3a27ba9c9d4@redhat.com> Date: Mon, 26 Feb 2024 12:23:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ceph: remove SLAB_MEM_SPREAD flag usage To: Chengming Zhou , idryomov@gmail.com, jlayton@kernel.org Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou References: <20240224134715.829225-1-chengming.zhou@linux.dev> From: Xiubo Li In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: r3qyz9z5oh5p5p9f6xbp144sqfmc13s5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0411EC000E X-HE-Tag: 1708921424-929575 X-HE-Meta: U2FsdGVkX18UhuaduQM3wLej8wh7VoN3AKNs/dk4Vsc07oo1Y9myLASJRj5ggqjPm+P2KG95vAfiBapTt52/tmQzb1vfuRzp7T1AUXFy3A2wKvJGPujXVxddUVS6Tx2y6VxzwAZrmOxsUKRzAGcB+r2tZvgbGCEnKcgFi48xpWtmvaCUBQz5eQsbY22U2D5yZxDrBFKsyORz5pBD4+0N2/bd31oIR2QJ2FogXbnw+beawWmIP5lHie6j3nLUtmdtb4qvfnsCE4OCWK6g/FYGg57m9aC22VvUnLLjgBCKKQVp7R20ZGw4aEeIuD5zMtY9Es8J6+WpKifArsrzF2WX+0VP2sYR8V0kVNAhq3pfMjERaO4UY8pDGquTldtjYFdrB6Usrfn1EcgTF2Dnf4JyqhrxxEZf570fJe0pc7w3q22yv5py/iqjfAYfsFqLkMa7utapAVbdKnVNXSD+DhdHUqk5gNq2CSYUBb8FBgxWj3bpEW1y8sA9CKD94RuICNKpzKzNkBfWuOcEa4959myJBySebBJ1CoVSn87mhQuCeUX/H4vZhLHYKYiT8FFvDnZWCFnw77xh656q2oAa9qsZXKfNJ7ktvBLfsTWqpDgPsKpd6BKNOWzd2APRcKJRCjdYJjxwOxshuTPmzqgvtW2qnQTHKtzF5Jg+RJwzi8QT/4/F5kYVSRyfmtDlWilOuTyRhlWY6uIszyQStolrq67vQevBVn75NX2L2C2clyTQ61QpZYEKy469VGYv1o0IsRuROwVD7mbhWWhfgxR+kFO8FyBe1jODOS0syllBJgtGqmCGbFMfhHS2U7/MdHd5fuRhUFrz13L/Z+n60ykmND5XgHvl0qxMtoN3SdDnUCDruDyKEbwAD0l+Fh6AxJbrrQb78DrqfrzJj8ZvlrXnX8wUmFShuLcFhvoqLNTsJkIRpbo02xs8ZTzJmAQo+FlHzcd/2WfYtyGS7ssmTwxqL86 jLZX3Vnr iYZxQimGtj2yq31DC05N3y+6/cI6l2zUORqPr1yY3U/WZOE/t6Awk9NURtQotva1plhy3BCU4VRYBrVu5brH/spDNPULoUL8BDj85j6S5IK7B3UmMVgLJEO+uzhJQxpjtSHAw1zstc3hOW/4OyjfYgQXmiWYvi1hA4yEwr88JIqbbemyI6rypjAcZ3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/26/24 10:42, Chengming Zhou wrote: > On 2024/2/26 09:43, Xiubo Li wrote: >> Hi Chengming, >> >> Thanks for your patch. >> >> BTW, could you share the link of the relevant patches to mark this a no-op ? > Update changelog to make it clearer: > > The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was > removed as of v6.8-rc1, so it became a dead flag. And the series[1] > went on to mark it obsolete to avoid confusion for users. Here we > can just remove all its users, which has no functional change. > > [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Thanks for your quick feedback. BTW, I couldn't find this change in Linus' tree in the master and even the v6.8-rc1 tag, please see https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/slab.h?h=master. Did I miss something ? Or has this patch been merged ? - Xiubo > Thanks! > >> Thanks >> >> - Xiubo >> >> On 2/24/24 21:47, chengming.zhou@linux.dev wrote: >>> From: Chengming Zhou >>> >>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove >>> its usage so we can delete it from slab. No functional change. >>> >>> Signed-off-by: Chengming Zhou >>> --- >>>   fs/ceph/super.c | 18 +++++++++--------- >>>   1 file changed, 9 insertions(+), 9 deletions(-) >>> >>> diff --git a/fs/ceph/super.c b/fs/ceph/super.c >>> index 5ec102f6b1ac..4dcbbaa297f6 100644 >>> --- a/fs/ceph/super.c >>> +++ b/fs/ceph/super.c >>> @@ -928,36 +928,36 @@ static int __init init_caches(void) >>>       ceph_inode_cachep = kmem_cache_create("ceph_inode_info", >>>                         sizeof(struct ceph_inode_info), >>>                         __alignof__(struct ceph_inode_info), >>> -                      SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| >>> -                      SLAB_ACCOUNT, ceph_inode_init_once); >>> +                      SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, >>> +                      ceph_inode_init_once); >>>       if (!ceph_inode_cachep) >>>           return -ENOMEM; >>>   -    ceph_cap_cachep = KMEM_CACHE(ceph_cap, SLAB_MEM_SPREAD); >>> +    ceph_cap_cachep = KMEM_CACHE(ceph_cap, 0); >>>       if (!ceph_cap_cachep) >>>           goto bad_cap; >>> -    ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, SLAB_MEM_SPREAD); >>> +    ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, 0); >>>       if (!ceph_cap_snap_cachep) >>>           goto bad_cap_snap; >>>       ceph_cap_flush_cachep = KMEM_CACHE(ceph_cap_flush, >>> -                       SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); >>> +                       SLAB_RECLAIM_ACCOUNT); >>>       if (!ceph_cap_flush_cachep) >>>           goto bad_cap_flush; >>>         ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info, >>> -                    SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); >>> +                    SLAB_RECLAIM_ACCOUNT); >>>       if (!ceph_dentry_cachep) >>>           goto bad_dentry; >>>   -    ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD); >>> +    ceph_file_cachep = KMEM_CACHE(ceph_file_info, 0); >>>       if (!ceph_file_cachep) >>>           goto bad_file; >>>   -    ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, SLAB_MEM_SPREAD); >>> +    ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, 0); >>>       if (!ceph_dir_file_cachep) >>>           goto bad_dir_file; >>>   -    ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, SLAB_MEM_SPREAD); >>> +    ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, 0); >>>       if (!ceph_mds_request_cachep) >>>           goto bad_mds_req; >>>