From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EAFBC433E0 for ; Fri, 12 Feb 2021 10:14:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1674A64E57 for ; Fri, 12 Feb 2021 10:14:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1674A64E57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8AD748D0037; Fri, 12 Feb 2021 05:14:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 837E38D0015; Fri, 12 Feb 2021 05:14:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B1F18D0037; Fri, 12 Feb 2021 05:14:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 505168D0015 for ; Fri, 12 Feb 2021 05:14:29 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 19D405DED for ; Fri, 12 Feb 2021 10:14:29 +0000 (UTC) X-FDA: 77809206258.16.self67_59185d927620 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id EBD9D100E690C for ; Fri, 12 Feb 2021 10:14:28 +0000 (UTC) X-HE-Tag: self67_59185d927620 X-Filterd-Recvd-Size: 4284 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 12 Feb 2021 10:14:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613124867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J2fAtOqtlFprVzhOykuVJGPyK43JZHoiCBMHURJCN5g=; b=NU9+o943uQ2mZeCOPflM0Mbn+w0CgvMA9VInphf5bQ54/5JqLXN/NXYNVCdMh0j1ESlEFT UVsvCsdFq72H5ATNnH//H7fVgjVNBud6RzqnCz2P4mRS1m1xHSLdEjeZI1zzAyBZtWlw0s l63MWxTBbf3ImCL+1sORakx09n3bb7Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-UgtpkCbdO5-rEgbxQBzfTA-1; Fri, 12 Feb 2021 05:14:23 -0500 X-MC-Unique: UgtpkCbdO5-rEgbxQBzfTA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E6141005501; Fri, 12 Feb 2021 10:14:22 +0000 (UTC) Received: from [10.36.114.178] (ovpn-114-178.ams2.redhat.com [10.36.114.178]) by smtp.corp.redhat.com (Postfix) with ESMTP id A633A100239F; Fri, 12 Feb 2021 10:14:20 +0000 (UTC) To: Adithya Chandrakasan , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org References: <20210211072918.376837-1-adithya.chandrakasan@gmail.com> <3512c272-dbec-2c0a-4476-203315341fe2@gmail.com> From: David Hildenbrand Organization: Red Hat GmbH Subject: Re: This reply comments on the patch to fixes the missing a blank line warning Message-ID: <35cbe08d-6c29-c904-1402-de18b787c5b0@redhat.com> Date: Fri, 12 Feb 2021 11:14:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <3512c272-dbec-2c0a-4476-203315341fe2@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.02.21 19:20, Adithya Chandrakasan wrote: > On 2/11/21 2:36 AM, David Hildenbrand wrote: >> ^ >> >> Please create proper patch subjects. Nobody has a glue what you are do= ing when looking at the subject. >> >> "mm/util: fix ??? warning" >> >> Which raises the question, what is ??? >> >> Compiler? static code checker? ... ? >> >> >> Thanks >> >> On 11.02.21 08:29, Adithya Chandrakasan wrote: >>> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations >>> >>> Signed-off-by: Adithya Chandrakasan >>> --- >>> =A0=A0 mm/util.c | 1 + >>> =A0=A0 1 file changed, 1 insertion(+) >>> >>> diff --git a/mm/util.c b/mm/util.c >>> index 8c9b7d1e7c49..60286876636d 100644 >>> --- a/mm/util.c >>> +++ b/mm/util.c >>> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *b= uffer, int buflen) >>> =A0=A0=A0=A0=A0=A0 unsigned int len; >>> =A0=A0=A0=A0=A0=A0 struct mm_struct *mm =3D get_task_mm(task); >>> =A0=A0=A0=A0=A0=A0 unsigned long arg_start, arg_end, env_start, env_= end; >>> + >>> =A0=A0=A0=A0=A0=A0 if (!mm) >>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 goto out; >>> =A0=A0=A0=A0=A0=A0 if (!mm->arg_end) >>> >> >> > Hi David, >=20 > Thanks for feedback. I have fixed the issues in the patch thread with > change in subject and also log message. Hi, Please always send patches via proper mails and versioned. E.g., rm *.patch git format-patch -1 -v2 git send-email --to ... *.patch The introducing patch is from 2014. So I wonder how you even get a=20 checkpatch warning? a90902531a06a ("proc read mm's {arg,env}_{start,end} with mmap semaphore=20 taken.") Anyhow, maybe just call this patch "mm: util.c: minor coding style fix",=20 that makes it clearer that this is really minor and has been in the code=20 for a while. Thanks! --=20 Thanks, David / dhildenb