From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FC22C433F5 for ; Mon, 8 Nov 2021 19:33:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0BA0B617E4 for ; Mon, 8 Nov 2021 19:33:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0BA0B617E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 164156B006C; Mon, 8 Nov 2021 14:33:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 113766B0072; Mon, 8 Nov 2021 14:33:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E81966B0073; Mon, 8 Nov 2021 14:33:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id DBBB96B006C for ; Mon, 8 Nov 2021 14:33:57 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 988A37C5C7 for ; Mon, 8 Nov 2021 19:33:57 +0000 (UTC) X-FDA: 78786763314.30.19286D2 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf14.hostedemail.com (Postfix) with ESMTP id 88DB660022CB for ; Mon, 8 Nov 2021 19:33:57 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1A8JCxiZ003356; Mon, 8 Nov 2021 19:33:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=ftthP2uYO3WeC9jVfSO5GkVVQ/IQVhcbuIbPy0jPwCk=; b=S/ekqFWgJP3NYre+izuHFZjwpYRrwanuNjCRStCFyIoQ7OQjzP+7QJAfL7rZUmbmKjrp Ui8krz5eTKo9+GnUXWmmOqRoPbdShwFhEVxBzQ2jYGaQJOHH0YMo0fPOzBQKyEuUJr8X zqipjDP1e8vwSS2ZaBomn4tnXJuDSmfdzSNDjy11kYZvX5ow3+YZ+IFyFs5y1Axez9DQ y5iGkz7Ext4qRWy1Z9tXuj1EumbYYV0Wkl5n9tFGlZ3QLZ5kAs0wqywU3W1BMmK+bKYU gM3TsUQFpVoCbZq+rAo2ihsFHZMlJ6jo6ITDtSOykphsho3KER6UXuKnLC/6FNx2D5yu wg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3c6uh4djue-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Nov 2021 19:33:30 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1A8JFLnS076512; Mon, 8 Nov 2021 19:33:17 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2043.outbound.protection.outlook.com [104.47.66.43]) by userp3030.oracle.com with ESMTP id 3c5etug41j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Nov 2021 19:33:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ytvc5McKWORBLuDNu0agfoZzm70/C+HhOdY23yGct+LixV69sMvZ5eGXxB3+XiK53UFQ1hA2WJeIbpt16dv9YysGtIYeZP6ksiqfgpflFunG8NpwQkUSvhmhBZnfaWVOS2ZMbY4Kflzi31uVBAHE8QE5oaM+w1HJcBrgoNWXZQ6pJWiqrLCZ4nlYJ3/rB3DKIvUZhanhGvFZ8xNJ60SANcQQUXjCUKciwxUAKl9VpBPw5x4qAnNvn0yFoOYUpGM/mIFRJYloPA4h9phT4iDEer/8n2VN2uo1QUw2O77XrcrF5lUDIisC1ZVEKEBQs0J3IltdA78hvdTEiQ9AFLdKlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ftthP2uYO3WeC9jVfSO5GkVVQ/IQVhcbuIbPy0jPwCk=; b=TKIthtUT3tciZyYzagpAPJKXMDEWkLGJwcluy1zmUq6EHUogBx4riWothlHzTFsjKCpiCfgI+xfwv2L6u1Bpsjc5MGqz7oKYcx8m/mdhOQK8Ky8uieOaMKvrhzIyMpaRVVZ50g6ND7yHr0gL4S/2y0uBDmB5QraZ1hbfJdRrpgnKelUPttLfKzzSCsx2WMATnZIQiZAHLzkk/9Up0/pw3opps1oncD/CFKB9xyIeP/Cb73FfhjPC5g7vMLGDTq8x7b4t7+hCZR9gAmCsCFeUoyp0YZAHaVTiGH0cMNtIke/86X0uKH8ldQv7aLIEHtyiLYftzDB//kvYTrdUGE/Uxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ftthP2uYO3WeC9jVfSO5GkVVQ/IQVhcbuIbPy0jPwCk=; b=s1AI+FMRzX+Kt24aZz5TXLzoHpu4cDh6o9O/RMwrfJmllWP7DnZE1hDN2synmlzkFCzs4pbywgVjeVx8myKYJ0RCQJPKW9EnW1/x+DA9Ryw+kuXP+kuM4iyyn5OfeSMFApgb67Ik1AGnZQ0mbxe1BS6ruVTzYDzVzE+PUXlSCzU= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by BYAPR10MB2950.namprd10.prod.outlook.com (2603:10b6:a03:8b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Mon, 8 Nov 2021 19:33:14 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::b5bc:c29f:1c2d:afd7]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::b5bc:c29f:1c2d:afd7%7]) with mapi id 15.20.4669.016; Mon, 8 Nov 2021 19:33:14 +0000 Subject: Re: [PATCH v7 0/5] Free the 2nd vmemmap page associated with each HugeTLB page To: Muchun Song , Andrew Morton , Oscar Salvador , Michal Hocko , David Hildenbrand , Jonathan Corbet , Matthew Wilcox Cc: Xiongchun duan , fam.zheng@bytedance.com, Muchun Song , Qi Zheng , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , "Song Bao Hua (Barry Song)" , Barry Song <21cnbao@gmail.com>, Chen Huang , "Bodeddula, Balasubramaniam" References: <20211101031651.75851-1-songmuchun@bytedance.com> From: Mike Kravetz Message-ID: <35c5217d-eb8f-6f70-544a-a3e8bd009a46@oracle.com> Date: Mon, 8 Nov 2021 11:33:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR14CA0054.namprd14.prod.outlook.com (2603:10b6:300:81::16) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 Received: from [192.168.168.181] (50.38.35.18) by MWHPR14CA0054.namprd14.prod.outlook.com (2603:10b6:300:81::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Mon, 8 Nov 2021 19:33:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d135204f-df65-4bae-9a55-08d9a2ee9b62 X-MS-TrafficTypeDiagnostic: BYAPR10MB2950: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jb+R/RFo3vgFC/NySveW0uutnc8Jjk3BwZtjmx007IO/syBM9CoAgzclCSfzKeSpjZCU9itLxVZ8DTvvJ1uUy5MR67jCMdUYu0d5S1D2XWN9XUGaoDyAg22oj61DsLeLagwt3x1m55vbcUlvm2f7ckY6Db9+hte6AsbOW2Ttytg6ev4OGHzBMDg3o1OtDno4qRFlDCK1ekyE9XjWd0HVWz/BuKFOgRxHzbjZXeBZ+gFXP5xojy+nwS1YOLwJbjpM2OzJFM0czhOu5I66PYQousI35td1gpTQC9JP07za0oe44XAZsgrEA6GfiJXRhU0m6osQQR3UrFLVpeo1tn2LGQr+bWRuPEo9+e0Ce10EubcciykDfvVFBNqWOtZxFkbTO03T24q3TnySyam9CwXz7pv4W2h0HgYnBbXR2AGP5uu2uA8K63CVSiGYBeXZCITh5leyHSEsRBvNjBcN/geS0quuylL1l5nHcn/q5CwYaGebdaxxorkxlbNC2iNP9w8WXFPzOk8ZHCO6D4f3lTrIPcVyetXdz4NwsalgbtTeTuQkDb1/CVJAB/w3hvsFN7ZvWoxdeTzDzBbw1z2qdwkvia0D7nioyyu9lJtWn/iwHdxTt5289G9zNrQfTBESi1j9qUUaLnVUtI0eSbAVWAqrdVpIMq38qiIe/HaebP2r4DY0dfSMPGBILwmBghkeUjxOGnxbGtrVF3QGcmLHgrFiDeuV+lVb39etkBRpjHHbqMml+2nVGCtu0rS55wZV/CHuaYPOUOR6hbYVv4dg+ZXjeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(86362001)(54906003)(4744005)(52116002)(110136005)(53546011)(8936002)(186003)(31696002)(83380400001)(508600001)(66476007)(8676002)(66556008)(6486002)(31686004)(7416002)(956004)(36756003)(2616005)(44832011)(5660300002)(316002)(38350700002)(4326008)(6666004)(16576012)(2906002)(38100700002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REpxKzNialBkb1pqMWNVb2c2OFNzQTJYOWsvUTROQ2h0T2laTkp6U0dYdUlT?= =?utf-8?B?VTdnOS9saUFwak53ZWZiQVBOckQyYmpua0VjMDJvT1liWFNxRHNPUFc1V1hp?= =?utf-8?B?OWw2Sm54UlUxMFBoVEZXRlpNaVR4NlhEVWRoQmZWc3RjWDBub2toN25rb0tR?= =?utf-8?B?T0hIbGdndm4rZUNNaUk1eWpaNDJjR0FISVdZRlJjKzBQamlnSFlITEg4dHlJ?= =?utf-8?B?YkU5b09zTnhrL2R0dUhjd0pDRW1xRmRrVS9UT0N6OUsvcENzN09ja0xmT3ls?= =?utf-8?B?aFpaZEY2dmZ3VGZpTUpqOFhNSUtIaWxpV1A2UElOMXNnRzlSYkpJVlk2bkYr?= =?utf-8?B?dmttQWowR2J4bklLQUxIYXVJZE9NWWowRWVjcDBVZmVXcjAzdEZuZjZrQ1hk?= =?utf-8?B?Wkc1Z3JXUmZ2N2l5QUk4MGpKbXV6TlBod0F2TG1wdkVrOVRCcVhUcFEzSFFD?= =?utf-8?B?L0NiUmNwL0JLTUR6REtOYjhsM3F3S0tIcWNYMHNXaFlZUk9HYks1TjBES2RG?= =?utf-8?B?OHYwMW9XcGRaQ1BJRSt4UTVKYTl2Z1BxQ1VqbUJZNmtaVXRXSjh1ZzdUY0ZT?= =?utf-8?B?cXh4Q1Q0SE5WUnNnVUxPUXdKcSs3WDdZcktaUWNGbWZQUVR1RWY5b01WVXBG?= =?utf-8?B?bHZsb1lYMlNxZGFhWm1zWW5aa3MvdC94RjZZVmJlcjlpY0dqbUR6MmcwQks1?= =?utf-8?B?cnRYVm1wTXR5Qmo4ejVwV0ExbWYwa3k4WjVxaFBQYXpwU1poWGxDT3RXQ3hE?= =?utf-8?B?QW9EbWFVVXZ3R3JZMktoSE1SU1ROTHh3blEwSkRLd2RkYTJQMGhQUlArdmk4?= =?utf-8?B?b1pqMEpPbXNSNEFWWDJXMFB5YUtRbWJPa0dxSEpTVlBnRVIvUnFZckNvZytm?= =?utf-8?B?WjhlSFdtUXhOS0E1MjN3OVNhdzdQVzBKWmVEdTVhM1p4RGVOV1o1SzQzZkgy?= =?utf-8?B?T1Vkc0NrbEQ3R3lEOXZUTElndTFQM0xNZU95bjN6Syt2QlZDS3h3WnRGM1ZU?= =?utf-8?B?SGJRZ1BmOEdxS2VvcW5zVGlCU0tFcXRCQnliQVF4ZGhXL1ZMRWovL2xuZFVa?= =?utf-8?B?b3h1U2s3dU0vMmh6QmFIT0hqSS9KQWpYSis0a0cvaUdST3hFVlozcUJxWjNh?= =?utf-8?B?QjV2cDQzRVJmSEFmdFBvc3RCb3pnOXJOZFJ5UXpVQU1CM3J5WkhuNkNxbjVY?= =?utf-8?B?OVorNnIraDJOb21xVFFkQk51SGN4RGVRcEV5VjdBd25iK1U4SXI1UzFYQlVH?= =?utf-8?B?NmJCQnNoY05COFgxcWV1Tmk1cHZpZmlpZVJpRTlnanRVcmo2STdaSTA2YkFr?= =?utf-8?B?LzI2UGN6WDBMM05rZWlUbkJzMzl1THYrUHllblJNNi9FbjZ2U3JRWVFhMmJv?= =?utf-8?B?b3l0S29FQnR1TytSeDg4eC93UWIxK1pYT2RML29scnpaeDdBR1JBcE5TbEdE?= =?utf-8?B?bytwaU5ROUk0clk3NUw0b3JTQVo0eFd5ZWI3Y0hUSjF5UDlXOXNFVWFxQ2JM?= =?utf-8?B?QlNadTZhaTFCYVhwSTdROFdRb2xOV3U3NFhKaVFUNzJXWnJ0TWx1MUZzRmZs?= =?utf-8?B?UHBoQ0pZeHYvRmdERUhRanRlc21xQ0NSUk83TnNRSUVwOGtuYkFpYXErSjVr?= =?utf-8?B?L2RBczhoUGF0bzJGR3kvTHNxc3ZUUENwK0xLZjUvaGJ6V0M0b1ZmcFp3QzRk?= =?utf-8?B?UjZLRHBiTGRFVEtFQXZidUJDYi9wNWp6b3ZPNmJVMFVwUTVyMHQyMUo2MHNO?= =?utf-8?B?eEw2ZzJOa0Z0bS91Q3BNdUNYMXFGUWhFcTc3Smk3NFdVWkljSkFFSHZSR1E4?= =?utf-8?B?eWpSQURRb08xSWVuMWN2K0YyN3RwKzgvYTg1cUNBY2ZBMC9iOVRHajBpMklS?= =?utf-8?B?L3gzUDVPRlBTTzh3czczNzBFbGlFeVBuZXRONVh2ZFdQcXcvZ0thNzBiOVRS?= =?utf-8?B?aFdWN3U5cENnbjV1bE5DcUgxRkdjdDFzREVSSGt0cGdWK3E5VW15U1c3UVJt?= =?utf-8?B?dVJhbEJEb3MvemlXdHF0Wk1hdkZzTXRWWHF1Q09oYWFMdmJjZzRhRmRiT2xu?= =?utf-8?B?MEx6UHhjVmZINGJBT3pHeUhWRlIrRVE0bHo5YXFCSndRTndiYnQ4RWpXQWho?= =?utf-8?B?V0RFRHVKcXlwQzlhNzlPQU4xTDJTL0N1Y0lUa3hsK01PQ1NITVJXekduZ0FI?= =?utf-8?Q?+RK+EzqHCDeXR0SLcmSkQ7w=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d135204f-df65-4bae-9a55-08d9a2ee9b62 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2021 19:33:14.4284 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BCzEnOQHucmN4ORTqJdr1p7nw3eFAuJM8FVocjlT8yGLnjlIV3S5BQ8xwust9wylmvl0YcxwXPQpLMwNhl36Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2950 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10162 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 mlxscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111080114 X-Proofpoint-ORIG-GUID: fK0MeXbHlpBLTMURaFgwTgJCDx3x0Qi3 X-Proofpoint-GUID: fK0MeXbHlpBLTMURaFgwTgJCDx3x0Qi3 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b="S/ekqFWg"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=s1AI+FMR; spf=none (imf14.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 88DB660022CB X-Stat-Signature: irt8jzmb1juj8udxz6jjw51qw6q1ed49 X-HE-Tag: 1636400037-227211 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/8/21 12:16 AM, Muchun Song wrote: > On Mon, Nov 1, 2021 at 11:22 AM Muchun Song wrote: >> >> This series can minimize the overhead of struct page for 2MB HugeTLB pages >> significantly. It further reduces the overhead of struct page by 12.5% for >> a 2MB HugeTLB compared to the previous approach, which means 2GB per 1TB >> HugeTLB. It is a nice gain. Comments and reviews are welcome. Thanks. >> > > Hi, > > Ping guys. Does anyone have any comments or suggestions > on this series? > > Thanks. > I did look over the series earlier. I have no issue with the hugetlb and vmemmap modifications as they are enhancements to the existing optimizations. My primary concern is the (small) increased overhead for the helpers as outlined in your cover letter. Since these helpers are not limited to hugetlb and used throughout the kernel, I would really like to get comments from others with a better understanding of the potential impact. -- Mike Kravetz