From: Mike Kravetz <mike.kravetz@oracle.com>
To: Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
David Hildenbrand <david@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Matthew Wilcox <willy@infradead.org>
Cc: Xiongchun duan <duanxiongchun@bytedance.com>,
fam.zheng@bytedance.com, Muchun Song <smuchun@gmail.com>,
Qi Zheng <zhengqi.arch@bytedance.com>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
"Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
Barry Song <21cnbao@gmail.com>,
Chen Huang <chenhuang5@huawei.com>,
"Bodeddula, Balasubramaniam" <bodeddub@amazon.com>
Subject: Re: [PATCH v7 0/5] Free the 2nd vmemmap page associated with each HugeTLB page
Date: Mon, 8 Nov 2021 11:33:08 -0800 [thread overview]
Message-ID: <35c5217d-eb8f-6f70-544a-a3e8bd009a46@oracle.com> (raw)
In-Reply-To: <CAMZfGtUeL45=WG3ceaZ_tALMGZTLtuD9jbfKEzeQv270OnaLYQ@mail.gmail.com>
On 11/8/21 12:16 AM, Muchun Song wrote:
> On Mon, Nov 1, 2021 at 11:22 AM Muchun Song <songmuchun@bytedance.com> wrote:
>>
>> This series can minimize the overhead of struct page for 2MB HugeTLB pages
>> significantly. It further reduces the overhead of struct page by 12.5% for
>> a 2MB HugeTLB compared to the previous approach, which means 2GB per 1TB
>> HugeTLB. It is a nice gain. Comments and reviews are welcome. Thanks.
>>
>
> Hi,
>
> Ping guys. Does anyone have any comments or suggestions
> on this series?
>
> Thanks.
>
I did look over the series earlier. I have no issue with the hugetlb and
vmemmap modifications as they are enhancements to the existing
optimizations. My primary concern is the (small) increased overhead
for the helpers as outlined in your cover letter. Since these helpers
are not limited to hugetlb and used throughout the kernel, I would
really like to get comments from others with a better understanding of
the potential impact.
--
Mike Kravetz
next prev parent reply other threads:[~2021-11-08 19:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 3:16 Muchun Song
2021-11-01 3:16 ` [PATCH v7 1/5] mm: hugetlb: free " Muchun Song
2021-11-01 3:16 ` [PATCH v7 2/5] mm: hugetlb: replace hugetlb_free_vmemmap_enabled with a static_key Muchun Song
2021-11-01 3:16 ` [PATCH v7 3/5] mm: sparsemem: use page table lock to protect kernel pmd operations Muchun Song
2021-11-01 3:16 ` [PATCH v7 4/5] selftests: vm: add a hugetlb test case Muchun Song
2021-11-01 3:16 ` [PATCH v7 5/5] mm: sparsemem: move vmemmap related to HugeTLB to CONFIG_HUGETLB_PAGE_FREE_VMEMMAP Muchun Song
2021-11-08 8:16 ` [PATCH v7 0/5] Free the 2nd vmemmap page associated with each HugeTLB page Muchun Song
2021-11-08 19:33 ` Mike Kravetz [this message]
2021-11-10 6:18 ` Muchun Song
2021-11-22 4:21 ` Muchun Song
2021-11-24 3:09 ` Andrew Morton
2022-01-26 8:04 ` Muchun Song
2022-02-09 7:44 ` Muchun Song
2022-02-09 22:48 ` Mike Kravetz
2022-02-10 7:45 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c5217d-eb8f-6f70-544a-a3e8bd009a46@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bodeddub@amazon.com \
--cc=chenhuang5@huawei.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=fam.zheng@bytedance.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=smuchun@gmail.com \
--cc=song.bao.hua@hisilicon.com \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox