From: Qi Zheng <zhengqi.arch@bytedance.com>
To: peterz@infradead.org, agordeev@linux.ibm.com,
kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de,
david@redhat.com, jannh@google.com, hughd@google.com,
yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev,
vbabka@kernel.org, lorenzo.stoakes@oracle.com,
akpm@linux-foundation.org, rientjes@google.com,
vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org,
aneesh.kumar@kernel.org, npiggin@gmail.com,
dave.hansen@linux.intel.com, rppt@kernel.org,
ryan.roberts@arm.com
Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-arch@vger.kernel.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-um@lists.infradead.org,
Qi Zheng <zhengqi.arch@bytedance.com>
Subject: [PATCH v4 06/15] s390: pgtable: add statistics for PUD and P4D level page table
Date: Mon, 30 Dec 2024 17:07:41 +0800 [thread overview]
Message-ID: <35be22a2b1666df729a9fc108c2da5cce266e4be.1735549103.git.zhengqi.arch@bytedance.com> (raw)
In-Reply-To: <cover.1735549103.git.zhengqi.arch@bytedance.com>
Like PMD and PTE level page table, also add statistics for PUD and P4D
page table.
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Suggested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: linux-s390@vger.kernel.org
---
arch/s390/include/asm/pgalloc.h | 29 +++++++++++++++++++-------
arch/s390/include/asm/tlb.h | 37 +++++++++++++++++----------------
2 files changed, 40 insertions(+), 26 deletions(-)
diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h
index 7b84ef6dc4b6d..a0c1ca5d8423c 100644
--- a/arch/s390/include/asm/pgalloc.h
+++ b/arch/s390/include/asm/pgalloc.h
@@ -53,29 +53,42 @@ static inline p4d_t *p4d_alloc_one(struct mm_struct *mm, unsigned long address)
{
unsigned long *table = crst_table_alloc(mm);
- if (table)
- crst_table_init(table, _REGION2_ENTRY_EMPTY);
+ if (!table)
+ return NULL;
+ crst_table_init(table, _REGION2_ENTRY_EMPTY);
+ pagetable_p4d_ctor(virt_to_ptdesc(table));
+
return (p4d_t *) table;
}
static inline void p4d_free(struct mm_struct *mm, p4d_t *p4d)
{
- if (!mm_p4d_folded(mm))
- crst_table_free(mm, (unsigned long *) p4d);
+ if (mm_p4d_folded(mm))
+ return;
+
+ pagetable_p4d_dtor(virt_to_ptdesc(p4d));
+ crst_table_free(mm, (unsigned long *) p4d);
}
static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address)
{
unsigned long *table = crst_table_alloc(mm);
- if (table)
- crst_table_init(table, _REGION3_ENTRY_EMPTY);
+
+ if (!table)
+ return NULL;
+ crst_table_init(table, _REGION3_ENTRY_EMPTY);
+ pagetable_pud_ctor(virt_to_ptdesc(table));
+
return (pud_t *) table;
}
static inline void pud_free(struct mm_struct *mm, pud_t *pud)
{
- if (!mm_pud_folded(mm))
- crst_table_free(mm, (unsigned long *) pud);
+ if (mm_pud_folded(mm))
+ return;
+
+ pagetable_pud_dtor(virt_to_ptdesc(pud));
+ crst_table_free(mm, (unsigned long *) pud);
}
static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long vmaddr)
diff --git a/arch/s390/include/asm/tlb.h b/arch/s390/include/asm/tlb.h
index e95b2c8081eb8..b946964afce8e 100644
--- a/arch/s390/include/asm/tlb.h
+++ b/arch/s390/include/asm/tlb.h
@@ -110,24 +110,6 @@ static inline void pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd,
tlb_remove_ptdesc(tlb, pmd);
}
-/*
- * p4d_free_tlb frees a pud table and clears the CRSTE for the
- * region second table entry from the tlb.
- * If the mm uses a four level page table the single p4d is freed
- * as the pgd. p4d_free_tlb checks the asce_limit against 8PB
- * to avoid the double free of the p4d in this case.
- */
-static inline void p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d,
- unsigned long address)
-{
- if (mm_p4d_folded(tlb->mm))
- return;
- __tlb_adjust_range(tlb, address, PAGE_SIZE);
- tlb->mm->context.flush_mm = 1;
- tlb->freed_tables = 1;
- tlb_remove_ptdesc(tlb, p4d);
-}
-
/*
* pud_free_tlb frees a pud table and clears the CRSTE for the
* region third table entry from the tlb.
@@ -140,11 +122,30 @@ static inline void pud_free_tlb(struct mmu_gather *tlb, pud_t *pud,
{
if (mm_pud_folded(tlb->mm))
return;
+ pagetable_pud_dtor(virt_to_ptdesc(pud));
tlb->mm->context.flush_mm = 1;
tlb->freed_tables = 1;
tlb->cleared_p4ds = 1;
tlb_remove_ptdesc(tlb, pud);
}
+/*
+ * p4d_free_tlb frees a p4d table and clears the CRSTE for the
+ * region second table entry from the tlb.
+ * If the mm uses a four level page table the single p4d is freed
+ * as the pgd. p4d_free_tlb checks the asce_limit against 8PB
+ * to avoid the double free of the p4d in this case.
+ */
+static inline void p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d,
+ unsigned long address)
+{
+ if (mm_p4d_folded(tlb->mm))
+ return;
+ pagetable_p4d_dtor(virt_to_ptdesc(p4d));
+ __tlb_adjust_range(tlb, address, PAGE_SIZE);
+ tlb->mm->context.flush_mm = 1;
+ tlb->freed_tables = 1;
+ tlb_remove_ptdesc(tlb, p4d);
+}
#endif /* _S390_TLB_H */
--
2.20.1
next prev parent reply other threads:[~2024-12-30 9:09 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 9:07 [PATCH v4 00/15] move pagetable_*_dtor() to __tlb_remove_table() Qi Zheng
2024-12-30 9:07 ` [PATCH v4 01/15] Revert "mm: pgtable: make ptlock be freed by RCU" Qi Zheng
2024-12-30 9:07 ` [PATCH v4 02/15] riscv: mm: Skip pgtable level check in {pud,p4d}_alloc_one Qi Zheng
2025-01-06 11:20 ` Alexandre Ghiti
2024-12-30 9:07 ` [PATCH v4 03/15] asm-generic: pgalloc: Provide generic p4d_{alloc_one,free} Qi Zheng
2024-12-30 9:07 ` [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table Qi Zheng
2025-01-02 16:53 ` Kevin Brodsky
2025-01-03 3:53 ` Qi Zheng
2025-01-03 7:46 ` Kevin Brodsky
2024-12-30 9:07 ` [PATCH v4 05/15] arm64: pgtable: use mmu gather to free p4d " Qi Zheng
2024-12-30 9:07 ` Qi Zheng [this message]
2025-01-06 10:32 ` [PATCH v4 06/15] s390: pgtable: add statistics for PUD and P4D " Alexander Gordeev
2025-01-06 11:05 ` Qi Zheng
2025-01-06 13:34 ` Alexander Gordeev
2025-01-06 13:37 ` Qi Zheng
2024-12-30 9:07 ` [PATCH v4 07/15] mm: pgtable: introduce pagetable_dtor() Qi Zheng
2025-01-06 10:34 ` Alexander Gordeev
2025-01-06 10:55 ` Qi Zheng
2025-01-06 12:36 ` Alexander Gordeev
2025-01-06 13:23 ` Qi Zheng
2025-01-07 9:23 ` Kevin Brodsky
2024-12-30 9:07 ` [PATCH v4 08/15] arm: pgtable: move pagetable_dtor() to __tlb_remove_table() Qi Zheng
2024-12-30 9:07 ` [PATCH v4 09/15] arm64: " Qi Zheng
2024-12-30 9:07 ` [PATCH v4 10/15] riscv: " Qi Zheng
2025-01-02 16:53 ` Kevin Brodsky
2025-01-03 3:48 ` Qi Zheng
2025-01-03 8:02 ` Kevin Brodsky
2025-01-03 9:13 ` Qi Zheng
2025-01-03 9:35 ` Qi Zheng
2025-01-03 13:27 ` Kevin Brodsky
2025-01-06 3:49 ` Qi Zheng
2025-01-07 9:57 ` Kevin Brodsky
2025-01-07 10:51 ` Qi Zheng
2025-01-07 11:58 ` Kevin Brodsky
2025-01-07 12:31 ` Qi Zheng
2025-01-07 14:17 ` Kevin Brodsky
2024-12-30 9:07 ` [PATCH v4 11/15] x86: " Qi Zheng
2024-12-30 9:07 ` [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD " Qi Zheng
2025-01-06 10:36 ` Alexander Gordeev
2025-01-06 11:02 ` Qi Zheng
2025-01-06 12:44 ` Alexander Gordeev
2025-01-06 13:34 ` Qi Zheng
2025-01-06 14:35 ` Alexander Gordeev
2025-01-06 14:44 ` Qi Zheng
2024-12-30 9:07 ` [PATCH v4 13/15] mm: pgtable: introduce generic __tlb_remove_table() Qi Zheng
2025-01-07 12:32 ` Andreas Larsson
2025-01-07 12:34 ` Qi Zheng
2025-01-07 14:20 ` Alexander Gordeev
2024-12-30 9:07 ` [PATCH v4 14/15] mm: pgtable: move __tlb_remove_table_one() in x86 to generic file Qi Zheng
2024-12-30 9:07 ` [PATCH v4 15/15] mm: pgtable: introduce generic pagetable_dtor_free() Qi Zheng
2025-01-07 14:22 ` Alexander Gordeev
2024-12-31 0:24 ` [PATCH v4 00/15] move pagetable_*_dtor() to __tlb_remove_table() Andrew Morton
2025-01-02 17:00 ` Kevin Brodsky
2025-01-03 3:56 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35be22a2b1666df729a9fc108c2da5cce266e4be.1735549103.git.zhengqi.arch@bytedance.com \
--to=zhengqi.arch@bytedance.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=muchun.song@linux.dev \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox