From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E0FC433EF for ; Wed, 22 Sep 2021 04:49:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 01054611B0 for ; Wed, 22 Sep 2021 04:49:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 01054611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8BB4E6B0072; Wed, 22 Sep 2021 00:49:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 843CC6B0073; Wed, 22 Sep 2021 00:49:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64787900002; Wed, 22 Sep 2021 00:49:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 540336B0072 for ; Wed, 22 Sep 2021 00:49:09 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 03CDD2D4C6 for ; Wed, 22 Sep 2021 04:49:09 +0000 (UTC) X-FDA: 78613980018.16.33C4F68 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2054.outbound.protection.outlook.com [40.107.96.54]) by imf05.hostedemail.com (Postfix) with ESMTP id 81A3E571B9BD for ; Wed, 22 Sep 2021 04:49:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQklw2SDVZ0Li1Dk9GoOQboa+JbzBgysnh6JM7yVZWA4r37Y4ekuGcJ25nhBmZgZYubPsotiqbDrigHVwAyjq2/NeH+Mqz6vocS7t+zfnE4/QkxRHVBTRt1h29zzQyINZUTyhvzea77Tjkgo5nNgNJzYGBFgN8JE6LdmqojyvtUmS4SognlGRfDNuF1/bL+KdJnmNvM2z0gQUkRk32GQccxAxPdZsXhyupyecZDlrROh/2alnIBfmHZdQ/C+gfEF1yuRwo/FxTf03ky5oMYecC4xqm3GxowiQLy0BKm+tfgo4flh5Y28ROivqWB4nhf+vA/ruudfqMemd9jaed01aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WKpjESRKlEut09q7+apd0aXcfwc2p9fMX50TNPlY5M4=; b=R7uQqOgxti20LqOCZIfxzRC/jRQGsDplhX/llT89uaSKwl5z3SHX1TsYNEsn6kUQg3iT2ACoPo1bryzYgojYojyNT66Z9KjC6W1hkABlN5Ams5uZq6mibXqIh3YcP91PQqWZ4toABi1lRUsrJJcxGU/KYyagIUF715Vw02q3quW7iFnOJY6dz+gzPNYd/qTDS8GBHbVM9LPYek7QBx8bNk1qH0/2a5sIrgA8PIq8k8Nm6Sju3OAQ3eMIfOZTHisTdH70yCnbU0ge3L9EP9nGtTa4V5jbuAoBRpbPfb3Xg+IXWjumxPDimhDLSNSRe/T8hBqnG0iYHyyqlZUvVF5LLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WKpjESRKlEut09q7+apd0aXcfwc2p9fMX50TNPlY5M4=; b=qn82Ma+mriwZy2B+7VWECUdVwmYR3lYypNPVcGW+jcn72zMcIxJlfmnditpnnUlcH5ifnYgND6dB3BeTHWO4cP52SjPOZSbWzf4x/6CU8fM65Y26KObK27sANDg1C/VIcOHoWV551BUF1yTebadehepr/lFLpFUd+PfQPHdm5DAlXBr9AnnqHUxOH/b5cyY3C0kNTwEyR5hoET5bpyK3+NTjuzO3f968+ehVS2XzBqwU2fmy6tHtM8WBJhi3LTbqdQCLQ3htYqnupWNR+NvYUDc3Rk1EwUPNRVSVAFYIJJnNJnD/7rTxUQAgAB3Ag5K9qXwD4Ns5ZIh7xcnEMxRhjQ== Received: from BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) by BYAPR12MB3192.namprd12.prod.outlook.com (2603:10b6:a03:139::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Wed, 22 Sep 2021 04:49:06 +0000 Received: from BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::6811:59ee:b39f:97b9]) by BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::6811:59ee:b39f:97b9%8]) with mapi id 15.20.4544.013; Wed, 22 Sep 2021 04:49:06 +0000 Message-ID: <35ba1b41-507a-a178-b81f-9d7305726b9f@nvidia.com> Date: Tue, 21 Sep 2021 21:49:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH v2 2/2] mm/debug: sync up latest migrate_reason to migrate_reason_names Content-Language: en-US To: Weizhao Ouyang , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual , Michal Hocko , Pavel Tatashin , Yang Shi , Zi Yan , Dave Hansen , Minchan Kim , Mina Almasry , "Matthew Wilcox (Oracle)" , "Huang, Ying" , Oscar Salvador , Wei Xu References: <20210921064553.293905-1-o451686892@gmail.com> <20210921064553.293905-3-o451686892@gmail.com> From: John Hubbard In-Reply-To: <20210921064553.293905-3-o451686892@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY3PR05CA0033.namprd05.prod.outlook.com (2603:10b6:a03:39b::8) To BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) MIME-Version: 1.0 Received: from [10.2.92.177] (216.228.112.22) by BY3PR05CA0033.namprd05.prod.outlook.com (2603:10b6:a03:39b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.6 via Frontend Transport; Wed, 22 Sep 2021 04:49:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99d782ba-e560-4011-eb55-08d97d844f1b X-MS-TrafficTypeDiagnostic: BYAPR12MB3192: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:210; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XKnQtuvPtxzvmPlAxO1Bo+himz8T34whsrNk3EZf4clxt9NasrF50XLd7Gh5O1cbfnJ4zlF3mZIjW8DTI9SjmyueqkJWLHIWRz04UNt11RAgAURa5vZ2ILJt58hnvUnVHVD3KbvYDMJ1DcAX1k+4cgjyeaYiLDqoP2m2K0S/Dt26J46xqFSYBlG1Q8S9QfA2YNZq6mM+ltvaVtP4c5JvV2GYjpcfsGQkZDchiIiHzXRYc0xf+c8CVC32+vBXH/KL01cGNWh7KBgXt18Vw2Ycx0L9kehLUQ/Cf2snfdOQNOImS0D8oyuat3tVOFqXVe1fDlmdrjwh4sBvWbf/DIhnaUbN9VWAXwvE8N7LhtPXqiKKVJ6c0//9/aYD4BMXRlBxYy8D4QNyrlUl0fi0lVWid5hWYyyNxUg3Mbnp8h5cRa/Wj8LmBt4P+1wvbihA8kiWQLUjlJixPvwUwnTtHZ91XeM608Ob5qUS8iiQG/Nomg3Yco5t7Gf0FXMgkqe7Ydod83u7BZkK6dsomquyo5EZnTDatcX3A15uXJvZvlpGwsGM3QPoS92zNIPkCQFzupuvyjBUxJb9S0/D1MbMKdayQ5YW3uUlBvcMLErSxOeCuoqZ3h6E8r8yasTDbfVVtRR69nIYoW1B7mjyHYlF4t76XPrsQhfyEgazgKOgEmxGfu+LqGoHLD9DVQTapjolQ7YWpYyjepp0DEHge5Y/YrOo1Pao1cOsDAwQrBPpvIBH+rs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4130.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(2616005)(956004)(16576012)(83380400001)(66946007)(6486002)(53546011)(508600001)(66556008)(36756003)(31696002)(110136005)(2906002)(8676002)(7416002)(38100700002)(54906003)(86362001)(8936002)(186003)(316002)(5660300002)(4326008)(31686004)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDhHZVgyTWNNV2FOejVPYm55V2dHaThtUUdjTURVYjFXSXNUbks5VjVSSUVL?= =?utf-8?B?ZmkrcHhJUFVjM2Jpd3ZHbDJTdTdiSDh6a0JWQ2tmVGJxZTAvRGN6bVVpZW9B?= =?utf-8?B?VWtKRzVqQW1XWWNPVGJrRFdIMy9XS2Jvc0QvVWxWVnhKQ0FWWXNtaWVDeW1K?= =?utf-8?B?bC9WTVJweXpvRzcram5yZkltUE1rc2lNVEtIRkxGU0xCdWZCdmIyMVB3ZzlE?= =?utf-8?B?TWJaUWFJY25ta0RFc2l0K2JFeHhmb05IMm4yc0JFZVdheG4xUkd4d1F5dGVv?= =?utf-8?B?a2oxeElsYzR2UkVoaTl1OEtSSUdlWUhIM2FvU0ZENjR2VWRXVVkwZE9MRnZK?= =?utf-8?B?bGFtQm5OdHZnZERubHNqVVNaR2VKVEdOWHU4TUlSRWh3aVhvKzZGdXNpVVFQ?= =?utf-8?B?dlRJSEo3OTc5RHZVVU8vY09SeUpHZ3lwVWsyc3FJVm95ZU5yK3ZoaGF2czBZ?= =?utf-8?B?Y0pzQ0RWM2J3am84U0lwMHp3aVVCclU2akhna3I1U0xlZFVwUWROTUJxczFj?= =?utf-8?B?T0t0UjY2NEtTczNJTjI4aUFWTjBldFNlUllEQXljblh5ZkdZcjBLY1JLcGxy?= =?utf-8?B?SVFsSCtteFNJL1gzNVB3Z05TdVdIaFNMZEJOUGUvYldkWEhDMWVySmNxSEtx?= =?utf-8?B?dHJZaHphQ05FeHdnSkZrcENXOGoxUE5NMDg0ZHZSSmNzV2RvbEJ4VmlwMXZX?= =?utf-8?B?eXVSMHo0UEMvWkhiU2xlMHB1UVdTdFpmTnFZSGdDY3FzS2p1OEdZK3dzTjk3?= =?utf-8?B?WTNXUlBTZE5YNFA1dHZuTGxXWDF6VmJFREg0VjR5Ukwya1E5ZTc5ZVZlNjRX?= =?utf-8?B?QU9kTXlqRk0yZGZSV3RrbnQxZ0kva3BqaW52YjhKUjRCMEZxTVdsMml3Y3Rj?= =?utf-8?B?ekJ0MWlHTEJjY2lBd1hxdEYvd1BGbjlac0VDelFaM09TMDhVNWxCc3Y4RlEy?= =?utf-8?B?T0ZySGNuTHFhbGNNRXR3alVuSGRYMVFZTkd0ZE96OEozRFgvZSt4UWpmL2Uy?= =?utf-8?B?SDk2eXhWVkh6NUpnWms0MVd3ZDJXTXpJUDZucE4yTWtOaTdNY2Z6OHdFZDBC?= =?utf-8?B?bmlTakpaVkwzK2twdDBLak5iS2orcW1DRUFOS0tIdjE3UVpTdllSVHdIdE1o?= =?utf-8?B?Z0VDaENvd0JIUE8vd2taVDF2eFoyZitSRDUvSFM1QmZESEwzR0xrN09MY1JS?= =?utf-8?B?VUZ6ZHgyL3JOeDBjODhkYlJUaXRWVG90cDZjcHFWRjBBTHgrOXNYMEs1UjNZ?= =?utf-8?B?Y0Y2cHg1cDEvMEhJVFEvZUJmMGNSdGZwaGhGbnFOdloxYUFaZU9BT1RkZExy?= =?utf-8?B?WGo3KzhoQ1ZGVUVyUHlpaE84M0piK1VjYUovMjJwcHN4UjJrM2VjVFlvdXQ0?= =?utf-8?B?STZUYm1JZlZzMCtRc1lSa3Qzd0lsdzJ5dWFDS0d4MHFXcVAvVEJ4cVBFeVU4?= =?utf-8?B?MWpKNnErT2VQYTVFeVEzYzBlYTU1V3UrbUhZYjhaUTgrN05nZVBsRWtJd2FU?= =?utf-8?B?RnRkRzRHc21Wck54MzJGMTg1a1VJUFpDeTQxMnRBK3kxZG9saEp1eVdrdFNS?= =?utf-8?B?cFRFcmRmNFlXNnQ4QVQwSGJzUjR6QVpMRXUwby9ZTERCNXZGYXRoUlNJeC8y?= =?utf-8?B?ZDVnVlkwc3A0Q091UzNjMzFoS3RvQmVQVHZoK1dTUzQ0SmxmZFlyRzJXb3lM?= =?utf-8?B?VWlRRVdJem5ycDFqT0crR0srWjhnK2pZc0R1OVN0Tzd4N2tySFNUdXAzUnlO?= =?utf-8?Q?oHLr2eeA8KR55LoqC/HEXnlBFkgoeWeXMeidAbV?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99d782ba-e560-4011-eb55-08d97d844f1b X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 04:49:06.7334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q77PhCoSBKupBHEKm5xSzHaAAeU0Hz2rvnGdAqVnXdUcB3YoRb0FL+k1TSNNoS+s0i7ctbwHCXd28iPJpGbYYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3192 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=qn82Ma+m; spf=none (imf05.hostedemail.com: domain of jhubbard@nvidia.com has no SPF policy when checking 40.107.96.54) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=quarantine) header.from=nvidia.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 81A3E571B9BD X-Stat-Signature: jouygiwh88re8aza6tw3nr939g5e4i7z X-HE-Tag: 1632286148-565497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/20/21 23:45, Weizhao Ouyang wrote: > Sync up MR_DEMOTION to migrate_reason_names and add a synch prompt. > > Fixes: 26aa2d199d6f ("mm/migrate: demote pages during reclaim") > Signed-off-by: Weizhao Ouyang > Reviewed-by: "Huang, Ying" > --- > include/linux/migrate.h | 6 +++++- > mm/debug.c | 1 + > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index 326250996b4e..c8077e936691 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -19,6 +19,11 @@ struct migration_target_control; > */ > #define MIGRATEPAGE_SUCCESS 0 > > +/* > + * Keep sync with: > + * - macro MIGRATE_REASON in include/trace/events/migrate.h > + * - migrate_reason_names[MR_TYPES] in mm/debug.c > + */ > enum migrate_reason { > MR_COMPACTION, > MR_MEMORY_FAILURE, > @@ -32,7 +37,6 @@ enum migrate_reason { > MR_TYPES > }; > > -/* In mm/debug.c; also keep sync with include/trace/events/migrate.h */ > extern const char *migrate_reason_names[MR_TYPES]; > > #ifdef CONFIG_MIGRATION > diff --git a/mm/debug.c b/mm/debug.c > index e61037cded98..fae0f81ad831 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -26,6 +26,7 @@ const char *migrate_reason_names[MR_TYPES] = { > "numa_misplaced", > "contig_range", > "longterm_pin", > + "demotion", > }; > > const struct trace_print_flags pageflag_names[] = { > Looks good. Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA