From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D7AC36002 for ; Wed, 9 Apr 2025 11:31:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2389280044; Wed, 9 Apr 2025 07:31:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD23E6B011E; Wed, 9 Apr 2025 07:31:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99CAF280044; Wed, 9 Apr 2025 07:31:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7D1656B011C for ; Wed, 9 Apr 2025 07:31:26 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9D8D61606C3 for ; Wed, 9 Apr 2025 11:31:27 +0000 (UTC) X-FDA: 83314289814.07.42DFFEA Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf09.hostedemail.com (Postfix) with ESMTP id BE69B14000B for ; Wed, 9 Apr 2025 11:31:25 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=c7FFw26W; spf=pass (imf09.hostedemail.com: domain of bhsharma@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=bhsharma@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744198286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FLV91CEpQSeUuhyrf6X7Y7S8BnEVeMNhFp42arzdGXU=; b=z7vst8rVWpUnNH7jAfgE8oyfDSYRWF91gN6C0/ThIXIPCW+O9xa8TUMX6jlNKKknlVYYZZ CJxcyTHpcmAn0v1pDNdXUvF3wxEU8Y3WfbGVVgibeb6WjvAew4PURijh6DWLPH3+GFqm/I zFBtZcXFP6E5rLn/PgvZJiipNE3GGPY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=c7FFw26W; spf=pass (imf09.hostedemail.com: domain of bhsharma@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=bhsharma@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744198286; a=rsa-sha256; cv=none; b=6uyJQAlZT1TWgrtdpf/7ih6+v8UHTRlGQfDQuze4YvdRVlY9KdULqkYvxCpxnMvFEoYMRe cNhD7EiU8GanyHkP34fFlFkpMyfwnPtpDj7zd7CPGA8n8/LBZPncCfv8QpJgyk2WoFF28s DauFqAgIAuE25qMJz041Jbvxkn8VXRs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FLV91CEpQSeUuhyrf6X7Y7S8BnEVeMNhFp42arzdGXU=; b=c7FFw26WRc/QcDvoT6DswQt2BF pjsKo96k8Jhg6DT1jL3A3zD7qVhGe56ZplefRjSMaFlWqNTwbLQVraOPY49tPDM7zeU44PESHMfKG a59aze3NrikVXGDVi4+CrVzjqoWsgU7OGjCTRVcdk+VPwWVwA2UAXDKxq+vFcWmOs+DIFo2q9r+XK eSrJ8D+dW0Tfh3UD5XamwRVfJSKNz+CMdWCkDyNXcf+MTE3Pd05g6qYN9pQ5F3vzXTtd3ySDlnBFa 8wcaYPrekUWunloaKUrUeOwDomnHCLi0UXfRP2Lt/LbuaND8CCQeZBvZMZG77BT7guBdM/HYNq1Hs NvbHA9ww==; Received: from [223.233.71.56] (helo=[192.168.1.12]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1u2TeA-00E4Ri-Pl; Wed, 09 Apr 2025 13:31:11 +0200 Message-ID: <35b4fe2a-606c-f25c-0d5c-1abb6e7b3003@igalia.com> Date: Wed, 9 Apr 2025 17:01:05 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 1/3] exec: Dynamically allocate memory to store task's full name Content-Language: en-US To: Kees Cook Cc: Bhupesh , akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com References: <20250331121820.455916-1-bhupesh@igalia.com> <20250331121820.455916-2-bhupesh@igalia.com> <202504030924.50896AD12@keescook> <3202d24e-b155-ab0a-86cd-0a3204ec52dd@igalia.com> <202504041023.A21FA17DDC@keescook> From: Bhupesh Sharma In-Reply-To: <202504041023.A21FA17DDC@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BE69B14000B X-Stat-Signature: trzm8e68z4zgg9ds98xr7g73yzp354k9 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744198285-436059 X-HE-Meta: U2FsdGVkX19oRpEfzMnCCyvUwhhhwt7RLGLe5RushW0slsf47CCCyAgshw1IWKNEleoRpxK4N2MeS3+42jZUWeELvumT+IAOIK0Qg7sglA4u3JZHi66SNqGwVe5DUonMd7Ja2d/ws8vL58p0efTvMIudXN2cI2U/EPDl5g2L3yAm2Ko3AN+mXA/B3BBVH2YAl7c9Mg0Zz5bIOM7fcPc+ETBYtqPXL3B9C2Y6dTSiwfTehfN/lunQopUSw5guNwWltifgmaLoXVGiXTFxHWgls+GpvCsndFB5WSAWp1PSZWwhpXRSOrBXMwp6YgPt+QBhfHe/D3ai6o1RooYjFUuR3D57eBbUSE3FH2+e4n2yTWIzp+qtOmqBo5QRhxeT/XjZjj9lXpexNzAL/HW5MfzJV5PDu9bDOZGGJ6tU61AZKZ9D9gWLQvPvTo6zwYEq5BNq7rOhxLqFE9I2UDhRPEjil5pZvfOF7l6h1FTaPBU6eKpBzxfGz7BUITk2T8LkaFnLAnqs7tVf4DHLQuSku+ByEwUBdgxQSeW3QAimChJL/GyzAQsEzFDGH1npROdlaiOcawaVyc144882xylYJ8Ga43reqGsu+xUJIZLOBZ90LOAXwK+5ymbVes2v5PQHxsqJe62nC1FNp/FMcoldFDhdqKkS3ZoU1eMP2LaqBJ3mzpmhPipgQrwW+KuH9jxyTAC/ieq1xP1dlYTtP2o8sa9BHwo0GX3KjlWwRlYtdz+SnoINOmOXBxeNkvI511OfKvQSS2Q4/URzPSf6b/Mkd8Dut+UsTjNJVyCf+TsmbYkL7xl/TRaz4HUBCpSUj3Qf3bWfcOAIivwdcYmG+vASpzFAF99WMrlgy7lCkLvUayOEKroDYADzw6Ck4Mgj7T95xYXgwsx6VSCPAGEq9Sys7VsKdejWdHYBVP+sFSPzr2Yz+uQ//JluY7+0lk61JGWlLv8TCFY2DMdCHlJ7KyGSqqC P4QJhNet 31Q4isdwTjWnHXPZKBPxRbM7GDa02KLHneVqVA7Poip3nZeiiSFm3hGP3LEMFMnUy1OsL2sMeZAGTA0oNnyLJoXqGvUPa0/y1ANhhdROgS3aLVMrwA3F5FavcwZkvvcKuZYxkhBjNtveTgG7w1H+TZVtABpBvEWd0+5IgpxKwwXmXyyTakHrZFA4DU0m392bQsRrHtl6uM7SNgX/0jtZJ7tjcibrqnOy5aV/q3mD9JHAn2wZ8daRrW6QPnr3K9X0OcWnLJ4hqzobjSlNT9eMtjwNAEL6hfF7r4TwREUfU59kBku6Y5qeHh1YsxVtoR3zC4EyjYYcTelWJwDbFeNsHoVOzRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kees, Sorry for the delay - I was out for a couple of days. On 4/4/25 10:54 PM, Kees Cook wrote: > On Fri, Apr 04, 2025 at 12:18:56PM +0530, Bhupesh Sharma wrote: >> In another review for this series, Yafang mentioned the following cleanup + >> approach suggested by Linus (see [0]). >> Also I have summarized my understanding on the basis of the suggestions >> Linus shared and the accompanying background threads (please see [1]). >> >> Kindly share your views on the same, so that I can change the implementation >> in v3 series accordingly. > In thinking about this a little more I think we can't universally change > all the APIs to use the new full_name since it is a pointer, which may > be getting changed out from under readers if a setter changes it. So > this may need some careful redesign, likely with RCU. hmm. > Thinking more about this, Linus mentioned in [0]: 'Since user space can randomly change their names anyway, using locking was always wrong for readers (for writers it probably does make sense to have some lock' So, if we go with the union approach, probably we can do with just a writer-lock, whereas if we go with a task->full_name like pointer one, we would probably need a rcu lock. Please let me know your comments. [0]. https://lore.kernel.org/all/CAHk-=wivfrF0_zvf+oj6==Sh=-npJooP8chLPEfaFV0oNYTTBA@mail.gmail.com/