From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB2CBC3601E for ; Sun, 13 Apr 2025 20:09:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1EC3280100; Sun, 13 Apr 2025 16:09:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACE5E2800F7; Sun, 13 Apr 2025 16:09:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96F11280100; Sun, 13 Apr 2025 16:09:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7880A2800F7 for ; Sun, 13 Apr 2025 16:09:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7AC4FC0EFC for ; Sun, 13 Apr 2025 20:09:36 +0000 (UTC) X-FDA: 83330110752.06.55609E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 144DB40009 for ; Sun, 13 Apr 2025 20:09:33 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Rqv7WeFv; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744574974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=31dW4hhoE6rQzohYOFQKu+yIo7zhpk3yfsTJqJ61yIk=; b=GrPFeK1tIy1cmHG1+CQrxLZVCIK41nPibGFINXR6UYHw0iFrNmwkC7CP4GVsK+CX1DrlSR FyUUZan72EXGApbGqudImd4Mtc7BgibHkK9Zej7lKavZ9kw3twPE2byWYOyRfwF5UVPdFD yBWcxQlP7bH7XnMFAL8asIv0JgKgn7g= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Rqv7WeFv; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744574974; a=rsa-sha256; cv=none; b=z9JQeCg6E1UMQDU0QtOxEhHHhet7MGAAIrnCL+gmzNYkiGG5TL80TtWr7kcJXUCCz8Ujh+ A2EvVwN2C6rfEczwfKO2Eq4lU7A5y7mjav/JHv260sRkWQI261iHBSvxsRXvrB/skQof6m HbA1DmPzjW8MycvInyoXCD22wu52Jzg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744574973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=31dW4hhoE6rQzohYOFQKu+yIo7zhpk3yfsTJqJ61yIk=; b=Rqv7WeFvwXVGFWncyARoUoAIhv7ECi6NVGzOV7WvSSEo7hseOuJ0BkDmJlUcQzQDL7k9mg e2KDl8FroRQtVd2oJc+Ap34Wm3MMyoIF1fKJBFIP/tFgT9iv3SwaTBinjCZUh4skWjNQrZ CvbXocch2g2RprSV1Gmz0amTHIuiCXE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-xVDBnVIlPuC6MPATWF2zEQ-1; Sun, 13 Apr 2025 16:09:31 -0400 X-MC-Unique: xVDBnVIlPuC6MPATWF2zEQ-1 X-Mimecast-MFC-AGG-ID: xVDBnVIlPuC6MPATWF2zEQ_1744574971 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39134c762ebso1486020f8f.0 for ; Sun, 13 Apr 2025 13:09:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744574970; x=1745179770; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=31dW4hhoE6rQzohYOFQKu+yIo7zhpk3yfsTJqJ61yIk=; b=QXZoyINeyfDtuuVzuc+sqZRbTPUxlGHHPkzUj5aDCc2Qhso65nMQNkIBZbqygMdf6P eVFu72lZ7pCjxE1o/+2Ip84gkPriN/WpLj5TC53y3FYifjbI4ZiSgs483L/27ymfh9DR HdrLN5ayQn1yj9CSicURux0vFxbSKAjs4Ootzpf8xlIf53XtK/fvgl9ouPvGAE+3dR3R hgD6b4gT7FngYoD73v+RqFMVSUz3hLyPEb1/AMitQHWbb9jfmeb5TvBqUhzZEvhEQsSi oHetSRcUjCo/h68VRhH0ZRKikepsQH8icYhj+kxcbWtP+Lexy5LNeOrhiUSTm4LCphRY f+Sg== X-Forwarded-Encrypted: i=1; AJvYcCW3GwwaxRbYH8SCtfdGW4T/cfGJ2uBh4LgjR1Geu6ngvh6OGlkc9ldpazIl5RInb9emfZ48VqgX9w==@kvack.org X-Gm-Message-State: AOJu0Yw7XR/xkwuRgp57sOzgZAJ8FwzQUpwCKt7qElrKoGfb5NPIJwJ0 MS+Ah7G7YkgdyQ6vp958ZsqSHlC+QIz7sbZx8RcZK9vCMtm7a2hQN/VVBlS5WO5WAp39U/XV6bd MzG4EKGuXMHQy/qzeQEEUeg+xX39+qL8bEO871ua5CWJ8vLXy X-Gm-Gg: ASbGncukdd49tmDYH2o/hDLQSAWaSmwLaKUWTYqVvvJU0eC25hX8sQG3e8FCZrGDL8N EcaFPmq7OWYfGd6gx+lkaAa8BDkB+mNT/o9HEpMAHG9mJqHEWP1/bDvBf79xqz5Or2beMOPIr3W 5I2t6tV4TbHMdSw44RktLefO6Vhr9lyv2prH8UvfnAKVUthZw6wTiLXT8m0a1FSlc/DhzNdSZop jfjurprBs085hsg0f6BdnByEY/mc8Yi9m4eK7o08H7ldgwKSWPPFjbDmPtdS3kk8bxSjJNfb3FE h//fZfRTdlmTgQ0cnENf8fiAVViQeryoRhUy3uuu6DlD9uFtvp+hzrt86CnziU3J/UR2DymzkJ4 EVurG6qvij4i2cfu8eHRBSDedeUrKXeEHEYvfzl8= X-Received: by 2002:a05:6000:22c1:b0:391:3d97:bd33 with SMTP id ffacd0b85a97d-39ea51f506emr7749395f8f.13.1744574970646; Sun, 13 Apr 2025 13:09:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHf5y8Urm27uqHtUYFYgEjadABoT249/CjidrtT4w8oUCDaLSsP7Fzxka+tkR6nzr7xf5LIIg== X-Received: by 2002:a05:6000:22c1:b0:391:3d97:bd33 with SMTP id ffacd0b85a97d-39ea51f506emr7749387f8f.13.1744574970198; Sun, 13 Apr 2025 13:09:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf43cc72sm9013629f8f.67.2025.04.13.13.09.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Apr 2025 13:09:29 -0700 (PDT) Message-ID: <35a93c36-6e97-4b33-aae5-efd1c907518a@redhat.com> Date: Sun, 13 Apr 2025 22:09:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/4] mm/gup: clean up codes in fault_in_xxx() functions To: Baoquan He , linux-mm@kvack.org Cc: akpm@linux-foundation.org, osalvador@suse.de, yanjun.zhu@linux.dev, linux-kernel@vger.kernel.org References: <20250410035717.473207-1-bhe@redhat.com> <20250410035717.473207-5-bhe@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: imz6-dYyuVfjvBn2Q23gFKol_UAzPKjG4p1ZjFiNcQM_1744574971 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 144DB40009 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: h34s6xcpgqex3axok4s9h57oij3gd5yp X-HE-Tag: 1744574973-1823 X-HE-Meta: U2FsdGVkX19FhEAXkSa0FdTa0HbHJOgWwOv5rNNWThLDdAmPQ7uxFfPxsFJTEtLbUHqF+Yv8ZFpcQDHsO7o88cLd9LzjHy4q2jRBaHJ6S5N8mbibv2vYsmb42/XxNS3cBCXvE+1l0STIx6yJdswjdFUAEQChLVASHLK8xzHgePcacVC/afyzOFraCPygP0VghHpuVUM+fYTsdte4YfVQMdF0oeI1XJQ9xcp+QS+sa4LeQ5qDSUWyb7Nm7Ygt8ZxwjyPwXbVOtHw3Xfm+c60FrCpDnGnfOCrJzEJ60WrHK9hskJgw6mCTdZ4w15izLJARsNOcHDddh9MQUkuJ9AcjxSSrV1KtqM4z6Ix4sUecT6ya3cgDVq/Iz4eJe/80VHjv3jH7IbJgjFZcUxbSPkqa46HQCGQ2eGSM/iPAv7DpHdeclRUbJTBK5GeKlWYKon6TkjV1tM84klpm5PQjr0QFp+VF93wQd30MyHkrfBymQA09CkhTBbu4CLTYTuAXZUat/KSFnwEhLf+GvujEQW9xIxUAva4nUW9mDkyxRkVAtNJc4HMIhHHIDF9/s92MKEgEOXuB4UWOmvbPxHfBSOEbU/KjGcnEySirIR5zEabPD9jf0N8j+UBZScD1ZDj+xzIXUjtZbmXCW2cSrgqc2Ef7HkM89ijEbX/nAS6CaVnmjUzpmKIIAFBmcxKFWuWcm6JWHZaE0YKqScfxbRkJEt0jZwKzyf/fcoLo1lKKeMkthPZvKquq1+ydtUq2lq1EqyjiYXVlEUSpkrARG1aJhheloG+84NKnnQuoXbqjJF1FYXkX0yfdEK6s1SMf4FjrdKb8AvqOOllTR4mtEyyplwoeeOG9EmEiK0CbGuAqCAevcG7yV4w2o/8bjsivx2rzmQAVAqoZMsA9KxhBvq8kT2CEmOpsYpo0Vct72QfiHemWE7G8RF8Pex7el9qqE6ufggayJBSePZ6mSWxGGyNN8xy Tuo1m/EC u56mBMcA4fIYScQQfTLifjv9dk+YcOlO/wOuWJJ25EFI61e687ybbXy18K/7tD//5zZEh5NFH/9fmRmzZLrIa+fu7xj0QwvZp9Q+Y77pODoP1pvpJ1BGndna+ufBf4sN8XD9II8X2pVTsK+cOqEdioeuHYCdk9ujWv578iw2HpIFIvEXVKifYvx4J164VknfFakZuMiFJVkc+NHxesE10McnUxWrLJHg7GwfHreSH3TrcBW7/hCN0mcbhQhclcS+qZsve4lln1e0qezzgTfRe6XKS4QjZCNPpvFJ/al2kfwFMpYnXl+7lACtjTC38EqVjGLAJbEmq6QgkyvDFtckYToti7Umu90GpEJ7R1y0+N9JHiA/DilrkXXv6PfGsiVIeJG1o7NCv/YmPJoRp66QaEwlL2h+2vVU8dcnCyK18xtlhrerSXC9aGp9lHyVFE4c3pUpdUvPR39mFedtClP07FIO4ZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.04.25 04:04, Baoquan He wrote: > The code style in fault_in_readable() and fault_in_writable() is a > little inconsistent with fault_in_safe_writeable(). In fault_in_readable() > and fault_in_writable(), it uses 'uaddr' passed in as loop cursor. While > in fault_in_safe_writeable(), local variable 'start' is used as loop > cursor. This may mislead people when reading code or making change in > these codes. > > Here define explicit loop cursor and use for loop to simplify codes in > these three functions. These cleanup can make them be consistent in > code style and improve readability. > > Signed-off-by: Baoquan He > --- Hopefully we don't introduce anything unexpected ... do we have some unit test that could make use feel better, especially regarding end < start? If not, could we add one based on some feature that ends up calling at least one of these functions? Acked-by: David Hildenbrand -- Cheers, David / dhildenb