From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1081FC10F16 for ; Tue, 30 Apr 2024 13:31:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83FAE6B008A; Tue, 30 Apr 2024 09:31:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C8416B008C; Tue, 30 Apr 2024 09:31:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61A966B0092; Tue, 30 Apr 2024 09:31:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 407C66B008A for ; Tue, 30 Apr 2024 09:31:24 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AFA3C1A0838 for ; Tue, 30 Apr 2024 13:31:23 +0000 (UTC) X-FDA: 82066284846.23.DC6D8C8 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf09.hostedemail.com (Postfix) with ESMTP id E2C6614002E for ; Tue, 30 Apr 2024 13:31:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EVx0AtRU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714483881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sQkyBn4Lnt15qpQKjjn6/FTdXdojZaggT0oJDgNx33c=; b=GIhLhJs2ggo5bTZGPZLPs+uH7Xn5siD+eqFtpswDfo1eLp9pxx25ZzJUfQTa7V3Kcuc0KT 0Ob0FDXa/W1wlFjVGmFFBUwcQVL0CTAdaAnrDEoz0BAgQL9sItr6UK0xEHuKzkjfYUm8/m hUMz4ucpAFAvBmn60KdI/1ceKgz5Fa4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EVx0AtRU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714483881; a=rsa-sha256; cv=none; b=gyCd2picwz2Za9GtYifY56WVVp9/VPovaVo9cDyz+KiFJnszBogNpTxIIW8747TzKDIXMz crJJUxa1YpM4AgM3frLPBlIkXgpBP/b3i9e5hhZsFVa+m8/aZ6LtS7xOKl+LD03brTKmWZ S1sAKgO7cn/YUiu1X9q9jAV1AVOw1AY= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a58e7628aeaso405150466b.2 for ; Tue, 30 Apr 2024 06:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714483879; x=1715088679; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sQkyBn4Lnt15qpQKjjn6/FTdXdojZaggT0oJDgNx33c=; b=EVx0AtRU0AVHNRlZdUh8R/xBDbqf+AkVLcDnjjt/drzly8FTrbJGantVhqKJjRv9uQ KwT7AAoOlaNFEeZdaDX5Uu2Fqqr7vfVzGtZSfDVk8MMkpI0My60aWa83Hxyqq3oHjLDI NtU29tzob1XQrGlW1k4IPp0Wl2CaVoziKNuKSgXIwYWAB0SYZzb4qre//ARJdnz+NODL uWjJwMDmuY22GWc9HsVFtUqv4k+h9YSvaxNV8CAt94AOpqBd0MMhGze0NkA/dsDGDF/8 6L7I0mjO8BOjghnVHkA8Fk7u/gIpc/coT3NxZTnCa3KvsQg4TI8iiD7GWFL0fvpv9ahI Y7dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714483879; x=1715088679; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sQkyBn4Lnt15qpQKjjn6/FTdXdojZaggT0oJDgNx33c=; b=a/bwfOm/etvuRmPnLoglr9kcQqrTsvSTUF7QzeDvxPs8lXdYHB15NeZ/JBgcRRQ/lO feiF/siaXRF9UWkSC7TTO5zZk0Qhq76bPKgUvSekNfNUZ9QhwqB0yXH5Mif9vWfOIg2c z1Zw0sFcjHLE2KdpauEH0YAFx7PR8lKoOV5+8spsfOoXpj7CPX/Ak9eNy2rEICfLylgd pZLsh1Q1LXjpsHgvx7a6bIUOSpCHVPwbs4a9a1zNxDRR/PdEGoIzro2AqyCeakffk1LX N0QizCLHLbXtvfM40RQ4OjqFdBHrH08AIRvEB8m4x25UPtGfgVJUDUgcKVuH3W5bdpKs OPxg== X-Forwarded-Encrypted: i=1; AJvYcCVSRsUSH0Ef2F+8Kco1dh9YznavWKKjX9RFORXF2QnM3RhEnEgSWIRacDNBlNFMRujkHm66IseYQvCJYtPdW+h5zP0= X-Gm-Message-State: AOJu0YwNjFITwN0gB8E54cw/TBi9jxwjDoYjPMklfGovxIzRb0tc0/hq XkMsByRhupg4pQz+J6CBeF9fVJdyEMcmN7XNdOjiG+M2OMv4swn0 X-Google-Smtp-Source: AGHT+IG4D9H/56/A4rQ0pU5al3G+zQuIMq1mBSgq9KUwXS9Rk/+kL4o0ZAf4JvbTFbHU0G4DNFxL/g== X-Received: by 2002:a17:906:fb17:b0:a58:e74b:7e16 with SMTP id lz23-20020a170906fb1700b00a58e74b7e16mr2032608ejb.46.1714483879081; Tue, 30 Apr 2024 06:31:19 -0700 (PDT) Received: from [192.168.42.188] ([163.114.131.193]) by smtp.gmail.com with ESMTPSA id l9-20020a17090615c900b00a555be38aaasm15011385ejd.164.2024.04.30.06.31.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 06:31:18 -0700 (PDT) Message-ID: <35a79edf-e4ca-4501-99ad-231a3ab2b216@gmail.com> Date: Tue, 30 Apr 2024 14:31:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support To: Mina Almasry , David Wei Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Amritha Nambiar , Maciej Fijalkowski , Alexander Mikhalitsyn , Kaiyuan Zhang , Christian Brauner , Simon Horman , David Howells , Florian Westphal , Yunsheng Lin , Kuniyuki Iwashima , Jens Axboe , Arseniy Krasnov , Aleksander Lobakin , Michael Lass , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Richard Gobert , Sridhar Samudrala , Xuan Zhuo , Johannes Berg , Abel Wu , Breno Leitao , Jason Gunthorpe , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox References: <20240403002053.2376017-1-almasrymina@google.com> <20240403002053.2376017-8-almasrymina@google.com> <8357256a-f0e9-4640-8fec-23341fc607db@davidwei.uk> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E2C6614002E X-Stat-Signature: 9i5jc8uubbpcpeojhcz7wdhho3yppwgw X-HE-Tag: 1714483880-821248 X-HE-Meta: U2FsdGVkX1+D/9JbcZSKgPxqJtfHKI9fTQHXBRbLqQqj5wlWb3SnX/GUbHb1oAmX5V98Qlc0kUYLYgoDr2JP0jGi1+ZmmTd4qqnniNxx9fLkgTJ6gFSUjgqrvemT+bQPzQLthncIXVPEoxVBgEj0nM/mfn/8OISzAgvfB3mIh9vIDSuKYDlFEecvMifUJSOUdNCjEX9LgRLlOBkv5iWAVBpyUwbDCwcezZI7WWs9DT/CfyO2hYAIY02zme6RFgkTzCXuwzxtopEXat1igcXVHA1WHcC/SRcOQx1DmyPvsplq1HrymMYngI5cjanf9Yu1IKTFTN6HFQBzK7/VtKQhRPkRpWgAcPJLuxQOFyZck9b6cODuXHQPl6FmjhbGAAvs2TZbDz3JMGdr3dJMFbpWu5ATTnKcQDVSmlicfncoqbeRhtGmAOkYmmMGrnvdPz953XWp9CfyG//lqj2HI1kIhstu0dPupRVCO8iCuFkXlTycVPS5KYIgJPyL2Rpc1CP1MyBzt0sXToU3lEVgUQuF4aImm7BAnoVM8fSyWrbB6TVnPMiHt2SQ/RvOE1DQR7+XeTTpWeNclBCYlBOYVEZSJ1ByhjOfnty/ICRhqfioj5tCtbZd5RXvgZ+WuRadfJRfqNoUF/Jg0bU1FIh26fVPHx6mKWlOs1J7aB8z7FvuedmOm7rO8f5FkmIPVQeRqwlxeQqC8oI9JOa4nL4xaUmSxGAw1QZOjjqbMglTBbPcWK2yLmw7eljNf3/fZXABPWLj7tbT6JNehxI212/OvFCSCZ5GsWF3mPAI5yhpeOAORyCMx7aRjW9GJ57FMEFJqf2gQrTuogz/dLbb3vrc9ozFzhpCcjJ6dCdDkl7IDP4rHH28hiHKsDehYP4lcIyl9p8p0j+ynL6a1e3XCOqpSh7uQLj9PukhawQ1rOugnDLSmbuhvMa5ruJKs1XgytFbSE05B3j80RKE3V9cefV6msu 7pbla4R2 SNa6TT+VfPU09QZCER948k8nWpck3ScjWkmiIPkiio/DlSemAxzQ7Wt2MPic5JawajvTsa2GgzZpOIvrPs6VJof/mg/99/CnQLmv7VDBvY7sEwAWfNRsTcUFJl6PUz20JgRxa7F8oT9Fn0ksGgzTXkF70VPqCFp+pElq1+SB4Cslj/iOrxWVID4LfE0f687JncV1HjKOBuwiiFa7MR2QusWU28MVl00Bjp1w4vnsookOVFshZ7WvbDE2L+75VEjkrEFAd16GlGl58P1c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/27/24 03:11, Mina Almasry wrote: > On Fri, Apr 26, 2024 at 5:18 PM David Wei wrote: >> >> On 2024-04-02 5:20 pm, Mina Almasry wrote: >>> @@ -69,20 +106,26 @@ net_iov_binding(const struct net_iov *niov) >>> */ >>> typedef unsigned long __bitwise netmem_ref; >>> >>> +static inline bool netmem_is_net_iov(const netmem_ref netmem) >>> +{ >>> +#if defined(CONFIG_PAGE_POOL) && defined(CONFIG_DMA_SHARED_BUFFER) >> >> I am guessing you added this to try and speed up the fast path? It's >> overly restrictive for us since we do not need dmabuf necessarily. I >> spent a bit too much time wondering why things aren't working only to >> find this :( > > My apologies, I'll try to put the changelog somewhere prominent, or > notify you when I do something that I think breaks you. > > Yes, this is a by-product of a discussion with regards to the > page_pool benchmark regressions due to adding devmem. There is some > background on why this was added and the impact on the > bench_page_pool_simple tests in the cover letter. > > For you, I imagine you want to change this to something like: > > #if defined(CONFIG_PAGE_POOL) > #if defined(CONFIG_DMA_SHARED_BUFFER) || defined(CONFIG_IOURING) > > or something like that, right? Not sure if this is something I should Feels a bit flimsy, if the argument is that you want to be able to disable netmem overhead, then adding a netmem config option sounds like a better way forward. I have doubts this conditional handling is desirable in the first place, but perhaps I missed the discussion. > do here or if something more appropriate to be in the patches you > apply on top. > > I additionally think you may also need to run the > page_pool_benchmark_simple tests like I do in the cover letter to see > if you're affecting those. -- Pavel Begunkov