linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Wang, Yalin" <Yalin.Wang@sonymobile.com>
To: 'Rob Herring' <robherring2@gmail.com>,
	'Joe Perches' <joe@perches.com>,
	'Russell King - ARM Linux' <linux@arm.linux.org.uk>,
	'Will Deacon' <Will.Deacon@arm.com>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	"'akinobu.mita@gmail.com'" <akinobu.mita@gmail.com>,
	"'linux-mm@kvack.org'" <linux-mm@kvack.org>,
	"'linux-arm-kernel@lists.infradead.org'"
	<linux-arm-kernel@lists.infradead.org>
Subject: [RFC V5 1/3] add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction
Date: Wed, 29 Oct 2014 13:50:35 +0800	[thread overview]
Message-ID: <35FD53F367049845BC99AC72306C23D103E010D18264@CNBJMBX05.corpusers.net> (raw)
In-Reply-To: <35FD53F367049845BC99AC72306C23D103E010D18261@CNBJMBX05.corpusers.net>

this change add CONFIG_HAVE_ARCH_BITREVERSE config option,
so that we can use arm/arm64 rbit instruction to do bitrev operation
by hardware.

Change bitrev16() bitrev32() to be inline function,
don't need export symbol for these tiny functions.

Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
---
 include/linux/bitrev.h | 21 ++++++++++++++++++---
 lib/Kconfig            |  9 +++++++++
 lib/bitrev.c           | 17 ++---------------
 3 files changed, 29 insertions(+), 18 deletions(-)

diff --git a/include/linux/bitrev.h b/include/linux/bitrev.h
index 7ffe03f..413c52c 100644
--- a/include/linux/bitrev.h
+++ b/include/linux/bitrev.h
@@ -3,14 +3,29 @@
 
 #include <linux/types.h>
 
-extern u8 const byte_rev_table[256];
+#ifdef CONFIG_HAVE_ARCH_BITREVERSE
+#include <asm/bitrev.h>
+
+#define bitrev32 __arch_bitrev32
+#define bitrev16 __arch_bitrev16
+#define bitrev8 __arch_bitrev8
 
+#else
+extern u8 const byte_rev_table[256];
 static inline u8 bitrev8(u8 byte)
 {
 	return byte_rev_table[byte];
 }
 
-extern u16 bitrev16(u16 in);
-extern u32 bitrev32(u32 in);
+static inline u16 bitrev16(u16 x)
+{
+	return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
+}
+
+static inline u32 bitrev32(u32 x)
+{
+	return (bitrev16(x & 0xffff) << 16) | bitrev16(x >> 16);
+}
 
+#endif /* CONFIG_HAVE_ARCH_BITREVERSE */
 #endif /* _LINUX_BITREV_H */
diff --git a/lib/Kconfig b/lib/Kconfig
index 54cf309..cd177ca 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -13,6 +13,15 @@ config RAID6_PQ
 config BITREVERSE
 	tristate
 
+config HAVE_ARCH_BITREVERSE
+	boolean
+	default n
+	depends on BITREVERSE
+	help
+	  This option provides an config for the architecture which have instruction
+	  can do bitreverse operation, we use the hardware instruction if the architecture
+	  have this capability.
+
 config RATIONAL
 	boolean
 
diff --git a/lib/bitrev.c b/lib/bitrev.c
index 3956203..40ffda9 100644
--- a/lib/bitrev.c
+++ b/lib/bitrev.c
@@ -1,3 +1,4 @@
+#ifndef CONFIG_HAVE_ARCH_BITREVERSE
 #include <linux/types.h>
 #include <linux/module.h>
 #include <linux/bitrev.h>
@@ -42,18 +43,4 @@ const u8 byte_rev_table[256] = {
 };
 EXPORT_SYMBOL_GPL(byte_rev_table);
 
-u16 bitrev16(u16 x)
-{
-	return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
-}
-EXPORT_SYMBOL(bitrev16);
-
-/**
- * bitrev32 - reverse the order of bits in a u32 value
- * @x: value to be bit-reversed
- */
-u32 bitrev32(u32 x)
-{
-	return (bitrev16(x & 0xffff) << 16) | bitrev16(x >> 16);
-}
-EXPORT_SYMBOL(bitrev32);
+#endif /* CONFIG_HAVE_ARCH_BITREVERSE */
-- 
2.1.1

  reply	other threads:[~2014-10-29  5:50 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24  5:10 [PATCH RFC] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit Wang, Yalin
2014-10-27  6:37 ` [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction Wang, Yalin
2014-10-27  6:46   ` Joe Perches
2014-10-27  7:13     ` Wang, Yalin
2014-10-28 21:18     ` [PATCH] carl9170: Convert byte_rev_table uses to bitrev8 Joe Perches
2014-10-28 21:22     ` [PATCH] 6fire: " Joe Perches
2014-10-29  2:42       ` Wang, Yalin
2014-10-29  3:06         ` Joe Perches
2014-10-29  3:10           ` Wang, Yalin
2014-10-29  3:28     ` [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction Rob Herring
2014-10-29  5:14       ` [RFC V4 1/3] add " Wang, Yalin
2014-10-29  5:15         ` [RFC V4 2/3] arm:add bitrev.h file " Wang, Yalin
2014-10-29  5:16           ` [RFC V4 3/3] arm64:add " Wang, Yalin
2014-10-29  5:50             ` Wang, Yalin [this message]
2014-10-29  5:51               ` [RFC V5 2/3] arm:add " Wang, Yalin
2014-10-29  5:52                 ` [RFC V5 3/3] arm64:add " Wang, Yalin
2014-10-30 12:01                   ` Will Deacon
2014-10-30 12:26                     ` Ard Biesheuvel
2014-10-30 13:57                       ` Will Deacon
2014-10-31  5:40                         ` [RFC V6 1/3] add CONFIG_HAVE_ARCH_BITREVERSE " Wang, Yalin
2014-10-31  5:40                           ` [RFC V6 2/3] " Wang, Yalin
2014-10-31  5:42                             ` [RFC V6 2/3] arm:add bitrev.h file " Wang, Yalin
2014-10-31  7:40                               ` [RFC] arm:remove clear_thread_flag(TIF_UPROBE) Wang, Yalin
2014-10-31  7:45                                 ` Joe Perches
2014-10-31  7:51                                   ` Wang, Yalin
2014-10-31  7:58                                     ` Joe Perches
2014-10-31  7:59                                       ` Wang, Yalin
2014-10-31  8:01                                     ` [RFC V2] " Wang, Yalin
2014-11-13 23:53                               ` [RFC V6 2/3] arm:add bitrev.h file to support rbit instruction Russell King - ARM Linux
2014-11-14  0:05                                 ` Joe Perches
2014-11-14  0:17                                   ` Russell King - ARM Linux
2014-11-14  0:45                                     ` Joe Perches
2014-11-14  1:18                                       ` Russell King - ARM Linux
2014-11-14  1:26                                         ` Joe Perches
2014-11-14  9:52                                           ` Russell King - ARM Linux
2014-11-14  6:37                                   ` Takashi Iwai
2014-11-14  6:55                                     ` Joe Perches
2014-11-14  7:03                                       ` Takashi Iwai
2014-11-14  2:01                                 ` Wang, Yalin
2014-11-14  9:58                                   ` Russell King - ARM Linux
2014-11-17  2:38                                     ` Wang, Yalin
2015-01-08 18:40                                       ` Russell King - ARM Linux
2015-01-09  2:16                                         ` Wang, Yalin
2015-01-09 11:10                                           ` Russell King - ARM Linux
2015-01-09 12:40                                             ` Wang, Yalin
2015-01-14 16:38                                               ` Russell King - ARM Linux
2015-01-16  1:42                                                 ` Wang, Yalin
2014-10-31  7:54                             ` [RFC V6 2/3] add CONFIG_HAVE_ARCH_BITREVERSE " Wang, Yalin
2014-10-31  5:41                           ` [RFC V6 3/3] arm64:add bitrev.h file " Wang, Yalin
2014-10-31 10:43                             ` Will Deacon
2014-11-03  2:17                               ` Wang, Yalin
2014-11-03  8:47                                 ` Ard Biesheuvel
2014-11-03  9:50                                   ` Will Deacon
2014-11-04  1:45                                     ` Wang, Yalin
2014-10-31  2:03                     ` [RFC V5 " Wang, Yalin
2014-10-29  5:21         ` [RFC V4 1/3] add CONFIG_HAVE_ARCH_BITREVERSE " Joe Perches
2014-10-29  5:36           ` Wang, Yalin
2014-10-29  5:20       ` [RFC V2] arm/arm64:add " Wang, Yalin
2014-10-27  8:02   ` [RFC V3] " Wang, Yalin
2014-10-27 10:48     ` Will Deacon
2014-10-28  1:34       ` Wang, Yalin
2014-10-28 13:59         ` Will Deacon
2014-10-29  2:52           ` Wang, Yalin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35FD53F367049845BC99AC72306C23D103E010D18264@CNBJMBX05.corpusers.net \
    --to=yalin.wang@sonymobile.com \
    --cc=Will.Deacon@arm.com \
    --cc=akinobu.mita@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robherring2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox