From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) by kanga.kvack.org (Postfix) with ESMTP id 6DDF382BDC for ; Thu, 25 Sep 2014 21:56:53 -0400 (EDT) Received: by mail-pd0-f177.google.com with SMTP id v10so9989729pde.22 for ; Thu, 25 Sep 2014 18:56:53 -0700 (PDT) Received: from cnbjrel01.sonyericsson.com (cnbjrel01.sonyericsson.com. [219.141.167.165]) by mx.google.com with ESMTPS id ru9si6494958pbc.151.2014.09.25.18.56.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Sep 2014 18:56:52 -0700 (PDT) From: "Wang, Yalin" Date: Fri, 26 Sep 2014 09:56:44 +0800 Subject: RE: [PATCH resend] arm:extend the reserved memory for initrd to be page aligned Message-ID: <35FD53F367049845BC99AC72306C23D103D6DB491637@CNBJMBX05.corpusers.net> References: <35FD53F367049845BC99AC72306C23D103D6DB49161F@CNBJMBX05.corpusers.net> <20140919095959.GA2295@e104818-lin.cambridge.arm.com> <20140925143142.GF5182@n2100.arm.linux.org.uk> In-Reply-To: <20140925143142.GF5182@n2100.arm.linux.org.uk> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: 'Russell King - ARM Linux' , Catalin Marinas Cc: Will Deacon , "'linux-kernel@vger.kernel.org'" , "'linux-arm-kernel@lists.infradead.org'" , "'linux-mm@kvack.org'" , "'linux-arm-msm@vger.kernel.org'" , =?iso-8859-1?Q?=27Uwe_Kleine-K=F6nig=27?= , DL-WW-ContributionOfficers-Linux > On Fri, Sep 19, 2014 at 11:00:02AM +0100, Catalin Marinas wrote: > > On Fri, Sep 19, 2014 at 08:09:47AM +0100, Wang, Yalin wrote: > > > this patch extend the start and end address of initrd to be page > > > aligned, so that we can free all memory including the un-page > > > aligned head or tail page of initrd, if the start or end address of > > > initrd are not page aligned, the page can't be freed by > free_initrd_mem() function. > > > > > > Signed-off-by: Yalin Wang > > > > Acked-by: Catalin Marinas > > > > (as I said, if Russell doesn't have any objections please send the > > patch to his patch system) >=20 > I now have an objection. The patches in the emails were properly formatt= ed. > The patches which were submitted to the patch system (there's two of them > doing the same thing...) are not: >=20 > --- ../kernel.torvalds.git.origin/arch/arm/mm/init.c 2014-09-24 > 16:24:06.863759000 +0800 > +++ arch/arm/mm/init.c 2014-09-24 16:27:11.455456000 +0800 >=20 > This is totally broken. Let's read the patch(1) man page: >=20 > First, patch takes an ordered list of candidate file names as > follows: >=20 > =B7 If the header is that of a context diff, patch takes the old = and > new > file names in the header. A name is ignored if it does not > have > enough slashes to satisfy the -pnum or --strip=3Dnum option. T= he > name > /dev/null is also ignored. >=20 > =B7 If there is an Index: line in the leading garbage and if eit= her > the > old and new names are both absent or if patch is conformin= g > to > POSIX, patch takes the name in the Index: line. >=20 > =B7 For the purpose of the following rules, the candidate file na= mes > are > considered to be in the order (old, new, index), regardless of > the > order that they appear in the header. >=20 > Then patch selects a file name from the candidate list as follows: >=20 > =B7 If some of the named files exist, patch selects the first = name > if > conforming to POSIX, and the best name otherwise. > ... > =B7 If no named files exist, no RCS, ClearCase, Perforce, or SCCS > master > was found, some names are given, patch is not conforming to > POSIX, > and the patch appears to create a file, patch selects the best > name > requiring the creation of the fewest directories. >=20 > =B7 If no file name results from the above heuristics, you are as= ked > for > the name of the file to patch, and patch selects that name. >=20 > ... >=20 > NOTES FOR PATCH SENDERS > There are several things you should bear in mind if you are going = to > be > sending out patches. > ... > If the recipient is supposed to use the -pN option, do not send > output > that looks like this: >=20 > diff -Naur v2.0.29/prog/README prog/README > --- v2.0.29/prog/README Mon Mar 10 15:13:12 1997 > +++ prog/README Mon Mar 17 14:58:22 1997 >=20 > because the two file names have different numbers of slashes, and > dif- > ferent versions of patch interpret the file names differently. > To > avoid confusion, send output that looks like this instead: >=20 > diff -Naur v2.0.29/prog/README v2.0.30/prog/README > --- v2.0.29/prog/README Mon Mar 10 15:13:12 1997 > +++ v2.0.30/prog/README Mon Mar 17 14:58:22 1997 >=20 Got it , I will resend the patch, By the way, how to remove my wrong patch in the patch system ? Thanks -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org