From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C92C433FE for ; Mon, 3 Oct 2022 23:17:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 237E56B0071; Mon, 3 Oct 2022 19:17:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20DF56B0073; Mon, 3 Oct 2022 19:17:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 088726B0074; Mon, 3 Oct 2022 19:17:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EAFD96B0071 for ; Mon, 3 Oct 2022 19:17:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A65F81A0744 for ; Mon, 3 Oct 2022 23:17:56 +0000 (UTC) X-FDA: 79981202952.07.C8EE7E3 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf07.hostedemail.com (Postfix) with ESMTP id 5354540003 for ; Mon, 3 Oct 2022 23:17:56 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id a26so2523325pfg.7 for ; Mon, 03 Oct 2022 16:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date; bh=cF6w9w5X7amibS6REZNPvQpkz6hVdgXqlpPTRgjKOOU=; b=EdhdDGXccvWvAcdeD8lKaCH9Qlu8RC1doJmdQv10fYLzDxDnFHinxgTu7ZVp3hSxnx 2dfOgLm/ifEfE7tWxOlAl5GKBKeSKuZYvVc0MpBJhfSzkBDd0GG5yWXzPHFIoe7Acnvt 7ffe9OYuua1fSTX7G+l97pE2EqOcGDcxfn2KQYiOKfrSwJJhnHYBBJuHHie335oLn9Bt m+YUFW7HRp/FgJISMk4C0UQUCSOq2do0gLRgqQnOHO6z7b6J+zwizQJXckKIiLwzwJ3w UWAG3ka0c3bn9FIFyYNJvkAr6T2/b99u3MwyQy9UlPFZ7rWJKQ2335FNc8tZb0UZ2jLD i5Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=cF6w9w5X7amibS6REZNPvQpkz6hVdgXqlpPTRgjKOOU=; b=xf7OFUf9L/XSDlGH3ZA8S1WYegISy/yjjeGU9Sy8GCf8vHfhR+CCc8X47MSWuHRGPY ou0tV9QFDaq3OiAjk5sS8N+5roqri+JXfp2H6baoiHY3+gPXzR82JJbnIernHm8FXSA1 JRgYT6GeeVIvlOv++8GRYz4oLUTj1Vel+49WDAnd8siuUNLxVkG707Wz5yqOm/cxqW/O Jrr/1ceilum0PpBXhOuqx21nBaPm8oUlWnIBIXLRO1tNAUBuOXvwcyIaWHF2hKAHKYzT bqE/GWCHL5kKJ5V4B5rYN4EZNojilKZlzKwfz1Gv9BugdNNAFqJBWt4jSxiS2bQwVnk+ LTLA== X-Gm-Message-State: ACrzQf3o5tX79XuF3dBbXnCy2bZcLZfAePA26kpRgSOQMQ2bDq9SdZgO aH273u3wMnJ4CKDFc9paaVw= X-Google-Smtp-Source: AMsMyM4n/AJvFE/d3TYFJJYJ4un/v9u7OCLnjbu3wozi/xsNx3IhRWyZCu0U8G5vBhH2rNE3kNGwNQ== X-Received: by 2002:a62:8342:0:b0:560:fea3:f45e with SMTP id h63-20020a628342000000b00560fea3f45emr9606455pfe.45.1664839075037; Mon, 03 Oct 2022 16:17:55 -0700 (PDT) Received: from smtpclient.apple ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id l16-20020a170902f69000b0016c5306917fsm7825144plg.53.2022.10.03.16.17.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2022 16:17:54 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH v2 12/39] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY to _PAGE_COW From: Nadav Amit In-Reply-To: <64313344833c3b1701002a347d539e69276b66fb.camel@intel.com> Date: Mon, 3 Oct 2022 16:17:51 -0700 Cc: "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "jannh@google.com" , "dethoma@microsoft.com" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "bp@alien8.de" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "Yang, Weijiang" , Andy Lutomirski , "pavel@ucw.cz" , "arnd@arndb.de" , "Moreira, Joao" , Thomas Gleixner , "mike.kravetz@oracle.com" , "x86@kernel.org" , "linux-doc@vger.kernel.org" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "mingo@redhat.com" , "Shankar, Ravi V" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Content-Transfer-Encoding: quoted-printable Message-Id: <35EEB9F0-D99A-4664-9628-27029B52CFD1@gmail.com> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-13-rick.p.edgecombe@intel.com> <64313344833c3b1701002a347d539e69276b66fb.camel@intel.com> To: "Edgecombe, Rick P" X-Mailer: Apple Mail (2.3696.120.41.1.1) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664839076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cF6w9w5X7amibS6REZNPvQpkz6hVdgXqlpPTRgjKOOU=; b=ssnNOpQoBGKhEb2n3cvsYMb5nnl5GCDj2sBN9fe9NfRVWEQvzPUsIRCT0nqpmNvl2izO1v dNVjWLvZkupH2yfgbLVgK0jZ32gJXLrtnJcOpGmHeyWf4SDgjJtyvLtvpCNd6bOrOIJ/cW 4HNEIwtzP5t3QMZN6mVaPQZa+AK3VG8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EdhdDGXc; spf=pass (imf07.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664839076; a=rsa-sha256; cv=none; b=oGoJjL/pLAqTtg0ybafsmIZmXW5hB+7e5JBsK1MZaxr1xcTQUTCnvTq3yPv82iAl/7y22M Pq8O1XsB1ZijshLrT9uKU+nftqJcMDIj7mgMLyvyQx3IBvr7sH/zd3F460dvxXhj+kMn78 zjWxfGVhl1A/ymHyqdVrtc5FSQCJCLo= Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EdhdDGXc; spf=pass (imf07.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5354540003 X-Rspam-User: X-Stat-Signature: sx6nkioacswojpeifpy6gxy7467hmy9b X-HE-Tag: 1664839076-319767 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Oct 3, 2022, at 3:28 PM, Edgecombe, Rick P = wrote: > On Mon, 2022-10-03 at 11:11 -0700, Nadav Amit wrote: >> Did you have a look at ptep_set_access_flags() and friends and >> checked they >> do not need to be changed too?=20 >=20 > ptep_set_access_flags() doesn't actually set any additional dirty bits > on x86, so I think it's ok. Are you sure about that? (lost my confidence today so I am hesitant). Looking on insert_pfn(), I see: entry =3D maybe_mkwrite(pte_mkdirty(entry), = vma); if (ptep_set_access_flags(vma, addr, pte, entry, = 1)) ... This appears to set the dirty bit while potentially leaving the = write-bit clear. This is the scenario you want to avoid, no? >> Perhaps you should at least add some >> assertion just to ensure nothing breaks. >=20 > You mean in ptep_set_access_flags()? I think some assertions would be > really great, I'm just not sure where. Yes, on x86=E2=80=99s version of the function.