From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCFDC3ABDA for ; Wed, 14 May 2025 08:50:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDF7C6B0100; Wed, 14 May 2025 04:50:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB5E56B0101; Wed, 14 May 2025 04:50:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2FB56B0102; Wed, 14 May 2025 04:50:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 95B686B0100 for ; Wed, 14 May 2025 04:50:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E110012096C for ; Wed, 14 May 2025 08:50:05 +0000 (UTC) X-FDA: 83440891170.21.60E3416 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 5D3EF40003 for ; Wed, 14 May 2025 08:50:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IrmkGGU0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747212603; a=rsa-sha256; cv=none; b=kMwbsREL0lGui51EIvtaqgskBDiQz2uan2txknocE2TwL8a1VL89j96D1TDCq4jxBGchcy 2KHJtdACdYwchxTW2/vA1eskp8LOsLHPTV3S3j4CEEEFyOxN+uJ10/AYqmE4cYrGtsPVeO sQkCYEMpWip+pPZyL4O1n/SmtFZMHV8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IrmkGGU0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747212603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGCYzGq+10U52uzl5GrK9QGPWD9+panpGcBnB5BqM6M=; b=M8VkmogoVF3t1aHeyp5GfWj59BuzAlKgqtVXZ4leZbtgLD2c2O48zJG2ksrTAP9nFej/sb 663uPWo2kQnMeaFe9AC3OwBB+mb3OJm3H91333oce97sKkzgjdwpOtOgYFA8Z7HeXAmy6R TZF3oLAS/SGHgzcpwpC41dYzQtihOYA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747212602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XGCYzGq+10U52uzl5GrK9QGPWD9+panpGcBnB5BqM6M=; b=IrmkGGU03UbzRTe8sV8iYhYuepN4V4fHuo/NXMkwpEB/nlD8le2MbM4a90BCepS9NFvNNH vzpObk01kvze/alzRvq1zHgEC9+zunRwOj4vGdAl+MHewm0kqMKDw8fB6YXZLmrv9HFCQt 40ha7sHQSHkW/B/2U+wn7OfjIMqQlBc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-H91Wfv2XNOOWhhyx2Pdisg-1; Wed, 14 May 2025 04:50:01 -0400 X-MC-Unique: H91Wfv2XNOOWhhyx2Pdisg-1 X-Mimecast-MFC-AGG-ID: H91Wfv2XNOOWhhyx2Pdisg_1747212600 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-442e0e6eb84so24359255e9.0 for ; Wed, 14 May 2025 01:50:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747212600; x=1747817400; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XGCYzGq+10U52uzl5GrK9QGPWD9+panpGcBnB5BqM6M=; b=lNeyFfOe5BT1GXO//HG/nsaNZ4KeK4lASyltGcaP5Z+I/kLl+SlexYYaS7AxNXFuBu TyFp+GUdCn/HAE+qlmyVD1Sb2SWn7umr/AJihI1FDyo8CCmXe2sMuiuaJKgxXbyoX+Zm W7sBB9FZ4AvZEYnq2EcensqxgbJNYmoIB52BaXH1XA4LH6HYbAZ5tjScs+rfNO0bZFo4 OA0fzdv8lQ4iW2NoLsZ8POUnBr2GE8gIDHJw+YMIOuYSuJRSiEWUpYcQaN9l8fyrrlmA mWh/Bt43UhbYEu+acVsl1mcAG9ccOZjEIiXnoUEg3+NbakRRIDMRfT4x3/rEfx6+zzrd LwDA== X-Forwarded-Encrypted: i=1; AJvYcCUei7//tYR5JVmQp4BkjJ6sbcBSGesuFrW+MdTsuMbJ73cYHJqCP92ka+T/phrmUQu2MNXhiCvV3w==@kvack.org X-Gm-Message-State: AOJu0YxmZjMxVGmdf9uwmIajFJOVgfjG03mMic94izGt+71Qv8CixSYT YwM+UDN+JjMCbWarC+AVYYHLIasLL7k3QHSqrzNRtP172MipIpjY5ET7DrTqU+BCC3t5fzdgDSa xJ/iFmSyirMnXC1SS2/9u+Wapfh4Z38XMrwIoweCRkj7rl9ph X-Gm-Gg: ASbGncuKhU99949FA2Tgo7/TxbhjZnbPhEx+/DQXgK0oPwaviHiIVtKyy5YWav3t5n4 HuZy0ZvdSn+10T3WNvKX+tMpO0pQnM8PPM8oF72W32VZ8GS/w1dMMVrkKqcuw0xKOJ30iXsjHVc Pbm7GoWwj4K+xajGWCrL3QSWDN2vMe240wkzHYEWOSfKPr5HdT1zTA8RnQgalIZWQwOf+h+Qzuw NhsYF0bg57hKbGuyy7ogSO8tog+5g7B72mhJASQvdHzJ3n1JNL006G6gJ+w76+VbvNLRucYrh59 Sa+vZkv91lioZqbeY845xeh3Uo7YuPOWwbyqfGJl3GvqZPKfpBO43MyYsR3T8dVZ1WTTk7zEDeB Wl794lqyBhZoKa2EjFSIVfxpsez2TZrScUt+lZtI= X-Received: by 2002:a05:600c:4f45:b0:440:6a37:be09 with SMTP id 5b1f17b1804b1-442f210dd4bmr22236955e9.16.1747212600031; Wed, 14 May 2025 01:50:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqK/FLQvs6m1u6MPRybA3SYVWQ7b8xgB1l5R/aMzznMPMuEHXl7NkRRFQ8qBzehy5+ltlr+Q== X-Received: by 2002:a05:600c:4f45:b0:440:6a37:be09 with SMTP id 5b1f17b1804b1-442f210dd4bmr22236685e9.16.1747212599683; Wed, 14 May 2025 01:49:59 -0700 (PDT) Received: from ?IPV6:2003:d8:2f15:6200:d485:1bcd:d708:f5df? (p200300d82f156200d4851bcdd708f5df.dip0.t-ipconnect.de. [2003:d8:2f15:6200:d485:1bcd:d708:f5df]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f57ddfbesm19239910f8f.10.2025.05.14.01.49.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 01:49:59 -0700 (PDT) Message-ID: <357de3b3-6f70-49c4-87d4-f6e38e7bec11@redhat.com> Date: Wed, 14 May 2025 10:49:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove WARN_ON_ONCE() in file_has_valid_mmap_hooks() To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox References: <20250514084024.29148-1-lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250514084024.29148-1-lorenzo.stoakes@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fkx9ujL2LLNnZPUBGLaHoAn299hfEQWY2sKAJjR-NPw_1747212600 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: m6eh83rn8m6kc8e5oxoji5s78689jbaj X-Rspam-User: X-Rspamd-Queue-Id: 5D3EF40003 X-Rspamd-Server: rspam06 X-HE-Tag: 1747212603-556304 X-HE-Meta: U2FsdGVkX18pcSQySJujwz7rEKDqq/LJziMLhDoXAknfKOOuUElPIKUDTYfB45Sdz7ftVsnj5AsqCWgR3gc3JymbKGqkwqYjrUYr+XPwDy/YKSXgVmAo8fIk08sddihCb1fgFK/t6Gltxja8KpkKdhVijpA0MfIN2GzqC4phDw7l0qvoSfL1rmmkTqf8P3Hfnk7v+/OEp49s8z0S5o0UJwBU597OqfQvlFyiGPYHA4Ylj2VGbKYto/nYpV+DhGoSki0hGooJ9QO1rpooMDc0TOmm+7mNZlqrgRt/CrD835DpO4ekPEEXTqu22vDdtuMjZIMqB8r6TjdMltAzd3fTyLAMr/iPrHiOdvRMQ8J8wuMezFiRJ6Pz8BNf2Hi85hqzgqEMbj13a0lIL7r+AaUrKRrRTwdvR/C0GUWIcwxi/NT71SHNIM8sR7DmESYDDe5jAze5hK1Kfci/UNjkZS6sgsLrhe6vyhXmnbk8vm34lvMsQiFQe5H5UslAF3Pn+4NRt9yWc7qHyaHpytn7RK5/HtfbXPYMy6RGE7hsXAUJFHzyvqy+mz3JJYedaUpYInhTcG5Kt8qkxJQ/H/UWikOT6YXaiCa2a5GRhuhlSdWvljA5/wvIfPtXQLzewXY/zLUuDDdcrU7YnrvCbkgsvwEaW+4AKj30FQLPNHhJHa2IiBRZfM1l097ng6Ke+MKrbcvy8FhhQYdqiECfJWGei1MWrE9lxV9tRrJPYQdofECujk8ZbJ4biJb930IQRAzSjLyLffTglvmFEj73vAPxbuNWM42DHsQwXWd3qKur9/1PK0DsWzr8qDR59C2Tt2HdiGetZiUyo7ZQgFGwBjTbyj8W3u7FxUJpJfBuAAkEq87Xpp11KOHpvgXPbPna5pTpYAQBwzA8oMfrPuUk5kkv3MBPqFNIl+wJJPII+6DW4ttsR1XP7slL0ls1lH9XpDMRrc4txwo92T+96fafughldza 96eqtYN0 u2QOO8HAHIYrVvzJ15pZTSANpahKEWw8xv2H8E9nXp57ZVBTMAZ71E84MhRWMK3vcV/XxC0RA7zENpmtdGyyIQ39Aev7VJ/s3pe1AzzI+72659PqF3PtzdapQWV+NiosEZkPgChV0fHXsR3Ptvm/XVs3LbDQRLc6unNO9EWKqkz1yNDjul1nULZAVepyB9mMwog1YzK278FnjOEfz9jWmIZiRyKnX/Ru5Nm0wFk6t/xbEBtG1FjVF4ubpNGztbePJVYc+uYa2OJKEvfhvjGX2T30tfXj7RhAuu+TW3mwbLyYYS4hpuDtH0BrrlWNmJbenlFJgEQihxdAi3KGLWPconoo9JxQqs/MwuSG3TRYGQ63ZLuAMSe85byjN3UIja3s1nX3m0+NgFgLA+SEKqF5tRZZVRw3Hgj0UiG+btp/U/hZmnDMbXeQl4H+ZKKYZg8Maqb8YJoUpevxqDQvbAw1E4A7EjeUaHSP0uNiFCBETSAdWjtYn2XZNvwl25B5sMvmiOXk/HW2YrdVNadG3loWGRU1h+CW6NmS0foNQVkLTNYSTUzo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.05.25 10:40, Lorenzo Stoakes wrote: > Having encountered a trinity report in linux-next (Linked in the 'Closes' > tag) it appears that there are legitimate situations where a file-backed > mapping can be acquired but no file->f_op->mmap or file->f_op->mmap_prepare > is set, at which point do_mmap() should simply error out with -ENODEV. > > Since previously we did not warn in this scenario and it appears we rely > upon this, restore this situation, while retaining a WARN_ON_ONCE() for the > case where both are set, which is absolutely incorrect and must be > addressed and thus always requires a warning. > > If further work is required to chase down precisely what is causing this, > then we can later restore this, but it makes no sense to hold up this > series to do so, as this is existing and apparently expected behaviour. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202505141434.96ce5e5d-lkp@intel.com > Signed-off-by: Lorenzo Stoakes > --- > > Andrew - > > Since this series is in mm-stable we should take this fix there asap (and > certainly get it to -next to fix any further error reports). I didn't know > whether it was best for it to be a fix-patch or not, so have sent > separately so you can best determine what to do with it :) A couple more days in mm-unstable probably wouldn't have hurt here, especially given that I recall reviewing + seeing review yesterday? Fixes: c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file callback") Acked-by: David Hildenbrand -- Cheers, David / dhildenb