From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECDACD5AE6B for ; Thu, 7 Nov 2024 06:47:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 525E96B008C; Thu, 7 Nov 2024 01:47:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D60C6B0098; Thu, 7 Nov 2024 01:47:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39D536B0099; Thu, 7 Nov 2024 01:47:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1BCDE6B008C for ; Thu, 7 Nov 2024 01:47:36 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B51A212047C for ; Thu, 7 Nov 2024 06:47:35 +0000 (UTC) X-FDA: 82758367062.12.A156C94 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf03.hostedemail.com (Postfix) with ESMTP id 9A6A82000E for ; Thu, 7 Nov 2024 06:47:16 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XVw1F93I; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730961884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s4sYJYVbNn+8nZHewUYqHaSq6iJqGNPs8Z77SlmIpAU=; b=gX2P3kb17Nv4A3GC3tV9EXJLC4uqIIycm5l7wpcg86oobsOiL+y+iFLNCDWID74mYQd/jG Ww7pIsl1Csw66QIgWvYSbASkuDHdu0yV3e8B2zHrKMKX3P7fPcD2NGadhXtMx6WfQIViy1 ptkohxG81TWVYBu0IBYEmjiECY7uQCs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XVw1F93I; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730961884; a=rsa-sha256; cv=none; b=3BedYEYxCVC8ntXYSJBrqnp0MmDD/J2lOcIkKlX+DvkNDvEnYl+CZKdCZW/sKXxmlIi9b0 hNZCvC7/Lc8Bjbjt8HQWZbGFHGte+lrQCfdBAak+Cf6+hhn3mgNYYNXGFsDtVexDXAiH9A 0a1dSnZ48HEcU1jYwJ83ZympruyiY1I= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-72041ff06a0so471201b3a.2 for ; Wed, 06 Nov 2024 22:47:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1730962051; x=1731566851; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s4sYJYVbNn+8nZHewUYqHaSq6iJqGNPs8Z77SlmIpAU=; b=XVw1F93ISZSRAn4AqP4opKapK97L/V+s2wKvh/37dQav9hHP6rbkzY1r3teRh9mSLv snxGh27OAhWVMnD2a5YOW6koPct0Ur0NzkcCHvwEqpd23vWs/W8sAXF4e2sDsJMbdTtS 9CX/PHxPPh/vVicELyTgtToK/AC3/kinPnL+IGFf4vC7BRUz5OttQeZdah0uZ+gY3aA6 qgjhF6hgxnklfNqL20RyrVdQ8SKo6fc22gV0laWkFnuPW/latgpTjj6Fzt74ZbwmvF2a Zf4K+0IcnH2hSbbfnX+pfIbc4sscouv/sYaXoi0rgy3bRdlGjRu36VrBYUqCAEOVOpiu Cq7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730962051; x=1731566851; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s4sYJYVbNn+8nZHewUYqHaSq6iJqGNPs8Z77SlmIpAU=; b=r7Bt2xVKnVst+PtdSJoodnNOt7fQY9EQWbAcC48iPqyZlNfkAuNoY4Emp2RsOS7psT vj/Kubb/97tbTOTuqdIT9qkWr+I9IolrlZe/hrOuAxy0T45t8F9319xXpf3qmhl4n5bV DG/tuiUTGjYIMZGiaHZJgV7dSM8gd/wXqtiJ8vCg0a6xIqmnSWv24OM8t3ausLgf7xZu eFPIIFN2ZcMQm6e7vxRUYn/aHX81KgWs9awXYytgu5ypIJgntE9/BJYg+iHje5evMUbV TFlgib9ZcRw0CL8F45kirOIoWGYk0mfg2aYWAXnW5dvNMXLSCjPQQ6XCQCLGf7CbQ6ao iNtw== X-Forwarded-Encrypted: i=1; AJvYcCWXUMaY1IMxVmxyPHPN5yJlm7+4jlWToNezvtZZXExWS1gJuWUzMQI4mY69Zls7RSOsaF3mirCTig==@kvack.org X-Gm-Message-State: AOJu0YxwWbyNdEshQ9shUbkuxfe2rhX6nyheMs0osmw8vot2f8410ULJ ZNiEykmvE3jn8Ja05Zg4VA9gz++cHRH65NjB66tSGvPoGVv2IlSWWDbq2KN1ihw= X-Google-Smtp-Source: AGHT+IGp00cwnqhnTxAKDFFNKj94JDLmBpGJ7s9/Sh6DkVmQYzY5A32qRipE+c1ujUWd9JYadTCp2w== X-Received: by 2002:a05:6a00:3917:b0:71d:e93e:f542 with SMTP id d2e1a72fcca58-720c9990c4amr28075226b3a.21.1730962051155; Wed, 06 Nov 2024 22:47:31 -0800 (PST) Received: from [10.84.149.95] ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724078ce169sm722303b3a.86.2024.11.06.22.47.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Nov 2024 22:47:30 -0800 (PST) Message-ID: <356ef11a-02aa-4661-b8af-4c72cef5c9b5@bytedance.com> Date: Thu, 7 Nov 2024 14:47:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] docs/mm: add VMA locks documentation Content-Language: en-US To: Lorenzo Stoakes Cc: Jann Horn , Jonathan Corbet , Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Alice Ryhl , Boqun Feng , Matthew Wilcox , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Suren Baghdasaryan , "open list:DOCUMENTATION" References: <20241101185033.131880-1-lorenzo.stoakes@oracle.com> <2bf6329e-eb3b-4c5e-bd3a-b519eefffd63@lucifer.local> <5969f498-a515-4394-a2b6-5d3abe2872aa@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9A6A82000E X-Stat-Signature: 3szoyrbe336w3ba9g6cdpfzjwr4xm5ho X-Rspam-User: X-HE-Tag: 1730962036-404297 X-HE-Meta: U2FsdGVkX1+wpIyuTlDABMZX8HAPwFdMo/wJCXDtipE704ClN0jwXNmi7cNQPMJbcQP/q3lYOVU0mlNEjC6EFRFRolieKTxxEBYJ3QG5KC+WTH7ElqWi19VvwhQiyg0AmJuXrZsXgg9fbiIMcctn43bZuFMFDInuWw6uDHM38envXaTeuEnfc2zFa9CAaP4lVPxjbKPmxw5aZhIsb1fWcPq+B9zT+S1OAhWiUUJ5oLzmqH1+y/oh+5alVfvSwW0gINabduG8QOYweqr+GiXy0WtRueY9fiH1KUWBHa8bemOnTVroxgDVEH2gxjtLRBoA/9vFm/glc0jwT+tNUU/tyRW9nxM1IXYdEirdwWrQ1Hc/m+Zii+L3okstmIzc6lmVTaGiXItEH53GXkFSvH03ORY9TBB2WQYtRTxQ0dq7INHl/c28IEq2jrfhrwzCqMVUVwp6+/jO7V2DmdSMOzZl3rxPimP5jld8BRBQNqSbhiuG1QETSLtJgU0sw/Mtida+iSvNvlV0IjwHFNRYmspKLmfqArD47G6Od0bCJ5YDqWXMb+JSka6BqpAGL1MBha6rbJWcsfW+qbONmA1TQvd7Bu6YAqv5KGLyrNgylr7bz/PAP2RSuMh7RWFgzM2iceEe17F5szDLGBCOiRq3yUE4uTbhtV8NJ5rkB9aVITcPU5n9CpGtFrY+8VkWd27YLn6ORozJKel6YCAeS1X9Gs0yjJMlcH2D2T83noM0tKdQrDaIcHLEMVM6VIEQxdjDu1NNEwD9O0BMFuohw4XjRKGFm/WiAjX03j0Sul+qYq5KD5Zc0ajY9VCMUGwMe5OcIR6nu8HMQX2GdJSEhj2/IvqcmufYl0Vz4JDCc2PvbW/tZ5UpMlRk5M5Ubu6bCbKKpkvxoM5tsjeSQncuh9cIli+uT0Ls1wiHLifHsf60u0fjTZogstEaRacvlQ2I287yTNs9kZtkjsBqxXN96nM0yWa NpxGmxSC KdR1FjXkX89QiRWZWgk/qBHej6dclj4gGDOCubhpEV2M5i6RSeEXXjVDlw808+hQzNNzmBUpCYjn1q3X+KwCfkuYTKSQbJCyrrc0HV4TWSFxArH20O3klejag0GJ/i7ywWrs9W1T0Uwlp664zmRmhMiNPIKBCLUT1h4vx/SxUfx8Rggt/Tk55Y0Qcvt3kuZf9Kul9ryp3WEZPI5KIDg791ow0JTH3fsS6hrfU66bdhySHboYJDX0zXkwoC249esc3rRdzOywI246FTBRGeVth786G4mfasqX6HxEixQ+4FZiBCl3TTvz9oENAAkCe50LAEc236GXvBgc7eCV/PAp24zOgBqxvnt5orSbSeDsulwY7a0pFAG+LWP7aFrk1K+4AbesitiBLJKZaiKXT/j3DJ2Zmbh3H88V5t7Vikw0UmSq3ftImh2YwO3opoEwhb81o+DzuFht8tEZahx4R1Ih/6JjC+TipBI5nlWHZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/11/6 19:28, Lorenzo Stoakes wrote: > On Wed, Nov 06, 2024 at 10:56:29AM +0800, Qi Zheng wrote: >> >> >> On 2024/11/5 00:42, Lorenzo Stoakes wrote: >>> On Sat, Nov 02, 2024 at 02:45:35AM +0100, Jann Horn wrote: >>>> On Fri, Nov 1, 2024 at 7:50 PM Lorenzo Stoakes >> >> [...] >> >>>>> + >>>>> +Page table locks >>>>> +---------------- >> >> Many thanks to Lorenzo for documenting page table locks! This is really >> needed. And at a glance, I agree with Jann's additions. > > Thanks! > > Will be respinning with all comments taken into account relatively soon. > >> >>>> >>>> (except last-level page tables: khugepaged already deletes those for >>>> file mappings without using the mmap lock at all in >>>> retract_page_tables(), and there is a pending series that will do the >>>> same with page tables in other VMAs too, see >>>> ) >> >> Thanks to Jann for mentioning this series, I just updated it to v2 >> recently: >> >> https://lore.kernel.org/lkml/cover.1730360798.git.zhengqi.arch@bytedance.com/ > > Yeah I need to read through a little bit as I was unaware of these paths (mm is > a big and sprawling subsystem more so than one might expect... :) > > Could you cc- me on any respin, as at least an interested observer? Thanks! Sure, will cc- you in the next version. ;) > >> >>> >>> Ugh wut OK haha. Will look into this. >> >> Thanks! >> > > :>)