From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61053C432BE for ; Fri, 13 Aug 2021 10:15:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F200B60F21 for ; Fri, 13 Aug 2021 10:15:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F200B60F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7866A6B006C; Fri, 13 Aug 2021 06:15:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7360D6B0071; Fri, 13 Aug 2021 06:15:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64C568D0001; Fri, 13 Aug 2021 06:15:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 482A86B006C for ; Fri, 13 Aug 2021 06:15:16 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E06F318023875 for ; Fri, 13 Aug 2021 10:15:15 +0000 (UTC) X-FDA: 78469649790.08.1617EFF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 8946E300E558 for ; Fri, 13 Aug 2021 10:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628849714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aczmwnkPDpm5Nf6klh4qkwlPCGDJuD/VAUZqmda05wo=; b=QnhtCVJHhHNSGJk67fe8IT4AYRoTD0S3lVLQkbrGQdxWtbT1iHXiB+LHqmlTF0G4wyfsU5 A2C9wcbLl16NFHTnV+e8HLJW8Kv4JGnQE0CLFToz+I9NIxBCWlcMKNhSuYd2yNgggx+mge vISZhrWrQTPGsU/Aypbxr3WFhJTNvMQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-5neowFxsNJKluUZp8Yv30w-1; Fri, 13 Aug 2021 06:15:13 -0400 X-MC-Unique: 5neowFxsNJKluUZp8Yv30w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D1838042EB; Fri, 13 Aug 2021 10:15:12 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id C3D355D9D5; Fri, 13 Aug 2021 10:15:11 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <162880453171.3369675.3704943108660112470.stgit@warthog.procyon.org.uk> References: <162880453171.3369675.3704943108660112470.stgit@warthog.procyon.org.uk> To: willy@infradead.org Cc: dhowells@redhat.com, linux-mm@kvack.org Subject: Re: [RFC PATCH] folio: Add a function to get the host inode for a folio MIME-Version: 1.0 Date: Fri, 13 Aug 2021 11:15:10 +0100 Message-ID: <3565083.1628849710@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-ID: <3565082.1628849710.1@warthog.procyon.org.uk> Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QnhtCVJH; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf03.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: frrdhymuz63g1squrrxijqnr6sofq3gk X-Rspamd-Queue-Id: 8946E300E558 X-Rspamd-Server: rspam05 X-HE-Tag: 1628849715-914472 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Howells wrote: > +static inline struct inode *folio_inode(struct folio *folio) > +{ > + return folio_mapping(folio)->host; > +} I've changed my mind on how I implemented it. I think that if this is intended to be used from within filesystems, then it should be calling folio_file_mapping() instead - or possibly just doing folio->mapping->host. folio_mapping() seems unnecessarily complex for a page a filesystem is pretty sure belongs to it. David