linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Honggyu Kim <honggyu.kim@sk.com>
To: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: kernel_team@skhynix.com, damon@lists.linux.dev,
	kernel-team@meta.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH 1/2] mm/damon/Kconfig: set DAMON_{VADDR,PADDR,SYSFS} default to DAMON
Date: Thu, 22 May 2025 14:54:33 +0900	[thread overview]
Message-ID: <35593bd8-85db-4490-9f18-9d9674d5c6e1@sk.com> (raw)
In-Reply-To: <20250521042755.39653-2-sj@kernel.org>

Hi SeongJae,

This is the patch I was waiting for.  Since enabling DAMON build doesn't
directly impact the kernel behaviors as it is disabled by default.

On 5/21/2025 1:27 PM, SeongJae Park wrote:
> DAMON_{VADDR,PADDR,SYSFS} are de-facto essential parts of DAMON for
> normal usages.  Because those need to be enabled one by one, however,
> and there are other test-purpose or non-essential configurations, it is
> easy to be confused and make mistakes at setup.  Make the essential
> configurations default to CONFIG_DAMON, so that those can be enabled by
> default with a single change.
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
>   mm/damon/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
> index c213cf8b5638..c93d0c56b963 100644
> --- a/mm/damon/Kconfig
> +++ b/mm/damon/Kconfig
> @@ -28,6 +28,7 @@ config DAMON_VADDR
>   	bool "Data access monitoring operations for virtual address spaces"
>   	depends on DAMON && MMU
>   	select PAGE_IDLE_FLAG
> +	default DAMON
>   	help
>   	  This builds the default data access monitoring operations for DAMON
>   	  that work for virtual address spaces.
> @@ -36,6 +37,7 @@ config DAMON_PADDR
>   	bool "Data access monitoring operations for the physical address space"
>   	depends on DAMON && MMU
>   	select PAGE_IDLE_FLAG
> +	default DAMON
>   	help
>   	  This builds the default data access monitoring operations for DAMON
>   	  that works for the physical address space.
> @@ -55,6 +57,7 @@ config DAMON_VADDR_KUNIT_TEST
>   config DAMON_SYSFS
>   	bool "DAMON sysfs interface"
>   	depends on DAMON && SYSFS
> +	default DAMON
>   	help
>   	  This builds the sysfs interface for DAMON.  The user space can use
>   	  the interface for arbitrary data access monitoring.

I'm not sure if I'm elighble to ack your patch, but I would like to add

	Acked-by: Honggyu Kim <honggyu.kim@sk.com>

Thanks,
Honggyu


  reply	other threads:[~2025-05-22  5:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21  4:27 [PATCH 0/2] mm/damon: build-enable essential DAMON components by default SeongJae Park
2025-05-21  4:27 ` [PATCH 1/2] mm/damon/Kconfig: set DAMON_{VADDR,PADDR,SYSFS} default to DAMON SeongJae Park
2025-05-22  5:54   ` Honggyu Kim [this message]
2025-05-22 17:10     ` SeongJae Park
2025-05-21  4:27 ` [PATCH 2/2] mm/damon/Kconfig: enable CONFIG_DAMON by default SeongJae Park
2025-05-22  5:55   ` Honggyu Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35593bd8-85db-4490-9f18-9d9674d5c6e1@sk.com \
    --to=honggyu.kim@sk.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=kernel-team@meta.com \
    --cc=kernel_team@skhynix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox