From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6D4C28CF5 for ; Wed, 26 Jan 2022 06:29:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42DE36B0074; Wed, 26 Jan 2022 01:29:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DDEA6B0075; Wed, 26 Jan 2022 01:29:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CC496B0078; Wed, 26 Jan 2022 01:29:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 191346B0074 for ; Wed, 26 Jan 2022 01:29:49 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CF5649009F for ; Wed, 26 Jan 2022 06:29:48 +0000 (UTC) X-FDA: 79071462456.24.DD7C775 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf01.hostedemail.com (Postfix) with ESMTP id 78BD440004 for ; Wed, 26 Jan 2022 06:29:48 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id l24-20020a17090aec1800b001b55738f633so2566701pjy.1 for ; Tue, 25 Jan 2022 22:29:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=f8frVsVREroL3Vl0pIdy9j6ct69/Sw7kT8s/BIn1OP0=; b=gy5tGnViW/Q6q8SpmvwPsZUbEzrCa2iw8BwV+Kr4swwgu1E6FOCgAuJmkdStBznndg 9cjW4qvwSkTsmGt0KtXmdyu1dCO04aWArje9PMSy/oq7zV2ucYXI9j68aM84xAvGCbTo zcsRf1WDSZSv2shyzfX/GGDWkshjlW8hPBNBla4pRVRsz2IhqE8nQrdZnQ1ME5Ce0Jec IHy6WYuQCKY3QEZpQMVBC8YfvDpGVxYeRIgK5K/Hih56TRQParsBGng7Lk5mzhpvD06p xOpgMwAUDztxP5zUB1GOUNbaS47FqViQysx1Xohj7LbAuCa1xZdVsx2TBS2RcjvePdG8 hPWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=f8frVsVREroL3Vl0pIdy9j6ct69/Sw7kT8s/BIn1OP0=; b=0deBlLKabs8Cg6YMGCtyk28pdNgVQ9PcsaZkO9bPAFXBZ9LYRrP1AKOd1zjjX9PVyn QHUW/b0FzhmAYSPNNxXSrToUeufLWjWF9mi0IOALvuG7zi98S1SVSTznfkR442mAmmNK xLUHu/DTmi3DwuPKg60eys5uH3prFmJGBN6GdS41kyZ2MTktLJO2hEJ8Mz6nahD5dpFM ci9jYsN5nAfECcgJGrLW56v/Po6oJLmnL+9TBYcyBmOKnJASE1izKgKiO3dXOxRpjoDb vRAIIkyNSXIx/ca09IXQbn5vgbbgIVBXhETuofZ0+If1TYvOyEV3W+cVL49ejWio0jyw ia5Q== X-Gm-Message-State: AOAM532d9zt07VNfxALyh+gikfUXUxKQr3DUE8aOYHj4AV7U4yZWH7Gx VnXCXhPVEgQrZ9HVikq3Zd6BlQ== X-Google-Smtp-Source: ABdhPJzY3OgX15h2i/8uaHpXMIoN0rhfEE21wgImuXokndNRSLyyzAsTE9pd6eFD/b/jNH0mn8hjRg== X-Received: by 2002:a17:902:be18:b0:14a:aef3:af2a with SMTP id r24-20020a170902be1800b0014aaef3af2amr21354312pls.25.1643178587225; Tue, 25 Jan 2022 22:29:47 -0800 (PST) Received: from [2620:15c:29:204:6f7a:fc02:d37c:a8b0] ([2620:15c:29:204:6f7a:fc02:d37c:a8b0]) by smtp.gmail.com with ESMTPSA id t3sm929149pfg.28.2022.01.25.22.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 22:29:46 -0800 (PST) Date: Tue, 25 Jan 2022 22:29:45 -0800 (PST) From: David Rientjes To: Pasha Tatashin cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, pjt@google.com, weixugc@google.com, gthelen@google.com, mingo@redhat.com, will@kernel.org, rppt@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, aneesh.kumar@linux.ibm.com, jirislaby@kernel.org, songmuchun@bytedance.com, qydwhotmail@gmail.com, hughd@google.com, ziy@nvidia.com, anshuman.khandual@arm.com Subject: Re: [PATCH v3 2/4] mm/page_table_check: use unsigned long for page counters and cleanup In-Reply-To: <20220126060514.1574935-3-pasha.tatashin@soleen.com> Message-ID: <3554d255-dc76-c4a1-e2a1-f110f1e2c7b5@google.com> References: <20220126060514.1574935-1-pasha.tatashin@soleen.com> <20220126060514.1574935-3-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 78BD440004 X-Stat-Signature: e8gzu1qrdozmam6gc9nngdomsejrrjnb Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=gy5tGnVi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of rientjes@google.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=rientjes@google.com X-Rspam-User: nil X-HE-Tag: 1643178588-655568 X-Bogosity: Ham, tests=bogofilter, spamicity=0.014013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 26 Jan 2022, Pasha Tatashin wrote: > For the consistency, use "unsigned long" for all page counters. > > Also, reduce code duplication by calling > __page_table_check_*_clear() from __page_table_check_*_set() functions. > > Signed-off-by: Pasha Tatashin > Reviewed-by: Wei Xu Acked-by: David Rientjes