From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC1AC3DA5D for ; Fri, 19 Jul 2024 08:29:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E25806B0088; Fri, 19 Jul 2024 04:29:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DADF26B0089; Fri, 19 Jul 2024 04:29:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD9B96B008C; Fri, 19 Jul 2024 04:29:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9B8496B0088 for ; Fri, 19 Jul 2024 04:29:26 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4798DA22A1 for ; Fri, 19 Jul 2024 08:29:26 +0000 (UTC) X-FDA: 82355827932.16.2CC23E4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 1117BA0019 for ; Fri, 19 Jul 2024 08:29:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P3gYQDIs; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721377722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mEvURRuXIQlOojLd3hkXa2g29GkpFSOYGY/bvxncEiI=; b=Pi0KTZ7Zi5gRIXwVu+R1pW2XAgz4M2TZ50OB1gfc15e81GadetioyC9W7eQLarPUtKnTLf rYDJl+ehFsUDvqpihwYyKJ1kfwuzBhYOVAiEvuhF2Ac4lZbEyWmx4UlOLpLR/o0gviFJ5K Ry1wVAkjDey4Eu4zwlxaShY0tLwsC0w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721377722; a=rsa-sha256; cv=none; b=hkddlZ0eMkWjFOoxXBM7WT3Efq4A+zY0zsqqMJiLYmL3aB1BSLNNWgkkjSEk2IZpF0OQBN cHBHLksxSHbvnULIjSzi3V3ZupLu90z4J84qzHtD02kmMGKfWx44lFI3HuDyMIbYQfT3f5 x5wQ2K34D05C7WWFxwDRWTavki3taOU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P3gYQDIs; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721377763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mEvURRuXIQlOojLd3hkXa2g29GkpFSOYGY/bvxncEiI=; b=P3gYQDIsUILwEUr77zY7FRWEEc4ReX/wQ4WbdUyVBOk2LcDOMGatNB6u6qhUJHyFjEireX /6aTRmn0mYjmf05HcuYouzhBI/yEKCx3WnUSHHBvaOWbHPkLLiI7pKn1CF70nPwVVhOa7u HO0S09UEKARykDUw2dEIfO1gdO5Yoz4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-ybGSHbD-Mnil4Zhy78g9yg-1; Fri, 19 Jul 2024 04:29:21 -0400 X-MC-Unique: ybGSHbD-Mnil4Zhy78g9yg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-427d7263682so3252825e9.3 for ; Fri, 19 Jul 2024 01:29:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721377760; x=1721982560; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mEvURRuXIQlOojLd3hkXa2g29GkpFSOYGY/bvxncEiI=; b=jSV0HqoqOnziGGdTiCmusPIkOotOm8rcwNS1G4skJHLr+mRGLaVixQmqDROmKodJtk 5fgTCAuO2Qkrmk4sYWUDiggGadXgP6YVm221+6a/C5IbElBowxrKDStIiMFWzkXXAYJs HBbg3su/uuGLoim94lVQF1yHlkWTkf3In5tXmyjiwJ07zX7Om7BQ87v9CNDqMbkoIgBG clqbImVrhPUqWT45+ecbVDRCvy40zEOJ0Ocwva1MEB6+3IJZW5I4J4JDCOFj3UQO2gs+ UUgZ1JnZpbnVmVd0aZl1803+TGvH4NW6ZOpHCsl2PqVCRddANOiCxGkwGBFvCF3Wjx/m SSkA== X-Forwarded-Encrypted: i=1; AJvYcCVuDt5IUlVgVhe8NvTHPuCPd880kam7ljWe+wAZK+wm64Rhxfegjwv+acTd7qv1b9dvKdgfBP/BpfUQ6YF861UpDAk= X-Gm-Message-State: AOJu0YxhxmYy4YGenVPaixng9LovSVVAlgtUcmmy6OQHYCnSHdPI2t3h YG3vtYmz1KBAaQaNy7WLm7eDy8FuGV3lYKC+VsQUVNel4f6dOH+jlaTWRa6TXECWvivqMLQ1HaG FjLaqDZHMPM4QAU8GKrq5L2ycAtUAWSqFoaiN1iOI+KaGDV3Q X-Received: by 2002:a05:600c:310c:b0:427:9dad:e6ac with SMTP id 5b1f17b1804b1-427c2d0bfccmr55859565e9.34.1721377760461; Fri, 19 Jul 2024 01:29:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1edBeEIkR/q4EqHK7aqXX0vmgXSP/PkUzbHsdU4iz0wEMQf6PafOjyNLNtMF8SP4cU7eyJw== X-Received: by 2002:a05:600c:310c:b0:427:9dad:e6ac with SMTP id 5b1f17b1804b1-427c2d0bfccmr55859385e9.34.1721377760041; Fri, 19 Jul 2024 01:29:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:1000:c4af:a24f:b8ba:8bbc? (p200300cbc7051000c4afa24fb8ba8bbc.dip0.t-ipconnect.de. [2003:cb:c705:1000:c4af:a24f:b8ba:8bbc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d6936e1esm15687055e9.44.2024.07.19.01.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jul 2024 01:29:19 -0700 (PDT) Message-ID: <3551520d-d81d-40d7-8651-f55e642d24dc@redhat.com> Date: Fri, 19 Jul 2024 10:29:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 3/4] mm: Override mTHP "enabled" defaults at kernel cmdline To: Barry Song , Ryan Roberts Cc: Andrew Morton , Hugh Dickins , Jonathan Corbet , "Matthew Wilcox (Oracle)" , Lance Yang , Baolin Wang , Gavin Shan , Pankaj Raghav , Daniel Gomez , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240717071257.4141363-1-ryan.roberts@arm.com> <20240717071257.4141363-4-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1117BA0019 X-Stat-Signature: cr8yeprtw6r41by6ziftfkgwydy1f7eh X-HE-Tag: 1721377763-421393 X-HE-Meta: U2FsdGVkX1/F1EnfZs+fxC9ynhkXYljkkrlHRCpN8K5LF7wrNRfqZQfzhPVXemhARmyYEM//pQnrUb5P+w1F4lhPMRaJrRAWqKzfy3aSGuFZJv09UQl2i6rOhkj4xf19NkA6fgKduamhdJX5mGwtNdiJDZCE7pl2FkWVXT0uQvAH+m8x/f1Y0fX/evlIyVdDypiR9yA2Bm7rJ4JDYlBAgNIU/Ypy639+s0Mz2BUGY2umCC4ZBKpZGl+5bzOKmT9n8DTwBZK2p/z9D3mmYYyobM9l44GGY7tfoXvgMjvmyPIFO0QXRTOqANMB9Vjn/36YIb087bqrEood7QfFDNVLgtnpT9OAeeT/rCtDrdgx1s2cWTlTTiOwFdV60GK4zlnIURGSe1awQLLxU/+vT7/zF7VZkbOYZ5bvUML/bVRpHGV8bGkM2tC2/9Tp0IZ2uiwkiQTZ5MrIjiiCbU3iztERYLrSdVt1ujDnQ+pHUC/O6Ky6A8YCD3dXepVD2Ncj3czRCN/EBtUkjYEUq/VBPUTGfc1hS2i1EAIp7td+che5skIge+9fkwDvWAmZTjf4AiMPtgSpPXmiYxHNE+V73jvCIbheTAp/ZPvmn0HH0Vn1tCj3XybArq7bbPNp3eX3+wEctqOf0QE7Yomxo73LMlXb/9SFtyfJgmiyJ27ZOdpEfPnSmhIUt3y4OscATiuaBkKPA/FGdbTEI3eiHDKZUtZJAcJUt6N43SEEs/etGVRi402+3ZYj4diSC6dC3bmhnhTbnqxrbW3DaP9ynHPX86+blGC3W4Foi+vlyTNeMRDNOyqvzYDCmzOABkgZHEoXCFugG+xzuZAR+wAI/v8crB9BSgges+kNGNxWr+QkYzHu6rGjcyLhiDRLDkaKVxSj9euDU2pHENX6Tnl0Z4vzNEI1Yo9yf1llnyZG0mIUfo2xfRxLXFs2RrjPrkl4q38cHvx0ffPfZUXVuHjQJ2rKWWK yNVFekKK Vj1eocZAVNr2KSWWincWnRrepZJSuZJY+hrWYASguE+yUxjIFxxq+RYc8A/0j4RunLW8YxQphAqgKBUyBRrB+p0JyWv0rtOPTfXdHX9oLYz8RpSW2XyxIniuLSkswFfIEy8fj+iq0uH233q7cTlBB3qwYJ3cNi9jQ3FUjrqfae5iWdETOtHTXy8heslpPGPwoiex+5t3wmv3ZDkoVRLPQjNWu9/M0H0nnoUPixe2x2F+eoZKBlcs6CXeqEVS2Gq8+6dzJ63n3wH218bV/ie7CgJYXJFHOx1B8QWdhcUjwtwvo5qcgfoshYKLW35+DX7Lp4R4S/SS5rccmMJ/WQpebLVdFrBTMMpTuMEoC1+RMXlstHiRqtP3mBAh6G+eGEPISiAN4tzHoWyYpOoBwcR6gaMd2wefkM1s16HfFEaLqlJKntvWy6OFCNlgGH5/7yfovt0BjHxWsXjh7Nbg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.07.24 09:52, Barry Song wrote: > On Fri, Jul 19, 2024 at 7:48 PM Ryan Roberts wrote: >> >> On 19/07/2024 01:46, Barry Song wrote: >>> On Wed, Jul 17, 2024 at 7:13 PM Ryan Roberts wrote: >>>> >>>> Add thp_anon= cmdline parameter to allow specifying the default >>>> enablement of each supported anon THP size. The parameter accepts the >>>> following format and can be provided multiple times to configure each >>>> size: >>>> >>>> thp_anon=[KMG]: >>>> >>>> See Documentation/admin-guide/mm/transhuge.rst for more details. >>>> >>>> Configuring the defaults at boot time is useful to allow early user >>>> space to take advantage of mTHP before its been configured through >>>> sysfs. >>> >>> This is exactly what I need and want to implement, as the current behavior >>> is problematic. We need to boot up the system and reach the point where >>> we can set up the sys interfaces to enable mTHP. Many processes miss the >>> opportunity to use mTHP. >>> >>> On the other hand, userspace might have been tuned to detect that mTHP >>> is enabled, such as a .so library. However, it turns out we have had >>> inconsistent settings between the two stages - before and after setting >>> mTHP enabled by sys interfaces. >> >> Good feedback - sounds like I should separate out this patch from the rest of >> the series to get it reviewed and merged faster? > > +1 Agreed, this is reasonable to have. -- Cheers, David / dhildenb