linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Vern Hao <haoxing990@gmail.com>
Cc: mgorman@techsingularity.net, akpm@linux-foundation.org,
	linux-mm@kvack.org,  linux-kernel@vger.kernel.org,
	Xin Hao <vernhao@tencent.com>
Subject: Re: [PATCH RFC v1 0/2] mm, pcp: add high order page info in /proc/zoneinfo
Date: Mon, 15 Jan 2024 12:32:05 -0800 (PST)	[thread overview]
Message-ID: <3550dfef-af8c-b76c-4f4d-6ec790864359@google.com> (raw)
In-Reply-To: <20240115093437.87814-1-vernhao@tencent.com>

On Mon, 15 Jan 2024, Vern Hao wrote:

> From: Xin Hao <vernhao@tencent.com>
> 
> With /proc/zoneinfo we can simply get the number of pages used each cpu,
> but we can't get more detailed information about the distribution of
> those pages, such as the count of high order pages, through these
> patches, we can know the usage of each order page in detail, which will
> be helpful for us to analyze the pcp memory usage of application on the
> related cpus.
> 

Could you elaborate on the use case for this?

I'm not exactly sure what is meant by analyzing the pcp memory usage of an 
application; this would be a property of page allocations and freeing on 
individual cpus for orders that have pcp lists.  That's traditionally not 
a property of an individual application.

> By the way, on my intel 32 cores machine, i found that the 'struct
> per_cpu_pages' size increases 64 bytes, it seems like a bad news,
> i did some tests like stress-ng, but it did not see any performance
> degradation, and maybe use 'pcp->list' is also a possible way to get
> high order pages count, but it will increase the /proc/zoneinfo query
> time, so any meaningful suggestions are welcome!
> 
> Xin Hao (2):
>   mm, pcp: rename pcp->count to pcp->total_count
>   mm, pcp: add more detail info about high order page count
> 
>  include/linux/mmzone.h |  3 ++-
>  mm/page_alloc.c        | 46 +++++++++++++++++++++++-------------------
>  mm/show_mem.c          |  6 +++---
>  mm/vmstat.c            | 22 ++++++++++++--------
>  4 files changed, 44 insertions(+), 33 deletions(-)
> 
> -- 
> 2.31.1
> 
> 
> 


      parent reply	other threads:[~2024-01-15 20:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15  9:34 Vern Hao
2024-01-15  9:34 ` [PATCH RFC v1 1/2] mm, pcp: rename pcp->count to pcp->total_count Vern Hao
2024-01-15  9:34 ` [PATCH RFC v1 2/2] mm, pcp: add more detail info about high order page count Vern Hao
2024-01-15 20:34   ` David Rientjes
2024-01-16 14:31   ` Mel Gorman
2024-01-15 20:32 ` David Rientjes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3550dfef-af8c-b76c-4f4d-6ec790864359@google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=haoxing990@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=vernhao@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox