From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC795E7D0A2 for ; Thu, 21 Sep 2023 18:17:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FEAD6B0246; Thu, 21 Sep 2023 14:17:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AF3A6B0249; Thu, 21 Sep 2023 14:17:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 476FA6B024B; Thu, 21 Sep 2023 14:17:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 38CDA6B0246 for ; Thu, 21 Sep 2023 14:17:54 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 05B45120E9B for ; Thu, 21 Sep 2023 18:17:53 +0000 (UTC) X-FDA: 81261413268.29.DADFF92 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id C7E1E40017 for ; Thu, 21 Sep 2023 18:17:51 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JYDrhLw3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695320271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MzTcdyGI2+mbR4kqUecFI/lIF7d7z4fF019Uf7kMsFc=; b=oy83YDpoqNNOikBVA0PQPfsXZ8x1PTguK6TXp87sW18d2rg5qSB+H/5syXF9CMxTvw/gLb K+yzgOeNWQGEDGsQAikVCLMe/QTJ4GGNnSuMGjOLhNtg7DmZlvvHeb13Bb/4kV6RA+dIz1 7b7JYZXUTNNszk9wuPGtslzfWVzN0iI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JYDrhLw3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695320271; a=rsa-sha256; cv=none; b=uKd4q55XdRhOFmIpylXJugkDKKdrm+evBXUtk49KuEDs2zT786pCSS1w1xasrz2OpwCSJP 1FAGbvHZ1icH2irnuFpBhSwwG5/o3mt4kM1lTAnk8MSa33/zjmX10U3nGFYwDNvvo6qQvs 9kHpr9zDXjmW3PmaT2vk3/THNpD9elo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695320271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MzTcdyGI2+mbR4kqUecFI/lIF7d7z4fF019Uf7kMsFc=; b=JYDrhLw3BKbCNplIUR762TBwcHsRP2QlY8YLgWkjc2EGOvS1maU9utY0bYmOR22Z7nz8i2 Rk1FQhWeJI9twCV/Hyb7GkFEx1I3TMn4bzDCkJatPDQabISc1w4GyX+nd4A9ErnOvJI+b2 nNhnsTGHBlXlXmvp+lHwBaqUEtjtkzM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-206-aG44sKPRPyeQGpNoqVHeYw-1; Thu, 21 Sep 2023 14:17:48 -0400 X-MC-Unique: aG44sKPRPyeQGpNoqVHeYw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40309efe8b1so9529335e9.2 for ; Thu, 21 Sep 2023 11:17:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695320267; x=1695925067; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MzTcdyGI2+mbR4kqUecFI/lIF7d7z4fF019Uf7kMsFc=; b=TUPXKDeVhkTjXeG66HBptLz48p9L/PAtYAoWm5YvLH1pJ+/LWMgzgaRnpY0+2icK8L lpGr/02fwm+zzGW35LWjLRzGtbwPJBlTNcFE48Ovch5jPJL38c8kk+eTEnyv+iscjmO4 JpQWGGbF4V98tbuu7RswFUX5nJCaX/4ZepmAeIF1yjrSvoDUGGxDj7oZWBtFg/Li1VGW 7j9VaE9NEd1kb8KpZJgzYxKOXUYYf8i81kJIMhZHbioVKQrVJZQ8n3YCS5hfm5hAuSGr NsCLE0xN1/oGO83gdLzi6ltij7pzOOoJVtva5r5zNLjkvvnCtJqIFg3FNq6KziSTaQix qbqg== X-Gm-Message-State: AOJu0YytExtA7N1X9zjc2e/7GFRn+gy+wcKO4ujCRTqj+il3Eu0ixd8t UD8D1//HjHDBGSALDHhukcmwUw6Q6k/W3BBg8X+EmyvmcG6YBRMZi8CVUsICyted7RamWyX5tkU 3iRFtduzrUjM= X-Received: by 2002:a1c:740f:0:b0:401:daf2:2735 with SMTP id p15-20020a1c740f000000b00401daf22735mr5528376wmc.31.1695320267487; Thu, 21 Sep 2023 11:17:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnVaSJCzaFK2qmY3g4W/8mz+pVzeGQKzxpMU+YTexuT26Aj3jV+KbrvHxK+ANFw1c9j6a+MA== X-Received: by 2002:a1c:740f:0:b0:401:daf2:2735 with SMTP id p15-20020a1c740f000000b00401daf22735mr5528356wmc.31.1695320267022; Thu, 21 Sep 2023 11:17:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:3c00:9eab:fce5:e6f3:e626? (p200300cbc70d3c009eabfce5e6f3e626.dip0.t-ipconnect.de. [2003:cb:c70d:3c00:9eab:fce5:e6f3:e626]) by smtp.gmail.com with ESMTPSA id o17-20020a05600c379100b003fe1a96845bsm5414170wmr.2.2023.09.21.11.17.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Sep 2023 11:17:46 -0700 (PDT) Message-ID: <354f2508-74d5-2723-502c-32d009f77a3e@redhat.com> Date: Thu, 21 Sep 2023 20:17:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI To: Suren Baghdasaryan Cc: Matthew Wilcox , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com References: <20230914152620.2743033-1-surenb@google.com> <20230914152620.2743033-3-surenb@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C7E1E40017 X-Stat-Signature: db8jtno46acfnj6inwhdds5qpr6u9ned X-Rspam-User: X-HE-Tag: 1695320271-552779 X-HE-Meta: U2FsdGVkX19FCmSF4OfAb2XfQQrgKiwt5uv+1iHjuxicHj1NjJENCiK0OsHgAk22zyY4Wlzawca1UR3ZBa7ZibRaOx1Mv5WPUl1NcsFi1VbvYARgTtHe2ZD/ZUBP2H+/qpyMHNZ/01h7cZHic3MU8jwZvPYDVpztN6tIK+/N9aMgpgK2Atc/3Ijy6NKB4jDzmLZe2jP28puonLXaqxdKDnIOuUQbqz+oPVciBw69zVvTQMJn9TQwIGbh5LnhI4ifv7yBYFxG4pJQfhQ/0JAmsxRWWsB7ILvMdPI53TALgdJDIQLtgJhx2QekI6mXLg9d9N9utdKrdyyF6n0V5nNZttgvtqC2lYGaRmLZeYdyi0EtglO/lqC8Xg7ArPPNg8cVJc7u1evz6RerUQDggZ1ST5Y0YD5TSr/AbDWUZDTN2fJQt6rhi7xIT8jjZto3DVeAbtulV/AB/fgWjw/d+YKmeEIc1XGpSQi6bIbisYtgNB6JiUiUz1hENnbtLGFEKRXf9IgP6WY/WVXdnLN+13cRVwRAuzq4jEp/wocmJ9s3avyTfDNAOVmj4LVUIPS8DY3LwJ3ntoXDcQpcdfDnFrkyOXxjRMXMoDr2HnVs5dZHN7t63oWQhxxOnodUgJEVkMhokzeLsStv1YakT/SM3C9MTy+6szS3cWJqfTqQxM7hyIEdLoa/ktLbFYGym6LUUWqIzt8FPFOW5aX6P8IiPUDk94XQCG/TPM4QidYBYbhYqKusDGik9+7xgB+KkEY917Km98sfj070uS4stLfoJsIpkQ+b10vVwfqTgLD9jV98sRZ9V+4TQrdzMiB2p0bC9dyalwh05w7P1Ik7t0p7l8LoaT8ogqaOiKvcLHQlWkZmP0iqP7RaSiazP+KwrtTZdsZti/Np+Fc6PukBb3n8CGgSr8NY7RP+8gsbPPtET5RvpFkpQrMioGedcVCmkeFfDLpTxvFcfXuCEj04eOwaMN6 CFN/6rxr /SOjobEdQyQDynjnrrhCOMLbHIwyBfJws89HazR7X4MShD+NeJ9mYVnSiOgJH4dw4Xu+jfKmhsf2+slTZCGHozP8CmsgOigLsPrLjNAf8hWkyN4gZ5ad8Oj+nqyuu8HPgjdhjn3k1geavHjsYFuSCB0Wm7ucjZDWrFuynuwU7tYZojS2tVRNSbPozQy3dDNIrM6njdC3JktJZGvzIkCDdIxilA2xw2V3gHduSLEnLbAUOtP6Gt0N1WE2xnb/zwrhJ6pL3unoX31EXCuZ867eX/OTBcvfiWEz2hxHct0/ZY4BORXM251ofUaGTKyBnODZgaLS6zhdW2X7euQlF0mo65jU4ZQYr6K2WiyQv+qT0JyWy0gjHXMDhjxuBahTcDp+J+u0Tfs9Ph1cjj+nVZCJi4TX83SXiGx/fhVmbvl9vQ55OXuEuN71qPugu0IZaJxG46a1IgDSZl8JMBOI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.09.23 20:04, Suren Baghdasaryan wrote: > On Thu, Sep 14, 2023 at 6:45 PM David Hildenbrand wrote: >> >> On 14.09.23 20:43, David Hildenbrand wrote: >>> On 14.09.23 20:11, Matthew Wilcox wrote: >>>> On Thu, Sep 14, 2023 at 08:26:12AM -0700, Suren Baghdasaryan wrote: >>>>> +++ b/include/linux/userfaultfd_k.h >>>>> @@ -93,6 +93,23 @@ extern int mwriteprotect_range(struct mm_struct *dst_mm, >>>>> extern long uffd_wp_range(struct vm_area_struct *vma, >>>>> unsigned long start, unsigned long len, bool enable_wp); >>>>> >>>>> +/* remap_pages */ >>>>> +extern void double_pt_lock(spinlock_t *ptl1, spinlock_t *ptl2); >>>>> +extern void double_pt_unlock(spinlock_t *ptl1, spinlock_t *ptl2); >>>>> +extern ssize_t remap_pages(struct mm_struct *dst_mm, >>>>> + struct mm_struct *src_mm, >>>>> + unsigned long dst_start, >>>>> + unsigned long src_start, >>>>> + unsigned long len, __u64 flags); >>>>> +extern int remap_pages_huge_pmd(struct mm_struct *dst_mm, >>>>> + struct mm_struct *src_mm, >>>>> + pmd_t *dst_pmd, pmd_t *src_pmd, >>>>> + pmd_t dst_pmdval, >>>>> + struct vm_area_struct *dst_vma, >>>>> + struct vm_area_struct *src_vma, >>>>> + unsigned long dst_addr, >>>>> + unsigned long src_addr); >>>> >>>> Drop the 'extern' markers from function declarations. >>>> >>>>> +int remap_pages_huge_pmd(struct mm_struct *dst_mm, >>>>> + struct mm_struct *src_mm, >>>>> + pmd_t *dst_pmd, pmd_t *src_pmd, >>>>> + pmd_t dst_pmdval, >>>>> + struct vm_area_struct *dst_vma, >>>>> + struct vm_area_struct *src_vma, >>>>> + unsigned long dst_addr, >>>>> + unsigned long src_addr) >>>>> +{ >>>>> + pmd_t _dst_pmd, src_pmdval; >>>>> + struct page *src_page; >>>>> + struct anon_vma *src_anon_vma, *dst_anon_vma; >>>>> + spinlock_t *src_ptl, *dst_ptl; >>>>> + pgtable_t pgtable; >>>>> + struct mmu_notifier_range range; >>>>> + >>>>> + src_pmdval = *src_pmd; >>>>> + src_ptl = pmd_lockptr(src_mm, src_pmd); >>>>> + >>>>> + BUG_ON(!pmd_trans_huge(src_pmdval)); >>>>> + BUG_ON(!pmd_none(dst_pmdval)); >>>>> + BUG_ON(!spin_is_locked(src_ptl)); >>>>> + mmap_assert_locked(src_mm); >>>>> + mmap_assert_locked(dst_mm); >>>>> + BUG_ON(src_addr & ~HPAGE_PMD_MASK); >>>>> + BUG_ON(dst_addr & ~HPAGE_PMD_MASK); >>>>> + >>>>> + src_page = pmd_page(src_pmdval); >>>>> + BUG_ON(!PageHead(src_page)); >>>>> + BUG_ON(!PageAnon(src_page)); >>>> >>>> Better to add a src_folio = page_folio(src_page); >>>> and then folio_test_anon() here. >>>> >>>>> + if (unlikely(page_mapcount(src_page) != 1)) { >>>> >>>> Brr, this is going to miss PTE mappings of this folio. I think you >>>> actually want folio_mapcount() instead, although it'd be more efficient >>>> to look at folio->_entire_mapcount == 1 and _nr_pages_mapped == 0. >>>> Not wure what a good name for that predicate would be. >>> >>> We have >>> >>> * It only works on non shared anonymous pages because those can >>> * be relocated without generating non linear anon_vmas in the rmap >>> * code. >>> * >>> * It provides a zero copy mechanism to handle userspace page faults. >>> * The source vma pages should have mapcount == 1, which can be >>> * enforced by using madvise(MADV_DONTFORK) on src vma. >>> >>> Use PageAnonExclusive(). As long as KSM is not involved and you don't >>> use fork(), that flag should be good enough for that use case here. >>> >> ... and similarly don't do any of that swapcount stuff and only check if >> the swap pte is anon exclusive. > > I'm preparing v2 and this is the only part left for me to address but > I'm not clear how. David, could you please clarify how I should be > checking swap pte to be exclusive without swapcount? If you have a real swp pte (not a non-swap pte like migration entries) you should be able to just use pte_swp_exclusive(). -- Cheers, David / dhildenb