From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1508BECAAA1 for ; Sat, 17 Sep 2022 01:17:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88BF48D0002; Fri, 16 Sep 2022 21:17:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83AE78D0001; Fri, 16 Sep 2022 21:17:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 729EC8D0002; Fri, 16 Sep 2022 21:17:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 641428D0001 for ; Fri, 16 Sep 2022 21:17:57 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 267C8C0459 for ; Sat, 17 Sep 2022 01:17:57 +0000 (UTC) X-FDA: 79919815794.04.0A32226 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 55580A00A6 for ; Sat, 17 Sep 2022 01:17:55 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VPz2Le7_1663377472; Received: from 30.27.91.208(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VPz2Le7_1663377472) by smtp.aliyun-inc.com; Sat, 17 Sep 2022 09:17:53 +0800 Message-ID: <354da702-ae1f-d884-3cc4-b8cde3ae9757@linux.alibaba.com> Date: Sat, 17 Sep 2022 09:17:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH V2] mm/hugetlb: add is_resv_equal_free() func To: Mike Kravetz , Andrew Morton Cc: songmuchun@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220916064127.1904-1-xhao@linux.alibaba.com> <20220916131249.68d59133cdb0366e0831592b@linux-foundation.org> From: haoxin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663377476; a=rsa-sha256; cv=none; b=7Zr7W+2/1J1CJw8RcbgmTL4CHRqK+SZMNZqw5AmFCmle3EUIVt45Eo6ROL3JO1dV2Q/rH5 nJtnkRnAmxr4vIoWJu4XRFQ/REBsfCojYG+PqPcRDf+3xNxeN5M8/pAEsPfYwL2HXtD5Qs 4zscO/sWy7tQfZTyj2ve3SyOr0Z/3ZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663377476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGvZ75TMCj+7vn8+ZV6bzwLLWlRyWJa8rSp7kIfCJZg=; b=7m9uM34F5/8ReB6dWZNMVu4qgelUa9LUaBnB+auxOZvC698JgBgc+M2ygF0fNeOpFGdVsF WFjMYKwXBY9CIO+eHpnQfqa1/ppehDYZB439GZiH3vn2u+F5LdJvbVKwVgd7At6hZyy5zm 0xnKeI3MoxXqZ3L9185XOg3SFEhaXHY= Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Stat-Signature: qwrmw94wwegaxhsqykgksaskdbekq4z4 X-Rspamd-Queue-Id: 55580A00A6 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1663377475-897844 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/9/17 上午5:09, Mike Kravetz 写道: > On 09/16/22 13:12, Andrew Morton wrote: >> On Fri, 16 Sep 2022 14:41:27 +0800 Xin Hao wrote: >> >>> In hugetlb.c file, there are several places to compare the values of >>> 'h->free_huge_pages' and 'h->resv_huge_pages', it looks a bit messy, so >>> there add a new is_resv_equal_free() func to do these. >>> >>> ... >>> >>> --- a/mm/hugetlb.c >>> +++ b/mm/hugetlb.c >>> @@ -1191,6 +1191,11 @@ static struct page *dequeue_huge_page_nodemask(struct hstate *h, gfp_t gfp_mask, >>> return NULL; >>> } >>> >>> +static inline bool is_resv_equal_free(struct hstate *h) >> I'm not sure that's a well chosen name. A better name would reflect >> the *meaning* of free_huge_pages being equal to resv_huge_pages. Maybe >> something like reserves_exhausted()? > How about calling it free_non_reserved_huge_pages() and returning the actual > value (h->free_huge_pages - h->resv_huge_pages)? > > Perhaps available_huge_pages()? Ok, I am going to use available_huge_pages() in the patch v3, thanks. > It could then be used in at least one other place > - if (h->free_huge_pages - h->resv_huge_pages > 0) > >> This would all be clearer if we'd bothered to document the fields of >> struct hstate :( > Agree, and discussed elsewhwere some may even be able to be eliminated. I can > add that to my todo list.