From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EFB4EE645A for ; Fri, 15 Sep 2023 12:19:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D91AC6B0343; Fri, 15 Sep 2023 08:19:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1B586B0344; Fri, 15 Sep 2023 08:19:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBBF26B0347; Fri, 15 Sep 2023 08:19:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A7AE46B0343 for ; Fri, 15 Sep 2023 08:19:56 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 840051A0F85 for ; Fri, 15 Sep 2023 12:19:56 +0000 (UTC) X-FDA: 81238738392.14.65A9BD8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id A511540014 for ; Fri, 15 Sep 2023 12:19:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tgndc4TQ; spf=pass (imf12.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694780394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S6YdaabWMt5kMqbNYNBaQroIwASFlYwE8xKBnDy2tD0=; b=RwO+86v3+TcsnpAS1rfqCR9JIYLkJjhHZFiii9I6ZGGBOJnan6kUmCbucSI6dOeuibJUoT XLDc/Wr8FguLkeFgcfP3v2bdQZcsu9zpR/fJPiHC//D2YvgnjyTfLzTIwAW9eWA04JaCg6 99R9bpTM85oUOUXIj5e9SC5of9PYFJo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694780394; a=rsa-sha256; cv=none; b=X+eBR9t5AdJ/T1BCCoz+/bsetXhC2M3cFMcEjKFf9a1rG9qH+LkRE8px3UwlK2QNwElPcs k17x2nKBXkMzkzn5EOghqsti4ONMYzq7VZxvBVQEu/qBPWy6FSVaXiW63kZ/WrTZ0KUvCF NDBd1N2mf9a7Q+t7IJf7mR5oNusW+HA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tgndc4TQ; spf=pass (imf12.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694780394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S6YdaabWMt5kMqbNYNBaQroIwASFlYwE8xKBnDy2tD0=; b=Tgndc4TQeoBXy1EVNFhx6kooHXEfmCczdjKqRULdUgG61Mt8NzYSHIX+Uz/jPAH94S6rxO bU8Tx39MjSe6TiHVFO2TUH2oKllAblmy0g3jqc1tAMHJsygI+22ujlCnoGm0JIFJFRLS8C J+LmH4KLdbwu3irCNthnlHJ/N6gfoG4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-426-7G8sFEHCP9WrzceNBoHclg-1; Fri, 15 Sep 2023 08:19:49 -0400 X-MC-Unique: 7G8sFEHCP9WrzceNBoHclg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CEA2E857F8A; Fri, 15 Sep 2023 12:19:48 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B0591004145; Fri, 15 Sep 2023 12:19:46 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230914221526.3153402-1-dhowells@redhat.com> <20230914221526.3153402-10-dhowells@redhat.com> To: David Laight Cc: dhowells@redhat.com, Al Viro , Linus Torvalds , Jens Axboe , Christoph Hellwig , "Christian Brauner" , Matthew Wilcox , "Brendan Higgins" , David Gow , "linux-fsdevel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kunit-dev@googlegroups.com" , "linux-kernel@vger.kernel.org" , Andrew Morton , Christian Brauner , David Hildenbrand , John Hubbard Subject: Re: [RFC PATCH 9/9] iov_iter: Add benchmarking kunit tests for UBUF/IOVEC MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3545839.1694780385.1@warthog.procyon.org.uk> Date: Fri, 15 Sep 2023 13:19:45 +0100 Message-ID: <3545840.1694780385@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Queue-Id: A511540014 X-Rspam-User: X-Stat-Signature: 58rj474rf17r3s6zgr6mt8gi9gaw488k X-Rspamd-Server: rspam03 X-HE-Tag: 1694780394-429241 X-HE-Meta: U2FsdGVkX1+5JHlu9nqifpFqud6fLM2E/rc9BXHw4xRqgi/dK2csBOyH4aen5hr2zuXI/KESFxDafT327yZvWenevTMb7VpFFrHyAeulyIEF04GCdUmvA2z0mkQ7YTxjS7iE4wWZBMytjshOhiv0jvemmzJ67MQK6JwbWFZwoHoYzcAVO4Gq9CPaMrgDxpjTPBGg/xo/KwmEi209Ayvz8NUbLmvUxNhvGLE4Hoz8dcBJ1ld4EbDznHWl1zFRU5NhUY+Nq47erXIGhCPNFVyDHrGE20ApOYlPBecEfvyvFfRegBCMSLJ3U2n7FP9KcG0HZfpsne2KBAvhpDg0X6//fw3H9tR6mGHvCCHnRpxgXnkiIpHdMC7BCoEoZGeeNYbyg3cKXNt2BnF4B9YrgsIcRdNT2JwycGj2PLPksrmz5an5/bvNlUscVIX2HwvRlK1io+eizLejP7N0RkXInB8o6Ak7COf5/4Ltf2f7DfW5QrxRRSg0sdK3wZ6TaSYL4nsV82lnqBMCuvR3fL6bo9NA3o6wIicg9ddfj0ZPRRCJWG8al//SE78II7HJFQCWGljd/Ja8gLNYBypa2T8uI7LRWH5x8CaJR6zoLq7oXWbLE7Rhd6wJPmqo8QjjcAx6iKwbJLAzBIvueXI105E3a2RGxN9miFH8bIcqogLQYmmIQkgFpf02iU33+Bz121cNdqmOJEZ995yj1uPQG5E2cFGSg2/4BEXsiJRecLm07rH/N48vaYU5rc6SlG6gvubMlb/M3OHaM2C/CxFOdPyXqMkHrFiDvo9oVAUQQwXnX0ndEHEww9zhoSxEwmNhIywrly5lVK5gTT89tdPUJVjx/l6XWhngJCzxrmqR4CaY4oZh0a523+59unPU/YZYfVDiA+146ukbQ3RUV9gkB1vfDHg7Hf3w4dB7DQaz9pSe9XdxzUYo4Pkr+9Lq+fU4kbpkE5VTSUgf8ZhNX2wJAimbOKE cfFiLl2u oH8wxe79dow4N5idUNwZp/j8M4U51nfTGukV/ZEVssTroATNaikqbbICvqcnTN+Zu1GfEJeUZJkY58PScHN4blXGN5nuVCenAI13TP9SmKPl+9faXL5ZQFxxHoru15fYIgWNIUEKmdlh+1wTbcHScAIePoS8Z4GC73IB6UqG257vbi6ltRchAOchAAWkSgpONFwtoQTy9yK5HyYqz+nwlg1LJAY+io/SDqB0erRgiuVRxxSBXqLCK6Gt4uwvLqnxEQ4oXpaGqSp0+A7M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Laight wrote: > Isn't that going to be completely dominated by the cache fills > from memory? > > I'd have thought you'd need to use something with a lot of > small fragments so that the iteration code dominates the copy. Okay, if I switch it to using MAP_ANON for the big 256MiB buffer, switch all the benchmarking tests to use copy_from_iter() rather than copy_to_iter() and make the iovec benchmark use a separate iovec for each page, there's then a single page replicated across the mapping. Given that, without my macro-to-inline-func patches applied, I see: iov_kunit_benchmark_bvec: avg 3184 uS, stddev 16 uS iov_kunit_benchmark_bvec: avg 3189 uS, stddev 17 uS iov_kunit_benchmark_bvec: avg 3190 uS, stddev 16 uS iov_kunit_benchmark_bvec_outofline: avg 3731 uS, stddev 10 uS iov_kunit_benchmark_bvec_outofline: avg 3735 uS, stddev 10 uS iov_kunit_benchmark_bvec_outofline: avg 3738 uS, stddev 11 uS iov_kunit_benchmark_bvec_split: avg 3403 uS, stddev 10 uS iov_kunit_benchmark_bvec_split: avg 3405 uS, stddev 18 uS iov_kunit_benchmark_bvec_split: avg 3407 uS, stddev 29 uS iov_kunit_benchmark_iovec: avg 6616 uS, stddev 20 uS iov_kunit_benchmark_iovec: avg 6619 uS, stddev 22 uS iov_kunit_benchmark_iovec: avg 6621 uS, stddev 46 uS iov_kunit_benchmark_kvec: avg 2671 uS, stddev 12 uS iov_kunit_benchmark_kvec: avg 2671 uS, stddev 13 uS iov_kunit_benchmark_kvec: avg 2675 uS, stddev 12 uS iov_kunit_benchmark_ubuf: avg 6191 uS, stddev 1946 uS iov_kunit_benchmark_ubuf: avg 6418 uS, stddev 3263 uS iov_kunit_benchmark_ubuf: avg 6443 uS, stddev 3275 uS iov_kunit_benchmark_xarray: avg 3689 uS, stddev 5 uS iov_kunit_benchmark_xarray: avg 3689 uS, stddev 6 uS iov_kunit_benchmark_xarray: avg 3698 uS, stddev 22 uS iov_kunit_benchmark_xarray_outofline: avg 4202 uS, stddev 3 uS iov_kunit_benchmark_xarray_outofline: avg 4204 uS, stddev 9 uS iov_kunit_benchmark_xarray_outofline: avg 4210 uS, stddev 9 uS and with, I get: iov_kunit_benchmark_bvec: avg 3241 uS, stddev 13 uS iov_kunit_benchmark_bvec: avg 3245 uS, stddev 16 uS iov_kunit_benchmark_bvec: avg 3248 uS, stddev 15 uS iov_kunit_benchmark_bvec_outofline: avg 3705 uS, stddev 12 uS iov_kunit_benchmark_bvec_outofline: avg 3706 uS, stddev 10 uS iov_kunit_benchmark_bvec_outofline: avg 3709 uS, stddev 9 uS iov_kunit_benchmark_bvec_split: avg 3446 uS, stddev 10 uS iov_kunit_benchmark_bvec_split: avg 3447 uS, stddev 12 uS iov_kunit_benchmark_bvec_split: avg 3448 uS, stddev 12 uS iov_kunit_benchmark_iovec: avg 6587 uS, stddev 22 uS iov_kunit_benchmark_iovec: avg 6587 uS, stddev 22 uS iov_kunit_benchmark_iovec: avg 6590 uS, stddev 27 uS iov_kunit_benchmark_kvec: avg 2671 uS, stddev 12 uS iov_kunit_benchmark_kvec: avg 2672 uS, stddev 12 uS iov_kunit_benchmark_kvec: avg 2676 uS, stddev 19 uS iov_kunit_benchmark_ubuf: avg 6241 uS, stddev 2199 uS iov_kunit_benchmark_ubuf: avg 6266 uS, stddev 2245 uS iov_kunit_benchmark_ubuf: avg 6513 uS, stddev 3899 uS iov_kunit_benchmark_xarray: avg 3695 uS, stddev 6 uS iov_kunit_benchmark_xarray: avg 3695 uS, stddev 7 uS iov_kunit_benchmark_xarray: avg 3703 uS, stddev 11 uS iov_kunit_benchmark_xarray_outofline: avg 4215 uS, stddev 16 uS iov_kunit_benchmark_xarray_outofline: avg 4217 uS, stddev 20 uS iov_kunit_benchmark_xarray_outofline: avg 4224 uS, stddev 10 uS Interestingly, most of them are quite tight, but UBUF is all over the place. That's with the test covering the entire 256M span with a single UBUF iterator, so it would seem unlikely that the difference is due to the iteration framework. David