From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8404FC00528 for ; Wed, 2 Aug 2023 12:40:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2396728016E; Wed, 2 Aug 2023 08:40:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EA0D280143; Wed, 2 Aug 2023 08:40:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D96228016E; Wed, 2 Aug 2023 08:40:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F185C280143 for ; Wed, 2 Aug 2023 08:40:26 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CD7A8C0971 for ; Wed, 2 Aug 2023 12:40:26 +0000 (UTC) X-FDA: 81079122852.12.FBCA863 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 34281C000C for ; Wed, 2 Aug 2023 12:40:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf28.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690980024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HC0cU2oVHRW1+a+2oZeTTEk9I5ow90vNHE3i9Okfx0Y=; b=0fY5RyDoe55Hjp6QvZK33nmpb4FntwFze02gAoa4rD9rwfBNW028XpBf5rbLcZFtmjwMrQ +NS9zbBCZvtPGRl7neyXJy88FcpyR8xAC85eU9TirxkQM7mTTZQDNhUSnQjr1JisM01wcU U4e71HjzswgHsdqeyi2CgF5rMDbC46E= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf28.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690980024; a=rsa-sha256; cv=none; b=3yhiYQ2NUiaMhom7UeJ3Hf9fCukzInz1jZ+hDunTVGJQdQu0yIvQWoTry4vIXW21B31uhc k+nrY3mHwHTbP+GE+XZBT6okIiPzNGC7DoYkGPuxd7wFEvQp3TzkKE+CQiguZvPjQbxeHb EUpP3bhp7aoYkX1MM/Uqz0G/j91VelU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4FDED1424; Wed, 2 Aug 2023 05:41:06 -0700 (PDT) Received: from [10.57.77.90] (unknown [10.57.77.90]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 626F13F6C4; Wed, 2 Aug 2023 05:40:20 -0700 (PDT) Message-ID: <3541d2de-5cf8-2f84-8153-277e2bfc0101@arm.com> Date: Wed, 2 Aug 2023 13:40:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/2] don't use mapcount() to check large folio sharing To: "Yin, Fengwei" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, minchan@kernel.org, yuzhao@google.com, david@redhat.com, shy828301@gmail.com References: <20230728161356.1784568-1-fengwei.yin@intel.com> <3bbfde16-ced1-dca8-6a3f-da893e045bc5@arm.com> <56c8f4f9-b54b-b0bb-250c-ec8643accfc7@intel.com> From: Ryan Roberts In-Reply-To: <56c8f4f9-b54b-b0bb-250c-ec8643accfc7@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 34281C000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 3sk97ftoeh168n974fenr3dy4qohrh3m X-HE-Tag: 1690980023-94765 X-HE-Meta: U2FsdGVkX1+NV/nq85bdbk+kjJ2nOUNSXWK6C3+TMuVthiOTCy4gnU4XUTfUEN6A/v8+NZ5UoVY46EGSxj2k24zvQIbzcdvT6+/PpCH/bbhp/be5NNeBPfvAKEqgj0BUMtE2lPXga30vwCvUwsnJ6xey8DpR5nVUoJLkxhPRrz6a7J28fllRNEOmXX60yzvmpRxxmwJojfNpcPZ+7dZddngVO2qSAgeVbiWnrUc9WpTNlg+2sjFviMptE0o8Ai/8z22jD8nozQoUSgzkfv8TjJR/Hk/l1QkLJsoRGK3+Ytju47m5+xjD5R3SVHd+tJsd3yxhPgFThixVKR6jMMnN3btd7A0BhZaai1A4qnfUTjUZjxrcrdPMfEesMQzqPqgMGfuuWbfpP9EaPbWT5K1/8xPZoKmPyERZm+6xT6Nc9MMeJRq3cAd3MX3GCUnUAwol4lvC6y+UMg8i0gAjI/CvfCDcmlDEFWEsl31KHZkj+FzcbkIp3iuhYJqixgXS7bj1TPutrqUgxthg3CFaNmrEArWpu44A0htTEwD3eeZM3BNAU/6gH4TIZSA66LI97LTEAG9p6xO/gsXZbwwyObyM9evM8tvML434TI+qMZiNaswWlF/4fqVYlDow2a7/QFzXPdhJrGnU8VnsJQ+BuTBsmV/6NmF+IxlBdSJccJ+rYvwxLl1O8VfGr2KTM8Y3jMWrRF4tGaKH4ykyiLNODoLVAJ/YwMTo8YJjcF4DZ9VxYvRKAeOg7qS8vFG6f4dIDxPmSdyZUHJWYhsHKoScMdHgUStnvfTkyYH4rGmYwokJft9shaP/ezhAF65az8Aa1rhuicMoSgzUH7ySbxQq+0qZhn6/7EY/87r3FiHSvOk6CSqUCkNxhYnFqLEn4rlYa3dW1btSCdas9K9FikGw9+qOkyr9QQT1jL6QS0iK4WB14DKw0WF0qJRN0t/dnD3umw1fXdS8RbC57X90fOwfnw0 OMsIFdnC aAktfnpvIq4c7qgxU9HfUZAguSyv5+rcZ9otiy++TbKwHr7OBJUjDUvbcdlLpMY3mpcvXoBmjDBdu3hM9Vb5jvJBO4xSwKnRCZhNCQrlc6IXY3p+CKb5l722NPOPlOHx3vkRe79EXgkOciGVGTx2W0VJIfF4nzcR5qbJGfEqsrrkZOiDxpln/LpyqAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/08/2023 13:35, Yin, Fengwei wrote: > > > On 8/2/2023 6:27 PM, Ryan Roberts wrote: >> On 28/07/2023 17:13, Yin Fengwei wrote: >>> In madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(), >>> folio_mapcount() is used to check whether the folio is shared. But it's >>> not correct as folio_mapcount() returns total mapcount of large folio. >>> >>> Use folio_estimated_sharers() here as the estimated number is enough. >>> >>> Yin Fengwei (2): >>> madvise: don't use mapcount() against large folio for sharing check >>> madvise: don't use mapcount() against large folio for sharing check >>> >>> mm/huge_memory.c | 2 +- >>> mm/madvise.c | 6 +++--- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >> >> As a set of fixes, I agree this is definitely an improvement, so: >> >> Reviewed-By: Ryan Roberts > Thanks. > >> >> >> But I have a couple of comments around further improvements; >> >> Once we have the scheme that David is working on to be able to provide precise >> exclusive vs shared info, we will probably want to move to that. Although that >> scheme will need access to the mm_struct of a process known to be mapping the >> folio. We have that info, but its not passed to folio_estimated_sharers() so we >> can't just reimplement folio_estimated_sharers() - we will need to rework these >> call sites again. > Yes. This could be extra work. Maybe should delay till David's work is done. What you have is definitely an improvement over what was there before. And is probably the best we can do without David's scheme. So I wouldn't delay this. Just pointing out that we will be able to make it even better later on (if David's stuff goes in). > >> >> Given the aspiration for most of the memory to be large folios going forwards, >> wouldn't it be better to avoid splitting the large folio where the large folio >> is mapped entirely within the range of the madvise operation? Sorry if this has >> already been discussed and decided against - I didn't follow the RFC too >> closely. Or perhaps you plan to do this as a follow up? > Yes. We are on same page. RFC patchset did that. But there are some other opens > on the RFC. So I tried to submit this part of change which is bug fix. The other > thing left in RFC is optimization (avoid split large folio if we can). > > > Regards > Yin, Fengwei > >> >> Thanks, >> Ryan >>