From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E45BC3DA6E for ; Wed, 3 Jan 2024 12:08:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B7706B034B; Wed, 3 Jan 2024 07:08:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83D6D6B034C; Wed, 3 Jan 2024 07:08:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 668966B034D; Wed, 3 Jan 2024 07:08:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B7166B034B for ; Wed, 3 Jan 2024 07:08:29 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1749780970 for ; Wed, 3 Jan 2024 12:08:29 +0000 (UTC) X-FDA: 81637877538.13.220AA9B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 3479D100013 for ; Wed, 3 Jan 2024 12:08:26 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AT5Td98Y; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704283707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xn3hPmKlXFLs1haHAodNqDYoLKo2JnMk0c6eSg9WYzE=; b=aFFFRE0eTKGV0XkFUjVVNGp4L5mzTGOaHBUq/FUOfuf4KyAwr8dNSUYQaUKHt2cT3RVSuS mhQHo2Q+cii8awH4Sri+brJOIntjOXIM0wzdR3EPFNdJhHloR7Jdi32sCwqdMMYkFPENCw VXSFWATcPDpyqhmEUcNljNPscUT1i3I= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AT5Td98Y; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704283707; a=rsa-sha256; cv=none; b=DCUjHVt1HaVLm/6gsG6Gz3pOfffESA9rW5XH2OFMuqECT2HuODE2Viwyr5rf5DhGSK6k75 JWUN+irzIcwxbiHoScSet9f3xJXCnrUDNzgKUctjzenXj1fvug3WmG171aucH0AmZ6ZPH6 YmnyKhRLUYre2b2h1tIn1wCm1x+3wzo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704283706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xn3hPmKlXFLs1haHAodNqDYoLKo2JnMk0c6eSg9WYzE=; b=AT5Td98YhH5DVj8AA3Q3H043oKTOVgfg9H/pF+8I4xez/VOFhMyh89g05oCHGmXYcSMoXL XGgP+LO82USNCYaEfqt1jNIJ8SDQru5aBOc/+SaJYOBNR+nc44JQLjns5wYvB8Me1/ntRP RrVVRrnjC/N3f3TzVis1LdDex9Dg/tk= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-464-ipNzNXHGPhaBuxD3VhW4ZQ-1; Wed, 03 Jan 2024 07:08:23 -0500 X-MC-Unique: ipNzNXHGPhaBuxD3VhW4ZQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0F9663C025B4; Wed, 3 Jan 2024 12:08:22 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id C516D492BE6; Wed, 3 Jan 2024 12:08:18 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20231221132400.1601991-1-dhowells@redhat.com> <20231221132400.1601991-41-dhowells@redhat.com> To: Dominique Martinet Cc: dhowells@redhat.com, Jeff Layton , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH v5 40/40] 9p: Use netfslib read/write_iter MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <354049.1704283697.1@warthog.procyon.org.uk> Date: Wed, 03 Jan 2024 12:08:18 +0000 Message-ID: <354050.1704283698@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Rspamd-Queue-Id: 3479D100013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k37bucj57mza81wbj5exjfy7g6g1f1d5 X-HE-Tag: 1704283706-300149 X-HE-Meta: U2FsdGVkX1+YIgCQ0bvKlPkYvDpMfpnUK8jCz4/cjYDNeigO/mlPZ6FHZOpnUQS6U1n62rw0dm7e0PuIO2rf1IkH7ai8dal5PJY/spF5kOg1kAnXVJZ0cmq3x2u+YbZlU5uq6odsoQg0a7jfJ2GtF2jRSP6Cc1gm8gNNipRBZm2xNrgT9wj8WXX+AvaHXE8fbGqSzKICUHrm6AoeVQSRfhE0ZxeutTGO4JaOJ8HJIvg0CGDTsGFQD10iK65oMh0YqVvNVILG9mNn6ZBpMCAfRnLq6Kx6lOpZYbTvUmPqlUXGGJKns3zNeE3u8WJ4qCivJhHZxhL7W8/2zddewXkHRrM+8QzgLKG5x+7DBIWQsow9RwyPj77oBO1cWn6Je5m0nehgFrUWy5mpKX3JkNweFaLJOajRPErF+JB+2Zh0M/sbCBOh1j7mP/YKW64Z4+Njdcym/2W+jN+p5HySLEkASlnd5ERmBAWpYT99imBFtzEOFCK9pbvUyAxE2hey2xpauidk0XxvXOHdzGiz/uvaHK0gehGf640YFOO0Kr1B1pRk3zkyElqY+45v+EM9R8eq/sS3A4AeAkXD3eYmGXKvgj0eND4TKGl+B8JyNda3FVw5L1kzwYJlElaPbmFmqUM57tPD2HqSzWmm+zj2gSYzp+IETSx5SUyyrYV82csjgkIrzsrjXHVMesb+ZVFC+VvDt9id5d4cblxfda8Bt8n6nvsECMNqVqCVOogQd9N6+3xBIvr8jIaNzVD764yrRsA3mhFW1nNKuJA4W6lfIkJZ3Dlx0m1p8Pq8AqZsmJ9JGE9ecELM+ShS1aAykfTZdyojusRGYlw9d3qZZFcLlJ8bcVaJuCAT7julgun9mleMYtRoT8K9OqBQtf54gvSdt4VpSWAmzzQETCKVLF4kSkhnpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Dominique Martinet wrote: > I've also manually confirmed one of the big improvements I'd been asking > for (that writes in cached modes, which used to be chunked to 4k, and > are now properly aggregated, so e.g 'dd bs=1M count=1' will properly > issue a minimal number of TWRITE calls capped by msize) -- this is > great! After the merge window, we can look at enabling multipage folios for 9p. > I've noticed we don't cache xattrs are all, I haven't given this any particular thought. We could attach them to the cachefile object as xattrs, but it means you have to do two xattr lookups in the event of a cache miss. At this point, I'm going to ask Christian to stack the extra patch on his branch rather than folding it down and retagging. > I've got a couple of questions below, but: I'll address those separately. > Tested-by: Dominique Martinet > Acked-by: Dominique Martinet Thanks! David