From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB59CE8379 for ; Mon, 30 Sep 2024 17:36:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7EDC280010; Mon, 30 Sep 2024 13:36:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2F3E280003; Mon, 30 Sep 2024 13:36:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF731280010; Mon, 30 Sep 2024 13:36:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F5E7280003 for ; Mon, 30 Sep 2024 13:36:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3CA1B408B7 for ; Mon, 30 Sep 2024 17:36:30 +0000 (UTC) X-FDA: 82622108940.10.A8B17D7 Received: from bout3.ijzerbout.nl (bout3.ijzerbout.nl [136.144.140.114]) by imf06.hostedemail.com (Postfix) with ESMTP id 28B8018000C for ; Mon, 30 Sep 2024 17:36:27 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ijzerbout.nl header.s=key header.b=P9poVHKA; spf=pass (imf06.hostedemail.com: domain of kees@ijzerbout.nl designates 136.144.140.114 as permitted sender) smtp.mailfrom=kees@ijzerbout.nl; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727717724; a=rsa-sha256; cv=none; b=eMYV8U8enreQi7fFjzkYODpep/o5hc+krfuKOxvS6IBa/zaDkDAfRezq3IYsw/mRWM0mW9 jDMEpa6wCwefeOtbzj6Fz/4LlZ0+M53goPtL8hEbnzKZsodIeKsM90KO0AfBg/GdgoALZa VxgO9Tdgvi84Y1Laichiae3zkwpXq28= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ijzerbout.nl header.s=key header.b=P9poVHKA; spf=pass (imf06.hostedemail.com: domain of kees@ijzerbout.nl designates 136.144.140.114 as permitted sender) smtp.mailfrom=kees@ijzerbout.nl; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727717724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S1xdIfFOr4JlABxLD4egyK6UPJSOiAHMbqbW1tc8/vw=; b=hRPP/5pnMCvT5iiMN6/OcjlNmm4wvqsblwsOAs8xeD/j51r+zR4D4cKPbzrZrqkKw6b3Rz gS9BgdgPUdQvYWyAbclZWC3xi0TYjXchpiaaGsULqjZ04smt2FUW/iDh8izc7EmocXV5n6 mJrILsiQttYJcKfy0CqPcHAUIsM66+w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ijzerbout.nl; s=key; t=1727717786; bh=kvASDgQEQw5COW6XOE41pHOgcpsYuEybcRPjzMwQzLc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=P9poVHKA0uTfgvfDOBiaRKqMAXGv9b8de482/+ymVmD66DUbGEaazt+TI+htdt1x+ e/M/IAiVj/7/GhxG5HGL7eD1CmQ2vDvj7b+1yIZps0lB0cJ0VcRIh+wocQm9Lj3ymo MoJ6ktUmqyVmmAONSpWu7ao03HEsEZJ7IbsMWPPgv7sw6CuTi0bzo703ThZ7XUUKpd 7sxP4Ld+iyY31f4ffRMzpUxNn87r1p/H1QM+DU54r5W/p1xCy6pnugbwWNGI8TLIcI l45klgPdMSWrSPMkmv1dLb/f7FtNHjNtQ1dh3T1CCLwctDTBD5CQPxm6te41+bNK6P oY8zqbFBM0K8a3M7+1FEtM0Cu2g+DNroERMEeDVbcaKupHx22QtTgPKX2f6fflKtO7 lrOQ8iMuO96TQf26tZiTfgHCZP0Ba7MWwubBWRRWuZg2CutDMWpX9bjdhW2q9O7IjI 9OvIXMcC4Ppg49ql51XFWsJ/6kH0djIG+h7cQEJ9ICr0U3xcHL8ouBxSUDDKBdo09e Wf1ilcV0TEY8w+ox+KCNKgptj5GUgDfZ5I7x5nYd+EYj9qco9PVbabK2bwaT8EilAN LGJSqeK7AMJ249PvCuXBju1yFYu2vVhT+V91psYUfvH4cTqH8hhD6UvkGBhAxSkmGT hmKipLn735Mq0NAYZAG/28IM= Received: from [IPV6:2a10:3781:99:1:1ac0:4dff:fea7:ec3a] (racer.ijzerbout.nl [IPv6:2a10:3781:99:1:1ac0:4dff:fea7:ec3a]) by bout3.ijzerbout.nl (Postfix) with ESMTPSA id 5B0BD167DD8; Mon, 30 Sep 2024 19:36:25 +0200 (CEST) Message-ID: <35130b82-0b6f-4468-83a2-084f188fcf5d@ijzerbout.nl> Date: Mon, 30 Sep 2024 19:36:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -v3 3/3] resource, kunit: Add test case for region_intersects() To: "Huang, Ying" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Dan Williams , David Hildenbrand , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Andy Shevchenko , Bjorn Helgaas , Baoquan He References: <20240906030713.204292-1-ying.huang@intel.com> <20240906030713.204292-4-ying.huang@intel.com> <9c9586ab-0426-46c1-bcc6-6ee2927b7a86@ijzerbout.nl> <87ldzaotcg.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Language: en-US From: Kees Bakker In-Reply-To: <87ldzaotcg.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: wy68kg1rf3d7x1oz5nst5tzswn3jat88 X-Rspamd-Queue-Id: 28B8018000C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727717787-673722 X-HE-Meta: U2FsdGVkX1+4ih0MF8Q11zDEXY8fb4ClGzdhLejQYt+Z+bKKUgZB1z53tZ6M7H3LIvGAvRKWslESUA1CixIL7DjlB/usn8o2CQA75PX/Th+hxFBGgHJfrFHCVAoga6WOfVlEyq2wfUFfe0JL6OTOL89hv3qLWO203c9pG3WdmzEPWRAfSIdUugru7jLq7jUj3no0ffKh57va8JZLX2EY6+2CcCUEbaZL2U7NDJdO/yGRvN4nSgMppdE8ow5GDp43rbupyltFB7VHoeoQ/Ta8NKjNmezS7AwfY+7hGeOnHZ8L/nLPeeJW4bompQ8f6gLGcylJrACCHglwfNmY7Ldqaoi6yhrnAIr6HfUER/c1kLALM1BxA3XgKSgXL/O04MAcY+em+tJUiTYU9F0+tnqI6ODFbpvr6wohMlBJd+E0e9Cc0f9NIPXWizlEQ2dTbJRJYhDioyulTvaAJQjna68aJQBSqMS1pivcpCs8kqEW8LOcJDEYsSH3eXhFdTxQYiptMA5UMKR4wzXWPRJclOR5TgvZPSyoCQsS2E5v6LH/vGn5w5Al4kZAC2Lwr6NSNMM+6teFdQ8PHSBD6Ik1eDvuo/pazwWwdAqcQenIsxKG52gSjWp96/w93QDjiaKhMxIj6V9aCQNcuyvopvNAKtnxheWIfHBeeocCNvcFVCjwuVp3XDgd7CTwwelTEKZMTwhbU7H8wVCyIO7w3g+HSHbBaZPZMP5THrJTQ7M5HosgwuqTPEC8jKW48Yh4BkyKbF6reHrB+iX1iQTXCkglhn9SW3xbYGn9S7+oW+m882HLBfOkmfjzxhSsKo1h90HFYoyW/hIVpzY2jxbWhvIeNMaEKVsvzhJG58kN4H6d2hnH2EmdKvGLvqjQT5Jw+YprJ3JWjmuN2eh0/p6zuig16eNajP9+HQS7yMJFZlqGIlIRQom403B9Ft30TW1jgI9UOy+2ZPFx5A6dSuk+EhLWMiG xdD7M9LK i+LTM5d1+VuGNXXb6MWtbz3TrYXXHOMEx6X8z1iA9WRLUZS1N3pEpJRkQP5vyoEasgTOD29+CoiCObU9uWoJtyySqykSXplt5joozjm7Bnzhe0fR6K3aPvnrblcS7vw/LMhecM/AA8S0XxempDjJ/BteP+T5f+hcwLVIuKVsdM/SCeALwcusRN42U8jyAqqlUjaXPpoRg/2UduNdzogbiHLmzOIa9n2GtDw5JSoZkyVynBcvE62HO9/2+UQvEgTbIQ2wk/LlrKAJ+7OlYVWmbknqhVlciXrdH4jT4T1DdBH8qevWmdascpJrI45ZHpcIVnnPFYi0oKZZdB6Hvsix1oIh0Ol7uxmU+nlVGJ56A2uAWLUOHtumrZ5fVvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Op 30-09-2024 om 02:53 schreef Huang, Ying: > Kees Bakker writes: > >> Op 06-09-2024 om 05:07 schreef Huang Ying: >>> [...] >>> +static void resource_test_insert_resource(struct kunit *test, struct resource *parent, >>> + resource_size_t start, resource_size_t size, >>> + const char *name, unsigned long flags) >>> +{ >>> + struct resource *res; >>> + >>> + res = kzalloc(sizeof(*res), GFP_KERNEL); >>> + KUNIT_ASSERT_NOT_NULL(test, res); >>> + >>> + res->name = name; >>> + res->start = start; >>> + res->end = start + size - 1; >>> + res->flags = flags; >>> + if (insert_resource(parent, res)) { >>> + kfree(res); >>> + KUNIT_FAIL_AND_ABORT(test, "Fail to insert resource %pR\n", res); >> Isn't this a user-after-free? > Good catch! Thanks for pointing this out. I should be more careful for > the error path. I have to honest, it wasn't me who found this. It was Coverity. >>> + } >>> + >>> + kunit_add_action_or_reset(test, remove_free_resource, res); > This may cause use-after-free if failed to allocate memory for > add_action. Will fix this too. > >>> +} >>> > -- > Best Regards, > Huang, Ying